bugsnag 1.3.8 → 1.4.0

data/CHANGELOG.md

@@ -1,6 +1,21 @@
 Changelog
 =========
 
+1.4.0
+-----
+- 	Add ignore_user_agents to ignore certain user agents
+-  	Change bugsnag middleware order to have Callbacks last
+- 	Allow nil values to be sent to bugsnag
+
+1.3.8
+-----
+- 	Add truncated only when a field has been truncated
+
+1.3.7
+-----
+- 	Fix warden bug where user id is an array of ids
+- 	Filter get params from URLs as well as meta_data
+
 1.3.6
 -----
 -   Filter out meta-data keys containing the word 'secret' by default

data/README.md

@@ -311,6 +311,18 @@ By default, `ignore_classes` contains the following:
 ]
 ```
 
+###ignore_user_agents
+
+Sets an array of Regexps that can be used to ignore exceptions from
+certain user agents.
+
+```ruby
+config.ignore_user_agents << %r{Chrome}
+```
+
+By default, `ignore_user_agents` is empty, so exceptions caused by all
+user agents are reported.
+
 ###logger
 
 Sets which logger to use for Bugsnag log messages. In rails apps, this is

data/VERSION

@@ -1 +1 @@
-1.3.8
+1.4.0

data/bugsnag.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{bugsnag}
-  s.version = "1.3.8"
+  s.version = "1.4.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["James Smith"]
-  s.date = %q{2013-06-12}
+  s.date = %q{2013-07-09}
   s.description = %q{Ruby notifier for bugsnag.com}
   s.email = %q{james@bugsnag.com}
   s.extra_rdoc_files = [

data/lib/bugsnag/configuration.rb

@@ -13,6 +13,7 @@ module Bugsnag
     attr_accessor :app_version
     attr_accessor :params_filters
     attr_accessor :ignore_classes
+    attr_accessor :ignore_user_agents
     attr_accessor :endpoint
     attr_accessor :logger
     attr_accessor :middleware
@@ -35,6 +36,8 @@ module Bugsnag
       "Mongoid::Errors::DocumentNotFound"
     ].freeze
 
+    DEFAULT_IGNORE_USER_AGENTS = [].freeze
+
     def initialize
       # Set up the defaults
       self.release_stage = nil
@@ -43,6 +46,7 @@ module Bugsnag
       self.use_ssl = false
       self.params_filters = Set.new(DEFAULT_PARAMS_FILTERS)
       self.ignore_classes = Set.new(DEFAULT_IGNORE_CLASSES)
+      self.ignore_user_agents = Set.new(DEFAULT_IGNORE_USER_AGENTS)
       self.endpoint = DEFAULT_ENDPOINT
 
       # Set up logging
@@ -74,4 +78,4 @@ module Bugsnag
       Thread.current[THREAD_LOCAL_NAME] = nil
     end
   end
-end
+end

data/lib/bugsnag/helpers.rb

@@ -20,7 +20,7 @@ module Bugsnag
             clean_hash[k] = "[FILTERED]"
           else
             clean_obj = cleanup_obj(v, filters)
-            clean_hash[k] = clean_obj unless clean_obj.nil?
+            clean_hash[k] = clean_obj
           end
         end
         clean_hash

data/lib/bugsnag/middleware_stack.rb

@@ -14,7 +14,12 @@ module Bugsnag
     def insert_after(after, new_middleware)
       return if @disabled_middleware.include?(new_middleware)
 
-      index = @middlewares.rindex(after)
+      if after.is_a? Array
+        index = @middlewares.rindex {|el| after.include?(el)}
+      else
+        index = @middlewares.rindex(after)
+      end
+
       if index.nil?
         @middlewares << new_middleware
       else
@@ -25,8 +30,13 @@ module Bugsnag
     def insert_before(before, new_middleware)
       return if @disabled_middleware.include?(new_middleware)
 
-      index = @middlewares.index(before) || @middlewares.length
-      @middlewares.insert index, new_middleware
+      if before.is_a? Array
+        index = @middlewares.index {|el| before.include?(el)}
+      else
+        index = @middlewares.index(before)
+      end
+
+      @middlewares.insert index || @middlewares.length, new_middleware
     end
     
     def disable(*middlewares)

data/lib/bugsnag/notification.rb

@@ -176,10 +176,7 @@ module Bugsnag
     end
 
     def ignore?
-      ex = @exceptions.last
-      @configuration.ignore_classes.any? do |to_ignore|
-        to_ignore.is_a?(Proc) ? to_ignore.call(ex) : to_ignore == error_class(ex)
-      end
+      ignore_exception_class? || ignore_user_agent?
     end
 
     def request_data
@@ -192,6 +189,21 @@ module Bugsnag
 
     private
 
+    def ignore_exception_class?
+      ex = @exceptions.last
+      @configuration.ignore_classes.any? do |to_ignore|
+        to_ignore.is_a?(Proc) ? to_ignore.call(ex) : to_ignore == error_class(ex)
+      end
+    end
+
+    def ignore_user_agent?
+      if @configuration.request_data && @configuration.request_data[:rack_env] && (agent = @configuration.request_data[:rack_env]["HTTP_USER_AGENT"])
+        @configuration.ignore_user_agents.any? do |to_ignore|
+          agent =~ to_ignore
+        end
+      end
+    end
+
     # Generate the meta data from both the request configuration, the overrides and the exceptions for this notification
     def generate_meta_data(exceptions, overrides)
       # Copy the request meta data so we dont edit it by mistake

data/lib/bugsnag/rack.rb

@@ -23,8 +23,8 @@ module Bugsnag
         end
 
         # Hook up rack-based notification middlewares
-        config.middleware.insert_before(Bugsnag::Middleware::Rails3Request, Bugsnag::Middleware::RackRequest) if defined?(::Rack)
-        config.middleware.use Bugsnag::Middleware::WardenUser if defined?(Warden)
+        config.middleware.insert_before([Bugsnag::Middleware::Rails3Request,Bugsnag::Middleware::Callbacks], Bugsnag::Middleware::RackRequest) if defined?(::Rack)
+        config.middleware.insert_before(Bugsnag::Middleware::Callbacks, Bugsnag::Middleware::WardenUser) if defined?(Warden)
       end
     end
 

data/lib/bugsnag/rails.rb

@@ -28,7 +28,7 @@ module Bugsnag
         config.release_stage = RAILS_ENV if defined?(RAILS_ENV)
         config.project_root = RAILS_ROOT if defined?(RAILS_ROOT)
 
-        config.middleware.use Bugsnag::Middleware::Rails2Request
+        config.middleware.insert_before(Bugsnag::Middleware::Callbacks,Bugsnag::Middleware::Rails2Request)
       end
 
       # Auto-load configuration settings from config/bugsnag.yml if it exists

data/lib/bugsnag/railtie.rb

@@ -18,7 +18,7 @@ module Bugsnag
         config.release_stage = Rails.env.to_s
         config.project_root = Rails.root.to_s
         config.params_filters += Rails.configuration.filter_parameters
-        config.middleware.insert_after Bugsnag::Middleware::RackRequest, Bugsnag::Middleware::Rails3Request
+        config.middleware.insert_before Bugsnag::Middleware::Callbacks, Bugsnag::Middleware::Rails3Request
       end
 
       # Auto-load configuration settings from config/bugsnag.yml if it exists

data/lib/bugsnag/rake.rb

@@ -24,7 +24,7 @@ module Bugsnag::Rake
             notif.context ||= task.name
           }
 
-          yield
+          yield if block_given?
         rescue Exception => e
           Bugsnag.notify(e)
           raise

data/spec/notification_spec.rb

@@ -368,6 +368,18 @@ describe Bugsnag::Notification do
     Bugsnag.notify(BugsnagTestException.new("It crashed"), {:request => {:params => {:password => "1234", :other_password => "123456", :other_data => "123456"}}})
   end
 
+  it "should not filter params from payload hashes if their values are nil" do
+    Bugsnag::Notification.should_receive(:deliver_exception_payload) do |endpoint, payload|
+      event = get_event_from_payload(payload)
+      event[:metaData].should_not be_nil
+      event[:metaData][:request].should_not be_nil
+      event[:metaData][:request][:params].should_not be_nil
+      event[:metaData][:request][:params].should have_key(:nil_param)
+    end
+
+    Bugsnag.notify(BugsnagTestException.new("It crashed"), {:request => {:params => {:nil_param => nil}}})
+  end
+
   it "should not notify if the exception class is in the default ignore_classes list" do
     Bugsnag::Notification.should_not_receive(:deliver_exception_payload)
 
@@ -390,6 +402,16 @@ describe Bugsnag::Notification do
     Bugsnag.notify_or_ignore(BugsnagTestException.new("It crashed"))
   end
 
+  it "should not notify if the user agent is present and matches a regex in ignore_user_agents" do
+    Bugsnag.configuration.ignore_user_agents << %r{BugsnagUserAgent}
+
+    Bugsnag::Notification.should_not_receive(:deliver_exception_payload)
+
+    ((Thread.current["bugsnag_req_data"] ||= {})[:rack_env] ||= {})["HTTP_USER_AGENT"] = "BugsnagUserAgent"
+
+    Bugsnag.notify_or_ignore(BugsnagTestException.new("It crashed"))
+  end
+
   it "should not unwrap the same exception twice" do
     Bugsnag::Notification.should_receive(:deliver_exception_payload) do |endpoint, payload|
       event = get_event_from_payload(payload)

metadata

@@ -4,9 +4,9 @@ version: !ruby/object:Gem::Version
   prerelease: false
   segments: 
   - 1
-  - 3
-  - 8
-  version: 1.3.8
+  - 4
+  - 0
+  version: 1.4.0
 platform: ruby
 authors: 
 - James Smith
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2013-06-12 00:00:00 +01:00
+date: 2013-07-09 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency