bugsnag 1.3.1 → 1.3.2

data/CHANGELOG.md

@@ -1,6 +1,10 @@
 Changelog
 =========
 
+1.3.2
+-----
+-   Notify will now build exceptions if a non-exception is passed in.
+
 1.3.1
 -----
 -   Add support for Bugsnag rake integration

data/README.md

@@ -154,20 +154,22 @@ Rake Integration
 ----------------
 
 Bugsnag can automatically notify of all exceptions that happen in your rake tasks. In order
-to enable this, you need to `require "bugsnag/rake"`, like so:
+to enable this, you need to `require "bugsnag/rake"` in your Rakefile, like so:
 
 ```ruby
+require File.expand_path('../config/application', __FILE__)
+require 'rake'
 require "bugsnag/rake"
 
-desc "Sample task"
-task sample_task => :environment do
-  puts "doing work"
-  raise "Something went wrong" # Reported to bugsnag
+Bugsnag.configure do |config|
+  config.api_key = "YOUR_API_KEY_HERE"
 end
+
+YourApp::Application.load_tasks
 ```
 
-**NOTE**: If you dont load your rails environment as part of your rake task, you will still need
-to ensure that Bugsnag has been configured by manually running the Bugsnag.configure method.
+**NOTE**: We also configure Bugsnag in the Rakefile, so the tasks that do not load the full
+environment can still notify Bugsnag.
 
 Standard Ruby Scripts
 ---------------------

data/VERSION

@@ -1 +1 @@
-1.3.1
+1.3.2

data/bugsnag.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{bugsnag}
-  s.version = "1.3.1"
+  s.version = "1.3.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["James Smith"]
-  s.date = %q{2013-04-06}
+  s.date = %q{2013-04-18}
   s.description = %q{Ruby notifier for bugsnag.com}
   s.email = %q{james@bugsnag.com}
   s.extra_rdoc_files = [

data/lib/bugsnag/notification.rb

@@ -55,6 +55,18 @@ module Bugsnag
       @exceptions = []
       ex = exception
       while ex != nil && !@exceptions.include?(ex) && @exceptions.length < MAX_EXCEPTIONS_TO_UNWRAP
+        unless ex.is_a? Exception
+          if ex.respond_to?(:to_exception)
+            ex = ex.to_exception
+          elsif ex.respond_to?(:exception)
+            ex = ex.exception
+          end
+          unless ex.is_a? Exception
+            Bugsnag.warn("Converting non-Exception to RuntimeError: #{ex.inspect}")
+            ex = RuntimeError.new(ex.to_s)
+          end
+        end
+
         @exceptions << ex
 
         if ex.respond_to?(:continued_exception) && ex.continued_exception

data/spec/notification_spec.rb

@@ -414,4 +414,26 @@ describe Bugsnag::Notification do
 
     Bugsnag.notify_or_ignore(first_ex)
   end
+
+  it "should call to_exception on i18n error objects" do
+    Bugsnag::Notification.should_receive(:deliver_exception_payload) do |endpoint, payload|
+      exception = get_exception_from_payload(payload)
+      exception[:errorClass].should be == "I18n::MissingTranslationData"
+    end
+
+    I18n.exception_handler = lambda do |exception, locale, key, options|
+      Bugsnag.notify exception
+    end
+    I18n.t(:test)
+  end
+
+  it "should generate runtimeerror for non exceptions" do
+    Bugsnag::Notification.should_receive(:deliver_exception_payload) do |endpoint, payload|
+      exception = get_exception_from_payload(payload)
+      exception[:errorClass].should be == "RuntimeError"
+      exception[:message].should be == "test message"
+    end
+
+    Bugsnag.notify("test message")
+  end
 end

data/spec/spec_helper.rb

@@ -1,4 +1,5 @@
 require 'bugsnag'
+require 'i18n'
 
 class BugsnagTestException < RuntimeError; end
 

metadata

@@ -5,8 +5,8 @@ version: !ruby/object:Gem::Version
   segments: 
   - 1
   - 3
-  - 1
-  version: 1.3.1
+  - 2
+  version: 1.3.2
 platform: ruby
 authors: 
 - James Smith
@@ -14,7 +14,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2013-04-06 00:00:00 -07:00
+date: 2013-04-18 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency