bugsnag 1.2.7 → 1.2.8

data/CHANGELOG.md

@@ -0,0 +1,76 @@
+Changelog
+=========
+
+1.2.8
+-----
+-   Added `disable` method to Bugsnag middleware, allows you to force-disable
+    built-in Bugsnag middleware.
+
+1.2.7
+-----
+-   Protect against rare exception-unwrapping infinite loop 
+    (only in some exceptions using the `original_exception` pattern)
+
+1.2.6
+-----
+-   Fix for rails 2 request data extraction
+-   Deploy environment customization support (thanks coop)
+-   Ensure Bugsnag rails 3 middleware runs before initializers
+
+1.2.5
+-----
+-   Show a warning if no release_stage is set when delivering exceptions
+-   Require resque plugin in a safer way
+
+1.2.4
+-----
+-   Automatically set the release_stage in a safer way on rack/rails
+
+1.2.3
+-----
+-   Re-add support for sending bugsnag notifications via resque
+
+1.2.2
+-----
+-   Add rspec tests for rack middleware
+
+1.2.1
+-----
+-   Fix a bug where before/after hooks were not being fired
+
+1.2.0
+-----
+-   Added Bugsnag Middleware and callback, easier ways to add custom data to
+    your exceptions
+-   Added automatic Sidekiq integration
+-   Added automatic Devise integration
+-   Comprehensive rspec tests
+
+1.1.5
+-----
+-   Fix minor internal version number parsing bug
+
+1.1.4
+-----
+-   Move Bugsnag rack middleware later in the middleware stack, fixes 
+    issue where development exception may not have been delivered
+
+1.1.3
+-----
+-   Fix multi_json conflict with rails 3.1
+-   Make bugsnag_request_data public for easier EventMachine integration
+    (thanks fblee)
+
+1.1.2
+-----
+-   Fix multi_json gem dependency conflicts
+
+1.1.1
+-----
+-   Capistrano deploy tracking support
+-   More reliable project_root detection for non-rails rack apps
+-   Support for sending test exceptions from rake (`rake bugsnag:test_exception`)
+
+1.1.0
+-----
+-   First public release

data/VERSION

@@ -1 +1 @@
-1.2.7
+1.2.8

data/bugsnag.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "bugsnag"
-  s.version = "1.2.7"
+  s.version = "1.2.8"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["James Smith"]
-  s.date = "2012-12-10"
+  s.date = "2013-01-08"
   s.description = "Ruby notifier for bugsnag.com"
   s.email = "james@bugsnag.com"
   s.extra_rdoc_files = [
@@ -20,6 +20,7 @@ Gem::Specification.new do |s|
     ".document",
     ".rspec",
     ".travis.yml",
+    "CHANGELOG.md",
     "Gemfile",
     "Gemfile.lock",
     "LICENSE.txt",

data/lib/bugsnag/middleware_stack.rb

@@ -2,17 +2,18 @@ module Bugsnag
   class MiddlewareStack
     def initialize
       @middlewares = []
+      @disabled_middleware = []
     end
   
     def use(new_middleware)
-      @middlewares << new_middleware
-    end
+      return if @disabled_middleware.include?(new_middleware)
 
-    def delete(middleware)
-      @middlewares.delete(middleware)
+      @middlewares << new_middleware
     end
   
     def insert_after(after, new_middleware)
+      return if @disabled_middleware.include?(new_middleware)
+
       index = @middlewares.rindex(after)
       if index.nil?
         @middlewares << new_middleware
@@ -22,10 +23,18 @@ module Bugsnag
     end
   
     def insert_before(before, new_middleware)
+      return if @disabled_middleware.include?(new_middleware)
+
       index = @middlewares.index(before) || @middlewares.length
       @middlewares.insert index, new_middleware
     end
     
+    def disable(*middlewares)
+      @disabled_middleware += middlewares
+
+      @middlewares.delete_if {|m| @disabled_middleware.include?(m)}
+    end
+
     # This allows people to proxy methods to the array if they want to do more complex stuff
     def method_missing(method, *args, &block)
       @middlewares.send(method, *args, &block)

data/spec/middleware_spec.rb

@@ -87,4 +87,18 @@ describe Bugsnag::MiddlewareStack do
     
     callback_run_count.should be == 1
   end
+
+  it "should not execute disabled bugsnag middleware" do
+    callback_run_count = 0
+    Bugsnag.configure do |config|
+      config.middleware.disable(Bugsnag::Middleware::Callbacks)
+    end
+    
+    Bugsnag.before_notify_callbacks << lambda {|notif|
+      callback_run_count += 1
+    }
+    
+    Bugsnag.notify(BugsnagTestException.new("It crashed"))
+    callback_run_count.should be == 0
+  end
 end

data/spec/notification_spec.rb

@@ -2,14 +2,7 @@ require 'spec_helper'
 require 'securerandom'
 
 module ActiveRecord; class RecordNotFound < RuntimeError; end; end
-
-class RecursiveException < StandardError
-  attr_accessor :original_exception
-  def initialize(*args)
-    self.original_exception = self
-    super(message)
-  end
-end
+class NestedException < StandardError; attr_accessor :original_exception; end
 
 describe Bugsnag::Notification do
   it "should contain an api_key if one is set" do
@@ -301,10 +294,14 @@ describe Bugsnag::Notification do
 
   it "should not unwrap the same exception twice" do
     Bugsnag::Notification.should_receive(:deliver_exception_payload) do |endpoint, payload|
-      get_exception_from_payload(payload)
+      event = get_event_from_payload(payload)
+      event[:exceptions].should have(1).items
     end
 
-    Bugsnag.notify_or_ignore(RecursiveException.new("Self-referential exception"))
+    ex = NestedException.new("Self-referential exception")
+    ex.original_exception = ex
+
+    Bugsnag.notify_or_ignore(ex)
   end
   
   it "should not unwrap more than 5 exceptions" do
@@ -313,9 +310,9 @@ describe Bugsnag::Notification do
       event[:exceptions].should have(5).items
     end
 
-    first_ex = ex = RecursiveException.new("Deep exception")
+    first_ex = ex = NestedException.new("Deep exception")
     10.times do |idx|
-      ex = ex.original_exception = RecursiveException.new("Deep exception #{idx}")
+      ex = ex.original_exception = NestedException.new("Deep exception #{idx}")
     end
 
     Bugsnag.notify_or_ignore(first_ex)

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: bugsnag
 version: !ruby/object:Gem::Version 
-  hash: 17
+  hash: 15
   prerelease: 
   segments: 
   - 1
   - 2
-  - 7
-  version: 1.2.7
+  - 8
+  version: 1.2.8
 platform: ruby
 authors: 
 - James Smith
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-12-10 00:00:00 Z
+date: 2013-01-08 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   requirement: &id001 !ruby/object:Gem::Requirement 
@@ -114,6 +114,7 @@ files:
 - .document
 - .rspec
 - .travis.yml
+- CHANGELOG.md
 - Gemfile
 - Gemfile.lock
 - LICENSE.txt