bug_bunny 4.10.3 → 4.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 31a6f6e9b83b1a82216f344a101ca0a99daebb5fd9e44bf5abc9c9e9753f4011
-  data.tar.gz: f101254aad9d8bbd66a359438a1efe970acd58e4b853841bcda72966c2472c8c
+  metadata.gz: efe99ebd57d867b306ecb7bc2b67d92b72bb1b0b3ddaabaf1c72755ed337ded9
+  data.tar.gz: 997cb254c582a4524275c295ad12694762f1b7b010e690cbb70dfdd7c6684039
 SHA512:
-  metadata.gz: 6b8a42f884ae9c8075dab9e4052658a5c0828cae904800fe222fd058cdaf3cd1307bba6478ca7824e273a517484d71da0416fd3b7c38bb08a9a0845e39dacb90
-  data.tar.gz: 6de916fae62566f01142b557b6e6c4ed4cf44d58298d9ff3c174e8d38b4422238487dacd29f273d7b3ea356d30f8c08a5c5a872f9ed08f6cacb8a540511a933a
+  metadata.gz: 7bb1d730e90c2d58c39087e65ea67415a258cd0f4dc4e0064610ee67d7167480726b3238155687f8d77f8390d2c41a707482df0d56da8022be9b2d89269a9f97
+  data.tar.gz: 4b46a0f617856554700b9c31e2917256ee5aa723f5699c0097cd8a1e82b28e8655e98ddf61ddb884e85794979ad9fcdf2b6c7bd2a8bcb7bd150bdeecdd71dfa8

data/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Changelog
 
+## [4.11.0] - 2026-04-08
+
+### Correcciones
+- **Query string en route matching:** El consumer incluía el query string como parte del path al hacer route matching (ej. `secrets?q%5Bname%5D=postgres_password`), causando 404 en rutas válidas con query params. Ahora se separa el path limpio via `URI.parse` antes de invocar `RouteSet#recognize`. — @Gabriel
+
+### ✨ New Features
+- **`BugBunny::RoutingError`:** Nueva excepción `RoutingError < NotFound` análoga a `ActionController::RoutingError` en Rails. Permite al productor distinguir "la ruta no existe en el servicio remoto" de "el recurso no fue encontrado". El consumer ahora envía `error_type: 'routing_error'` en el body del 404 cuando la ruta o el controller no existen, y el middleware `RaiseError` levanta `RoutingError` con el detalle del error. `rescue BugBunny::NotFound` sigue capturando ambos casos. — @Gabriel
+
 ## [4.10.2] - 2026-04-08
 
 ### Correcciones

data/lib/bug_bunny/consumer.rb

@@ -184,17 +184,18 @@ module BugBunny
       normalized_path = path.gsub(%r{^/|/$}, '')
 
       uri = URI.parse("http://dummy/#{normalized_path}")
+      clean_path = uri.path.delete_prefix('/dummy/').delete_prefix('/')
 
       # Extraemos query params (ej. /nodes?status=active)
       query_params = uri.query ? Rack::Utils.parse_nested_query(uri.query) : {}
       query_params = query_params.with_indifferent_access if defined?(ActiveSupport::HashWithIndifferentAccess)
 
       # Le preguntamos al motor de rutas global quién debe manejar esto
-      route_info = BugBunny.routes.recognize(http_method, normalized_path)
+      route_info = BugBunny.routes.recognize(http_method, clean_path)
 
       if route_info.nil?
-        safe_log(:warn, 'consumer.route_not_found', method: http_method, path: normalized_path)
-        handle_fatal_error(properties, 404, 'Not Found', "No route matches [#{http_method}] \"#{normalized_path}\"")
+        safe_log(:warn, 'consumer.route_not_found', method: http_method, path: clean_path)
+        handle_routing_error(properties, "No route matches [#{http_method}] \"#{clean_path}\"")
         session.channel.reject(delivery_info.delivery_tag, false)
         return
       end
@@ -213,7 +214,7 @@ module BugBunny
         controller_class = controller_class_name.constantize
       rescue NameError
         safe_log(:warn, 'consumer.controller_not_found', controller: controller_class_name)
-        handle_fatal_error(properties, 404, 'Not Found', "Controller #{controller_class_name} not found")
+        handle_routing_error(properties, "Controller #{controller_class_name} not found")
         session.channel.reject(delivery_info.delivery_tag, false)
         return
       end
@@ -300,6 +301,22 @@ module BugBunny
     # @param detail [String] Detalle del error.
     # @param exception [StandardError, nil] Excepción original (para status 500).
     # @api private
+    # Maneja errores de enrutamiento (ruta o controller no encontrado).
+    #
+    # Envía una respuesta 404 con `error_type: 'routing_error'` para que el
+    # middleware del productor pueda levantar {BugBunny::RoutingError} en vez
+    # de un {BugBunny::NotFound} genérico.
+    #
+    # @param properties [Bunny::MessageProperties] Headers y propiedades AMQP.
+    # @param detail [String] Descripción del error de routing.
+    # @api private
+    def handle_routing_error(properties, detail)
+      return unless properties.reply_to
+
+      body = { error: 'Not Found', detail: detail, error_type: 'routing_error' }
+      reply({ status: 404, body: body }, properties.reply_to, properties.correlation_id)
+    end
+
     def handle_fatal_error(properties, status, error_title, detail, exception = nil)
       return unless properties.reply_to
 

data/lib/bug_bunny/exception.rb

@@ -35,6 +35,15 @@ module BugBunny
   # El recurso solicitado (o la ruta RPC) no existe en el servidor remoto.
   class NotFound < ClientError; end
 
+  # Error 404 específico de enrutamiento.
+  # Se lanza cuando el servicio remoto no tiene una ruta registrada para el verbo y path solicitados.
+  # Análogo a `ActionController::RoutingError` en Rails.
+  #
+  # @example
+  #   rescue BugBunny::RoutingError => e
+  #     e.message # => 'No route matches [GET] "secrets"'
+  class RoutingError < NotFound; end
+
   # Error 406: Not Acceptable.
   # El servidor no puede generar una respuesta con las características de contenido aceptadas.
   class NotAcceptable < ClientError; end

data/lib/bug_bunny/middleware/raise_error.rb

@@ -39,7 +39,7 @@ module BugBunny
         when 400
           raise BugBunny::BadRequest, format_error_message(body)
         when 404
-          raise BugBunny::NotFound
+          raise_not_found(body)
         when 406
           raise BugBunny::NotAcceptable
         when 408
@@ -87,6 +87,20 @@ module BugBunny
         end
       end
 
+      # Distingue un error de routing (ruta/controller no existe en el servicio remoto)
+      # de un 404 genérico de recurso no encontrado.
+      #
+      # @param body [Hash, String, nil] El cuerpo de la respuesta 404.
+      # @raise [BugBunny::RoutingError] Si el consumer marcó `error_type: 'routing_error'`.
+      # @raise [BugBunny::NotFound] Para 404 genéricos.
+      def raise_not_found(body)
+        if body.is_a?(Hash) && body['error_type'] == 'routing_error'
+          raise BugBunny::RoutingError, format_error_message(body)
+        end
+
+        raise BugBunny::NotFound, format_error_message(body)
+      end
+
       # Maneja códigos de error genéricos no mapeados explícitamente en el `case`.
       #
       # @param status [Integer] El código de estado HTTP (ej. 418, 502).

data/lib/bug_bunny/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module BugBunny
-  VERSION = '4.10.3'
+  VERSION = '4.11.0'
 end

data/spec/unit/raise_error_spec.rb

@@ -0,0 +1,59 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe BugBunny::Middleware::RaiseError do
+  subject(:middleware) { described_class.new(->(_env) { {} }) }
+
+  describe '#on_complete' do
+    context 'when status is 404 with error_type routing_error' do
+      let(:response) do
+        {
+          'status' => 404,
+          'body' => { 'error' => 'Not Found', 'detail' => 'No route matches [GET] "secrets"',
+                      'error_type' => 'routing_error' }
+        }
+      end
+
+      it 'raises BugBunny::RoutingError' do
+        expect { middleware.on_complete(response) }.to raise_error(BugBunny::RoutingError)
+      end
+
+      it 'includes the detail in the error message' do
+        expect { middleware.on_complete(response) }.to raise_error(
+          BugBunny::RoutingError, /No route matches \[GET\] "secrets"/
+        )
+      end
+
+      it 'is rescuable as BugBunny::NotFound' do
+        expect { middleware.on_complete(response) }.to raise_error(BugBunny::NotFound)
+      end
+    end
+
+    context 'when status is 404 without error_type (resource not found)' do
+      let(:response) do
+        { 'status' => 404, 'body' => { 'error' => 'Not Found', 'detail' => 'User 999 not found' } }
+      end
+
+      it 'raises BugBunny::NotFound but not RoutingError' do
+        error = nil
+        begin
+          middleware.on_complete(response)
+        rescue BugBunny::NotFound => e
+          error = e
+        end
+
+        expect(error).to be_a(BugBunny::NotFound)
+        expect(error).not_to be_a(BugBunny::RoutingError)
+      end
+    end
+
+    context 'when status is 404 with nil body' do
+      let(:response) { { 'status' => 404, 'body' => nil } }
+
+      it 'raises BugBunny::NotFound' do
+        expect { middleware.on_complete(response) }.to raise_error(BugBunny::NotFound)
+      end
+    end
+  end
+end

data/spec/unit/route_spec.rb

@@ -176,5 +176,34 @@ RSpec.describe BugBunny::Routing::Route do
         expect(route_not_found_event[:kwargs][:path]).to eq('services/otaigccd59q0k7kxb1h193go2/restart')
       end
     end
+
+    context 'when properties.type includes query string' do
+      let(:properties) do
+        double('properties',
+               type: 'secrets?q%5Bname%5D=postgres_password',
+               headers: { 'x-http-method' => 'GET' },
+               correlation_id: 'corr-abc-123',
+               reply_to: nil,
+               content_type: 'application/json')
+      end
+
+      it 'strips query string before route recognition' do
+        allow(BugBunny.routes).to receive(:recognize).and_return(nil)
+
+        test_consumer.send(:process_message, delivery_info, properties, '')
+
+        expect(BugBunny.routes).to have_received(:recognize).with('GET', 'secrets')
+      end
+
+      it 'logs route_not_found with clean path (without query string)' do
+        allow(BugBunny.routes).to receive(:recognize).and_return(nil)
+
+        test_consumer.send(:process_message, delivery_info, properties, '')
+
+        route_not_found_event = logged_events.find { |e| e[:event] == 'consumer.route_not_found' }
+        expect(route_not_found_event).not_to be_nil
+        expect(route_not_found_event[:kwargs][:path]).to eq('secrets')
+      end
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bug_bunny
 version: !ruby/object:Gem::Version
-  version: 4.10.3
+  version: 4.11.0
 platform: ruby
 authors:
 - gabix
@@ -288,6 +288,7 @@ files:
 - spec/unit/observability_spec.rb
 - spec/unit/otel_spec.rb
 - spec/unit/producer_spec.rb
+- spec/unit/raise_error_spec.rb
 - spec/unit/remote_error_spec.rb
 - spec/unit/request_spec.rb
 - spec/unit/resource_attributes_spec.rb
@@ -303,7 +304,7 @@ metadata:
   homepage_uri: https://github.com/gedera/bug_bunny
   source_code_uri: https://github.com/gedera/bug_bunny
   changelog_uri: https://github.com/gedera/bug_bunny/blob/main/CHANGELOG.md
-  documentation_uri: https://github.com/gedera/bug_bunny/blob/v4.10.3/skill
+  documentation_uri: https://github.com/gedera/bug_bunny/blob/v4.11.0/skill
 post_install_message:
 rdoc_options: []
 require_paths: