bug_bunny 4.10.0 → 4.10.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: af9746f85e544f059873513a7ace9b478acb6664b9053bb90d1963afb1d72848
-  data.tar.gz: 32854fb9e2a67f8e5cb537550d957704443d95183d22d5305b48c3207edaf05b
+  metadata.gz: 1e1a5c8c069bdf7634c57b1df16aa226d5abc8fd6e864596d273431a680a1b55
+  data.tar.gz: 49b7cf39e53fe8c3f3b90331cfc4f171c8769264356ba1c1d4a767bf27b868ee
 SHA512:
-  metadata.gz: 90169fb942803e87f47cf1af2fb2b4cb4d66112aaf4ab6632bb6a8d5031383e1fc0105a4cf2449eed847822509a71c1e4695c8cacb9907889c286cc5cfefe70b
-  data.tar.gz: 39262e92b89fb583769bcfaa8a17972584b0aaeda9f197ff3cf7cf4c45941ca0ee0b3aa154e8073d4004f5213bb1852aa16cc6c6f809951b2bcf3c76b85fa66d
+  metadata.gz: '082acc0c03183a7d077381563ab9da50657e7468006334b5cfc2d00c8442d603285d38d0f557d67793c833fd6c4d5133c82b3cbbe5048f7f89721c19082971b9'
+  data.tar.gz: 9ee3d5a73a1e339d13241093bedfc9dfe212e2a77fb655f3fe21f1378b02d5e10c86417e12fe637eaa1f9591be3ae1e7c2a72d6ed3dac5ee3007f05d1ee7159f

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## [4.10.1] - 2026-04-08
+
+### Correcciones
+- Corregir route matching 404: el path del cliente ahora se normaliza antes de pasarlo a `RouteSet#recognize`. Antes, `URI.parse("http://dummy/#{path}")` prependead un `/` extra al path, causando que rutas existentes no hicieran match. Ahora se usa `path.gsub(%r{^/|/$}, '')` antes del recognize. — @Gabriel
+
 ## [4.9.1] - 2026-04-06
 
 ### Correcciones

data/lib/bug_bunny/consumer.rb

@@ -181,18 +181,20 @@ module BugBunny
       # ===================================================================
       # 3. Ruteo Declarativo
       # ===================================================================
-      uri = URI.parse("http://dummy/#{path}")
+      normalized_path = path.gsub(%r{^/|/$}, '')
+
+      uri = URI.parse("http://dummy/#{normalized_path}")
 
       # Extraemos query params (ej. /nodes?status=active)
       query_params = uri.query ? Rack::Utils.parse_nested_query(uri.query) : {}
       query_params = query_params.with_indifferent_access if defined?(ActiveSupport::HashWithIndifferentAccess)
 
       # Le preguntamos al motor de rutas global quién debe manejar esto
-      route_info = BugBunny.routes.recognize(http_method, uri.path)
+      route_info = BugBunny.routes.recognize(http_method, normalized_path)
 
       if route_info.nil?
-        safe_log(:warn, 'consumer.route_not_found', method: http_method, path: uri.path)
-        handle_fatal_error(properties, 404, 'Not Found', "No route matches [#{http_method}] \"/#{uri.path}\"")
+        safe_log(:warn, 'consumer.route_not_found', method: http_method, path: normalized_path)
+        handle_fatal_error(properties, 404, 'Not Found', "No route matches [#{http_method}] \"#{normalized_path}\"")
         session.channel.reject(delivery_info.delivery_tag, false)
         return
       end

data/lib/bug_bunny/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module BugBunny
-  VERSION = '4.10.0'
+  VERSION = '4.10.1'
 end

data/skill/SKILL.md

@@ -230,6 +230,10 @@ No registrar consumer middlewares durante la ejecución de `call()`. El stack to
 **Causa:** El mensaje intenta ejecutar un controlador que no hereda de `BugBunny::Controller`.
 **Resolución:** Verificar la jerarquía de controladores y que `config.controller_namespace` coincida.
 
+### BugBunny::RouteNotFoundError (404)
+**Causa:** El path del mensaje no coincide con ninguna ruta registrada. El path debe estar normalizado (sin slashes iniciales/trailing).
+**Resolución:** Verificar que el cliente envíe el path sin leading/trailing slashes (ej: `users/42`, no `/users/42/`).
+
 ### BugBunny::UnprocessableEntity (422)
 **Causa:** Fallo de validación en el servicio remoto.
 **Resolución:** `resource.save` devuelve `false`. Acceder a `resource.errors` o `rescue` con `e.error_messages`.

data/skill/references/consumer.md

@@ -21,13 +21,14 @@ consumer = BugBunny::Consumer.subscribe(
 2. Extrae campos **OTel messaging** del mensaje para logs estructurados (sin mutar headers).
 3. Valida que el mensaje tenga header `type` (path).
 4. Parsea el método HTTP de headers (`x-http-method` o `method`).
-5. Emite log `consumer.message_received` con campos OTel (`messaging_operation: 'process'`).
-6. Reconoce la ruta con `BugBunny.routes.recognize(method, path)`.
-7. Resuelve el controlador validando herencia de `BugBunny::Controller`.
-8. Ejecuta consumer middlewares → controller callbacks → acción.
-9. Responde via `reply_to` si está presente (RPC), inyectando campos OTel (`messaging_operation: 'publish'`).
-10. Emite log `consumer.message_processed` con campos OTel y duraciones.
-11. Hace `ack` del mensaje. En caso de error, `reject`.
+5. **Normaliza el path**: remueve slashes iniciales/trailing (`path.gsub(%r{^/|/$}, '')`).
+6. Emite log `consumer.message_received` con campos OTel (`messaging_operation: 'process'`).
+7. Reconoce la ruta con `BugBunny.routes.recognize(method, normalized_path)`.
+8. Resuelve el controlador validando herencia de `BugBunny::Controller`.
+9. Ejecuta consumer middlewares → controller callbacks → acción.
+10. Responde via `reply_to` si está presente (RPC), inyectando campos OTel (`messaging_operation: 'publish'`).
+11. Emite log `consumer.message_processed` con campos OTel y duraciones.
+12. Hace `ack` del mensaje. En caso de error, `reject`.
 
 ## Observability: OTel Fields
 

data/spec/unit/route_spec.rb

@@ -0,0 +1,180 @@
+# frozen_string_literal: true
+
+require 'spec_helper'
+
+RSpec.describe BugBunny::Routing::Route do
+  describe '#match? and #extract_params — path normalization' do
+    let(:route) { described_class.new('GET', 'services/otaigccd59q0k7kxb1h193go2/restart', to: 'services#restart') }
+
+    it 'matches path without leading slash' do
+      expect(route.match?('GET', 'services/otaigccd59q0k7kxb1h193go2/restart')).to be true
+    end
+
+    it 'matches path with leading slash' do
+      expect(route.match?('GET', '/services/otaigccd59q0k7kxb1h193go2/restart')).to be true
+    end
+
+    it 'matches path with trailing slash' do
+      expect(route.match?('GET', 'services/otaigccd59q0k7kxb1h193go2/restart/')).to be true
+    end
+
+    it 'matches path with leading and trailing slash' do
+      expect(route.match?('GET', '/services/otaigccd59q0k7kxb1h193go2/restart/')).to be true
+    end
+
+    it 'extracts params from path without slash' do
+      params = route.extract_params('services/otaigccd59q0k7kxb1h193go2/restart')
+      expect(params).to eq({})
+    end
+
+    it 'extracts params from path with slash' do
+      params = route.extract_params('/services/otaigccd59q0k7kxb1h193go2/restart')
+      expect(params).to eq({})
+    end
+
+    context 'route with dynamic segment' do
+      let(:route_with_id) { described_class.new('GET', 'nodes/:id', to: 'nodes#show') }
+
+      it 'extracts params from path without slash' do
+        params = route_with_id.extract_params('nodes/123')
+        expect(params).to eq({ 'id' => '123' })
+      end
+
+      it 'extracts params from path with slash' do
+        params = route_with_id.extract_params('/nodes/123')
+        expect(params).to eq({ 'id' => '123' })
+      end
+    end
+
+    context 'route defined with leading slash' do
+      let(:route_with_leading_slash) do
+        described_class.new('GET', '/services/otaigccd59q0k7kxb1h193go2/restart', to: 'services#restart')
+      end
+
+      it 'matches path without slash' do
+        expect(route_with_leading_slash.match?('GET', 'services/otaigccd59q0k7kxb1h193go2/restart')).to be true
+      end
+
+      it 'matches path with slash' do
+        expect(route_with_leading_slash.match?('GET', '/services/otaigccd59q0k7kxb1h193go2/restart')).to be true
+      end
+    end
+  end
+
+  describe 'RouteSet#recognize path normalization' do
+    let(:route_set) { BugBunny::Routing::RouteSet.new }
+
+    before do
+      route_set.draw do
+        get 'services/otaigccd59q0k7kxb1h193go2/restart', to: 'services#restart'
+      end
+    end
+
+    it 'recognizes path without slash' do
+      result = route_set.recognize('GET', 'services/otaigccd59q0k7kxb1h193go2/restart')
+      expect(result).not_to be_nil
+      expect(result[:controller]).to eq('services')
+      expect(result[:action]).to eq('restart')
+    end
+
+    it 'recognizes path with leading slash' do
+      result = route_set.recognize('GET', '/services/otaigccd59q0k7kxb1h193go2/restart')
+      expect(result).not_to be_nil
+      expect(result[:controller]).to eq('services')
+      expect(result[:action]).to eq('restart')
+    end
+
+    it 'returns nil for non-matching path' do
+      result = route_set.recognize('GET', 'services/nonexistent')
+      expect(result).to be_nil
+    end
+  end
+
+  describe 'Consumer path handling — URI parsing edge case' do
+    let(:channel) { BunnyMocks::FakeChannel.new(true) }
+    let(:connection) { BunnyMocks::FakeConnection.new(true, channel) }
+
+    let(:mock_channel) do
+      ch = double('channel')
+      allow(ch).to receive(:reject)
+      allow(ch).to receive(:ack)
+      allow(ch).to receive(:open?).and_return(true)
+      default_ex = double('default_exchange')
+      allow(default_ex).to receive(:publish)
+      allow(ch).to receive(:default_exchange).and_return(default_ex)
+      ch
+    end
+
+    let(:mock_session) do
+      s = instance_double(BugBunny::Session)
+      allow(s).to receive(:exchange).and_return(double('exchange'))
+      allow(s).to receive(:queue).and_return(double('queue'))
+      allow(s).to receive(:close)
+      allow(s).to receive(:channel).and_return(mock_channel)
+      s
+    end
+
+    let(:test_consumer) do
+      c = BugBunny::Consumer.new(connection)
+      c.instance_variable_set(:@session, mock_session)
+      c
+    end
+
+    let(:delivery_info) do
+      double('delivery_info',
+             exchange: 'events_x',
+             routing_key: 'users.created',
+             delivery_tag: 'delivery-tag-1',
+             redelivered?: false)
+    end
+
+    let(:properties) do
+      double('properties',
+             type: 'services/otaigccd59q0k7kxb1h193go2/restart',
+             headers: { 'x-http-method' => 'GET' },
+             correlation_id: 'corr-abc-123',
+             reply_to: nil,
+             content_type: 'application/json')
+    end
+
+    let(:logged_events) { [] }
+
+    before do
+      allow(test_consumer).to receive(:safe_log) do |level, event, **kwargs|
+        logged_events << { level: level, event: event, kwargs: kwargs }
+      end
+      allow(test_consumer).to receive(:handle_fatal_error)
+    end
+
+    it 'logs route_not_found with normalized path (without extra slash)' do
+      allow(BugBunny.routes).to receive(:recognize).and_return(nil)
+
+      test_consumer.send(:process_message, delivery_info, properties, '{}')
+
+      route_not_found_event = logged_events.find { |e| e[:event] == 'consumer.route_not_found' }
+      expect(route_not_found_event).not_to be_nil
+      expect(route_not_found_event[:kwargs][:path]).to eq('services/otaigccd59q0k7kxb1h193go2/restart')
+    end
+
+    context 'when properties.type has leading slash' do
+      let(:properties) do
+        double('properties',
+               type: '/services/otaigccd59q0k7kxb1h193go2/restart',
+               headers: { 'x-http-method' => 'GET' },
+               correlation_id: 'corr-abc-123',
+               reply_to: nil,
+               content_type: 'application/json')
+      end
+
+      it 'logs route_not_found with normalized path (stripped leading slash)' do
+        allow(BugBunny.routes).to receive(:recognize).and_return(nil)
+
+        test_consumer.send(:process_message, delivery_info, properties, '{}')
+
+        route_not_found_event = logged_events.find { |e| e[:event] == 'consumer.route_not_found' }
+        expect(route_not_found_event).not_to be_nil
+        expect(route_not_found_event[:kwargs][:path]).to eq('services/otaigccd59q0k7kxb1h193go2/restart')
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bug_bunny
 version: !ruby/object:Gem::Version
-  version: 4.10.0
+  version: 4.10.1
 platform: ruby
 authors:
 - gabix
@@ -290,6 +290,7 @@ files:
 - spec/unit/producer_spec.rb
 - spec/unit/request_spec.rb
 - spec/unit/resource_attributes_spec.rb
+- spec/unit/route_spec.rb
 - spec/unit/session_spec.rb
 - test/integration/infrastructure_test.rb
 - test/integration/manual_client_test.rb
@@ -301,7 +302,7 @@ metadata:
   homepage_uri: https://github.com/gedera/bug_bunny
   source_code_uri: https://github.com/gedera/bug_bunny
   changelog_uri: https://github.com/gedera/bug_bunny/blob/main/CHANGELOG.md
-  documentation_uri: https://github.com/gedera/bug_bunny/blob/v4.10.0/skill
+  documentation_uri: https://github.com/gedera/bug_bunny/blob/v4.10.1/skill
 post_install_message:
 rdoc_options: []
 require_paths: