buffered_job 0.4.2 → 0.5.0

data/README.md

@@ -33,7 +33,7 @@ Then. With this module,you can buffer `notify` method
  @user.buffer.notify(c2)
  # these two methods would be translated to
  @user.merge_notify([c1,c2])
- # then you can build other notification email with arryed comment objects
+ # So, you can write other notification email template which handles array of comment objects
 ```
 
 
@@ -77,11 +77,13 @@ flushing would be triggered by delayed_job. Start worker as follows after migrat
 $ (bundle exec) rake jobs:work
 ```
 
-See more details about [delayed_job_active_record](https://github.com/collectiveidea/delayed_job_active_record)
+See more details about [delayed_job](https://github.com/collectiveidea/delayed_job)
 
 
 ## Usage
 
+### With ActiveRecord Object
+
 Every active_record object has `buffer` method. You can put it  between receiver and method and bufferes method
 along with argument object.
 
@@ -96,11 +98,26 @@ invoke merge_{:original_method} method insted of original method on
 that User model,so in this case, you must define `merge_post_to_twitter` in User model.
 
 ```
-def merge_post_to_twitter(articles)
- ..
-end
+  def merge_post_to_twitter(articles)
+    ..
+  end
 ```
 
+### With ActionMailer Class
+
+Also, subclasses of ActionMailer::Base have buffer method. You can buffer sending method with
+buffering keyword. That keyword will be used to determine which methods should be merged.
+
+```
+ YourMailer.buffer("send_to/135").greeting(some_object)
+ YourMailer.buffer("send_to/135").greeting(other_object)
+ # these two will be merged 
+ #  and invoke merge_greeting([some_object,other_object])
+ YourMailer.buffer("send_to/222").greeting(yet_another_object)
+ # this won't be merged into preceding two.
+```
+
+
 ## Current Limitation
 
 Only one argument object can be passed to buffered method. 
@@ -115,6 +132,8 @@ BufferedJob.delay_time = 30.seconds
 ```
 
 
+
+
 ## Copyright
 
 Copyright (c) 2012 Masaki Sawamura. 

data/VERSION

@@ -1 +1 @@
-0.4.2
+0.5.0

data/buffered_job.gemspec

@@ -1,15 +1,15 @@
 # Generated by jeweler
 # DO NOT EDIT THIS FILE DIRECTLY
-# Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
+# Instead, edit Jeweler::Tasks in rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
 
 Gem::Specification.new do |s|
   s.name = "buffered_job"
-  s.version = "0.4.2"
+  s.version = "0.5.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Masaki Sawamura"]
-  s.date = "2012-06-05"
+  s.date = "2012-11-18"
   s.description = "Buffering jobs for a certain period and invoke specific method if two or more similer jobs in a buffer."
   s.email = "masaki.sw@gmail.com"
   s.extra_rdoc_files = [

data/lib/buffered_job/model.rb

@@ -12,51 +12,54 @@ module BufferedJob
     
     def self.flush!
       return if Lock.locked?
-      Lock.lock!
-      jobs = self.all
-      skip = []
-      @last_results = []
-      jobs.each do |j|
-        if skip[j.id]
-          j.destroy
-          next 
-        end
-        cojobs = jobs.select{ |o| o.user_id == j.user_id and o.category == j.category }
-        receiver = YAML.load(j.receiver)
-        if cojobs.size > 1
-          begin
-            targets = cojobs.map{|c|
-              YAML.load(c.target)
-            }
-            unless receiver.respond_to?(j.merge_method)
-              raise NoMergeMethodError,"define #{j.merge_method}"
+      begin
+        Lock.lock!
+        jobs = self.all
+        skip = []
+        @last_results = []
+        jobs.each do |j|
+          if skip[j.id]
+            j.destroy
+            next 
+          end
+          cojobs = jobs.select{ |o| o.user_id == j.user_id and o.category == j.category }
+          receiver = YAML.load(j.receiver)
+          if cojobs.size > 1
+            begin
+              targets = cojobs.map{|c|
+                YAML.load(c.target)
+              }
+              unless receiver.respond_to?(j.merge_method)
+                raise NoMergeMethodError,"define #{j.merge_method}"
+              end
+              if mailer?(receiver)
+                @last_results << receiver.send(j.merge_method,targets).deliver
+              else
+                @last_results << receiver.send(j.merge_method,targets)
+              end
+            rescue => er
+              @last_results << er
             end
-            if mailer?(receiver)
-              @last_results << receiver.send(j.merge_method,targets).deliver
-            else
-              @last_results << receiver.send(j.merge_method,targets)
+            cojobs.each do |c|
+              skip[c.id] = true
             end
-          rescue => er
-            @last_results << er
-          end
-          cojobs.each do |c|
-            skip[c.id] = true
-          end
-        else
-          begin
-            target = YAML.load(j.target)
-            if mailer?(receiver)
-              @last_results << receiver.send(j.method,target).deliver
-            else
-              @last_results << receiver.send(j.method,target)
+          else
+            begin
+              target = YAML.load(j.target)
+              if mailer?(receiver)
+                @last_results << receiver.send(j.method,target).deliver
+              else
+                @last_results << receiver.send(j.method,target)
+              end
+            rescue => er
+              @last_results << er
             end
-          rescue => er
-            @last_results << er
           end
+          j.destroy
         end
-        j.destroy
+      ensure
+        Lock.unlock!
       end
-      Lock.unlock!
     end
     
     def self.last_results

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: buffered_job
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.5.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-06-05 00:00:00.000000000 Z
+date: 2012-11-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -198,7 +198,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 656163624896390621
+      hash: 2567470579218584468
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements: