bucket_maker 0.0.3 → 0.0.4

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    YzdkOTI0ZTZjZWMwNTFjNjczODIwNDg5NGYwMjlmZmJhYzVhODFhNA==
-  data.tar.gz: !binary |-
-    YmE3NjUxNjgwY2VhMzhkZDEwMmFmYmQ0NzY2OGY1YTJhOGFiMTU1Mg==
+SHA1:
+  metadata.gz: 30ed3c7cb0fb1f9410f4b1b51a88469a6513c828
+  data.tar.gz: 1403adca94c8adf93701ffad2a142504018231cf
 SHA512:
-  metadata.gz: !binary |-
-    ZjQ3ZThhNWM4OWJlYTU5MDJmMWU1NTg4NTM1NDA5MWMxOWYyZDQ3MWNjY2Nh
-    YWZmZDU0ZWQ3MmZhZjgzM2M1YzNmOWNkN2JlNzYxYTE2MTA1NGQzODI3OGZk
-    OTkxYmFmYTYxZTJmODA1ZDI1NzRmOGNiYjE1Zjk4NTFiMjFkYjY=
-  data.tar.gz: !binary |-
-    OGQ4NzY2OGZhNzM3ODU3ZTFhMjdkZDczZDNiZTg0Njg4NDFiNWQ3ZjMwY2U3
-    YmU4M2RiOGRkNTU0ZjRlZDQxMzcxYjM2MGQ3NTk3NTFlZWMxNDhhMjJkMmQ0
-    MTNkMzU1ZTIyYWZjMjc0MzgxZGI5M2Q3ZTE5ZDEzODkzMzdjZDE=
+  metadata.gz: 17a7ac4bf551b6bc25d8139f28c468f946420496f2ddfef1bd4ec0745edfcdf24b029c49f8d672aa303872b54501070fb26ee8907c9ff40012b2cff162b93128
+  data.tar.gz: e3d990dc3997393806f57bcc6dabd8374a5388e8d619ce9b2dc05650985d519c2159b2168e4f6445b7e34616363c09971078068bfdd51059b1672ca3786e8106

data/.gitignore

@@ -4,6 +4,7 @@
 .config
 .yardoc
 .log
+gemfiles/
 Gemfile.lock
 InstalledFiles
 _yardoc
@@ -17,3 +18,4 @@ test/tmp
 test/version_tmp
 tmp
 *.log
+spec/dummy/log

data/.travis.yml

@@ -1,12 +1,14 @@
 cache: bundler
 language:
   - ruby
-before_install: gem install bundler -v=1.5.1
+before_install: gem install bundler
 install:
   - 'bundle install'
 rvm:
   - 1.9.3
   - 2.0.0
   - 2.1.0
+  - 2.1.2
+script: 'bundle exec rspec'
 env:
   - COVERALLS=true

data/README.md

@@ -5,6 +5,8 @@
 [![Build Status](https://travis-ci.org/dinks/bucket_maker.png?branch=master)](https://travis-ci.org/dinks/bucket_maker)
 [![Coverage Status](https://coveralls.io/repos/dinks/bucket_maker/badge.png)](https://coveralls.io/r/dinks/bucket_maker)
 [![Dependency Status](https://gemnasium.com/dinks/bucket_maker.png)](https://gemnasium.com/dinks/bucket_maker)
+[![Bitdeli Badge](https://d2weczhvl823v0.cloudfront.net/dinks/bucket_maker/trend.png)](https://bitdeli.com/free "Bitdeli Badge")
+[![bucket_maker API Documentation](https://www.omniref.com/ruby/gems/bucket_maker.png)](https://www.omniref.com/ruby/gems/bucket_maker)
 
 A Gem to categorize Objects into buckets. Typical use case is an A/B test for Users
 

data/bucket_maker.gemspec

@@ -29,8 +29,12 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "activerecord", ">= 3.1.0" # For model test
   spec.add_development_dependency "sqlite3"
   spec.add_development_dependency "appraisal" # Check against different Rails Versions
-  spec.add_development_dependency "capybara", "= 2.0.3"
-  spec.add_development_dependency "pry-debugger"
+  spec.add_development_dependency "capybara" # "= 2.0.3"
+  if RUBY_VERSION > "1.9.3"
+    spec.add_development_dependency "pry-byebug"
+  else
+    spec.add_development_dependency "pry-debugger"
+  end
   spec.add_development_dependency "rspec-rails"
   spec.add_development_dependency "factory_girl_rails"
   spec.add_development_dependency "mock_redis"

data/lib/bucket_maker/series.rb

@@ -32,8 +32,8 @@ module BucketMaker
 
     # Iterator going through each bucket
     #
-    def each_bucket
-      @buckets.each do |bucket_name, bucket|
+    def map_bucket
+      @buckets.map do |bucket_name, bucket|
         yield bucket_name, bucket
       end if block_given?
     end

data/lib/bucket_maker/series_maker.rb

@@ -1,4 +1,5 @@
 require 'singleton'
+require 'yaml'
 require 'active_support/inflector'
 require 'bucket_maker/series'
 require 'bucket_maker/bucket'
@@ -25,7 +26,7 @@ module BucketMaker
       absolute_config_path = Rails.root + config
 
       if File.exists?(absolute_config_path)
-        @configuration = YAML.load_file(absolute_config_path)
+        @configuration = ::YAML.load_file(absolute_config_path)
 
         @series = @configuration[BUCKET_ROOT].inject({}) do |result, (series_name, series_options)|
                     result[series_name.to_sym] = BucketMaker::Series.new(series_name, series_options)
@@ -47,9 +48,9 @@ module BucketMaker
     #
     def for_each_series_with_bucketable
       @series.map do |series_name, series|
-        series.each_bucket do |bucket_name, bucket|
+        series.map_bucket do |bucket_name, bucket|
           yield self, series_name, bucket_name
-        end
+        end.inject(true) {|result, value| result && value }
       end.inject(true) {|result, value| result && value } if block_given?
     end
 

data/lib/bucket_maker/version.rb

@@ -1,5 +1,5 @@
 module BucketMaker
   # Get the version number
   #
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/spec/controllers/bucket_maker_controller_spec.rb

@@ -1,12 +1,12 @@
 require 'spec_helper'
 require 'json'
 
-describe BucketMakerController do
+describe BucketMakerController, type: :controller do
 
   let(:user) { build(:user) }
 
   before do
-    ApplicationController.any_instance.stub(:set_current_user) { true }
+    allow_any_instance_of(ApplicationController).to receive(:set_current_user).and_return(true)
     controller.instance_variable_set(:@current_user, user)
   end
 
@@ -19,7 +19,7 @@ describe BucketMakerController do
       before { get :show, series_name: 'test_series_one', bucket_name: 'actual_test_one', group_name: 'group_one'}
 
       it 'returns failure' do
-        response.should_not be_success
+        expect(response.status).to eql(401)
       end
     end
 
@@ -27,7 +27,7 @@ describe BucketMakerController do
       before { post :switch, series_name: 'test_series_one', bucket_name: 'actual_test_one', group_name: 'group_one'}
 
       it 'returns failure' do
-        response.should_not be_success
+        expect(response.status).to eql(401)
       end
     end
 
@@ -35,7 +35,7 @@ describe BucketMakerController do
       before { post :randomize, series_name: 'test_series_one', bucket_name: 'actual_test_one'}
 
       it 'returns failure' do
-        response.should_not be_success
+        expect(response.status).to eql(401)
       end
     end
   end
@@ -46,7 +46,7 @@ describe BucketMakerController do
         before { get :show, series_name: 'non_existant_series', bucket_name: 'actual_test_one', group_name: 'group_one'}
 
         it 'returns failure' do
-          response.should_not be_success
+          expect(response.status).to eql(404)
         end
       end
 
@@ -54,7 +54,7 @@ describe BucketMakerController do
         before { post :switch, series_name: 'non_existant_series', bucket_name: 'actual_test_one', group_name: 'group_one'}
 
         it 'returns failure' do
-          response.should_not be_success
+          expect(response.status).to eql(404)
         end
       end
 
@@ -62,7 +62,7 @@ describe BucketMakerController do
         before { post :randomize, series_name: 'non_existant_series', bucket_name: 'actual_test_one'}
 
         it 'returns failure' do
-          response.should_not be_success
+          expect(response.status).to eql(404)
         end
       end
     end
@@ -70,17 +70,17 @@ describe BucketMakerController do
     context 'for get group' do
       it 'returns success' do
         get :show, series_name: 'test_series_one', bucket_name: 'actual_test_one', group_name: 'group_one'
-        response.should be_success
+        expect(response.status).to eql(200)
       end
 
       context 'for the correct bucket' do
         before do
-          user.stub(:in_bucket?).with('test_series_one', 'actual_test_one', 'group_one') { true }
+          allow(user).to receive(:in_bucket?).and_return(true)
           get :show, series_name: 'test_series_one', bucket_name: 'actual_test_one', group_name: 'group_one'
         end
 
         it 'has a true response' do
-          response.body.should include('true')
+          expect(response.body).to include('true')
         end
       end
     end
@@ -89,11 +89,11 @@ describe BucketMakerController do
       before { post :switch, series_name: 'test_series_one', bucket_name: 'actual_test_one', group_name: 'group_one'}
 
       it 'returns success' do
-        response.should be_success
+        expect(response.status).to eql(200)
       end
 
       it 'has a true response' do
-        response.body.should include('true')
+        expect(response.body).to include('true')
       end
     end
 
@@ -101,11 +101,11 @@ describe BucketMakerController do
       before { post :randomize, series_name: 'test_series_one', bucket_name: 'actual_test_one'}
 
       it 'returns success' do
-        response.should be_success
+        expect(response.status).to eql(200)
       end
 
       it 'has a true response' do
-        response.body.should include('true')
+        expect(response.body).to include('true')
       end
     end
   end

data/spec/{routing → routes}/routes_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe 'Routes' do
+describe 'Routes', type: :routing do
   context 'with default routes' do
     it 'should have get bucket route' do
       expect(get: '/2bOrNot2B/test_series_one/actual_test_one/group_one.json').to route_to(
@@ -36,18 +36,22 @@ describe 'Routes' do
   end
 
   context 'with special prefix' do
+    let(:new_path) { 'non_default_path/' }
+
     around do |example|
       default_base_path = BucketMaker.configuration.path_prefix
-      BucketMaker.configuration.path_prefix = 'non_default_path'
+      BucketMaker.configuration.path_prefix = new_path
 
       Rails.application.reload_routes!
 
+      example.run
+
       BucketMaker.configuration.path_prefix = default_base_path
       Rails.application.reload_routes!
     end
 
     it 'should have get bucket route' do
-      expect(get: '/non_default_path/test_series_one/actual_test_one/group_one.json').to route_to(
+      expect(get: "/#{new_path}test_series_one/actual_test_one/group_one.json").to route_to(
         controller:         'bucket_maker',
         action:             'show',
         series_name:        'test_series_one',
@@ -58,7 +62,7 @@ describe 'Routes' do
     end
 
     it 'should have force set bucket route' do
-      expect(post: '/non_default_path/test_series_one/actual_test_one/group_one.json').to route_to(
+      expect(post: "/#{new_path}test_series_one/actual_test_one/group_one.json").to route_to(
         controller:         'bucket_maker',
         action:             'switch',
         series_name:        'test_series_one',
@@ -69,7 +73,7 @@ describe 'Routes' do
     end
 
     it 'should have randomize bucket route' do
-      expect(post: '/non_default_path/test_series_one/actual_test_one.json').to route_to(
+      expect(post: "/#{new_path}test_series_one/actual_test_one.json").to route_to(
         controller:         'bucket_maker',
         action:             'randomize',
         series_name:        'test_series_one',

data/spec/unit/bucket_spec.rb

@@ -17,41 +17,59 @@ describe BucketMaker::Bucket do
 
   context 'for configuration' do
     it 'should have the correct distributions' do
-      bucket.distributions[:group_one].should == 0.3
-      bucket.distributions[:group_two].should == 0.5
-      bucket.distributions[:group_three].should == 0.2
+      expect(bucket.distributions[:group_one]).to eql(0.3)
+      expect(bucket.distributions[:group_two]).to eql(0.5)
+      expect(bucket.distributions[:group_three]).to eql(0.2)
     end
 
     context 'and distributions percent' do
       before { bucket.random_group }
 
       it 'should have the correct distribution percentages' do
-        bucket.distributions_percent[:group_one].should == (0..30)
-        bucket.distributions_percent[:group_two].should == (30..80)
-        bucket.distributions_percent[:group_three].should == (80..100)
+        expect(bucket.distributions_percent[:group_one]).to eql(0..30.0)
+        expect(bucket.distributions_percent[:group_two]).to eql(30.0..80.0)
+        expect(bucket.distributions_percent[:group_three]).to eql(80.0..100.0)
       end
     end
   end
 
   context '#is_bucketable?' do
-    it 'should return false if created after doesnt satisfy' do
-      user = build(:user, id: 12345, created_at: DateTime.parse('1st Jan 2010'))
-      bucket.is_bucketable?(user).should be_false
+    subject { bucket.is_bucketable?(user) }
+
+    context 'created after doesnt satisfy' do
+      let(:user) { build(:user, id: 12345, created_at: DateTime.parse('1st Jan 2010')) }
+
+      it 'should return false' do
+        expect(subject).to eql(false)
+      end
     end
 
-    it 'should return true if created after does satisfy' do
-      user = build(:user, id: 12345, created_at: DateTime.parse('3rd Jan 2010'))
-      bucket.is_bucketable?(user).should be_true
+    context 'created after does satisfy' do
+      let(:user) { build(:user, id: 12345, created_at: DateTime.parse('3rd Jan 2010')) }
+
+      it 'should return true' do
+        expect(subject).to eql(true)
+      end
     end
   end
 
   context '#has_group?' do
-    it 'should return false for non existant group' do
-      bucket.has_group?('non_existant_test').should be_false
+    subject { bucket.has_group?(group) }
+
+    context 'for non existant group' do
+      let(:group) { 'non_existant_test' }
+
+      it 'should return false' do
+        expect(subject).to eql(false)
+      end
     end
 
-    it 'should return true for existing group' do
-      bucket.has_group?('group_two').should be_true
+    context 'for existing group' do
+      let(:group) { 'group_two' }
+
+      it 'should return true' do
+        expect(subject).to eql(true)
+      end
     end
   end
 end

data/spec/unit/bucketable_spec.rb

@@ -9,6 +9,7 @@ describe BucketMaker::Models::Bucketable do
   let(:existing_series) { 'test_series_one' }
   let(:existing_bucket) { 'actual_test_one' }
   let(:existing_group)  { 'group_two' }
+  let(:non_existant_series) { 'non_existant_series' }
 
   before do
     dummy.extend BucketMaker::Models::Bucketable
@@ -32,68 +33,84 @@ describe BucketMaker::Models::Bucketable do
 
   context 'with stubbed group_for_key and set_group_for_key' do
     before do
-      dummy.stub(:group_for_key) { true }
-      dummy.stub(:set_group_for_key) { true }
-      dummy.stub(:has_attribute?) { true }
-      dummy.stub(:created_at) { DateTime.parse('1st Jan 2010') }
+      allow(dummy).to receive(:group_for_key).and_return(true)
+      allow(dummy).to receive(:set_group_for_key).and_return(true)
+      allow(dummy).to receive(:has_attribute?).and_return(true)
+      allow(dummy).to receive(:created_at).and_return(DateTime.parse('1st Jan 2010'))
     end
 
     context '#in_bucket?' do
       context 'with invalid params' do
+        subject { dummy.in_bucket?(non_existant_series, existing_bucket, existing_group) }
+
         it 'should return false' do
-          dummy.in_bucket?('non_existant_series', existing_bucket, existing_group).should be_false
+          expect(subject).to eql(false)
         end
       end
 
       context 'with valid params' do
+        subject { dummy.in_bucket?(existing_series, existing_bucket, existing_group) }
+
         it 'should return false' do
           # group_for_key return true and true == existing_group is false
-          dummy.in_bucket?(existing_series, existing_bucket, existing_group).should be_false
+          expect(subject).to eql(false)
         end
 
         context 'when group_for_key returns the current group' do
           before do
-            dummy.stub(:group_for_key).with(anything()) { existing_group }
+            allow(dummy).to receive(:group_for_key).and_return(existing_group)
           end
 
           it 'should return true' do
-            dummy.in_bucket?(existing_series, existing_bucket, existing_group).should be_true
+            expect(subject).to eql(true)
           end
         end
       end
     end
 
     context '#force_to_bucket!' do
+      subject { dummy.force_to_bucket!(series, existing_bucket, existing_group) }
+
       context 'with invalid params' do
+        let(:series) { non_existant_series }
+
         it 'should return false' do
-          dummy.force_to_bucket!('non_existant_series', existing_bucket, existing_group).should be_false
+          expect(subject).to eql(false)
         end
       end
 
       context 'with valid params' do
+        let(:series) { existing_series }
+
         it 'should return true' do
-          dummy.force_to_bucket!(existing_series, existing_bucket, existing_group).should be_true
+          expect(subject).to eql(true)
         end
       end
     end
 
     context '#bucketize_for_series_and_bucket!' do
+      subject { dummy.bucketize_for_series_and_bucket!(series, existing_bucket) }
+
       context 'with invalid params' do
+        let(:series) { non_existant_series }
+
         it 'should return false' do
-          dummy.bucketize_for_series_and_bucket!('non_existant_series', existing_bucket).should be_false
+          expect(subject).to eql(false)
         end
       end
 
       context 'with valid params' do
+        let(:series) { existing_series }
+
         it 'should return true' do
-          dummy.bucketize_for_series_and_bucket!(existing_series, existing_bucket).should be_true
+          expect(subject).to eql(true)
         end
       end
     end
 
     context '#bucketize!' do
       it 'should return true' do
-        dummy.bucketize!.should be_true
+        expect(dummy.bucketize!).to eql(true)
       end
     end
   end

data/spec/unit/series_maker_spec.rb

@@ -6,86 +6,137 @@ describe BucketMaker::SeriesMaker do
   let(:existing_series) { 'test_series_one' }
   let(:existing_bucket) { 'actual_test_one' }
   let(:existing_group)  { 'group_two' }
+  let(:non_existing_series) { 'non_existing_series' }
 
   before do
-    BucketMaker::Bucket.any_instance.stub(:random_group) { existing_group }
+    allow_any_instance_of(BucketMaker::Bucket).to receive(:random_group).and_return(existing_group)
   end
 
   context 'for configuration' do
+    let(:series) { bucket_maker.series_with_name(existing_series) }
+
     it 'should have correct number of series' do
-      bucket_maker.series.keys.length.should == 2 # Look at config/buckets.yml
+      expect(bucket_maker.series.keys.length).to eql(2) # Look at config/buckets.yml
     end
 
     it 'should have correct number of buckets' do
-      bucket_maker.series_with_name(existing_series).buckets.keys.length.should == 2
+      expect(series.buckets.keys.length).to eql(2)
     end
 
     it 'should have correct number of distribut' do
-      bucket_maker.series_with_name(existing_series).bucket_with_name(existing_bucket).distributions.keys.length.should == 3
+      expect(series.bucket_with_name(existing_bucket).distributions.keys.length).to eql(3)
     end
   end
 
   context '#configured?' do
+    subject { bucket_maker.configured? }
+
     it 'should be configured' do
-      bucket_maker.configured?.should be_true
+      expect(subject).to eql(true)
     end
   end
 
   context '#key_for_series' do
+    subject { bucket_maker.key_for_series(user, 'series_one', 'bucket_one') }
+
     it 'should return the correct key' do
-      bucket_maker.key_for_series(user, 'series_one', 'bucket_one').should == 'bucket_maker:user_12345:series_one:bucket_one'
+      expect(subject).to eql('bucket_maker:user_12345:series_one:bucket_one')
     end
   end
 
   context '#has_series?' do
-    it 'should return true for an existing series' do
-      bucket_maker.has_series?(existing_series).should be_true
+    subject { bucket_maker.has_series?(series) }
+
+    context 'for an existing series' do
+      let(:series) { existing_series }
+
+      it 'should return true' do
+        expect(subject).to eql(true)
+      end
     end
 
-    it 'should return false for a non existing series' do
-      bucket_maker.has_series?('non_existing_series').should be_false
+    context 'for a non existing series' do
+      let(:series) { non_existing_series }
+
+      it 'should return false' do
+        expect(subject).to eql(false)
+      end
     end
   end
 
   context '#series_with_name' do
+    subject { bucket_maker.series_with_name(existing_series) }
+
     it 'should return a Series object' do
-      bucket_maker.series_with_name(existing_series).should be_kind_of(BucketMaker::Series)
+      expect(subject).to be_kind_of(BucketMaker::Series)
     end
   end
 
   context '#has_bucket_in_series?' do
-    it 'should return true for an existing bucket' do
-      bucket_maker.has_bucket_in_series?(existing_series, existing_bucket).should be_true
+    subject { bucket_maker.has_bucket_in_series?(series, existing_bucket) }
+
+    context 'for an existing bucket' do
+      let(:series) { existing_series }
+
+      it 'should return true' do
+        expect(subject).to eql(true)
+      end
     end
 
-    it 'should return false for a non existing bucket' do
-      bucket_maker.has_bucket_in_series?('non_existing_series', existing_bucket).should be_false
+    context 'for a non existing bucket' do
+      let(:series) { non_existing_series }
+
+      it 'should return false' do
+        expect(subject).to eql(false)
+      end
     end
   end
 
   context '#has_group_in_bucket_in_series?' do
-    it 'should return true for an existing group' do
-      bucket_maker.has_group_in_bucket_in_series?(existing_series, existing_bucket, existing_group).should be_true
+    subject { bucket_maker.has_group_in_bucket_in_series?(series, existing_bucket, existing_group) }
+
+    context 'for an existing group' do
+      let(:series) { existing_series }
+
+      it 'should return true' do
+        expect(subject).to eql(true)
+      end
     end
 
-    it 'should return false for a non existing group' do
-      bucket_maker.has_group_in_bucket_in_series?('non_existing_series', existing_bucket, existing_group).should be_false
+    context 'for a non existing group' do
+      let(:series) { non_existing_series }
+
+      it 'should return false' do
+        expect(subject).to eql(false)
+      end
     end
   end
 
   context '#bucketize' do
+    subject { bucket_maker.bucketize(existing_series, existing_bucket) }
+
     it 'should return a valid group' do
-      bucket_maker.bucketize(existing_series, existing_bucket).should == existing_group
+      expect(subject).to eql(existing_group)
     end
   end
 
   context '#bucketable?' do
-    it 'should return true for valid params' do
-      bucket_maker.bucketable?(user, existing_series, existing_bucket, existing_group).should be_true
+    subject { bucket_maker.bucketable?(user, series, existing_bucket, existing_group) }
+
+    context 'for valid params' do
+      let(:series) { existing_series }
+
+      it 'should return true' do
+        expect(subject).to eql(true)
+      end
     end
 
-    it 'should return false for invalid params' do
-      bucket_maker.bucketable?(user, 'non_existing_series', existing_bucket, existing_group).should be_false
+    context 'for invalid params' do
+      let(:series) { non_existing_series }
+
+      it 'should return false' do
+        expect(subject).to eql(false)
+      end
     end
   end
 end

data/spec/unit/series_spec.rb

@@ -19,46 +19,86 @@ describe BucketMaker::Series do
   end
 
   let(:series) { BucketMaker::Series.new('test_series', series_options) }
+  let(:existant_bucket) { 'actual_test_one' }
+  let(:non_existant_bucket) { 'non_existant_test' }
 
   context '#bucket_with_name' do
-    it 'should return a Bucket object' do
-      series.bucket_with_name('actual_test_one').should be_kind_of(BucketMaker::Bucket)
+    subject { series.bucket_with_name(bucket) }
+
+    context 'with an existing bucket' do
+      let(:bucket) { existant_bucket }
+
+      it 'should return a Bucket object' do
+        expect(subject).to be_kind_of(BucketMaker::Bucket)
+      end
     end
 
-    it 'should return a Bucket object' do
-      series.bucket_with_name('non_existant_test').should be_nil
+    context 'with a non existing bucket' do
+      let(:bucket) { non_existant_bucket }
+
+      it 'should return nil' do
+        expect(subject).to be_nil
+      end
     end
   end
 
   context '#is_bucketable?' do
-    it 'should return false if created after doesnt satisfy' do
-      user = build(:user, id: 12345, created_at: DateTime.parse('1st Jan 2010'))
-      series.is_bucketable?(user).should be_false
+    subject { series.is_bucketable?(user) }
+
+    context 'when created after doesnt satisfy' do
+      let(:user) { build(:user, id: 12345, created_at: DateTime.parse('1st Jan 2010')) }
+
+      it 'should return false' do
+        expect(subject).to eql(false)
+      end
     end
 
-    it 'should return true if created after does satisfy' do
-      user = build(:user, id: 12345, created_at: DateTime.parse('3rd Jan 2010'))
-      series.is_bucketable?(user).should be_true
+    context 'when created after does satisfy' do
+      let(:user) { build(:user, id: 12345, created_at: DateTime.parse('3rd Jan 2010')) }
+
+      it 'should return true' do
+        expect(subject).to eql(true)
+      end
     end
   end
 
   context '#has_bucket?' do
-    it 'should return false for non existant bucket' do
-      series.has_bucket?('non_existant_test').should be_false
+    subject { series.has_bucket?(bucket) }
+
+    context 'for non existant bucket' do
+      let(:bucket) { non_existant_bucket }
+
+      it 'should return false' do
+        expect(subject).to eql(false)
+      end
     end
 
-    it 'should return true for existing bucket' do
-      series.has_bucket?('actual_test_one').should be_true
+    context 'for non existant bucket' do
+      let(:bucket) { existant_bucket }
+
+      it 'should return true' do
+        expect(subject).to eql(true)
+      end
     end
   end
 
   context '#has_group_in_bucket?' do
-    it 'should return false for non existant group' do
-      series.has_group_in_bucket?('actual_test_one', 'non_existant_test').should be_false
+    subject { series.has_group_in_bucket?(existant_bucket, group) }
+
+    context 'for non existant group' do
+      let(:group) { 'non_existant_test' }
+
+      it 'should return false' do
+        expect(subject).to eql(false)
+      end
     end
 
-    it 'should return false for non existant group' do
-      series.has_group_in_bucket?('actual_test_one', 'group_two').should be_true
+    context 'for an existant group' do
+      let(:group) { 'group_two' }
+
+      it 'should return true' do
+        expect(subject).to eql(true)
+      end
     end
   end
 end

metadata

@@ -1,206 +1,206 @@
 --- !ruby/object:Gem::Specification
 name: bucket_maker
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Dinesh Vasudevan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-04 00:00:00.000000000 Z
+date: 2014-10-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: redis
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.1.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.1.0
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.1.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.1.0
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: appraisal
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: capybara
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.0.3
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.0.3
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: pry-debugger
+  name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: factory_girl_rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: mock_redis
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: ! ' Create Simple A/B categories '
+description: " Create Simple A/B categories "
 email:
 - dinesh.vasudevan@gmail.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .travis.yml
+- ".gitignore"
+- ".travis.yml"
 - Appraisals
 - Gemfile
 - LICENSE.txt
@@ -262,7 +262,7 @@ files:
 - spec/dummy/db/migrate/20131223144333_create_users.rb
 - spec/dummy/db/test.sqlite3
 - spec/factories/factories.rb
-- spec/routing/routes_spec.rb
+- spec/routes/routes_spec.rb
 - spec/spec_helper.rb
 - spec/unit/bucket_spec.rb
 - spec/unit/bucketable_spec.rb
@@ -278,17 +278,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: 1.9.3
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.1.10
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: A Gem to categorize Objects into buckets. Typical use case is an A/B test
@@ -331,7 +331,7 @@ test_files:
 - spec/dummy/db/migrate/20131223144333_create_users.rb
 - spec/dummy/db/test.sqlite3
 - spec/factories/factories.rb
-- spec/routing/routes_spec.rb
+- spec/routes/routes_spec.rb
 - spec/spec_helper.rb
 - spec/unit/bucket_spec.rb
 - spec/unit/bucketable_spec.rb