buckaruby 1.6.0 → 1.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cd18b05ba430e3bacfcc57c185fbd9816bab502952952b29779e77020b0b0434
-  data.tar.gz: 907f88a18e966207aaf0bed93ec129c5e8a7768470fe9604fab99d8058823269
+  metadata.gz: bbc9889fbec21efa16afde817a492b839b2c69ae3c2d442ed5a4d0f8631d27ca
+  data.tar.gz: 3e09c5226383463a8364a16dcd21f70ace68632cede58ba48bc6c9d00e67470f
 SHA512:
-  metadata.gz: 00fcdbc6d4459d0af2762b1ca738f4970d50e50421db3a1409c6ff681cc8c46a05a62e34d3544a9d0642337fc37feed302c0412b390498f2a3dc97b3a0f22808
-  data.tar.gz: bdcb6e097e78763a40ee8ac317021ba730be60da19984c0a58b7b0ee2d0c38593a460f39e061ef5aa10e0596db6f9415d73df83446c2e05ec31c1d6314ea2a3a
+  metadata.gz: 3f89515b95016c1f954b9862de10c98c8a9d82027a6276307c60ae73a68075c880d36ceb560a5858acc9eafc404737cabc096c16572f09f645f8324b95194d74
+  data.tar.gz: 38a8749448b840d033f60c2698f050594f4feef63ace780122801c6fe5a2739cc3ab4a67c364358a66132b59a1233c177fa89fb28ae206c8f98b180b1fa45eae

data/.github/workflows/test.yml

@@ -0,0 +1,23 @@
+name: CI
+
+on:
+  push:
+    branches:
+      - 1.x
+  pull_request:
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby-version: ['2.4', '2.5', '2.6', '2.7', '3.0']
+
+    steps:
+    - uses: actions/checkout@v2
+    - uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby-version }}
+        bundler-cache: true
+    - name: Run tests
+      run: bundle exec rake

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Buckaruby changelog
 
+## 1.7.0 (2021-07-16)
+
+- Add payment method Giropay.
+
 ## 1.6.0 (2021-04-15)
 
 - Add Revolut to the list of iDEAL issuers.

data/Gemfile.lock

@@ -1,13 +1,13 @@
 PATH
   remote: .
   specs:
-    buckaruby (1.6.0)
+    buckaruby (1.7.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    addressable (2.6.0)
-      public_suffix (>= 2.0.2, < 4.0)
+    addressable (2.8.0)
+      public_suffix (>= 2.0.2, < 5.0)
     ast (2.4.0)
     crack (0.4.3)
       safe_yaml (~> 1.0.0)
@@ -17,7 +17,7 @@ GEM
     parallel (1.19.1)
     parser (2.7.0.5)
       ast (~> 2.4.0)
-    public_suffix (3.1.1)
+    public_suffix (4.0.6)
     rainbow (3.0.0)
     rake (12.3.3)
     rexml (3.2.4)

data/README.md

@@ -1,7 +1,7 @@
 # Buckaruby
 
 [![Gem Version](https://badge.fury.io/rb/buckaruby.svg)](https://badge.fury.io/rb/buckaruby)
-[![Build Status](https://travis-ci.org/KentaaNL/buckaruby.svg?branch=master)](https://travis-ci.org/KentaaNL/buckaruby)
+[![Build Status](https://github.com/KentaaNL/buckaruby/actions/workflows/test.yml/badge.svg)](https://github.com/KentaaNL/buckaruby/actions)
 [![Code Climate](https://codeclimate.com/github/KentaaNL/buckaruby/badges/gpa.svg)](https://codeclimate.com/github/KentaaNL/buckaruby)
 
 The Buckaruby gem provides a Ruby library for communicating with the Buckaroo Payment Engine 3.0.

data/lib/buckaruby/gateway.rb

@@ -173,7 +173,7 @@ module Buckaruby
       valid_payment_methods = [
         PaymentMethod::IDEAL, PaymentMethod::IDEAL_PROCESSING, PaymentMethod::VISA, PaymentMethod::MASTER_CARD,
         PaymentMethod::MAESTRO, PaymentMethod::AMERICAN_EXPRESS, PaymentMethod::SEPA_DIRECT_DEBIT,
-        PaymentMethod::PAYPAL, PaymentMethod::BANCONTACT_MISTER_CASH, PaymentMethod::SOFORT
+        PaymentMethod::PAYPAL, PaymentMethod::BANCONTACT_MISTER_CASH, PaymentMethod::SOFORT, PaymentMethod::GIROPAY
       ]
       validate_payment_method!(options, valid_payment_methods)
 

data/lib/buckaruby/payment_method.rb

@@ -9,6 +9,7 @@ module Buckaruby
     PAYPAL = "paypal"
     BANCONTACT_MISTER_CASH = "bancontactmrcash"
     SOFORT = "sofortueberweisung"
+    GIROPAY = "giropay"
     TRANSFER = "transfer"
 
     # Credit cards

data/lib/buckaruby/transaction_type.rb

@@ -18,7 +18,8 @@ module Buckaruby
              'C002', 'C004', 'C005',                          # (SEPA) Direct Debit
              'V010', 'V014',                                  # PayPal
              'C090', 'V090',                                  # Bancontact
-             'N074', 'C075',                                  # Sofort
+             'C075', 'N074',                                  # Sofort
+             'C241', 'N031',                                  # Giropay
              'C001',                                          # Transfer
 
              'C044', 'C192', 'C283', 'C293', 'C318', 'C345',
@@ -46,7 +47,8 @@ module Buckaruby
              'C102', 'C500',                                  # (SEPA) Direct Debit
              'V110',                                          # PayPal
              'C092', 'V092',                                  # Bancontact
-             'N540', 'C543',                                  # Sofort
+             'C543', 'N540',                                  # Sofort
+             'C242', 'N541',                                  # Giropay
              'C101',                                          # Transfer
 
              'C080', 'C194', 'C281', 'C290', 'C315', 'C342',

data/lib/buckaruby/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Buckaruby
-  VERSION = "1.6.0"
+  VERSION = "1.7.0"
 end

data/spec/buckaruby/gateway_spec.rb

@@ -228,6 +228,16 @@ RSpec.describe Buckaruby::Gateway do
       expect(response.to_h).to be_an_instance_of(Hash)
     end
 
+    it 'initiates a transaction for payment method giropay' do
+      response = subject.setup_transaction(amount: 10, payment_method: Buckaruby::PaymentMethod::GIROPAY, invoicenumber: "12345", return_url: "http://www.return.url/")
+      expect(response).to be_an_instance_of(Buckaruby::SetupTransactionResponse)
+      expect(response.transaction_id).to eq("41C48B55FA9164E123CC73B1157459E840BE5D24")
+      expect(response.transaction_status).to eq(Buckaruby::TransactionStatus::PENDING)
+      expect(response.transaction_type).to eq(Buckaruby::TransactionType::PAYMENT)
+      expect(response.redirect_url).not_to be nil
+      expect(response.timestamp).to be_an_instance_of(Time)
+    end
+
     context 'with custom variables' do
       it 'sends the custom variables with the request' do
         response = subject.setup_transaction(amount: 10, payment_method: Buckaruby::PaymentMethod::IDEAL, payment_issuer: "ABNANL2A", invoicenumber: "12345", return_url: "http://www.return.url/", custom: { foo: :bar, quux: "42" })
@@ -236,7 +246,7 @@ RSpec.describe Buckaruby::Gateway do
         expect(response.custom[:quux]).to eq("42")
 
         expect(WebMock).to have_requested(:post, "https://testcheckout.buckaroo.nl/nvp/?op=TransactionRequest")
-          .with(body: "brq_websitekey=12345678&brq_payment_method=ideal&brq_culture=nl-NL&brq_currency=EUR&brq_amount=10.0&brq_invoicenumber=12345&brq_service_ideal_action=Pay&brq_service_ideal_issuer=ABNANL2A&brq_service_ideal_version=2&brq_return=http%3A%2F%2Fwww.return.url%2F&cust_foo=bar&cust_quux=42&add_buckaruby=Buckaruby+#{Buckaruby::VERSION}&brq_signature=f2c060e624faf02aabf8958d2a1898e2cbcfeac7")
+          .with(body: "brq_websitekey=12345678&brq_payment_method=ideal&brq_culture=nl-NL&brq_currency=EUR&brq_amount=10.0&brq_invoicenumber=12345&brq_service_ideal_action=Pay&brq_service_ideal_issuer=ABNANL2A&brq_service_ideal_version=2&brq_return=http%3A%2F%2Fwww.return.url%2F&cust_foo=bar&cust_quux=42&add_buckaruby=Buckaruby+#{Buckaruby::VERSION}&brq_signature=979f64bc651c9e780844c0866380fa2554897131")
       end
     end
 
@@ -248,7 +258,7 @@ RSpec.describe Buckaruby::Gateway do
         expect(response.additional[:myreference]).to eq("12345")
 
         expect(WebMock).to have_requested(:post, "https://testcheckout.buckaroo.nl/nvp/?op=TransactionRequest")
-          .with(body: "brq_websitekey=12345678&brq_payment_method=ideal&brq_culture=nl-NL&brq_currency=EUR&brq_amount=10.0&brq_invoicenumber=12345&brq_service_ideal_action=Pay&brq_service_ideal_issuer=ABNANL2A&brq_service_ideal_version=2&brq_return=http%3A%2F%2Fwww.return.url%2F&add_myreference=12345&add_buckaruby=Buckaruby+#{Buckaruby::VERSION}&brq_signature=d9f8aebb207f8694ce819b6a84b557839cdbc69f")
+          .with(body: "brq_websitekey=12345678&brq_payment_method=ideal&brq_culture=nl-NL&brq_currency=EUR&brq_amount=10.0&brq_invoicenumber=12345&brq_service_ideal_action=Pay&brq_service_ideal_issuer=ABNANL2A&brq_service_ideal_version=2&brq_return=http%3A%2F%2Fwww.return.url%2F&add_myreference=12345&add_buckaruby=Buckaruby+#{Buckaruby::VERSION}&brq_signature=b3b7db8c80ea3260f86aa916de1a057ffce3db78")
       end
     end
   end
@@ -666,6 +676,19 @@ RSpec.describe Buckaruby::Gateway do
         expect(response.timestamp).to be_an_instance_of(Time)
         expect(response.to_h).to be_an_instance_of(Hash)
       end
+
+      it 'sets the transaction type to payment and payment method to Giropay for giropay callback' do
+        params = File.read("spec/fixtures/responses/callback_payment_giropay.txt")
+
+        response = subject.callback(params)
+        expect(response.transaction_status).to eq(Buckaruby::TransactionStatus::SUCCESS)
+        expect(response.transaction_type).to eq(Buckaruby::TransactionType::PAYMENT)
+        expect(response.payment_method).to eq(Buckaruby::PaymentMethod::GIROPAY)
+        expect(response.transaction_id).to eq("41C48B55FA9164E123CC73B1157459E840BE5D24")
+        expect(response.payment_id).to eq("E86256B2787EE7FF0C33D0D4C6159CD922227B79")
+        expect(response.invoicenumber).to eq("12345")
+        expect(response.timestamp).to be_an_instance_of(Time)
+      end
     end
 
     context 'when callback is a payment recurrent response' do

data/spec/fixtures/responses/callback_payment_giropay.txt

@@ -0,0 +1 @@
+brq_amount=10.00&brq_currency=EUR&brq_description=test&brq_invoicenumber=12345&brq_mutationtype=Collecting&brq_payment=E86256B2787EE7FF0C33D0D4C6159CD922227B79&brq_service_giropay_bankstatementid=2EGGF1P&brq_statuscode=190&brq_statuscode_detail=S990&brq_statusmessage=The+request+was+successful.&brq_test=true&brq_timestamp=2021-07-13+15%3A43%3A13&brq_transaction_method=giropay&brq_transaction_type=C241&brq_transactions=41C48B55FA9164E123CC73B1157459E840BE5D24&brq_websitekey=12345678&brq_signature=c741889fd17e7a567930ccddf1c12e6822bbfb6e

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: buckaruby
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 1.7.0
 platform: ruby
 authors:
 - Kentaa
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-04-15 00:00:00.000000000 Z
+date: 2021-07-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -74,9 +74,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/test.yml"
 - ".gitignore"
 - ".rubocop.yml"
-- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - Gemfile.lock
@@ -114,6 +114,7 @@ files:
 - spec/fixtures/responses/callback_payment_cancelled.txt
 - spec/fixtures/responses/callback_payment_empty_transaction_type.txt
 - spec/fixtures/responses/callback_payment_failed.txt
+- spec/fixtures/responses/callback_payment_giropay.txt
 - spec/fixtures/responses/callback_payment_pending.txt
 - spec/fixtures/responses/callback_payment_rejected.txt
 - spec/fixtures/responses/callback_payment_sepa.txt
@@ -158,7 +159,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.9
+rubygems_version: 3.0.8
 signing_key:
 specification_version: 4
 summary: Ruby library for communicating with the Buckaroo Payment Engine 3.0.
@@ -174,6 +175,7 @@ test_files:
 - spec/fixtures/responses/callback_payment_cancelled.txt
 - spec/fixtures/responses/callback_payment_empty_transaction_type.txt
 - spec/fixtures/responses/callback_payment_failed.txt
+- spec/fixtures/responses/callback_payment_giropay.txt
 - spec/fixtures/responses/callback_payment_pending.txt
 - spec/fixtures/responses/callback_payment_rejected.txt
 - spec/fixtures/responses/callback_payment_sepa.txt

data/.travis.yml

@@ -1,11 +0,0 @@
-language: ruby
-sudo: false
-cache: bundler
-before_install:
-  - gem update --system
-  - gem install bundler -v '< 2'
-rvm:
-  - 2.4.10
-  - 2.5.9
-  - 2.6.7
-  - 2.7.3