buckaruby 1.1.1 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 46d2621253829070076f927150389b8dcf796576689e6b3a623a87777c31ddde
-  data.tar.gz: 73bf6810bb4b140331c5cebd8c5635daff496579e0950a495f2192fd5299914f
+  metadata.gz: d4513790fda002b5a98011b97768f0e4daad118822dc2d8acfbb0eabe259f86b
+  data.tar.gz: 86fcda3eaf10ff9129d074c236e0e1b4037a3c905ab48cc72c8769e1bae22fd2
 SHA512:
-  metadata.gz: dacaf86700c9f959c9b888e4fa428d00eecc828aa20ea778973c507b9891d94c292243d3ff6dea9823dc48016549748257fa6888e1f64195ae836b6f975f471b
-  data.tar.gz: b07ac9a4d3295111ab5ecf80d3edfe294cb81e2bff867b44ef677c9608b9c448de33afff04e18c5d9500f29f24c4feec7193e46d9d13f385fa7ad3bbcae16eb1
+  metadata.gz: b50d76de5cebb6bae5c698b7f052619657a2afb9745e1c7dcf235d9be21e83ca4f05dc23be13dede2881c82fda4b47a1d117dfe90629a7b3d942b54dbab9a2ab
+  data.tar.gz: d6a9032e3b38d91ff1d4353aec269c558dbb0a034282ece2fbd512f69e000ccb65e2c738c0f2992bf040b0315bb8024bb932c7000c212a8c62846aff178dd75c

data/.gitignore

@@ -6,7 +6,6 @@
 .rvmrc
 .ruby-version
 .ruby-gemset
-Gemfile.lock
 InstalledFiles
 _yardoc
 coverage

data/.rubocop.yml

@@ -1,14 +1,20 @@
 # Buckaruby RuboCop configuration
 
+require:
+  - rubocop-performance
+  - rubocop-rspec
+
 AllCops:
   TargetRubyVersion: 2.3
   DisplayCopNames: true
   DisplayStyleGuide: true
 
+
 # We target 2.3, but still want to support 2.0.
 Gemspec/RequiredRubyVersion:
   Enabled: false
 
+
 Metrics/AbcSize:
   Max: 30
 
@@ -34,12 +40,30 @@ Metrics/ModuleLength:
 Metrics/PerceivedComplexity:
   Max: 9
 
+
 Naming/AccessorMethodName:
   Enabled: false
 
 Naming/MemoizedInstanceVariableName:
   Enabled: false
 
+
+RSpec/DescribedClass:
+  EnforcedStyle: explicit
+
+RSpec/ExampleLength:
+  Max: 15
+
+RSpec/MultipleExpectations:
+  Max: 12
+
+RSpec/NamedSubject:
+  Enabled: false
+
+RSpec/NestedGroups:
+  Max: 4
+
+
 Style/BlockDelimiters:
   Exclude:
     - 'spec/**/*.rb'

data/.travis.yml

@@ -3,9 +3,9 @@ sudo: false
 cache: bundler
 before_install:
   - gem update --system
-  - gem install bundler
+  - gem install bundler -v '< 2'
 rvm:
-  - 2.2.10
   - 2.3.8
-  - 2.4.5
-  - 2.5.3
+  - 2.4.6
+  - 2.5.5
+  - 2.6.3

data/CHANGELOG.md

@@ -1,9 +1,15 @@
 # Buckaruby changelog
 
+## 1.2.0 (2019-08-11)
+
+- Added support for sending custom & additional variables with the request.
+
 ## 1.1.1 (2018-11-30)
+
 - Added Handelsbanken to the list of iDEAL issuers.
 
 ## 1.1.0 (2018-06-01)
+
 - Added payment method iDEAL processing.
 - Added Moneyou to the list of iDEAL issuers.
 - Implemented refund transaction.

data/Gemfile

@@ -5,4 +5,8 @@ source 'https://rubygems.org'
 # Specify your gem's dependencies in buckaruby.gemspec
 gemspec
 
-gem 'rubocop', '~> 0.60.0', group: :test
+group :test do
+  gem 'rubocop', '~> 0.74.0'
+  gem 'rubocop-performance', '~> 1.4.0'
+  gem 'rubocop-rspec', '~> 1.35.0'
+end

data/Gemfile.lock

@@ -0,0 +1,69 @@
+PATH
+  remote: .
+  specs:
+    buckaruby (1.2.0)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    addressable (2.6.0)
+      public_suffix (>= 2.0.2, < 4.0)
+    ast (2.4.0)
+    crack (0.4.3)
+      safe_yaml (~> 1.0.0)
+    diff-lcs (1.3)
+    hashdiff (1.0.0)
+    jaro_winkler (1.5.3)
+    parallel (1.17.0)
+    parser (2.6.3.0)
+      ast (~> 2.4.0)
+    public_suffix (3.1.1)
+    rainbow (3.0.0)
+    rake (10.5.0)
+    rspec (3.8.0)
+      rspec-core (~> 3.8.0)
+      rspec-expectations (~> 3.8.0)
+      rspec-mocks (~> 3.8.0)
+    rspec-core (3.8.2)
+      rspec-support (~> 3.8.0)
+    rspec-expectations (3.8.4)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.8.0)
+    rspec-mocks (3.8.1)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.8.0)
+    rspec-support (3.8.2)
+    rubocop (0.74.0)
+      jaro_winkler (~> 1.5.1)
+      parallel (~> 1.10)
+      parser (>= 2.6)
+      rainbow (>= 2.2.2, < 4.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 1.4.0, < 1.7)
+    rubocop-performance (1.4.1)
+      rubocop (>= 0.71.0)
+    rubocop-rspec (1.35.0)
+      rubocop (>= 0.60.0)
+    ruby-progressbar (1.10.1)
+    safe_yaml (1.0.5)
+    unicode-display_width (1.6.0)
+    webmock (2.3.2)
+      addressable (>= 2.3.6)
+      crack (>= 0.3.2)
+      hashdiff
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  buckaruby!
+  bundler (~> 1.7)
+  rake (~> 10.0)
+  rspec (~> 3.0)
+  rubocop (~> 0.74.0)
+  rubocop-performance (~> 1.4.0)
+  rubocop-rspec (~> 1.35.0)
+  webmock (~> 2.3)
+
+BUNDLED WITH
+   1.17.3

data/README.md

@@ -170,6 +170,39 @@ response = gateway.status(transaction_id: 12345)
 
 See `Buckaruby::StatusResponse` for more details.
 
+### Merchant variables
+
+You can send custom variables and additional variables with each request.
+
+Use the parameter `custom` to build a hash with custom variables and `additional` for building a hash with additional variabeles.
+For example:
+
+```ruby
+options = {
+  amount: 10,
+  payment_method: Buckaruby::PaymentMethod::IDEAL,
+  payment_issuer: Buckaruby::Ideal::ISSUERS.keys.first,
+  invoicenumber: "12345",
+  return_url: "http://www.return.url/",
+  custom: {
+    foo: "bar",
+    quux: "42"
+  },
+  additional: {
+    myreference: "12345"
+  }
+}
+
+response = gateway.setup_transaction(options)
+```
+
+In the response, you can retrieve the custom and additional variables with the methods `custom` and `additional`:
+
+```ruby
+puts response.custom[:foo]
+puts response.additional[:myreference]
+````
+
 ### Error handling
 
 When missing or invalid parameters are passed to any method, an `ArgumentError` will be raised.

data/buckaruby.gemspec

@@ -23,6 +23,6 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency "bundler", "~> 1.7"
   spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency "rspec", "~> 3.5.0", ">= 3.5.0"
-  spec.add_development_dependency "webmock", "~> 2.3", ">= 2.3.2"
+  spec.add_development_dependency "rspec", "~> 3.0"
+  spec.add_development_dependency "webmock", "~> 2.3"
 end

data/lib/buckaruby/request.rb

@@ -50,14 +50,16 @@ module Buckaruby
     # Try to catch some common exceptions Net::HTTP might raise
     rescue Errno::ETIMEDOUT, Errno::EINVAL, Errno::ECONNRESET, Errno::ECONNREFUSED, Errno::EHOSTUNREACH,
            IOError, SocketError, Net::HTTPBadResponse, Net::HTTPHeaderSyntaxError, Net::OpenTimeout,
-           Net::ProtocolError, Net::ReadTimeout, OpenSSL::SSL::SSLError => ex
-      raise ConnectionException, ex
+           Net::ProtocolError, Net::ReadTimeout, OpenSSL::SSL::SSLError => e
+      raise ConnectionException, e
     end
 
     def build_request_data(options)
       params = { brq_websitekey: @config.website }
 
       params.merge!(build_request_params(options))
+      params.merge!(build_custom_params(options[:custom])) if options[:custom]
+      params.merge!(build_additional_params(options[:additional])) if options[:additional]
 
       params[:add_buckaruby] = "Buckaruby #{Buckaruby::VERSION}"
 
@@ -67,6 +69,14 @@ module Buckaruby
       params
     end
 
+    def build_custom_params(options)
+      options.map { |key, value| [:"cust_#{key}", value] }.to_h
+    end
+
+    def build_additional_params(options)
+      options.map { |key, value| [:"add_#{key}", value] }.to_h
+    end
+
     def post_data(params)
       params.map { |key, value| "#{key}=#{CGI.escape(value.to_s)}" }.join("&")
     end

data/lib/buckaruby/response.rb

@@ -39,6 +39,36 @@ module Buckaruby
       parse_time(params[:brq_timestamp])
     end
 
+    def custom
+      @custom ||= begin
+        custom = Support::CaseInsensitiveHash.new
+
+        params.each do |key, value|
+          next unless key.upcase.start_with?("CUST_")
+
+          new_key = key.to_s[5..-1]
+          custom[new_key] = value
+        end
+
+        custom
+      end
+    end
+
+    def additional
+      @additional ||= begin
+        additional = Support::CaseInsensitiveHash.new
+
+        params.each do |key, value|
+          next unless key.upcase.start_with?("ADD_")
+
+          new_key = key.to_s[4..-1]
+          additional[new_key] = value
+        end
+
+        additional
+      end
+    end
+
     private
 
     def parse_response(body)

data/lib/buckaruby/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Buckaruby
-  VERSION = "1.1.1"
+  VERSION = "1.2.0"
 end

data/spec/buckaruby/configuration_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Buckaruby::Configuration do
+RSpec.describe Buckaruby::Configuration do
   describe '#website' do
     it 'sets the website from options' do
       config = Buckaruby::Configuration.new(website: "12345678", secret: "7C222FB2927D828AF22F592134E8932480637C0D")

data/spec/buckaruby/gateway_spec.rb

@@ -2,10 +2,10 @@
 
 require 'spec_helper'
 
-describe Buckaruby::Gateway do
+RSpec.describe Buckaruby::Gateway do
   describe 'initialization' do
     describe 'bad parameters' do
-      it 'should raise an exception when creating a new instance with invalid parameters' do
+      it 'raises an exception when creating a new instance with invalid parameters' do
         expect {
           Buckaruby::Gateway.new
         }.to raise_error(ArgumentError)
@@ -31,7 +31,7 @@ describe Buckaruby::Gateway do
 
   describe '#issuers' do
     context 'when no or false parameters are passed' do
-      it 'should raise an ArgumentError' do
+      it 'raises an ArgumentError' do
         expect { subject.issuers }.to raise_error(ArgumentError)
         expect { subject.issuers(:wrong) }.to raise_error(ArgumentError)
       end
@@ -39,18 +39,20 @@ describe Buckaruby::Gateway do
 
     context 'when ideal is passed' do
       let(:issuers) { subject.issuers(Buckaruby::PaymentMethod::IDEAL) }
+
       it { expect(issuers.length).to be > 0 }
       it { expect(issuers).to include("INGBNL2A" => "ING") }
     end
 
     context 'when ideal processing is passed' do
       let(:issuers) { subject.issuers(Buckaruby::PaymentMethod::IDEAL_PROCESSING) }
+
       it { expect(issuers.length).to be > 0 }
       it { expect(issuers).to include("RABONL2U" => "Rabobank") }
     end
 
     context 'when visa, mastercard, maestro, bankcontact, sepa direct debit or paypal is passed' do
-      it 'should raise an ArgumentError' do
+      it 'raises an ArgumentError' do
         expect { subject.issuers(Buckaruby::PaymentMethod::VISA) }.to raise_error(ArgumentError)
         expect { subject.issuers(Buckaruby::PaymentMethod::MASTER_CARD) }.to raise_error(ArgumentError)
         expect { subject.issuers(Buckaruby::PaymentMethod::MAESTRO) }.to raise_error(ArgumentError)
@@ -62,11 +64,11 @@ describe Buckaruby::Gateway do
   end
 
   describe '#setup_transaction' do
-    before(:each) do
+    before do
       stub_request(:post, "https://testcheckout.buckaroo.nl/nvp/?op=TransactionRequest").to_return(body: File.read("spec/fixtures/responses/setup_transaction_success.txt"))
     end
 
-    it 'should raise an exception when initiating a transaction with missing parameters' do
+    it 'raises an exception when initiating a transaction with missing parameters' do
       expect {
         subject.setup_transaction(amount: 10)
       }.to raise_error(ArgumentError)
@@ -84,7 +86,7 @@ describe Buckaruby::Gateway do
       }.to raise_error(ArgumentError)
     end
 
-    it 'should raise an exception when initiating a transaction with invalid amount' do
+    it 'raises an exception when initiating a transaction with invalid amount' do
       expect {
         subject.setup_transaction(amount: 0, payment_method: Buckaruby::PaymentMethod::IDEAL, payment_issuer: Buckaruby::Ideal::ISSUERS.keys.first, invoicenumber: "12345", return_url: "http://www.return.url/")
       }.to raise_error(ArgumentError)
@@ -94,19 +96,19 @@ describe Buckaruby::Gateway do
       }.to raise_error(ArgumentError)
     end
 
-    it 'should raise an exception when initiating a transaction with invalid payment method' do
+    it 'raises an exception when initiating a transaction with invalid payment method' do
       expect {
         subject.setup_transaction(amount: 10, payment_method: "abc", payment_issuer: Buckaruby::Ideal::ISSUERS.keys.first, invoicenumber: "12345", return_url: "http://www.return.url/")
       }.to raise_error(ArgumentError)
     end
 
-    it 'should raise an exception when initiating a transaction with invalid payment issuer' do
+    it 'raises an exception when initiating a transaction with invalid payment issuer' do
       expect {
         subject.setup_transaction(amount: 10, payment_method: Buckaruby::PaymentMethod::IDEAL, payment_issuer: "abc", invoicenumber: "12345", return_url: "http://www.return.url/")
       }.to raise_error(ArgumentError)
     end
 
-    it 'should raise a ConnectionException when connection the Buckaroo fails' do
+    it 'raises a ConnectionException when connection the Buckaroo fails' do
       stub_request(:post, "https://testcheckout.buckaroo.nl/nvp/?op=TransactionRequest").to_raise(Errno::ECONNREFUSED)
 
       expect {
@@ -114,7 +116,7 @@ describe Buckaruby::Gateway do
       }.to raise_error(Buckaruby::ConnectionException)
     end
 
-    it 'should raise an InvalidResponseException when Buckaroo returns an invalid response' do
+    it 'raises an InvalidResponseException when Buckaroo returns an invalid response' do
       stub_request(:post, "https://testcheckout.buckaroo.nl/nvp/?op=TransactionRequest").to_return(status: 500)
 
       expect {
@@ -122,7 +124,7 @@ describe Buckaruby::Gateway do
       }.to raise_error(Buckaruby::InvalidResponseException)
     end
 
-    it 'should raise an ApiException when API result Fail is returned' do
+    it 'raises an ApiException when API result Fail is returned' do
       stub_request(:post, "https://testcheckout.buckaroo.nl/nvp/?op=TransactionRequest").to_return(body: "BRQ_APIRESULT=Fail&BRQ_APIERRORMESSAGE=Invalid+request")
 
       expect {
@@ -130,60 +132,63 @@ describe Buckaruby::Gateway do
       }.to raise_error(Buckaruby::ApiException)
     end
 
-    describe 'should initiate a transaction when amount is integer, decimal or string' do
+    describe 'initiates a transaction when amount is integer, decimal or string' do
       context 'when amount is an integer' do
         let(:response) { subject.setup_transaction(amount: 10, payment_method: Buckaruby::PaymentMethod::IDEAL, payment_issuer: Buckaruby::Ideal::ISSUERS.keys.first, invoicenumber: "12345", return_url: "http://www.return.url/") }
+
         it { expect(response).to be_an_instance_of(Buckaruby::SetupTransactionResponse) }
         it { expect(response.transaction_id).to eq("41C48B55FA9164E123CC73B1157459E840BE5D24") }
-        it { expect(response.redirect_url).to be }
+        it { expect(response.redirect_url).not_to be nil }
       end
 
       context 'when amount is a decimal' do
         let(:response) { subject.setup_transaction(amount: 10.50, payment_method: Buckaruby::PaymentMethod::IDEAL, payment_issuer: Buckaruby::Ideal::ISSUERS.keys.first, invoicenumber: "12345", return_url: "http://www.return.url/") }
+
         it { expect(response).to be_an_instance_of(Buckaruby::SetupTransactionResponse) }
         it { expect(response.transaction_id).to eq("41C48B55FA9164E123CC73B1157459E840BE5D24") }
-        it { expect(response.redirect_url).to be }
+        it { expect(response.redirect_url).not_to be nil }
       end
 
       context 'when amount is a string' do
         let(:response) { subject.setup_transaction(amount: '10', payment_method: Buckaruby::PaymentMethod::IDEAL, payment_issuer: Buckaruby::Ideal::ISSUERS.keys.first, invoicenumber: "12345", return_url: "http://www.return.url/") }
+
         it { expect(response).to be_an_instance_of(Buckaruby::SetupTransactionResponse) }
         it { expect(response.transaction_id).to eq("41C48B55FA9164E123CC73B1157459E840BE5D24") }
-        it { expect(response.redirect_url).to be }
+        it { expect(response.redirect_url).not_to be nil }
       end
     end
 
-    it 'should initiate a transaction for payment method ideal' do
+    it 'initiates a transaction for payment method ideal' do
       response = subject.setup_transaction(amount: 10, payment_method: Buckaruby::PaymentMethod::IDEAL, payment_issuer: Buckaruby::Ideal::ISSUERS.keys.first, invoicenumber: "12345", return_url: "http://www.return.url/")
       expect(response).to be_an_instance_of(Buckaruby::SetupTransactionResponse)
       expect(response.transaction_id).to eq("41C48B55FA9164E123CC73B1157459E840BE5D24")
       expect(response.transaction_status).to eq(Buckaruby::TransactionStatus::PENDING)
-      expect(response.redirect_url).to be
+      expect(response.redirect_url).not_to be nil
       expect(response.timestamp).to be_an_instance_of(Time)
       expect(response.to_h).to be_an_instance_of(Hash)
     end
 
-    it 'should initiate a transaction for payment method visa' do
+    it 'initiates a transaction for payment method visa' do
       response = subject.setup_transaction(amount: 10, payment_method: Buckaruby::PaymentMethod::VISA, invoicenumber: "12345", return_url: "http://www.return.url/")
       expect(response).to be_an_instance_of(Buckaruby::SetupTransactionResponse)
       expect(response.transaction_id).to eq("41C48B55FA9164E123CC73B1157459E840BE5D24")
       expect(response.transaction_status).to eq(Buckaruby::TransactionStatus::PENDING)
-      expect(response.redirect_url).to be
+      expect(response.redirect_url).not_to be nil
       expect(response.timestamp).to be_an_instance_of(Time)
       expect(response.to_h).to be_an_instance_of(Hash)
     end
 
-    it 'should initiate a transaction for payment method mastercard' do
+    it 'initiates a transaction for payment method mastercard' do
       response = subject.setup_transaction(amount: 10, payment_method: Buckaruby::PaymentMethod::MASTER_CARD, invoicenumber: "12345", return_url: "http://www.return.url/")
       expect(response).to be_an_instance_of(Buckaruby::SetupTransactionResponse)
       expect(response.transaction_id).to eq("41C48B55FA9164E123CC73B1157459E840BE5D24")
       expect(response.transaction_status).to eq(Buckaruby::TransactionStatus::PENDING)
-      expect(response.redirect_url).to be
+      expect(response.redirect_url).not_to be nil
       expect(response.timestamp).to be_an_instance_of(Time)
       expect(response.to_h).to be_an_instance_of(Hash)
     end
 
-    it 'should initiate a transaction for payment method sepa direct debit' do
+    it 'initiates a transaction for payment method sepa direct debit' do
       response = subject.setup_transaction(amount: 10, payment_method: Buckaruby::PaymentMethod::SEPA_DIRECT_DEBIT, invoicenumber: "12345", return_url: "http://www.return.url/", account_iban: "NL13TEST0123456789", account_name: "J. Tester", mandate_reference: "00P12345", collect_date: Date.new(2016, 1, 1))
       expect(response).to be_an_instance_of(Buckaruby::SetupTransactionResponse)
       expect(response.transaction_id).to eq("41C48B55FA9164E123CC73B1157459E840BE5D24")
@@ -192,23 +197,47 @@ describe Buckaruby::Gateway do
       expect(response.to_h).to be_an_instance_of(Hash)
     end
 
-    it 'should initiate a transaction for payment method paypal' do
+    it 'initiates a transaction for payment method paypal' do
       response = subject.setup_transaction(amount: 10, payment_method: Buckaruby::PaymentMethod::PAYPAL, invoicenumber: "12345", return_url: "http://www.return.url/")
       expect(response).to be_an_instance_of(Buckaruby::SetupTransactionResponse)
       expect(response.transaction_id).to eq("41C48B55FA9164E123CC73B1157459E840BE5D24")
       expect(response.transaction_status).to eq(Buckaruby::TransactionStatus::PENDING)
-      expect(response.redirect_url).to be
+      expect(response.redirect_url).not_to be nil
       expect(response.timestamp).to be_an_instance_of(Time)
       expect(response.to_h).to be_an_instance_of(Hash)
     end
+
+    context 'with custom variables' do
+      it 'sends the custom variables with the request' do
+        response = subject.setup_transaction(amount: 10, payment_method: Buckaruby::PaymentMethod::IDEAL, payment_issuer: "ABNANL2A", invoicenumber: "12345", return_url: "http://www.return.url/", custom: { foo: :bar, quux: "42" })
+        expect(response).to be_an_instance_of(Buckaruby::SetupTransactionResponse)
+        expect(response.custom[:foo]).to eq("bar")
+        expect(response.custom[:quux]).to eq("42")
+
+        expect(WebMock).to have_requested(:post, "https://testcheckout.buckaroo.nl/nvp/?op=TransactionRequest")
+          .with(body: "brq_websitekey=12345678&brq_payment_method=ideal&brq_culture=nl-NL&brq_currency=EUR&brq_amount=10.0&brq_invoicenumber=12345&brq_service_ideal_action=Pay&brq_service_ideal_issuer=ABNANL2A&brq_service_ideal_version=2&brq_return=http%3A%2F%2Fwww.return.url%2F&cust_foo=bar&cust_quux=42&add_buckaruby=Buckaruby+#{Buckaruby::VERSION}&brq_signature=0fb3ff3c1f140b5aede33a0fdacbc5675830120d")
+      end
+    end
+
+    context 'with additional variables' do
+      it 'sends the additional variables with the request' do
+        response = subject.setup_transaction(amount: 10, payment_method: Buckaruby::PaymentMethod::IDEAL, payment_issuer: "ABNANL2A", invoicenumber: "12345", return_url: "http://www.return.url/", additional: { myreference: "12345" })
+        expect(response).to be_an_instance_of(Buckaruby::SetupTransactionResponse)
+        expect(response.additional[:buckaruby]).to eq("1.2.0")
+        expect(response.additional[:myreference]).to eq("12345")
+
+        expect(WebMock).to have_requested(:post, "https://testcheckout.buckaroo.nl/nvp/?op=TransactionRequest")
+          .with(body: "brq_websitekey=12345678&brq_payment_method=ideal&brq_culture=nl-NL&brq_currency=EUR&brq_amount=10.0&brq_invoicenumber=12345&brq_service_ideal_action=Pay&brq_service_ideal_issuer=ABNANL2A&brq_service_ideal_version=2&brq_return=http%3A%2F%2Fwww.return.url%2F&add_myreference=12345&add_buckaruby=Buckaruby+#{Buckaruby::VERSION}&brq_signature=f7996840436bdd55dada28b80c62ed88af10cd23")
+      end
+    end
   end
 
   describe '#recurrent_transaction' do
-    before(:each) do
+    before do
       stub_request(:post, "https://testcheckout.buckaroo.nl/nvp/?op=TransactionRequest").to_return(body: File.read("spec/fixtures/responses/recurrent_transaction_success.txt"))
     end
 
-    it 'should raise an exception when initiating a recurrent transaction with missing parameters' do
+    it 'raises an exception when initiating a recurrent transaction with missing parameters' do
       expect {
         subject.recurrent_transaction(amount: 10)
       }.to raise_error(ArgumentError)
@@ -222,13 +251,13 @@ describe Buckaruby::Gateway do
       }.to raise_error(ArgumentError)
     end
 
-    it 'should raise an exception when initiating a transaction with invalid payment method' do
+    it 'raises an exception when initiating a transaction with invalid payment method' do
       expect {
         subject.recurrent_transaction(amount: 10, payment_method: Buckaruby::PaymentMethod::IDEAL, invoicenumber: "12345", transaction_id: "12345")
       }.to raise_error(ArgumentError)
     end
 
-    it 'should initiate a recurrent transaction for payment method visa' do
+    it 'initiates a recurrent transaction for payment method visa' do
       response = subject.recurrent_transaction(amount: 10, payment_method: Buckaruby::PaymentMethod::VISA, invoicenumber: "12345", transaction_id: "12345")
       expect(response).to be_an_instance_of(Buckaruby::RecurrentTransactionResponse)
       expect(response.transaction_id).to eq("41C48B55FA9164E123CC73B1157459E840BE5D24")
@@ -241,20 +270,20 @@ describe Buckaruby::Gateway do
   end
 
   describe '#refundable?' do
-    it 'should raise an exception when required parameters are missing' do
+    it 'raises an exception when required parameters are missing' do
       expect {
         subject.refundable?
       }.to raise_error(ArgumentError)
     end
 
-    it 'should return true when the transaction is refundable' do
+    it 'returns true when the transaction is refundable' do
       stub_request(:post, "https://testcheckout.buckaroo.nl/nvp/?op=RefundInfo").to_return(body: File.read("spec/fixtures/responses/refund_info_success.txt"))
 
       response = subject.refundable?(transaction_id: "41C48B55FA9164E123CC73B1157459E840BE5D24")
       expect(response).to be true
     end
 
-    it 'should return false when the transaction was not found' do
+    it 'returns false when the transaction was not found' do
       stub_request(:post, "https://testcheckout.buckaroo.nl/nvp/?op=RefundInfo").to_return(body: File.read("spec/fixtures/responses/refund_info_error.txt"))
 
       response = subject.refundable?(transaction_id: "41C48B55FA9164E123CC73B1157459E840BE5D24")
@@ -263,13 +292,13 @@ describe Buckaruby::Gateway do
   end
 
   describe '#refund_transaction' do
-    it 'should raise an exception when required parameters are missing' do
+    it 'raises an exception when required parameters are missing' do
       expect {
         subject.refund_transaction
       }.to raise_error(ArgumentError)
     end
 
-    it 'should raise an exception when the transaction is not refundable' do
+    it 'raises an exception when the transaction is not refundable' do
       stub_request(:post, "https://testcheckout.buckaroo.nl/nvp/?op=RefundInfo").to_return(body: File.read("spec/fixtures/responses/refund_info_error.txt"))
 
       expect {
@@ -277,7 +306,7 @@ describe Buckaruby::Gateway do
       }.to raise_error(Buckaruby::NonRefundableTransactionException)
     end
 
-    it 'should refund the transaction' do
+    it 'refunds the transaction' do
       stub_request(:post, "https://testcheckout.buckaroo.nl/nvp/?op=RefundInfo").to_return(body: File.read("spec/fixtures/responses/refund_info_success.txt"))
       stub_request(:post, "https://testcheckout.buckaroo.nl/nvp/?op=TransactionRequest").to_return(body: File.read("spec/fixtures/responses/refund_transaction_success.txt"))
 
@@ -295,11 +324,11 @@ describe Buckaruby::Gateway do
   end
 
   describe '#status' do
-    before(:each) do
+    before do
       stub_request(:post, "https://testcheckout.buckaroo.nl/nvp/?op=TransactionStatus").to_return(body: File.read("spec/fixtures/responses/status_success.txt"))
     end
 
-    it 'should raise an exception when required parameters are missing' do
+    it 'raises an exception when required parameters are missing' do
       expect {
         subject.status
       }.to raise_error(ArgumentError)
@@ -307,7 +336,7 @@ describe Buckaruby::Gateway do
 
     it { expect(subject.status(transaction_id: "41C48B55FA9164E123CC73B1157459E840BE5D24")).to be_an_instance_of(Buckaruby::StatusResponse) }
 
-    it 'should return transaction status' do
+    it 'returns transaction status' do
       response = subject.status(transaction_id: "41C48B55FA9164E123CC73B1157459E840BE5D24")
       expect(response.transaction_status).to eq(Buckaruby::TransactionStatus::SUCCESS)
       expect(response.transaction_type).to eq(Buckaruby::TransactionType::PAYMENT)
@@ -319,7 +348,7 @@ describe Buckaruby::Gateway do
       expect(response.to_h).to be_an_instance_of(Hash)
     end
 
-    it 'should include account iban, bic and name for an ideal response' do
+    it 'includes account iban, bic and name for an ideal response' do
       response = subject.status(transaction_id: "41C48B55FA9164E123CC73B1157459E840BE5D24")
       expect(response.account_iban).to eq("NL44RABO0123456789")
       expect(response.account_bic).to eq("RABONL2U")
@@ -328,20 +357,20 @@ describe Buckaruby::Gateway do
   end
 
   describe '#cancellable?' do
-    it 'should raise an exception when required parameters are missing' do
+    it 'raises an exception when required parameters are missing' do
       expect {
         subject.cancellable?
       }.to raise_error(ArgumentError)
     end
 
-    it 'should return true when the transaction is cancellable' do
+    it 'returns true when the transaction is cancellable' do
       stub_request(:post, "https://testcheckout.buckaroo.nl/nvp/?op=TransactionStatus").to_return(body: File.read("spec/fixtures/responses/status_cancellable.txt"))
 
       response = subject.cancellable?(transaction_id: "41C48B55FA9164E123CC73B1157459E840BE5D24")
       expect(response).to be true
     end
 
-    it 'should return false when the transaction is not cancellable' do
+    it 'returns false when the transaction is not cancellable' do
       stub_request(:post, "https://testcheckout.buckaroo.nl/nvp/?op=TransactionStatus").to_return(body: File.read("spec/fixtures/responses/status_noncancellable.txt"))
 
       response = subject.cancellable?(transaction_id: "41C48B55FA9164E123CC73B1157459E840BE5D24")
@@ -350,13 +379,13 @@ describe Buckaruby::Gateway do
   end
 
   describe '#cancel_transaction' do
-    it 'should raise an exception when required parameters are missing' do
+    it 'raises an exception when required parameters are missing' do
       expect {
         subject.cancel_transaction
       }.to raise_error(ArgumentError)
     end
 
-    it 'should raise an exception when the transaction is not cancellable' do
+    it 'raises an exception when the transaction is not cancellable' do
       stub_request(:post, "https://testcheckout.buckaroo.nl/nvp/?op=TransactionStatus").to_return(body: File.read("spec/fixtures/responses/status_noncancellable.txt"))
 
       expect {
@@ -364,7 +393,7 @@ describe Buckaruby::Gateway do
       }.to raise_error(Buckaruby::NonCancellableTransactionException)
     end
 
-    it 'should cancel the transaction' do
+    it 'cancels the transaction' do
       stub_request(:post, "https://testcheckout.buckaroo.nl/nvp/?op=TransactionStatus").to_return(body: File.read("spec/fixtures/responses/status_cancellable.txt"))
       stub_request(:post, "https://testcheckout.buckaroo.nl/nvp/?op=CancelTransaction").to_return(body: File.read("spec/fixtures/responses/cancel_success.txt"))
 
@@ -374,25 +403,25 @@ describe Buckaruby::Gateway do
   end
 
   describe '#callback' do
-    it 'should raise an exception when parameters are missing' do
+    it 'raises an exception when parameters are missing' do
       expect {
         subject.callback
       }.to raise_error(ArgumentError)
     end
 
-    it 'should raise an exception when parameter is an empty Hash' do
+    it 'raises an exception when parameter is an empty Hash' do
       expect {
         subject.callback({})
       }.to raise_error(ArgumentError)
     end
 
-    it 'should raise an exception when parameter is an empty String' do
+    it 'raises an exception when parameter is an empty String' do
       expect {
         subject.callback("")
       }.to raise_error(ArgumentError)
     end
 
-    it 'should raise a SignatureException when the signature is invalid' do
+    it 'raises a SignatureException when the signature is invalid' do
       params = File.read("spec/fixtures/responses/callback_invalid_signature.txt")
 
       expect {
@@ -400,36 +429,38 @@ describe Buckaruby::Gateway do
       }.to raise_error(Buckaruby::SignatureException, "Sent signature (abcdefgh1234567890abcdefgh1234567890) doesn't match generated signature (0a74bba15fccd8094f33678c001b44851643876d)")
     end
 
-    it 'should return the status when the signature is valid' do
+    it 'returns the status when the signature is valid' do
       params = File.read("spec/fixtures/responses/callback_valid_signature.txt")
 
       response = subject.callback(params)
       expect(response).to be_an_instance_of(Buckaruby::CallbackResponse)
-      expect(response.transaction_status).to be
-      expect(response.transaction_type).to be
-      expect(response.payment_method).to be
-      expect(response.payment_id).to be
-      expect(response.invoicenumber).to be
+      expect(response.transaction_status).to eq(Buckaruby::TransactionStatus::SUCCESS)
+      expect(response.transaction_type).to eq(Buckaruby::TransactionType::PAYMENT)
+      expect(response.payment_method).to eq(Buckaruby::PaymentMethod::IDEAL)
+      expect(response.transaction_id).to eq("41C48B55FA9164E123CC73B1157459E840BE5D24")
+      expect(response.payment_id).to eq("E86256B2787EE7FF0C33D0D4C6159CD922227B79")
+      expect(response.invoicenumber).to eq("12345")
       expect(response.timestamp).to be_an_instance_of(Time)
       expect(response.to_h).to be_an_instance_of(Hash)
     end
 
-    it 'should accept a Hash as parameters' do
+    it 'accepts a Hash as parameters' do
       params = { "brq_amount" => "10.00", "brq_currency" => "EUR", "brq_customer_name" => "J. de Tester", "brq_description" => "Test", "brq_invoicenumber" => "12345", "brq_mutationtype" => "Collecting", "brq_payer_hash" => "e02377112efcd30bb7420bb1b9855a3778864572", "brq_payment" => "E86256B2787EE7FF0C33D0D4C6159CD922227B79", "brq_service_ideal_consumerbic" => "RABONL2U", "brq_service_ideal_consumeriban" => "NL44RABO0123456789", "brq_service_ideal_consumerissuer" => "Rabobank", "brq_service_ideal_consumername" => "J. de Tester", "brq_statuscode" => "190", "brq_statuscode_detail" => "S001", "brq_statusmessage" => "Transaction successfully processed", "brq_test" => "true", "brq_timestamp" => "2014-11-05 13:10:42", "brq_transaction_method" => "ideal", "brq_transaction_type" => "C021", "brq_transactions" => "41C48B55FA9164E123CC73B1157459E840BE5D24", "brq_websitekey" => "12345678", "brq_signature" => "0a74bba15fccd8094f33678c001b44851643876d" }
 
       response = subject.callback(params)
       expect(response).to be_an_instance_of(Buckaruby::CallbackResponse)
-      expect(response.transaction_status).to be
-      expect(response.transaction_type).to be
-      expect(response.payment_method).to be
-      expect(response.payment_id).to be
-      expect(response.invoicenumber).to be
+      expect(response.transaction_status).to eq(Buckaruby::TransactionStatus::SUCCESS)
+      expect(response.transaction_type).to eq(Buckaruby::TransactionType::PAYMENT)
+      expect(response.payment_method).to eq(Buckaruby::PaymentMethod::IDEAL)
+      expect(response.transaction_id).to eq("41C48B55FA9164E123CC73B1157459E840BE5D24")
+      expect(response.payment_id).to eq("E86256B2787EE7FF0C33D0D4C6159CD922227B79")
+      expect(response.invoicenumber).to eq("12345")
       expect(response.timestamp).to be_an_instance_of(Time)
       expect(response.to_h).to be_an_instance_of(Hash)
     end
 
-    context 'payment response' do
-      it 'should set the success status when payment status is success' do
+    context 'when callback is a payment response' do
+      it 'sets the success status when payment status is success' do
         params = File.read("spec/fixtures/responses/callback_payment_success.txt")
 
         response = subject.callback(params)
@@ -443,7 +474,7 @@ describe Buckaruby::Gateway do
         expect(response.to_h).to be_an_instance_of(Hash)
       end
 
-      it 'should set the failed status when payment status is failed' do
+      it 'sets the failed status when payment status is failed' do
         params = File.read("spec/fixtures/responses/callback_payment_failed.txt")
 
         response = subject.callback(params)
@@ -457,7 +488,7 @@ describe Buckaruby::Gateway do
         expect(response.to_h).to be_an_instance_of(Hash)
       end
 
-      it 'should set the rejected status when payment status is rejected' do
+      it 'sets the rejected status when payment status is rejected' do
         params = File.read("spec/fixtures/responses/callback_payment_rejected.txt")
 
         response = subject.callback(params)
@@ -471,7 +502,7 @@ describe Buckaruby::Gateway do
         expect(response.to_h).to be_an_instance_of(Hash)
       end
 
-      it 'should set the cancelled status when payment status is cancelled' do
+      it 'sets the cancelled status when payment status is cancelled' do
         params = File.read("spec/fixtures/responses/callback_payment_cancelled.txt")
 
         response = subject.callback(params)
@@ -485,7 +516,7 @@ describe Buckaruby::Gateway do
         expect(response.to_h).to be_an_instance_of(Hash)
       end
 
-      it 'should set the pending status when payment status is pending' do
+      it 'sets the pending status when payment status is pending' do
         params = File.read("spec/fixtures/responses/callback_payment_pending.txt")
 
         response = subject.callback(params)
@@ -499,7 +530,7 @@ describe Buckaruby::Gateway do
         expect(response.to_h).to be_an_instance_of(Hash)
       end
 
-      it 'should include account iban, bic and name for an ideal response' do
+      it 'includes account iban, bic and name for an ideal response' do
         params = File.read("spec/fixtures/responses/callback_payment_success.txt")
 
         response = subject.callback(params)
@@ -513,7 +544,7 @@ describe Buckaruby::Gateway do
         expect(response.to_h).to be_an_instance_of(Hash)
       end
 
-      it 'should include account iban, name, mandate reference and collect date for a sepa direct debit response' do
+      it 'includes account iban, name, mandate reference and collect date for a sepa direct debit response' do
         params = File.read("spec/fixtures/responses/callback_payment_sepa.txt")
 
         response = subject.callback(params)
@@ -531,7 +562,7 @@ describe Buckaruby::Gateway do
         expect(response.to_h).to be_an_instance_of(Hash)
       end
 
-      it 'should return transaction type payment when cancelling a visa or mastercard transaction (empty transaction type)' do
+      it 'returns transaction type payment when cancelling a visa or mastercard transaction (empty transaction type)' do
         params = File.read("spec/fixtures/responses/callback_payment_empty_transaction_type.txt")
 
         response = subject.callback(params)
@@ -544,8 +575,8 @@ describe Buckaruby::Gateway do
       end
     end
 
-    context 'payment recurrent response' do
-      it 'should recognize a visa payment recurrent response' do
+    context 'when callback is a payment recurrent response' do
+      it 'recognizes a visa payment recurrent response' do
         params = File.read("spec/fixtures/responses/callback_recurrent_visa.txt")
 
         response = subject.callback(params)
@@ -559,7 +590,7 @@ describe Buckaruby::Gateway do
         expect(response.to_h).to be_an_instance_of(Hash)
       end
 
-      it 'should recognize a sepa direct debit payment recurrent response' do
+      it 'recognizes a sepa direct debit payment recurrent response' do
         params = File.read("spec/fixtures/responses/callback_recurrent_sepa.txt")
 
         response = subject.callback(params)
@@ -574,8 +605,8 @@ describe Buckaruby::Gateway do
       end
     end
 
-    context 'refund response' do
-      it 'should recognize an ideal refund response' do
+    context 'when callback is a refund response' do
+      it 'recognizes an ideal refund response' do
         params = File.read("spec/fixtures/responses/callback_refund_ideal.txt")
 
         response = subject.callback(params)
@@ -590,7 +621,7 @@ describe Buckaruby::Gateway do
         expect(response.to_h).to be_an_instance_of(Hash)
       end
 
-      it 'should recognize a paypal refund response' do
+      it 'recognizes a paypal refund response' do
         params = File.read("spec/fixtures/responses/callback_refund_paypal.txt")
 
         response = subject.callback(params)
@@ -606,8 +637,8 @@ describe Buckaruby::Gateway do
       end
     end
 
-    context 'reversal response' do
-      it 'should recognize a sepa direct debit reversal response' do
+    context 'when callback is a reversal response' do
+      it 'recognizes a sepa direct debit reversal response' do
         params = File.read("spec/fixtures/responses/callback_reversal_sepa.txt")
 
         response = subject.callback(params)
@@ -622,7 +653,7 @@ describe Buckaruby::Gateway do
         expect(response.to_h).to be_an_instance_of(Hash)
       end
 
-      it 'should recognize a paypal reversal response' do
+      it 'recognizes a paypal reversal response' do
         params = File.read("spec/fixtures/responses/callback_reversal_paypal.txt")
 
         response = subject.callback(params)

data/spec/buckaruby/iban_spec.rb

@@ -2,72 +2,72 @@
 
 require 'spec_helper'
 
-describe Buckaruby::Iban do
+RSpec.describe Buckaruby::Iban do
   describe 'calculate_iban' do
     describe 'bad initialization' do
-      it 'should raise an exception when account number is not supplied' do
+      it 'raises an exception when account number is not supplied' do
         expect {
           Buckaruby::Iban.calculate_iban(nil, 'INGB')
         }.to raise_error(ArgumentError)
       end
 
-      it 'should raise an exception when account number is empty' do
+      it 'raises an exception when account number is empty' do
         expect {
           Buckaruby::Iban.calculate_iban('', 'INGB')
         }.to raise_error(ArgumentError)
       end
 
-      it 'should raise an exception when bank code is not supplied' do
+      it 'raises an exception when bank code is not supplied' do
         expect {
           Buckaruby::Iban.calculate_iban('555', nil)
         }.to raise_error(ArgumentError)
       end
 
-      it 'should raise an exception when bank code is empty' do
+      it 'raises an exception when bank code is empty' do
         expect {
           Buckaruby::Iban.calculate_iban('555', '')
         }.to raise_error(ArgumentError)
       end
 
-      it 'should raise an exception when country code is not supplied' do
+      it 'raises an exception when country code is not supplied' do
         expect {
           Buckaruby::Iban.calculate_iban('555', 'INGB', '')
         }.to raise_error(ArgumentError)
       end
 
-      it 'should raise an exception when country code is invalid' do
+      it 'raises an exception when country code is invalid' do
         expect {
           Buckaruby::Iban.calculate_iban('555', 'INGB', 'TEST')
         }.to raise_error(ArgumentError)
       end
     end
 
-    it 'should calculate an IBAN for account number 1234 with ING bank' do
+    it 'calculates an IBAN for account number 1234 with ING bank' do
       iban = Buckaruby::Iban.calculate_iban('1234', 'INGB')
       expect(iban).to eq('NL08INGB0000001234')
     end
 
-    it 'should calculate an IBAN for account number 1234567 with ING bank' do
+    it 'calculates an IBAN for account number 1234567 with ING bank' do
       iban = Buckaruby::Iban.calculate_iban('1234567', 'INGB')
       expect(iban).to eq('NL20INGB0001234567')
     end
 
-    it 'should calculate an IBAN for account number 55505 with ING bank' do
+    it 'calculates an IBAN for account number 55505 with ING bank' do
       iban = Buckaruby::Iban.calculate_iban('55505', 'INGB')
       expect(iban).to eq('NL70INGB0000055505')
     end
 
-    it 'should calculate an IBAN for account number 395222419 with Rabobank' do
+    it 'calculates an IBAN for account number 395222419 with Rabobank' do
       iban = Buckaruby::Iban.calculate_iban('395222419', 'RABO')
       expect(iban).to eq('NL25RABO0395222419')
     end
 
-    it 'should calculate an IBAN for account number 707070406 with ABN Amro' do
+    it 'calculates an IBAN for account number 707070406 with ABN Amro' do
       iban = Buckaruby::Iban.calculate_iban('707070406', 'ABNA')
       expect(iban).to eq('NL87ABNA0707070406')
     end
 
-    it 'should calculate an IBAN for account number 254668844 with Triodos bank' do
+    it 'calculates an IBAN for account number 254668844 with Triodos bank' do
       iban = Buckaruby::Iban.calculate_iban('254668844', 'TRIO')
       expect(iban).to eq('NL56TRIO0254668844')
     end

data/spec/buckaruby/signature_spec.rb

@@ -2,33 +2,33 @@
 
 require 'spec_helper'
 
-describe Buckaruby::Signature do
+RSpec.describe Buckaruby::Signature do
   describe 'generate_signature_string' do
-    it 'should ignore parameters that are not prefixed with brq_, add_ or cust_' do
+    it 'ignores parameters that are not prefixed with brq_, add_ or cust_' do
       params = { abc: 'true', def: 'true', brq_test: 'true', add_test: 'true', cust_test: 'true' }
       string = Buckaruby::Signature.generate_signature_string(params, 'secret')
       expect(string).to eq('add_test=truebrq_test=truecust_test=truesecret')
     end
 
-    it 'should ignore the brq_signature parameter' do
+    it 'ignores the brq_signature parameter' do
       params = { brq_test: 'true', add_test: 'true', cust_test: 'true', brq_signature: 'foobar' }
       string = Buckaruby::Signature.generate_signature_string(params, 'secret')
       expect(string).to eq('add_test=truebrq_test=truecust_test=truesecret')
     end
 
-    it 'should accept boolean, integer and string as parameter types' do
+    it 'accepts boolean, integer and string as parameter types' do
       params = { brq_boolean: true, brq_integer: 1337, brq_string: 'foobar', brq_nil: nil }
       string = Buckaruby::Signature.generate_signature_string(params, 'secret')
       expect(string).to eq('brq_boolean=truebrq_integer=1337brq_nil=brq_string=foobarsecret')
     end
 
-    it 'should generate a valid signature string' do
+    it 'generates a valid signature string' do
       params = { brq_test: 'abcdef', brq_test2: 'foobar' }
       string = Buckaruby::Signature.generate_signature_string(params, 'secret')
       expect(string).to eq('brq_test=abcdefbrq_test2=foobarsecret')
     end
 
-    it 'should sort parameters case insensitive and preserve casing in keys/values' do
+    it 'sorts parameters case insensitive and preserve casing in keys/values' do
       params = { BRQ_TESTB: 'abcDEF', brq_testA: 'Foobar', BRQ_TestC: 'test' }
       string = Buckaruby::Signature.generate_signature_string(params, 'secret')
       expect(string).to eq('brq_testA=FoobarBRQ_TESTB=abcDEFBRQ_TestC=testsecret')
@@ -38,10 +38,10 @@ describe Buckaruby::Signature do
   describe 'generate_signature' do
     let(:config) { Buckaruby::Configuration.new(website: '12345678', secret: 'secret', hash_method: hash_method) }
 
-    context 'invalid hash method' do
+    context 'with invalid hash method' do
       let(:hash_method) { :invalid }
 
-      it 'should raise an exception when generating a signature' do
+      it 'raises an exception when generating a signature' do
         expect {
           params = { brq_test: 'abcdef', brq_test2: 'foobar' }
           Buckaruby::Signature.generate_signature(params, config)
@@ -49,20 +49,20 @@ describe Buckaruby::Signature do
       end
     end
 
-    context 'SHA-1 as hash method' do
+    context 'with SHA-1 as hash method' do
       let(:hash_method) { :sha1 }
 
-      it 'should generate a valid signature' do
+      it 'generates a valid signature' do
         params = { brq_test: 'abcdef', brq_test2: 'foobar' }
         string = Buckaruby::Signature.generate_signature(params, config)
         expect(string).to eq('c864c2abad67580274b2df00fd2a53739952b924')
       end
     end
 
-    context 'SHA-256 as hash method' do
+    context 'with SHA-256 as hash method' do
       let(:hash_method) { :sha256 }
 
-      it 'should generate a valid signature' do
+      it 'generates a valid signature' do
         params = { brq_test: 'abcdef', brq_test2: 'foobar' }
 
         string = Buckaruby::Signature.generate_signature(params, config)
@@ -70,10 +70,10 @@ describe Buckaruby::Signature do
       end
     end
 
-    context 'SHA-512 as hash method' do
+    context 'with SHA-512 as hash method' do
       let(:hash_method) { :sha512 }
 
-      it 'should generate a valid signature' do
+      it 'generates a valid signature' do
         params = { brq_test: 'abcdef', brq_test2: 'foobar' }
         string = Buckaruby::Signature.generate_signature(params, config)
         expect(string).to eq('161e485fd71c708fa7f39c1732349fae1e5b8a0c05cd4f9d806ad570b2414f5b99b4aaf89ed48c55c188b82b9565d93471d3d20163002909360f31f29f4a988d')

data/spec/buckaruby/support/case_insensitive_hash_spec.rb

@@ -2,7 +2,7 @@
 
 require 'spec_helper'
 
-describe Buckaruby::Support::CaseInsensitiveHash do
+RSpec.describe Buckaruby::Support::CaseInsensitiveHash do
   describe 'retrieve and assign' do
     it 'accepts String keys and makes them case insensitive' do
       hash = Buckaruby::Support::CaseInsensitiveHash.new

data/spec/fixtures/responses/setup_transaction_success.txt

@@ -1 +1 @@
-BRQ_ACTIONREQUIRED=redirect&BRQ_AMOUNT=10.00&BRQ_APIRESULT=ActionRequired&BRQ_CURRENCY=EUR&BRQ_DESCRIPTION=Test&BRQ_INVOICENUMBER=12345&BRQ_PAYMENT=12345&BRQ_PAYMENT_METHOD=ideal&BRQ_REDIRECTURL=https%3A%2F%2Ftestcheckout.buckaroo.nl%2Fhtml%2Fredirect.ashx%3Fr%3D41C48B55FA9164E123CC73B1157459E840BE5D24&BRQ_SERVICE_IDEAL_CONSUMERISSUER=Rabobank&BRQ_STATUSCODE=791&BRQ_STATUSCODE_DETAIL=S002&BRQ_STATUSMESSAGE=An+additional+action+is+required%3A+RedirectToIdeal&BRQ_TEST=true&BRQ_TIMESTAMP=2014-11-05+13%3A10%3A40&BRQ_TRANSACTIONS=41C48B55FA9164E123CC73B1157459E840BE5D24&BRQ_WEBSITEKEY=12345678&BRQ_SIGNATURE=3d6ef7e249d9509d120c7b84f27f081adf06074b
+ADD_BUCKARUBY=1.2.0&ADD_MYREFERENCE=12345&BRQ_ACTIONREQUIRED=redirect&BRQ_AMOUNT=10.00&BRQ_APIRESULT=ActionRequired&BRQ_CURRENCY=EUR&BRQ_DESCRIPTION=Test&BRQ_INVOICENUMBER=12345&BRQ_PAYMENT=12345&BRQ_PAYMENT_METHOD=ideal&BRQ_REDIRECTURL=https%3A%2F%2Ftestcheckout.buckaroo.nl%2Fhtml%2Fredirect.ashx%3Fr%3D41C48B55FA9164E123CC73B1157459E840BE5D24&BRQ_SERVICE_IDEAL_CONSUMERISSUER=Rabobank&BRQ_STATUSCODE=791&BRQ_STATUSCODE_DETAIL=S002&BRQ_STATUSMESSAGE=An+additional+action+is+required%3A+RedirectToIdeal&BRQ_TEST=true&BRQ_TIMESTAMP=2014-11-05+13%3A10%3A40&BRQ_TRANSACTIONS=41C48B55FA9164E123CC73B1157459E840BE5D24&BRQ_WEBSITEKEY=12345678&BRQ_SIGNATURE=591e4d66e904142bb6ad2583e2580bf0a4ebb19c&CUST_FOO=bar&CUST_QUUX=42

data/spec/spec_helper.rb

@@ -11,4 +11,6 @@ RSpec.configure do |config|
   config.formatter = 'documentation'
 
   config.raise_errors_for_deprecations!
+
+  config.disable_monkey_patching!
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: buckaruby
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.2.0
 platform: ruby
 authors:
 - Kentaa
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-30 00:00:00.000000000 Z
+date: 2019-08-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -44,20 +44,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.5.0
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 3.5.0
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.5.0
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 3.5.0
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
@@ -65,9 +59,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.3'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 2.3.2
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -75,9 +66,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.3'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 2.3.2
 description: The Buckaruby gem provides a Ruby library for communicating with the
   Buckaroo Payment Engine 3.0.
 email:
@@ -91,6 +79,7 @@ files:
 - ".travis.yml"
 - CHANGELOG.md
 - Gemfile
+- Gemfile.lock
 - LICENSE.txt
 - README.md
 - Rakefile
@@ -163,7 +152,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 2.7.9
 signing_key: 
 specification_version: 4
 summary: Ruby library for communicating with the Buckaroo Payment Engine 3.0.