buckaroo-ideal 0.0.1 → 0.0.2

data/.rvmrc

@@ -6,7 +6,7 @@
 # First we specify our desired <ruby>[@<gemset>], the @gemset name is optional,
 # Only full ruby name is supported here, for short names use:
 #     echo "rvm use 1.9.3" > .rvmrc
-environment_id="ruby-1.9.3-p125@buckaroo"
+environment_id="ruby-1.9.3@buckaroo"
 
 # Uncomment the following lines if you want to verify rvm version per project
 # rvmrc_rvm_version="1.10.3" # 1.10.1 seams as a safe start

data/buckaroo-ideal.gemspec

@@ -16,5 +16,10 @@ Gem::Specification.new do |gem|
   gem.version       = Buckaroo::Ideal::VERSION
   
   gem.add_dependency 'activesupport'
-  gem.add_dependency 'transliterator'
+  
+  if RUBY_VERSION < "1.9"
+    gem.add_dependency 'fastercsv'
+  else
+    gem.add_dependency 'transliterator'
+  end
 end

data/lib/buckaroo-ideal/config.rb

@@ -65,16 +65,16 @@ module Buckaroo
         # Default settings
         def defaults
           {
-            gateway_url:     'https://payment.buckaroo.nl/gateway/payment.asp',
-            merchant_key:    nil,
-            secret_key:      nil,
-            test_mode:       false,
-            success_url:     nil,
-            reject_url:      nil,
-            error_url:       nil,
-            return_method:   'POST',
-            style:           'PAGE',
-            autoclose_popup: false
+            :gateway_url     =>  'https://payment.buckaroo.nl/gateway/ideal_payment.asp',
+            :merchant_key    =>  nil,
+            :secret_key      =>  nil,
+            :test_mode       =>  false,
+            :success_url     =>  nil,
+            :reject_url      =>  nil,
+            :error_url       =>  nil,
+            :return_method   => 'POST',
+            :style           => 'PAGE',
+            :autoclose_popup => false
           }
         end
         

data/lib/buckaroo-ideal/order.rb

@@ -4,7 +4,7 @@ module Buckaroo
   module Ideal
     class Order
       def self.defaults
-        { currency: 'EUR' }
+        { :currency => 'EUR' }
       end
       
       # @return [Float] The total amount that this order is for

data/lib/buckaroo-ideal/request.rb

@@ -45,24 +45,24 @@ module Buckaroo
     class Request
       def self.defaults
         {
-          language:        'NL',
-          success_url:     Config.success_url,
-          reject_url:      Config.reject_url,
-          error_url:       Config.error_url,
-          return_method:   Config.return_method,
-          style:           Config.style,
-          autoclose_popup: Config.autoclose_popup
+          :language        => 'NL',
+          :success_url     => Config.success_url,
+          :reject_url      => Config.reject_url,
+          :error_url       => Config.error_url,
+          :return_method   => Config.return_method,
+          :style           => Config.style,
+          :autoclose_popup => Config.autoclose_popup
         }
       end
       
       # @return [String] The configured gateway_url in +Buckaroo::Ideal::Config+
-      delegate :gateway_url,  to: Config
+      delegate :gateway_url,  :to => Config
       
       # @return [Boolean] The configured test_mode in +Buckaroo::Ideal::Config+
-      delegate :test_mode,    to: Config
+      delegate :test_mode,    :to => Config
       
       # @return [String] The configured merchant_key in +Buckaroo::Ideal::Config+
-      delegate :merchant_key, to: Config
+      delegate :merchant_key, :to => Config
       
       # @return [Buckaroo::Ideal::Order] The order for which the payment request
       #   is being made

data/lib/buckaroo-ideal/request_signature.rb

@@ -32,13 +32,13 @@ module Buckaroo
       attr_reader :order
       
       # @return [Boolean] The configured test_mode in +Buckaroo::Ideal::Config+
-      delegate :test_mode,    to: Config
+      delegate :test_mode,    :to => Config
       
       # @return [String] The configured merchant_key in +Buckaroo::Ideal::Config+
-      delegate :merchant_key, to: Config
+      delegate :merchant_key, :to => Config
       
       # @return [String] The configured secret_key in +Buckaroo::Ideal::Config+
-      delegate :secret_key,   to: Config
+      delegate :secret_key,   :to => Config
       
       # Initialize a new +Buckaroo::Ideal::Signature+ instance for the given
       # order.

data/lib/buckaroo-ideal/response_signature.rb

@@ -6,10 +6,10 @@ module Buckaroo
     class ResponseSignature
       
       # @return [String] The configured merchant_key in +Buckaroo::Ideal::Config+
-      delegate :merchant_key, to: Config
+      delegate :merchant_key, :to => Config
       
       # @return [String] The configured secret_key in +Buckaroo::Ideal::Config+
-      delegate :secret_key,   to: Config
+      delegate :secret_key,   :to => Config
       
       # @return [String] The signature that was given in the response
       attr_reader :signature

data/lib/buckaroo-ideal/status.rb

@@ -1,37 +1,44 @@
-require 'csv'
-
 module Buckaroo
   module Ideal
     class Status
       class UnknownStatusCode < StandardError; end
       
       STATES = {
-        completed: %w(071 121 151 171 190 242 243 244 245 246 247 254 255 301
-                      401 461 462 463 464 551 601 701 801),
-        pending:   %w(000 001 070 090 091 100 105 120 126 135 136 150 156 157
-                      170 176 177 253 300 400 460 500 550 600 700 710 790 791
-                      792 793 800 811 814 815 831 834),
-        failed:    %w(072 073 074 075 076 101 102 103 104 106 122 123 124 125
-                      137 138 139 152 153 155 158 159 172 173 175 178 179 201
-                      203 204 205 206 207 251 252 260 261 262 302 303 304 305
-                      306 309 402 409 410 411 414 421 422 425 466 468 490 491
-                      492 501 552 553 554 555 556 560 581 590 602 605 609 610
-                      612 690 702 703 704 705 706 707 708 711 712 720 721 802
-                      803 804 810 812 813 816 820 821 822 823 824 830 833 835
-                      836 890 891 900 901 910 931 932 933 934 935 940 941 942
-                      943 944 945 946 947 948 949 950 951 952 953 954 955 956
-                      960 961 962 963 964 971 972 973 974 975 976 977 978 980
-                      981 982 983 990 991 992 993 999)
+        :completed => %w(071 121 151 171 190 242 243 244 245 246 247 254 255
+                         301 401 461 462 463 464 551 601 701 801),
+        :pending   => %w(000 001 070 090 091 100 105 120 126 135 136 150 156
+                         157 170 176 177 253 300 400 460 500 550 600 700 710
+                         790 791 792 793 800 811 814 815 831 834),
+        :failed    => %w(072 073 074 075 076 101 102 103 104 106 122 123 124
+                         125 137 138 139 152 153 155 158 159 172 173 175 178
+                         179 201 203 204 205 206 207 251 252 260 261 262 302
+                         303 304 305 306 309 402 409 410 411 414 421 422 425
+                         466 468 490 491 492 501 552 553 554 555 556 560 581
+                         590 602 605 609 610 612 690 702 703 704 705 706 707
+                         708 711 712 720 721 802 803 804 810 812 813 816 820
+                         821 822 823 824 830 833 835 836 890 891 900 901 910
+                         931 932 933 934 935 940 941 942 943 944 945 946 947
+                         948 949 950 951 952 953 954 955 956 960 961 962 963
+                         964 971 972 973 974 975 976 977 978 980 981 982 983
+                         990 991 992 993 999)
       }
       
       CSV_FILE = File.expand_path('../../../files/statuscodes.csv', __FILE__)
       
+      if RUBY_VERSION < "1.9"
+        require 'fastercsv'
+        CSV = ::FasterCSV
+      else
+        require 'csv'
+        CSV = ::CSV
+      end
+      
       attr_reader :code, :message
       
       def self.status_codes(csv_file = CSV_FILE)
         codes = {}
         
-        CSV.foreach(csv_file, col_sep: ';') do |row|
+        CSV.foreach(csv_file, :col_sep => ';') do |row|
           codes[row[0]] = row[1]
         end
         

data/lib/buckaroo-ideal/util.rb

@@ -1,12 +1,26 @@
-require 'transliterator'
-
 module Buckaroo
   module Ideal
     module Util
       extend self
       
-      def to_normalized_string(string)
-        Transliterator.asciify(string.to_s)
+      if RUBY_VERSION < "1.9"
+        
+        require 'iconv'
+        
+        STRIP_ACCENTS_RE = /[\^~"`']/
+        
+        def to_normalized_string(string)
+          Iconv.iconv('US-ASCII//IGNORE//TRANSLIT', 'UTF-8', string).to_s.gsub(STRIP_ACCENTS_RE, '')
+        end
+        
+      else
+        
+        require 'transliterator'
+        
+        def to_normalized_string(string)
+          Transliterator.asciify(string.to_s)
+        end
+        
       end
       
       def to_cents(amount)

data/lib/buckaroo-ideal/version.rb

@@ -1,5 +1,5 @@
 module Buckaroo
   module Ideal
-    VERSION = "0.0.1"
+    VERSION = '0.0.2'
   end
 end

data/spec/buckaroo-ideal/config_spec.rb

@@ -3,22 +3,22 @@ require 'spec_helper'
 describe Buckaroo::Ideal::Config do
   before do
     Buckaroo::Ideal::Config.configure(
-      merchant_key:   'merchant_key',
-      secret_key:     'secret_key',
-      test_mode:      true,
-      success_url:    'http://example.com/transaction/success',
-      reject_url:     'http://example.com/transaction/reject',
-      error_url:      'http://example.com/transaction/error',
-      return_method:  'GET',
-      style:          'POPUP',
-      autoclose_popup: true
+      :merchant_key    => 'merchant_key',
+      :secret_key      => 'secret_key',
+      :test_mode       => true,
+      :success_url     => 'http://example.com/transaction/success',
+      :reject_url      => 'http://example.com/transaction/reject',
+      :error_url       => 'http://example.com/transaction/error',
+      :return_method   => 'GET',
+      :style           => 'POPUP',
+      :autoclose_popup => true
     )
   end
   
   subject { Buckaroo::Ideal::Config }
   
   it 'has a gateway_url' do
-    subject.gateway_url.should == 'https://payment.buckaroo.nl/gateway/payment.asp'
+    subject.gateway_url.should == 'https://payment.buckaroo.nl/gateway/ideal_payment.asp'
   end
   
   it 'has a merchant_key' do

data/spec/buckaroo-ideal/order_spec.rb

@@ -5,15 +5,15 @@ describe Buckaroo::Ideal::Order do
   
   before do
     Buckaroo::Ideal::Config.configure(
-      merchant_key:   'merchant_key',
-      secret_key:     'secret_key',
-      test_mode:      true,
-      success_url:    'http://example.com/transaction/success',
-      reject_url:     'http://example.com/transaction/reject',
-      error_url:      'http://example.com/transaction/error',
-      return_method:  'GET',
-      style:          'POPUP',
-      autoclose_popup: true
+      :merchant_key    => 'merchant_key',
+      :secret_key      => 'secret_key',
+      :test_mode       => true,
+      :success_url     => 'http://example.com/transaction/success',
+      :reject_url      => 'http://example.com/transaction/reject',
+      :error_url       => 'http://example.com/transaction/error',
+      :return_method   => 'GET',
+      :style           => 'POPUP',
+      :autoclose_popup => true
     )
   end
   

data/spec/buckaroo-ideal/request_signature_spec.rb

@@ -2,18 +2,18 @@ require 'spec_helper'
 
 describe Buckaroo::Ideal::RequestSignature do
   it 'generates a signature for the given order' do
-    order  = mock invoice_number: 'EETNU-12345',
-                  amount:         12.50,
-                  currency:       'EUR'
+    order  = mock :invoice_number => 'EETNU-12345',
+                  :amount         => 12.50,
+                  :currency       => 'EUR'
     
-    Buckaroo::Ideal::Config.stub(:test_mode)
-                           .and_return(true)
+    Buckaroo::Ideal::Config.stub(:test_mode).
+                            and_return(true)
     
-    Buckaroo::Ideal::Config.stub(:merchant_key)
-                           .and_return('merchant_key')
+    Buckaroo::Ideal::Config.stub(:merchant_key).
+                            and_return('merchant_key')
     
-    Buckaroo::Ideal::Config.stub(:secret_key)
-                           .and_return('secret_key')
+    Buckaroo::Ideal::Config.stub(:secret_key).
+                            and_return('secret_key')
     
     signature = Buckaroo::Ideal::RequestSignature.new(order)
     
@@ -26,8 +26,8 @@ describe Buckaroo::Ideal::RequestSignature do
       'secret_key'    # config.secret_key
     ].join
     
-    Digest::MD5.should_receive(:hexdigest)
-               .with(expected_salt)
+    Digest::MD5.should_receive(:hexdigest).
+                            with(expected_salt)
     
     signature.to_s
   end

data/spec/buckaroo-ideal/request_spec.rb

@@ -6,15 +6,15 @@ describe Buckaroo::Ideal::Request do
   
   before do
     Buckaroo::Ideal::Config.configure(
-      merchant_key:   'merchant_key',
-      secret_key:     'secret_key',
-      test_mode:      true,
-      success_url:    'http://example.com/transaction/success',
-      reject_url:     'http://example.com/transaction/reject',
-      error_url:      'http://example.com/transaction/error',
-      return_method:  'GET',
-      style:          'POPUP',
-      autoclose_popup: true
+      :merchant_key    => 'merchant_key',
+      :secret_key      => 'secret_key',
+      :test_mode       => true,
+      :success_url     => 'http://example.com/transaction/success',
+      :reject_url      => 'http://example.com/transaction/reject',
+      :error_url       => 'http://example.com/transaction/error',
+      :return_method   => 'GET',
+      :style           => 'POPUP',
+      :autoclose_popup => true
     )
   end
   

data/spec/buckaroo-ideal/response_signature_spec.rb

@@ -2,14 +2,14 @@ require 'spec_helper'
 
 describe Buckaroo::Ideal::ResponseSignature do
   let(:response) {
-    mock transaction_id: 'transaction_id',
-         timestamp:      'timestamp',
-         invoice_number: 'invoice_number',
-         reference:      'reference',
-         currency:       'EUR',
-         amount:         12.50,
-         status:         mock(code: '101'),
-         test_mode:      true
+    mock :transaction_id => 'transaction_id',
+         :timestamp      => 'timestamp',
+         :invoice_number => 'invoice_number',
+         :reference      => 'reference',
+         :currency       => 'EUR',
+         :amount         => 12.50,
+         :status         => mock(:code => '101'),
+         :test_mode      => true
   }
   
   let(:signature) {
@@ -17,11 +17,11 @@ describe Buckaroo::Ideal::ResponseSignature do
   }
   
   before do
-    Buckaroo::Ideal::Config.stub(:merchant_key)
-                           .and_return('merchant_key')
+    Buckaroo::Ideal::Config.stub(:merchant_key).
+                            and_return('merchant_key')
     
-    Buckaroo::Ideal::Config.stub(:secret_key)
-                           .and_return('secret_key')
+    Buckaroo::Ideal::Config.stub(:secret_key).
+                            and_return('secret_key')
   end
   
   describe '#valid?' do
@@ -50,8 +50,7 @@ describe Buckaroo::Ideal::ResponseSignature do
         'secret_key'      # config.secret_key
       ].join
       
-      Digest::MD5.should_receive(:hexdigest)
-                 .with(expected_salt)
+      Digest::MD5.should_receive(:hexdigest).with(expected_salt)
       
       signature.generate_signature
     end

data/spec/buckaroo-ideal/response_spec.rb

@@ -52,7 +52,7 @@ describe Buckaroo::Ideal::Response do
   end
   
   it 'has a time' do
-    response.time.should == Time.new(2012, 05, 22, 12, 58, 13)
+    response.time.should == Time.local(2012, 05, 22, 12, 58, 13)
   end
   
   it 'has a timestamp' do
@@ -61,15 +61,13 @@ describe Buckaroo::Ideal::Response do
   
   describe '#valid?' do
     it 'returns true if the signature is valid' do
-      response.signature.stub(:valid?)
-                        .and_return(true)
+      response.signature.stub(:valid?).and_return(true)
       
       response.should be_valid
     end
     
     it 'returns false if the signature if not valid' do
-      response.signature.stub(:valid?)
-                        .and_return(false)
+      response.signature.stub(:valid?).and_return(false)
       
       response.should_not be_valid
     end

data/spec/buckaroo-ideal/util_spec.rb

@@ -7,6 +7,11 @@ describe Buckaroo::Ideal::Util do
       result = Buckaroo::Ideal::Util.to_normalized_string('îñtërnâtiônàlizâtiôn')
       result.should == 'internationalization'
     end
+    
+    it 'keeps dashes' do
+      result = Buckaroo::Ideal::Util.to_normalized_string('order-123')
+      result.should == 'order-123'
+    end
   end
   
   describe '#to_cents' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: buckaroo-ideal
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-05-24 00:00:00.000000000 Z
+date: 2012-10-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &70309503982320 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,15 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70309503982320
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: transliterator
-  requirement: &70309503981860 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -32,7 +37,12 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70309503981860
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: A simple Ruby library that aids you in handling iDEAL transactions via
   the Buckaroo iDEAL gateway.
 email:
@@ -94,7 +104,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.17
+rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: Integrate with the Buckaroo iDEAL API.