bubot 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2f70e8e24f5d875d8de41a2aa457fcbfeb374ee7
-  data.tar.gz: 34202112c92a9b3925f6e23db6b5f5dd05db2c22
+  metadata.gz: 74f041f6e5452977767a4b2b312c88a9ccd1735b
+  data.tar.gz: de3f6d5b47ffae106723727bfd591f39b79bdf18
 SHA512:
-  metadata.gz: 522a9bbb8a21ac58ac88bb531780f08fca92cb5655d444125b522d2c97aa6cb98dc4221c768cde481cf21042fa3aaf698c400cbf42895a1c53d8e8b875d541d4
-  data.tar.gz: a51b03f8ecd290aa917717b70595ac7d260bd62b48f523485fad3f45c03753d7e77f1801346fd1c8803b3380c748ccf0c980fd36cb3db2d7d4755f1210035ffa
+  metadata.gz: 70539412f14584c7f9cdf7df404fa39204fc4eea735c995f4c94ac4d47caee338c8dfaa80eef6097e29868770a90e45026700be14f0279e03150219201379a4c
+  data.tar.gz: 1e6752083102f66d367290819c2142f171646fe14e301f3d2651d824d3248c1ee71525394590ae739e07c50627ec418b72974af043b43e93fbb613f48b072925

data/lib/bubot.rb

@@ -2,17 +2,22 @@ require "bubot/version"
 
 module Bubot
 
-  def watch(method_name, timeout=0)
+  def watch(method_name, options={})
+    defaults = { timeout: 0 }
+    defaults.merge!(options)
     define_method("#{method_name}_with_feature") do |*args, &block|
       start_time = Time.now
-      if block
-        method_return_value = send("#{method_name}_without_feature".to_sym, *args, &block)
-      else
-        method_return_value = send("#{method_name}_without_feature".to_sym, *args)
-      end
-      if (total_time = Time.now - start_time) > timeout
-        yield(self, total_time, method_return_value)
+
+      method_return_value = send("#{method_name}_without_feature".to_sym, *args, &block)
+
+      if (total_time = Time.now - start_time) > defaults[:timeout]
+        if options[:with]
+          options[:with].call(self, total_time, method_return_value)
+        else
+          yield(self, total_time, method_return_value)
+        end
       end
+
       method_return_value
     end
 

data/lib/bubot/version.rb

@@ -1,3 +1,3 @@
 module Bubot
-  VERSION = "0.0.5"
+  VERSION = "0.0.6"
 end

data/spec/bubot_spec.rb

@@ -14,11 +14,11 @@ class Qux
   include Foo
   extend Bubot
 
-  watch :not_too_slow, 0.005 do
+  watch :not_too_slow, timeout: 0.005 do
     Baz.buz
   end
 
-  watch :too_slow, 0.005 do
+  watch :too_slow, timeout: 0.005 do
     Baz.buz
   end
 end
@@ -40,7 +40,7 @@ describe Bubot do
       it "watch is before the method" do
         class Before
           extend Bubot
-          watch(:next_method, 0.001) { Baz.buz }
+          watch(:next_method, timeout: 0.001) { Baz.buz }
           def next_method; sleep 0.002; end
         end
 
@@ -52,7 +52,7 @@ describe Bubot do
         class After
           extend Bubot
           def previous_method; sleep 0.002; end
-          watch(:previous_method, 0.001) { Baz.buz }
+          watch(:previous_method, timeout: 0.001) { Baz.buz }
         end
 
         Baz.should_receive(:buz).once
@@ -78,7 +78,7 @@ describe Bubot do
         expect do
           class MethodDoesNotExist
             extend Bubot
-            watch(:dont_exist, 0.001) { Baz.buz }
+            watch(:dont_exist, timeout: 0.001) { Baz.buz }
           end
         end.not_to raise_error
       end
@@ -94,7 +94,7 @@ describe Bubot do
 
         class PassesSelf
           extend Bubot
-          watch(:pass_self, 0.001) do |instance|
+          watch(:pass_self, timeout: 0.001) do |instance|
             RecievesSelfStrategy.execute(instance)
           end
           def pass_self; sleep 0.002; end
@@ -115,7 +115,7 @@ describe Bubot do
 
         class PassesTime
           extend Bubot
-          watch(:pass_time, 0.001) do |instance, time|
+          watch(:pass_time, timeout: 0.001) do |instance, time|
             RecievesTimeStrategy.execute(instance, time)
           end
           def pass_time; sleep 0.002; end
@@ -139,7 +139,7 @@ describe Bubot do
 
         class PassesReturnValue
           extend Bubot
-          watch(:pass_return_value, 0.001) do |instance, time, return_value|
+          watch(:pass_return_value, timeout: 0.001) do |instance, time, return_value|
             RecievesReturnValueStrategy.execute(instance, time, return_value)
           end
           def pass_return_value
@@ -159,6 +159,35 @@ describe Bubot do
       end
     end
 
+    describe "using a `with` strategy" do
+
+      it ":with" do
+        class RespondingStrategy
+          def self.call(method_name, timeout, method_return_value)
+            # do something
+          end
+        end
+
+        class UsingWith
+          extend Bubot
+
+          watch :original, with: RespondingStrategy
+
+          def original
+            "original value"
+          end
+        end
+
+        original_class = UsingWith.new
+        expect(RespondingStrategy).to receive(:call) do |instance, time, value|
+          expect(instance).to be(original_class)
+          expect(time).to be > 0
+          expect(value).to eq "original value"
+        end
+        original_class.original
+      end
+    end
+
     describe "the original method" do
       it "redefines the method to return the original value" do
         class OriginalMethod

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bubot
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Micah Cooper