bsv-wallet-postgres 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b1159b17c5c9a6d0f20be0c47648eab1fbb13f8131e4d9b48d5a13ff5edc8126
-  data.tar.gz: 4abd93ce4a43614e4c28b0601d031ce8ca51504dfd2270d6cf58856148dca1d8
+  metadata.gz: d007064fafd9853cdc8696661ef969ddef47c0eeb9a1c0451acc7793a67fd1f1
+  data.tar.gz: 21335a50ff36fbaf390ddfe558e5efbb67514ae4da5189f0b6b9c0a2a4b7c2e6
 SHA512:
-  metadata.gz: 846999a97dd79648e234d37863bbceeda51478d1926500d4e2176cbae5eb9646fbc240a67bb4c80a6e5554f49cc4ff51ac779c3b1d73c4d2e475fd335449ac1f
-  data.tar.gz: 5643c7caead597cf5327ada2b857a0faf375769f46010bc6545cb995130611c3e05b5c27985333f103e1b240573f4dbea4ce6be7259c23cc43d45448da1bcfb0
+  metadata.gz: bd2578b3303a8b2a1407c51366aa9a30e78d28e38875fb5f229d5408a76f02a6ecbcaddfa3e1a01d770257e0c3e3f18ea15a257097cd5c5cc5444b4d4501d382
+  data.tar.gz: e296a4026b3bddedd41cd572ad627c279ee9aaf16ca4d7ee061c11718a1b81e27cb76e9583dda0012bf55cdfaf7c28a34791c28306951802879c76463efd7157

data/CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to the `bsv-wallet-postgres` gem are documented here.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/)
 and this gem adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 0.3.1 — 2026-04-12
+
+### Fixed
+- `update_action_status` now scopes to a single row by primary key, preventing unintended multi-row updates when duplicate txids exist
+- Added migration 005: unique index on `wallet_actions.txid` enforcing one action per transaction
+
 ## 0.3.0 — 2026-04-12
 
 ### Added

data/lib/bsv/wallet_postgres/migrations/005_add_txid_unique_index.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+# Add a unique index on wallet_actions.txid.
+#
+# Within a single wallet there should be at most one action per transaction.
+# Without this constraint, concurrent inserts or retries could create duplicate
+# rows sharing the same txid, causing +update_action_status+ to update multiple
+# rows unintentionally.
+#
+# The index also accelerates the +where(txid:)+ lookups performed by
+# +update_action_status+ and +delete_action+.
+#
+# === Backward compatibility
+#
+# The migration will fail if duplicate txids already exist in the table. Clean
+# up any duplicates before running this migration:
+#
+#   DELETE FROM wallet_actions a
+#   USING wallet_actions b
+#   WHERE a.id > b.id AND a.txid = b.txid;
+Sequel.migration do
+  change do
+    alter_table(:wallet_actions) do
+      add_index :txid, unique: true, name: :wallet_actions_txid_unique
+    end
+  end
+end

data/lib/bsv/wallet_postgres/postgres_store.rb

@@ -103,16 +103,20 @@ module BSV
       end
 
       def update_action_status(txid, new_status)
-        ds = @db[:wallet_actions].where(txid: txid)
-        raise WalletError, "Action not found: #{txid}" if ds.empty?
-
-        ds.update(
+        # Fetch by txid first, then update by primary key so only exactly one
+        # row is targeted. The unique index on txid makes this unambiguous, but
+        # scoping to the id column makes the intent explicit and is safe even
+        # on databases where the migration has not yet been applied.
+        row = @db[:wallet_actions].where(txid: txid).first
+        raise WalletError, "Action not found: #{txid}" unless row
+
+        @db[:wallet_actions].where(id: row[:id]).update(
           data: Sequel.lit(
             "data || jsonb_build_object('status', ?)",
             new_status
           )
         )
-        symbolise_keys(ds.first[:data])
+        symbolise_keys(@db[:wallet_actions].where(id: row[:id]).first[:data])
       end
 
       def delete_action(txid)

data/lib/bsv/wallet_postgres/version.rb

@@ -2,6 +2,6 @@
 
 module BSV
   module WalletPostgres
-    VERSION = '0.3.0'
+    VERSION = '0.3.1'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bsv-wallet-postgres
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Simon Bettison
@@ -71,6 +71,7 @@ files:
 - lib/bsv/wallet_postgres/migrations/002_add_output_state.rb
 - lib/bsv/wallet_postgres/migrations/003_add_wallet_settings.rb
 - lib/bsv/wallet_postgres/migrations/004_add_pending_metadata.rb
+- lib/bsv/wallet_postgres/migrations/005_add_txid_unique_index.rb
 - lib/bsv/wallet_postgres/postgres_store.rb
 - lib/bsv/wallet_postgres/version.rb
 homepage: https://github.com/sgbett/bsv-ruby-sdk