brval 0.7.0 → 0.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4618b4783cbc5229fb9b7bc50ead9ec21789fef74a51b5ad998204912509af47
-  data.tar.gz: 020c85c74febb5e40a12db2c2e3977e604af7093dbb8a99dc8d67da31cb8db57
+  metadata.gz: 7260e4530a40cc16c181fc7aa4d12e0bdb359b744dc0862c688475269ac16e01
+  data.tar.gz: 4e4bc2bd3d2c9a35ccab8c33a7422179c8c12c6326e23f82effb54cb49fc77d8
 SHA512:
-  metadata.gz: 2e0b08c639776a7667150ded10de430653cf103407419cfe809c5b4c7931c378b8e2bbf099428ccf790a8cbd08b1432b0d63330cc10697b00943ab911bb5fac1
-  data.tar.gz: ad0ae0eb5992eb6aeedd8190c50ff516971b4bfbc7c352c4f9ddfef58b7a3d1ac2b9d8eda502c10c43a49d3a5aef80f203e536afb8cf97fd9f36153ce25d44c8
+  metadata.gz: 499890bc5c7a1220692c43d668afe8efa8990b55e474161996dd71a54966e4cdc45748ba7f27514e1c5b3b10dd383599a6c6aafceaf86e5d09ed46879436405f
+  data.tar.gz: a761ecc256adf51f505acca1468588f253a711681fa053dbbeaf1eb19a91de7565249a80f62d48aad1570b53ccc52a7d0732c7fec583de1c5a23ad1d17376f78

data/README.md

@@ -43,7 +43,7 @@ Brval.cep_valid?('70297-400') # => true
 
 ### Lista da Funções
 ### Functions List
-Above is the list with all the functions and validations avaible on Brval gem, after that a resume explaining about CEP validation:
+Above is the list with all the functions and validations avaible on Brval gem.
 
 | Function                  | Return      | Description |
 |-------------------------|--------------|-----------|
@@ -60,7 +60,7 @@ Above is the list with all the functions and validations avaible on Brval gem, a
 
 
 ### CEP Validation
-Brazilian postal code, CEP, doesn't has any formula or calculation to check is some CEP is valid or not, the only way to know that is searching in a database with all CEP's in Brazil
+Brazilian postal code, CEP, doesn't has any formula or calculation to check if some CEP is valid or not, the only way to know that is searching in a database with all CEP's in Brazil
 
 Apparently Correios doesn't provides any database with all CEP's of Brazil, so some devs developer their own services to search for a CEP info, some of those services are public API's and anyone can use it.
 
@@ -74,7 +74,7 @@ Considering this, Brval does the CEP validation following this flow:
 
 The gem uses the same procedure to get the info of some CEP with the function: `Brval.cep_info(00000000)`
 
- **OBS:** the gem "only" search in three API's, so if a CEP exists but any of these API's doesn't have it, the gem will return a false negative.
+ **OBS:** the gem "only" search in three API's, if a CEP exists but any of these API's doesn't have it, the gem will return a false negative.
 
 
 ## Contributing
@@ -85,6 +85,16 @@ If you want to contribute with some code create an issue so we can discuss about
 
 Don't forget the tests, Brval use Rspec to test. Update the README with the new info. Also, try to follow the gem pattern to implement your contribution.
 
+### Run the gem from local project
+You can run the gem with: `rake console`
+
+And before send your PR make a simulation installing the gem locally with your changes, just run the `./build.sh` script.
+
+```
+chmod +x build.sh
+./build.sh
+```
+
 Thanks!
 
 ## License

data/lib/brval/cep/via_cep.rb

@@ -11,7 +11,7 @@ module Cep
     private
 
     def json_valid? json
-      return false if json.key?('erro')
+      return false if json.nil? || json.key?('erro')
       json.key?('logradouro') && json.key?('bairro') && json.key?('localidade') && json.key?('uf')
     end
 

data/lib/brval/cep/widenet.rb

@@ -14,7 +14,7 @@ module Cep
     private
 
     def json_valid? json
-      return false if json.key?('message')
+      return false if json.nil? || json.key?('message')
       json.key?('district') && json.key?('city') && json.key?('address') && json.key?('state')
     end
 

data/lib/brval/version.rb

@@ -1,3 +1,3 @@
 module Brval
-  VERSION = "0.7.0"
+  VERSION = "0.7.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: brval
 version: !ruby/object:Gem::Version
-  version: 0.7.0
+  version: 0.7.1
 platform: ruby
 authors:
 - Lucas Andrade
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-01-20 00:00:00.000000000 Z
+date: 2019-01-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler