browser 3.0.2 → 3.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d8cf4326bc2b2d9ef069fdedd8c6be7a58ca40b7d3cb33ca0264db7df79504bc
-  data.tar.gz: bd6e16613c80c97b9aa0895baf7991088aa19946f3daeef27db2f5fadcfd171d
+  metadata.gz: 35cb9e029740dd22fac2f08ea933fb541b914ddc3d437f49e2402f68be7aecb3
+  data.tar.gz: 534a21b9b6892178c02976d19fe8ef81e9746783ac87469239efb9e8033bfaeb
 SHA512:
-  metadata.gz: 809f13b58435f1e26b7dcf188aa9b4bbe3bad566b8139c82399060794cbfb2a99747893de20c07687a85db5ec38463561d45f6f61b2020b36155c4be794a7182
-  data.tar.gz: 9fb22873f199a46dbfd709b75f7bf5cea2a8ef515ba4beaffdf10f2bbf9e395b18e77888deaaeace0ce7e5e201429bc7ebbdf138bf0690e6fec93a296aa2d61a
+  metadata.gz: fe9062f778c871766bddce4738c63ad005e0fc6310c46b0505f78da1c304e5d2f0359d8c2685727203876f8b83bf7ee06fc7dfa6b2f5fb6da719cf60bd5f80a7
+  data.tar.gz: ecce9f6468c7e5cfb11e47aeeaa68c44d8be5ad6b4e6e34cc9f64721dbaf0adae1514cb8b57097ec679481da7286713468fa4ac88de397190179bbf13ef42331

data/.travis.yml

@@ -1,10 +1,10 @@
 ---
 language: ruby
-sudo: false
 cache: bundler
 rvm:
-  - 2.6.0
-  - 2.5.0
+  - 2.7
+  - 2.6
+  - 2.5
 gemfile:
   - Gemfile
   - gemfiles/rails5.gemfile

data/CHANGELOG.md

@@ -4,6 +4,10 @@
 
 - Nothing yet.
 
+# 3.0.3
+
+- Deprecate `Browser.modern_rules` and `Browser::Base#modern?`. Theses methods will be removed on the next major released, or by June 1st 2020.
+
 ## 3.0.2
 
 - Remove .bundle directory from package.

data/README.md

@@ -34,7 +34,6 @@ browser.ie?(6)               # detect specific IE version
 browser.ie?([">8", "<10"])   # detect specific IE (IE9).
 browser.known?               # has the browser been successfully detected?
 browser.meta                 # an array with several attributes
-browser.modern?              # Webkit, Firefox 17+, IE 9+ and Opera 12+
 browser.name                 # readable browser name
 browser.nokia?
 browser.opera?
@@ -145,23 +144,26 @@ browser.mobile? #=> false
 - For a list of device detections, check [lib/browser/device.rb](https://github.com/fnando/browser/blob/master/lib/browser/device.rb)
 - For a list of bot detections, check [bots.yml](https://github.com/fnando/browser/blob/master/bots.yml)
 
-### What defines a modern browser?
+### Detecting modern browsers
 
-The current rules that define a modern browser are pretty loose.
-
-* Chrome 65+
-* Safari 10+
-* Firefox 52+
-* IE11+
-* Microsoft Edge 39+
-* Opera 50+
-
-You can define your own rules. A rule must be a proc/lambda or any object that implements the method === and accepts the browser object. To redefine all rules, clear the existing rules before adding your own.
+To detect whether a browser can be considered as modern or not, create a method that abstracts your versioning constraints. The following example will consider any of the following browsers as a modern:
 
 ```ruby
-# Only Google Chrome 79+ is considered modern.
-Browser.modern_rules.clear
-Browser.modern_rules << -> b { b.chrome? && b.version.to_i >= 79 }
+# Expects an Browser instance,
+# like in `Browser.new(user_agent, accept_language: language)`.
+def modern_browser?(browser)
+  [
+    browser.chrome? && browser.version.to_i >= 65,
+    browser.safari? && browser.version.to_i >= 10,
+    browser.firefox? && browser.version.to_i >= 52,
+    browser.ie? && browser.version.to_i >= 11 && !browser.compatibility_view?,
+    browser.edge? && browser.version.to_i >= 15,
+    browser.opera? && browser.version.to_i >= 50,
+    browser.facebook?
+      && browser.safari_webapp_mode?
+      && browser.webkit_full_version.to_i >= 602
+  ].any?
+end
 ```
 
 ### Rails integration
@@ -240,9 +242,6 @@ browser.msie_full_version
 
 browser.compatibility_view?
 #=> true
-
-browser.modern?
-#=> false
 ```
 
 This behavior changed in `v1.0.0`; previously there wasn't a way of getting the real browser version.
@@ -298,7 +297,7 @@ You can use the `Browser::Middleware` to redirect user agents.
 
 ```ruby
 use Browser::Middleware do
-  redirect_to "/upgrade" unless browser.modern?
+  redirect_to "/upgrade" if browser.ie?
 end
 ```
 
@@ -306,17 +305,7 @@ If you're using Rails, you can use the route helper methods. Just add something
 
 ```ruby
 Rails.configuration.middleware.use Browser::Middleware do
-  redirect_to upgrade_path unless browser.modern?
-end
-```
-
-Notice that you can have multiple conditionals.
-
-```ruby
-Rails.configuration.middleware.use Browser::Middleware do
-  next if browser.bot.search_engine?
-  redirect_to upgrade_path(browser: "oldie") if browser.ie? && !browser.modern?
-  redirect_to upgrade_path(browser: "oldfx") if browser.firefox? && !browser.modern?
+  redirect_to upgrade_path if browser.ie?
 end
 ```
 
@@ -324,7 +313,7 @@ If you need access to the `Rack::Request` object (e.g. to exclude a path), you c
 
 ```ruby
 Rails.configuration.middleware.use Browser::Middleware do
-  redirect_to upgrade_path unless browser.modern? || request.env["PATH_INFO"] == "/exclude_me"
+  redirect_to upgrade_path if browser.ie? && request.env["PATH_INFO"] != "/exclude_me"
 end
 ```
 

data/lib/browser/base.rb

@@ -52,6 +52,11 @@ module Browser
 
     # Return true if browser is modern (Webkit, Firefox 17+, IE9+, Opera 12+).
     def modern?
+      warn <<~TEXT
+        Browser::Base#modern? is now deprecated.
+        Check https://github.com/fnando/browser/issues/435 for details.
+      TEXT
+
       Browser.modern_rules.any? {|rule| rule === self } # rubocop:disable Style/CaseEquality
     end
 

data/lib/browser/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Browser
-  VERSION = "3.0.2"
+  VERSION = "3.0.3"
 end

data/test/test_helper.rb

@@ -24,3 +24,11 @@ module Minitest
     end
   end
 end
+
+# Override Browser::Base#warn, so we don't output deprecation messages.
+module Browser
+  class Base
+    def warn(*)
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: browser
 version: !ruby/object:Gem::Version
-  version: 3.0.2
+  version: 3.0.3
 platform: ruby
 authors:
 - Nando Vieira
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-01-09 00:00:00.000000000 Z
+date: 2020-01-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler