browser 2.0.1 → 2.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fb23db30128545d1362d657be31139c5c0d79ab1
-  data.tar.gz: dd8e2126bd5de416a2d29beb3ceff26c9ed28494
+  metadata.gz: 1e4f0f94511f5a4e169815e5b034e4fa3a53099d
+  data.tar.gz: 90fb62dfa2b9ba5198ede34f771aa4f0a13e752d
 SHA512:
-  metadata.gz: 6138595faa14527bc208ac1cdb8adb173ea3c0946988107d35846f67ad7c501e684e3f8eb28c84e71d6397156ac1259fc553bb64f78a87878fa8fd91e0586008
-  data.tar.gz: a750b44ed0eabdcaedf98755363a772772e0c58efc83fdad00ccc74f8ad5a1bc0a8c28648f31ad422934a54f3ea6f8f5595ce94b79c7999ac46a42c548e78a26
+  metadata.gz: 6de159fbcda822346be969345f46b7fca93231c624b163cda8b3f23e75589f2e8b2613d329a5d26feae03d3e554b70ceb54730261c9f371303ec60283f3e98f4
+  data.tar.gz: fac02f1cab7ed3d2afd41c5dcd7ba0d3e67a809eb1e5fdaf6b365490ebdc089b15665ec57ff5b44ef5685eef1c9137c806de357e10e0f9e866007611133a56d3

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## v2.0.2
+
+- Fix issue when user agent is set to `nil`.
+- Fix issue with user agent without version information.
+
 ## v2.0.1
 
 - Fix Rails integration.

data/lib/browser.rb

@@ -73,6 +73,8 @@ require "browser/meta/tablet"
 require "browser/meta/device"
 
 module Browser
+  EMPTY_STRING = "".freeze
+
   def self.root
     @root ||= Pathname.new(File.expand_path("../..", __FILE__))
   end
@@ -114,7 +116,7 @@ module Browser
       Safari,
       Generic,
     ]
-      .map {|klass| klass.new(user_agent, **kwargs) }
+      .map {|klass| klass.new(user_agent || EMPTY_STRING, **kwargs) }
       .find(&:match?)
   end
 

data/lib/browser/chrome.rb

@@ -14,7 +14,8 @@ module Browser
       ua[%r[Chrome/([\d.]+)], 1] ||
         ua[%r[CriOS/([\d.]+)], 1] ||
         ua[%r[Safari/([\d.]+)], 1] ||
-        ua[%r[AppleWebKit/([\d.]+)], 1]
+        ua[%r[AppleWebKit/([\d.]+)], 1] ||
+        "0.0"
     end
 
     def match?

data/lib/browser/firefox.rb

@@ -10,7 +10,7 @@ module Browser
     end
 
     def full_version
-      ua[%r[(?:Firefox|FxiOS)/([\d.]+)], 1]
+      ua[%r[(?:Firefox|FxiOS)/([\d.]+)], 1] || "0.0"
     end
 
     def match?

data/lib/browser/nokia.rb

@@ -10,7 +10,7 @@ module Browser
     end
 
     def full_version
-      ua[%r[S40OviBrowser/([\d.]+)], 1]
+      ua[%r[S40OviBrowser/([\d.]+)], 1] || "0.0"
     end
 
     def match?

data/lib/browser/opera.rb

@@ -10,7 +10,7 @@ module Browser
     end
 
     def full_version
-      ua[%r[OPR/([\d.]+)], 1] || ua[%r[Version/([\d.]+)], 1]
+      ua[%r[OPR/([\d.]+)], 1] || ua[%r[Version/([\d.]+)], 1] || "0.0"
     end
 
     def match?

data/lib/browser/phantom_js.rb

@@ -10,7 +10,7 @@ module Browser
     end
 
     def full_version
-      ua[%r[PhantomJS/([\d.]+)], 1]
+      ua[%r[PhantomJS/([\d.]+)], 1] || "0.0"
     end
 
     def match?

data/lib/browser/uc_browser.rb

@@ -10,7 +10,7 @@ module Browser
     end
 
     def full_version
-      ua[%r[UCBrowser/([\d.]+)], 1]
+      ua[%r[UCBrowser/([\d.]+)], 1] || "0.0"
     end
 
     def match?

data/lib/browser/version.rb

@@ -1,4 +1,4 @@
 # frozen_string_literal: true
 module Browser
-  VERSION = "2.0.1"
+  VERSION = "2.0.2"
 end

data/test/browser_test.rb

@@ -7,6 +7,30 @@ class BrowserTest < Minitest::Test
     assert_equal "Safari", browser.ua
   end
 
+  test "don't fail with nil user agent" do
+    browser = Browser.new(nil)
+    refute browser.known?
+  end
+
+  %w[
+    BlackBerry
+    Chrome
+    Edge
+    Firefox
+    MSIE
+    Opera
+    PhantomJS
+    S40OviBrowser
+    Safari
+    UCBrowser
+  ].each do |ua|
+    test "don't fail when have no version info (#{ua})" do
+      browser = Browser.new(ua)
+      assert_equal "0", browser.version
+      assert_equal "0.0", browser.full_version
+    end
+  end
+
   test "detects android" do
     browser = Browser.new(Browser["ANDROID"])
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: browser
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 2.0.2
 platform: ruby
 authors:
 - Nando Vieira
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-28 00:00:00.000000000 Z
+date: 2016-03-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler