browser 0.6.0 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a8f4650e2d1a3d6e81011637c57feea62b92444b
-  data.tar.gz: 6383b04357145bfd6acf774c235b1af3b71d4399
+  metadata.gz: 93f6d12da42a0b1944f3fb44ed75614d02e51e20
+  data.tar.gz: 876e5220638da02b508fb0070333d5c6426847c9
 SHA512:
-  metadata.gz: 69effb2ac78f0bd154b38aa43a479dc5f42e29fce57bf702fe8521981122cca202e4fa35692a3f6e1b2e359906387cc086ee9b4a8102d2d0cf67819fdf9a718e
-  data.tar.gz: b2c1172bc85607ceb885006a842837ac68d2e54c5443ab9885bcc17cd2c77a3aa779836d57f4037f9f72a1c561add97ce3221c25843af5362ed6f498de48e374
+  metadata.gz: ae24a76b7d3ea2dd0737c870605a5cff9c7347aa41474da7a478f17f06272fa21dffbb1eb5ab612e225153cc9727c8761987a48ccde24ad68e4a297f4f58f691
+  data.tar.gz: bca7fb51b2bd60ccb4f3fda10e4df85af44312d577bd4a825fa8f4b7a2fe4a5adcedaab1d54e983db46b6f71a187e046a204f370c676b81bfb2001f7ee088efd

data/README.md

@@ -19,7 +19,8 @@ require "browser"
 
 browser = Browser.new(:ua => "some string", :accept_language => "en-us")
 browser.name            # readable browser name
-browser.version
+browser.version         # major version number
+browser.full_version
 browser.safari?
 browser.opera?
 browser.chrome?
@@ -39,6 +40,10 @@ browser.linux?
 browser.blackberry?
 browser.bot?
 browser.search_engine?
+browser.phantom_js?
+browser.quicktime?
+browser.core_media?
+browser.silk?
 browser.meta            # an array with several attributes
 browser.to_s            # the meta info joined by space
 ```

data/bots.yml

@@ -1,9 +1,12 @@
+360Spider: "360Spider"
+ADmantX: "ADmantX Platform Semantic Analyzer"
 AdsBot-Google: "Google Adwords"
 AhrefsBot: "Ahrefs backlinks research tool"
 alexa: "Alexa Crawler"
 Apache-HttpClient: "Java http library"
 ApacheBench: "ApacheBench (ab)"
 AppEngine-Google: "Google App Engine"
+Ask Jeeves: "Ask Jeeves"
 AsyncHttpClient: "Java http and WebSocket client library"
 awe.sm: "Awe.sm URL expander"
 Baidu: "Chinese search engine"
@@ -23,6 +26,7 @@ curl: "curl unix CLI http client"
 developers.google.com/+/web/snippet/: "Google Plus"
 DigitalPersona Fingerprint Software: "HP Fingerprint scanner"
 DotBot: "Dot Bot"
+DuckDuckBot: "Duck Duck Go"
 Embedly: "Embedly"
 EOAAgent: "EOAAgent"
 EventMachine HttpClient: "Ruby http library"
@@ -42,9 +46,9 @@ Googlebot: "Google spider"
 Hatena::Bookmark: "Hatena::Bookmark"
 heritrix: "heritrix"
 HTMLParser: "HTMLParser"
-HTTP_Request2: "HTTP_Request2"
 HTTPClient: "HTTPClient"
 https://developers.google.com/+/web/snippet: "Google+ Snippet Fetcher"
+HTTP_Request2: "HTTP_Request2"
 HubSpot Connect: "HubSpot Connect"
 ia_archiver(OS-Wayback): "ia_archiver(OS-Wayback)"
 iCoreService: "iCoreService"
@@ -52,6 +56,7 @@ InAGist: "URL resolver"
 Insieve Bot: "Insieve Bot"
 InsieveBot: "InsieveBot"
 Instapaper: "Instapaper"
+IstellaBot: "IstellaBot"
 jack: "jack"
 Jakarta Commons-HttpClient: "Jakarta Commons-HttpClient"
 Jakarta Commons: "Jakarta Commons HttpClient"
@@ -67,12 +72,14 @@ libwww-perl: "Perl client-server library loved by script kids"
 linkdexbot: "Linkdex Bot"
 LinkedInBot: "LinkedIn"
 LinksCrawler: "LinksCrawler"
+Linode: "Linode Longview"
 Lipperhey: "Lipperhey"
 Livelapbot: "Livelapbot"
 LoadTimeBot: "Load Time Bot"
 LongURL: "URL expander service"
 Lumibot: "Lumibot"
 lwp-trivial: "Another Perl library loved by script kids"
+magpie-crawler: "magpie-crawler"
 Mail.RU_Bot: "Mail.ru Bot"
 Mediapartners-Google: "Google Adsense bot"
 MetaURI: "MetaURI"
@@ -94,6 +101,8 @@ peerindex: "peerindex"
 PercolateCrawler: "PercolateCrawler"
 PhantomJS: "PhantomJS"
 Pingdom: "Pingdom monitoring"
+Pinterest: "Pinterest"
+publiclibraryarchive.org: "publiclibraryarchive.org"
 PycURL: "Python http library"
 Python-httplib2: "Python-httplib2"
 python-requests: "Python http library"
@@ -109,6 +118,8 @@ Ruby/1.9.3: "Ruby/1.9.3"
 Ruby: "Ruby"
 Scrapy: "Scrapy"
 SemrushBot: "SEO analysis bot"
+SeznamBot: "SeznamBot"
+ShopWiki: "ShopWiki"
 ShortLinkTranslate: "Link shortener"
 ShowyouBot: "Showyou iOS app spider"
 Siege: "Joe Dog Siege"
@@ -119,6 +130,7 @@ spider: "generic web spider"
 Spinn3r: "Spinn3r aggregator"
 Test Certificate Info: "C http library?"
 trendictionbot: "trendiction search"
+TurnitinBot: "TurnitinBot"
 TweetmemeBot: "TweetMeMe Crawler"
 Twikle: "Social web search bot"
 TwitJobSearch: "TwitJobSearch"
@@ -128,12 +140,15 @@ Twurly: "Twurly"
 Typhoeus: "Typhoeus"
 UnwindFetch: "Gnip URL expander"
 UnwindFetchor: "Gnip crawler"
+Vagabondo: "Vagabondo"
 VB Project: "Visual Basic"
 vkShare: "VKontake Sharer"
+VoilaBot: "VoilaBot"
 Webscout: "Webscout"
 Wget: "wget unix CLI http client"
 WordPress: "WordPress spider"
 Xenu Link Sleuth: "Xenu Link Sleuth"
+XoviBot: "XoviBot"
 YandexBot: "Yandex spider"
 YandexDirect: "Yandex Direct spider"
 YandexMetrika: "Yandex Metrika spider"

data/lib/browser.rb

@@ -42,9 +42,9 @@ class Browser
   alias_method :ua=, :user_agent=
 
   NAMES = {
+    chrome: "Chrome", # Must come before android
     android: "Android",
     blackberry: "BlackBerry",
-    chrome: "Chrome",
     core_media: "Apple CoreMedia",
     firefox: "Firefox",
     ie: "Internet Explorer",
@@ -65,7 +65,8 @@ class Browser
   }
 
   VERSIONS = {
-    default: %r[(?:Version|MSIE|Firefox|Chrome|CriOS|QuickTime|BlackBerry[^/]+|CoreMedia v|PhantomJS)[/ ]?([a-z0-9.]+)]i,
+    chrome: %r[(?:Chrome|CriOS)/([\d.]+)],
+    default: %r[(?:Version|MSIE|Firefox|QuickTime|BlackBerry[^/]+|CoreMedia v|PhantomJS)[/ ]?([a-z0-9.]+)]i,
     opera: %r[(?:Opera/.*? Version/([\d.]+)|Chrome/([\d.]+).*?OPR)],
     ie: %r[(?:MSIE |Trident/.*?; rv:)([\d.]+)]
   }
@@ -156,7 +157,7 @@ class Browser
 
   # Detect if browser is Safari.
   def safari?
-    ua =~ /Safari/ && ua !~ /Chrome|CriOS|PhantomJS/
+    ua =~ /Safari/ && ua !~ /Android|Chrome|CriOS|PhantomJS/
   end
 
   # Detect if browser is Firefox.

data/lib/browser/methods/bots.rb

@@ -5,11 +5,15 @@ class Browser
     SEARCH_ENGINES = YAML.load_file(root.join("search_engines.yml"))
 
     def self.detect_empty_ua!
-      Browser::Bots::BOTS[''] = 'Generic bot'
+      @detect_empty_ua = true
+    end
+
+    def self.detect_empty_ua?
+      !!@detect_empty_ua
     end
 
     def bot?
-      BOTS.any? {|key, _| ua.include?(key) }
+      Browser::Bots.detect_empty_ua? && ua.strip == "" || BOTS.any? {|key, _| ua.include?(key) }
     end
 
     def search_engine?

data/lib/browser/methods/platform.rb

@@ -30,6 +30,11 @@ class Browser
       ios? && !!(ua =~ /OS 7/)
     end
 
+    # Detect if is iOS7.
+    def ios8?
+      ios? && !!(ua =~ /OS 8/)
+    end
+
     # Detect if is BlackBerry 4.
     def blackberry4?
       blackberry? && !!(ua =~ %r[BlackBerry\d+/4])
@@ -57,7 +62,7 @@ class Browser
 
     # Detect if current platform is Macintosh.
     def mac?
-      !!(ua =~ /Mac OS X/)
+      ua =~ /Mac OS X/ && !ios?
     end
 
     # Detect if current platform is Windows.

data/lib/browser/version.rb

@@ -1,7 +1,7 @@
 class Browser
   module Version
     MAJOR = 0
-    MINOR = 6
+    MINOR = 7
     PATCH = 0
     STRING = "#{MAJOR}.#{MINOR}.#{PATCH}"
   end

data/test/browser_spec.rb

@@ -4,6 +4,7 @@ require "spec_helper"
 describe Browser do
   before do
     @browser = Browser.new
+    Browser::Bots.instance_variable_set("@detect_empty_ua", false)
   end
 
   it "yields self when block is given" do
@@ -48,7 +49,8 @@ describe Browser do
     assert @browser.mobile?
     assert @browser.modern?
     assert @browser.ios?
-    assert ! @browser.tablet?
+    refute @browser.tablet?
+    refute @browser.mac?
     assert_equal "3.0", @browser.full_version
     assert_equal "3", @browser.version
   end
@@ -74,7 +76,8 @@ describe Browser do
     assert @browser.mobile?
     assert @browser.modern?
     assert @browser.ios?
-    assert ! @browser.tablet?
+    refute @browser.tablet?
+    refute @browser.mac?
     assert_equal "3.0", @browser.full_version
     assert_equal "3", @browser.version
   end
@@ -89,7 +92,8 @@ describe Browser do
     assert @browser.modern?
     assert @browser.ios?
     assert @browser.tablet?
-    assert ! @browser.mobile?
+    refute @browser.mobile?
+    refute @browser.mac?
     assert_equal "4.0.4", @browser.full_version
     assert_equal "4", @browser.version
   end
@@ -98,6 +102,7 @@ describe Browser do
     @browser.ua = $ua["IOS4"]
     assert @browser.ios?
     assert @browser.ios4?
+    refute @browser.mac?
   end
 
 
@@ -105,18 +110,28 @@ describe Browser do
     @browser.ua = $ua["IOS5"]
     assert @browser.ios?
     assert @browser.ios5?
+    refute @browser.mac?
   end
 
   it "detects ios6" do
     @browser.ua = $ua["IOS6"]
     assert @browser.ios?
     assert @browser.ios6?
+    refute @browser.mac?
   end
 
   it "detects ios7" do
     @browser.ua = $ua["IOS7"]
     assert @browser.ios?
     assert @browser.ios7?
+    refute @browser.mac?
+  end
+
+  it "detects ios8" do
+    @browser.ua = $ua["IOS8"]
+    assert @browser.ios?
+    assert @browser.ios8?
+    refute @browser.mac?
   end
 
   it "detects ie6" do
@@ -125,7 +140,7 @@ describe Browser do
     assert_equal "Internet Explorer", @browser.name
     assert @browser.ie?
     assert @browser.ie6?
-    assert ! @browser.modern?
+    refute @browser.modern?
     assert_equal "6.0", @browser.full_version
     assert_equal "6", @browser.version
   end
@@ -136,7 +151,7 @@ describe Browser do
     assert_equal "Internet Explorer", @browser.name
     assert @browser.ie?
     assert @browser.ie7?
-    assert ! @browser.modern?
+    refute @browser.modern?
     assert_equal "7.0", @browser.full_version
     assert_equal "7", @browser.version
   end
@@ -147,8 +162,8 @@ describe Browser do
     assert_equal "Internet Explorer", @browser.name
     assert @browser.ie?
     assert @browser.ie8?
-    assert ! @browser.modern?
-    assert ! @browser.compatibility_view?
+    refute @browser.modern?
+    refute @browser.compatibility_view?
     assert_equal "8.0", @browser.full_version
     assert_equal "8", @browser.version
   end
@@ -159,8 +174,8 @@ describe Browser do
     assert_equal "Internet Explorer", @browser.name
     assert @browser.ie?
     assert @browser.ie7?
-    assert ! @browser.ie8?
-    assert ! @browser.modern?
+    refute @browser.ie8?
+    refute @browser.modern?
     assert @browser.compatibility_view?
     assert_equal "7.0", @browser.full_version
     assert_equal "7", @browser.version
@@ -173,7 +188,7 @@ describe Browser do
     assert @browser.ie?
     assert @browser.ie9?
     assert @browser.modern?
-    assert ! @browser.compatibility_view?
+    refute @browser.compatibility_view?
     assert_equal "9.0", @browser.full_version
     assert_equal "9", @browser.version
   end
@@ -184,8 +199,8 @@ describe Browser do
     assert_equal "Internet Explorer", @browser.name
     assert @browser.ie?
     assert @browser.ie7?
-    assert ! @browser.ie9?
-    assert ! @browser.modern?
+    refute @browser.ie9?
+    refute @browser.modern?
     assert @browser.compatibility_view?
     assert_equal "7.0", @browser.full_version
     assert_equal "7", @browser.version
@@ -198,7 +213,7 @@ describe Browser do
     assert @browser.ie?
     assert @browser.ie10?
     assert @browser.modern?
-    assert ! @browser.compatibility_view?
+    refute @browser.compatibility_view?
     assert_equal "10.0", @browser.full_version
     assert_equal "10", @browser.version
   end
@@ -209,8 +224,8 @@ describe Browser do
     assert_equal "Internet Explorer", @browser.name
     assert @browser.ie?
     assert @browser.ie7?
-    assert ! @browser.ie10?
-    assert ! @browser.modern?
+    refute @browser.ie10?
+    refute @browser.modern?
     assert @browser.compatibility_view?
     assert_equal "7.0", @browser.full_version
     assert_equal "7", @browser.version
@@ -223,7 +238,7 @@ describe Browser do
     assert @browser.ie?
     assert @browser.ie11?
     assert @browser.modern?
-    assert ! @browser.compatibility_view?
+    refute @browser.compatibility_view?
     assert_equal "11.0", @browser.full_version
     assert_equal "11", @browser.version
   end
@@ -233,7 +248,7 @@ describe Browser do
 
     assert_equal "Opera", @browser.name
     assert @browser.opera?
-    assert ! @browser.modern?
+    refute @browser.modern?
     assert_equal "11.64", @browser.full_version
     assert_equal "11", @browser.version
   end
@@ -246,7 +261,7 @@ describe Browser do
     assert @browser.opera?
     assert @browser.webkit?
     assert @browser.modern?
-    assert ! @browser.chrome?
+    refute @browser.chrome?
     assert_equal "28.0.1500.37", @browser.full_version
     assert_equal "28", @browser.version
   end
@@ -256,7 +271,7 @@ describe Browser do
 
     assert_equal "Firefox", @browser.name
     assert @browser.firefox?
-    assert ! @browser.modern?
+    refute @browser.modern?
     assert_equal "3.8", @browser.full_version
     assert_equal "3", @browser.version
   end
@@ -288,7 +303,7 @@ describe Browser do
 
     assert_equal "Chrome", @browser.name
     assert @browser.chrome?
-    assert ! @browser.safari?
+    refute @browser.safari?
     assert @browser.webkit?
     assert @browser.modern?
     assert_equal "5.0.375.99", @browser.full_version
@@ -300,22 +315,35 @@ describe Browser do
 
     assert_equal "Chrome", @browser.name
     assert @browser.chrome?
-    assert ! @browser.safari?
+    refute @browser.safari?
     assert @browser.webkit?
     assert @browser.modern?
     assert_equal "19.0.1084.60", @browser.full_version
     assert_equal "19", @browser.version
   end
 
+  it "detects samsung chrome" do
+    @browser.ua = $ua["SAMSUNG_CHROME"]
+
+    assert_equal "Chrome", @browser.name
+    assert @browser.chrome?
+    assert @browser.android?
+    refute @browser.safari?
+    assert @browser.webkit?
+    assert @browser.modern?
+    assert_equal "28.0.1500.94", @browser.full_version
+    assert_equal "28", @browser.version
+  end
+
   it "detects android" do
     @browser.ua = $ua["ANDROID"]
 
     assert_equal "Android", @browser.name
     assert @browser.android?
-    assert @browser.safari?
+    refute @browser.safari?
     assert @browser.webkit?
     assert @browser.mobile?
-    assert ! @browser.tablet?
+    refute @browser.tablet?
     assert @browser.modern?
     assert_equal "3.1.2", @browser.full_version
     assert_equal "3", @browser.version
@@ -326,9 +354,9 @@ describe Browser do
 
     assert_equal "Android", @browser.name
     assert @browser.android?
-    assert @browser.safari?
+    refute @browser.safari?
     assert @browser.webkit?
-    assert ! @browser.mobile?
+    refute @browser.mobile?
     assert @browser.tablet?
     assert @browser.modern?
     assert_equal "4.0", @browser.full_version
@@ -341,7 +369,7 @@ describe Browser do
     assert_equal "Internet Explorer", @browser.name
     assert @browser.surface?
     assert @browser.ie?
-    assert ! @browser.mobile?
+    refute @browser.mobile?
     assert @browser.tablet?
     assert @browser.modern?
     assert_equal "10.0", @browser.full_version
@@ -353,9 +381,9 @@ describe Browser do
 
     assert_equal "BlackBerry", @browser.name
     assert @browser.blackberry?
-    assert ! @browser.tablet?
+    refute @browser.tablet?
     assert @browser.mobile?
-    assert ! @browser.modern?
+    refute @browser.modern?
     assert_equal "4.1.0", @browser.full_version
     assert_equal "4", @browser.version
   end
@@ -365,9 +393,9 @@ describe Browser do
 
     assert_equal "BlackBerry", @browser.name
     assert @browser.blackberry4?
-    assert ! @browser.tablet?
+    refute @browser.tablet?
     assert @browser.mobile?
-    assert ! @browser.modern?
+    refute @browser.modern?
     assert_equal "4.2.1", @browser.full_version
     assert_equal "4", @browser.version
   end
@@ -377,9 +405,9 @@ describe Browser do
 
     assert_equal "BlackBerry", @browser.name
     assert @browser.blackberry5?
-    assert ! @browser.tablet?
+    refute @browser.tablet?
     assert @browser.mobile?
-    assert ! @browser.modern?
+    refute @browser.modern?
     assert_equal "5.0.0.93", @browser.full_version
     assert_equal "5", @browser.version
   end
@@ -389,7 +417,7 @@ describe Browser do
 
     assert_equal "BlackBerry", @browser.name
     assert @browser.blackberry6?
-    assert ! @browser.tablet?
+    refute @browser.tablet?
     assert @browser.mobile?
     assert @browser.modern?
     assert_equal "534.11", @browser.full_version
@@ -401,7 +429,7 @@ describe Browser do
 
     assert_equal "BlackBerry", @browser.name
     assert @browser.blackberry7?
-    assert ! @browser.tablet?
+    refute @browser.tablet?
     assert @browser.mobile?
     assert @browser.modern?
     assert_equal "534.11", @browser.full_version
@@ -413,7 +441,7 @@ describe Browser do
 
     assert_equal "Safari", @browser.name
     assert @browser.blackberry10?
-    assert ! @browser.tablet?
+    refute @browser.tablet?
     assert @browser.mobile?
     assert @browser.modern?
     assert_equal "10.0.9.1675", @browser.full_version
@@ -443,8 +471,8 @@ describe Browser do
 
     assert_equal "PhantomJS", @browser.name
     assert @browser.phantom_js?
-    assert ! @browser.tablet?
-    assert ! @browser.mobile?
+    refute @browser.tablet?
+    refute @browser.mobile?
     assert @browser.modern?
     assert_equal "1.9.0", @browser.full_version
     assert_equal "1", @browser.version
@@ -469,11 +497,11 @@ describe Browser do
   it "detects other mobiles" do
     @browser.ua = "Symbian OS"
     assert @browser.mobile?
-    assert ! @browser.tablet?
+    refute @browser.tablet?
 
     @browser.ua = "MIDP-2.0"
     assert @browser.mobile?
-    assert ! @browser.tablet?
+    refute @browser.tablet?
   end
 
   it "detects windows mobile" do
@@ -482,8 +510,8 @@ describe Browser do
     assert @browser.mobile?
     assert @browser.windows?
     assert @browser.windows_mobile?
-    assert ! @browser.windows_phone?
-    assert ! @browser.tablet?
+    refute @browser.windows_phone?
+    refute @browser.tablet?
   end
 
   it "returns a zero version" do
@@ -516,7 +544,6 @@ describe Browser do
     assert meta.include?("ios")
     assert meta.include?("safari")
     assert meta.include?("safari3")
-    assert meta.include?("mac")
     assert meta.include?("modern")
     assert meta.include?("mobile")
   end
@@ -622,7 +649,7 @@ describe Browser do
 
     assert @browser.android?
     assert @browser.tablet?
-    assert ! @browser.mobile?
+    refute @browser.mobile?
   end
 
   it "detects nexus tablet" do
@@ -630,15 +657,15 @@ describe Browser do
 
     assert @browser.android?
     assert @browser.tablet?
-    assert ! @browser.mobile?
+    refute @browser.mobile?
   end
 
   it "detects blackberry playbook tablet" do
     @browser.ua = $ua["PLAYBOOK"]
 
-    assert ! @browser.android?
+    refute @browser.android?
     assert @browser.tablet?
-    assert ! @browser.mobile?
+    refute @browser.mobile?
 
     assert_equal "7.2.1.0", @browser.full_version
     assert_equal "7", @browser.version
@@ -648,7 +675,7 @@ describe Browser do
     @browser.ua = $ua["OPERA_MINI"]
 
     assert @browser.opera_mini?
-    assert ! @browser.tablet?
+    refute @browser.tablet?
     assert @browser.mobile?
   end
 
@@ -656,7 +683,7 @@ describe Browser do
     @browser.ua = $ua["OPERA_MOBI"]
 
     assert @browser.opera?
-    assert ! @browser.tablet?
+    refute @browser.tablet?
     assert @browser.mobile?
   end
 
@@ -667,8 +694,8 @@ describe Browser do
     assert_equal "7", @browser.version
     assert @browser.mobile?
     assert @browser.windows_phone?
-    assert ! @browser.windows_mobile?
-    assert ! @browser.tablet?
+    refute @browser.windows_mobile?
+    refute @browser.tablet?
   end
 
   it "detects windows phone 8" do
@@ -678,8 +705,8 @@ describe Browser do
     assert_equal "10", @browser.version
     assert @browser.mobile?
     assert @browser.windows_phone?
-    assert ! @browser.windows_mobile?
-    assert ! @browser.tablet?
+    refute @browser.windows_mobile?
+    refute @browser.tablet?
   end
 
   it "detects windows mobile" do
@@ -689,8 +716,8 @@ describe Browser do
     assert_equal "10", @browser.version
     assert @browser.mobile?
     assert @browser.windows_phone?
-    assert ! @browser.windows_mobile?
-    assert ! @browser.tablet?
+    refute @browser.windows_mobile?
+    refute @browser.tablet?
   end
 
   it "detects windows x64" do
@@ -705,8 +732,8 @@ describe Browser do
     assert @browser.ie?
     assert @browser.ie11?
     assert @browser.modern?
-    assert ! @browser.compatibility_view?
-    assert ! @browser.windows_rt?
+    refute @browser.compatibility_view?
+    refute @browser.windows_rt?
     assert @browser.windows_touchscreen_desktop?
     assert @browser.windows8?
     assert_equal "11.0", @browser.full_version
@@ -734,7 +761,7 @@ describe Browser do
     assert @browser.kindle?
     assert @browser.webkit?
     assert @browser.modern?
-    assert ! @browser.mobile?
+    refute @browser.mobile?
   end
 
   it "detects kindle fire hd mobile" do
@@ -751,14 +778,14 @@ describe Browser do
     @browser.ua = $ua["NOOK"]
 
     assert @browser.tablet?
-    assert ! @browser.mobile?
+    refute @browser.mobile?
   end
 
   it "detects samsung" do
     @browser.ua = $ua["SAMSUNG"]
 
     assert @browser.tablet?
-    assert ! @browser.mobile?
+    refute @browser.mobile?
   end
 
   it "detects nintendo wii" do
@@ -831,19 +858,24 @@ describe Browser do
     end
 
     @browser.ua = $ua["CHROME"]
-    assert ! @browser.bot?
+    refute @browser.bot?
   end
 
   it "doesn't consider empty UA as bot" do
     @browser.ua = ''
-    assert ! @browser.bot?
+    refute @browser.bot?
   end
 
   it "allows setting empty string as bots" do
     Browser::Bots.detect_empty_ua!
     @browser.ua = ''
     assert @browser.bot?
-    Browser::Bots::BOTS.delete('')
+  end
+
+  it "doesn't consider mozilla as a bot when considerint empty UA" do
+    Browser::Bots.detect_empty_ua!
+    @browser.ua = "Mozilla"
+    refute @browser.bot?
   end
 
   it "detects chrome os" do

data/test/ua.yml

@@ -37,6 +37,7 @@ XOOM: "Mozilla/5.0 (Linux; U; Android 3.0; en-us; Xoom Build/HRI39) AppleWebKit/
 NEXUS_TABLET: "Mozilla/5.0 (Linux; Android 4.1.1; Nexus 7 Build/JRO03D) AppleWebKit/535.19 (KHTML, like Gecko) Chrome/18.0.1025.166 Safari/535.19"
 NOOK: "Mozilla/5.0 (Linux; U; Android 2.3.4; en-us; NOOK BNTV250A Build/GINGERBREAD 1.4.3) AppleWebKit/533.1 (KHTML, like Gecko) Version/4.0 Safari/533.1"
 SAMSUNG: "Mozilla/5.0 (Linux; U; Android 4.0.4; en-us; SAMSUNG-SGH-I497 Build/IMM76D) AppleWebKit/534.30 (KHTML, like Gecko) Version/4.0 Safari/534.30"
+SAMSUNG_CHROME: "Mozilla/5.0 (Linux; Android 4.4.2; en-gb; SAMSUNG GT-I9195/I9195XXUCNEA Build/KOT49H) AppleWebKit/537.36 (KHTML, like Gecko) Version/1.5 Chrome/28.0.1500.94 Mobile Safari/537.36"
 OPERA_MINI: "Opera/9.80 (Android; Opera Mini/7.029952/28.2359;u; fr) Presto/2.8.119 Version/11.10"
 OPERA_MOBI: "Opera/9.8 (Android 2.3.5; Linux; Opera Mobi/ADR-1205181138; U; en) Presto/2.10.254 Version/12.00"
 WINDOWS_PHONE: "Mozilla/4.0 (compatible; MSIE 7.0; Windows Phone OS 7.0; Trident/3.1; IEMobile/7.0; DELL; Venue Pro)"
@@ -54,6 +55,7 @@ IOS4: "Mozilla/5.0 (iPhone; U; CPU iPhone OS 4_0 like Mac OS X; en-us) AppleWebK
 IOS5: "Mozilla/5.0 (iPhone; CPU iPhone OS 5_0 like Mac OS X) AppleWebKit/534.46 (KHTML, like Gecko) Version/5.1 Mobile/9A334 Safari/7534.48.3"
 IOS6: "Mozilla/5.0 (iPhone; CPU iPhone OS 6_0 like Mac OS X) AppleWebKit/536.26 (KHTML, like Gecko) Version/6.0 Mobile/10A5376e Safari/8536.25"
 IOS7: "Mozilla/5.0 (iPhone; CPU iPhone OS 7_0 like Mac OS X) AppleWebKit/537.51.1 (KHTML, like Gecko) Version/7.0 Mobile/11A465 Safari/9537.53"
+IOS8: "Mozilla/5.0 (iPhone; CPU iPhone OS 8_0 like Mac OS X) AppleWebKit/600.1.4 (KHTML, like Gecko) Version/8.0 Mobile/12A365 Safari/600.1.4"
 PLAYBOOK: "Mozilla/5.0 (PlayBook; U; RIM Tablet OS 2.1.0; en-US) AppleWebKit/536.2+ (KHTML, like Gecko) Version/7.2.1.0 Safari/536.2+"
 NINTENDO_WII: "Opera/9.00 (Nintendo Wii; U; ; 1309-9; en)"
 NINTENDO_WIIU: "Mozilla/5.0 (Nintendo WiiU) AppleWebKit/534.52 (KHTML, like Gecko) NX/2.1.0.8.23 NintendoBrowser/1.1.0.7579.EU"
@@ -77,3 +79,4 @@ YAHOO_SLURP: "Mozilla/5.0 (compatible; Yahoo! Slurp; http://help.yahoo.com/help/
 ASK: "Mozilla/2.0 (compatible; Ask Jeeves/Teoma; +http://sp.ask.com/docs/about/tech_crawling.html)"
 BINGBOT: "Mozilla/5.0 (compatible; bingbot/2.0; +http://www.bing.com/bingbot.htm)"
 DUCKDUCKGO: "DuckDuckBot/1.0; (+http://duckduckgo.com/duckduckbot.html)"
+ANDROID_WITH_SAFARI: 'Mozilla/5.0 (Linux; U; Android 4.3; en-us; SCH-I535 Build/JSS15J) AppleWebKit/534.30 (KHTML, like Gecko) Version/4.0 Mobile Safari/534.30'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: browser
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.7.0
 platform: ruby
 authors:
 - Nando Vieira
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-06 00:00:00.000000000 Z
+date: 2014-09-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler