browser 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d33f512a1af14cd694c0268b45aa9b197f5011fd
-  data.tar.gz: 73de6e2670165e5b7de2b1966ad67a7863afe55a
+  metadata.gz: 4b3b6a159e6f696022dbcf224f2366040a014066
+  data.tar.gz: 12cfb603efd44bfa40a6211dc81cdbfc8cc3175a
 SHA512:
-  metadata.gz: 69b2e09e88e616b7942e63285d704459002d39264f604ae46397ac8b198c5fcd2fe18663730076709b406b55986b13d7e041913bc584c0e5f132db59df3abf6a
-  data.tar.gz: 45c8ae00d05cc760f415e56a68ab7689a1f3d62f292f72ad5316f931769c56bca9b6a8ec10b09dec68cfe17c8b9bbcb31a364e11fd216ba3a01817ed6df9085a
+  metadata.gz: 73d07937171c917f60c801a15f6d7ad4fe637d041c49b7fee0eb0327d8cbeaeeda0e1322ee08e208021e689ff7a357e4af6aa1e9d532f7e4705fda8289511de2
+  data.tar.gz: bcee3558d4278b99921b93d6eb8763d640c475da9e5351b6c3f8f692ba6f7984427d2020c5eb0ad146b34d70286ef020731c7fd73732650672da3b3136e178fe

data/lib/browser/middleware.rb

@@ -5,6 +5,9 @@ class Browser
     # Detect the most common assets.
     ASSETS_REGEX = %r[\.(css|png|jpe?g|gif|js|svg|ico|flv|mov|m4v|ogg|swf)\z]i
 
+    # Detect the ACCEPT header. IE8 send */*.
+    ACCEPT_REGEX = %r[(text/html|\*/\*)]
+
     def initialize(app, &block)
       raise ArgumentError, "Browser::Middleware requires a block" unless block
 
@@ -18,7 +21,7 @@ class Browser
       # Only apply verification on HTML requests.
       # This ensures that images, CSS and JavaScript
       # will be rendered.
-      return run_app(env) unless html?(request)
+      return run_app(env) unless process?(request)
 
       path = catch(:redirected) do
         Context.new(request).instance_eval(&@block)
@@ -48,9 +51,16 @@ class Browser
       @app.call(env)
     end
 
+    def process?(request)
+      html?(request) && !assets?(request)
+    end
+
     def html?(request)
-      return if request.path.match(ASSETS_REGEX)
-      request.env["HTTP_ACCEPT"].to_s.include?("text/html")
+      request.env["HTTP_ACCEPT"].to_s.match(ACCEPT_REGEX)
+    end
+
+    def assets?(request)
+      request.path.match(ASSETS_REGEX)
     end
   end
 end

data/lib/browser/version.rb

@@ -2,7 +2,7 @@ class Browser
   module Version
     MAJOR = 0
     MINOR = 4
-    PATCH = 0
+    PATCH = 1
     STRING = "#{MAJOR}.#{MINOR}.#{PATCH}"
   end
 end

data/test/middleware_test.rb

@@ -35,6 +35,13 @@ class MiddlewareTest < Test::Unit::TestCase
     assert_equal 404, last_response.status
   end
 
+  def test_redirect_ie8_with_wildcard_http_accept
+    get "/", {}, {"HTTP_USER_AGENT" => "MSIE 8", "HTTP_ACCEPT" => "*/*"}
+    follow_redirect!
+
+    assert_equal 404, last_response.status
+  end
+
   def test_ignores_non_html_requests
     get "/", {}, {"HTTP_USER_AGENT" => "MSIE 6", "HTTP_ACCEPT" => "image/png"}
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: browser
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Nando Vieira
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-07 00:00:00.000000000 Z
+date: 2014-03-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -159,7 +159,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.0
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Do some browser detection with Ruby.