browse-everything 0.16.1 → 1.0.0.rc1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: 36223786bc3a801a4cde821810d4e8976f0a1034fcc228acaea6a7eba411770e
-  data.tar.gz: 1611bfb8566183526c1489bb3de4dd8beac2147c7cf0b637d18a445267984daf
+SHA1:
+  metadata.gz: 46cd3b246ede692cfea34a3251136fe8eb5e64a1
+  data.tar.gz: b0bc78f050b3c55dae7b3dab2962c606ecc9cf8c
 SHA512:
-  metadata.gz: 47f835658832bc8837d99c18f4e3dae6a5e8d1edebb183950022a3d44c9b309e04437853d727449b1c0705eaf959fa43ab62c7b5c50ccc78298d6b3d6d2d0e0c
-  data.tar.gz: a725066448c474d91fd38590dbc470ce5bdcf5cf7e60df0721a7ddfbc122fd004a23c99688565ca368610da3adf77f8b95d0bd383f940cf0285d4c189638756e
+  metadata.gz: a5e82c374b814abca77205c8d79705eb901952a5cb589559d66c7b6619a2673c8f5978f425f17f7639d9862b5dfb7155d28b1ac15a84ddcfc03246ad394b8b2c
+  data.tar.gz: 0a9935875a2ed98761c866e297a7114fa6352da032548f7c4fe9ca164ebd00101ff7404822f56529eb4c38199bb1a54438d55390b8e9317e6550f88b97a0ba07

data/.rubocop.yml

@@ -20,6 +20,9 @@ Metrics/ClassLength:
     - 'lib/browse_everything/driver/google_drive.rb'
 Metrics/LineLength:
   Max: 400
+  Exclude:
+    - 'spec/lib/browse_everything/driver/box_spec.rb'
+    - 'spec/lib/browse_everything/driver/dropbox_spec.rb'
 Metrics/BlockLength:
   Exclude:
     - '*.gemspec'

data/CODE_OF_CONDUCT.md

@@ -0,0 +1,36 @@
+The Samvera community is dedicated to providing a welcoming and
+positive experience for all its members, whether they are at a formal
+gathering, in a social setting, or taking part in activities online.
+The Samvera community welcomes participation from people all over the
+world and these members bring with them a wide variety of
+professional, personal and social backgrounds; whatever these may be,
+we treat colleagues with dignity and respect.
+
+Community members communicate primarily in English, though for many of
+them this is not their native language. We therefore strive to express
+ourselves simply and clearly remembering that unnecessary use of
+jargon and slang will be a barrier to understanding for many of our
+colleagues.  We are sensitive to the fact that the international
+nature of the community means that we span many different social norms
+around language and behaviour and we strive to conduct ourselves,
+online and in person, in ways that are unlikely to cause offence.
+
+Samvera conversations are often information-rich and intended to
+generate discussion and debate.  We discuss ideas from a standpoint of
+mutual respect and reasoned argument.
+
+Community members work together to promote a respectful and safe
+community. In the event that someone’s conduct is causing offence or
+distress, Samvera has a detailed
+[Anti-Harassment Policy and Protocol](https://wiki.duraspace.org/display/samvera/Anti-Harassment+Policy)
+which can be applied to address the problem. The first step in dealing
+with any serious misconduct is to contact a local meeting organizer,
+the
+[Samvera community helpers](https://wiki.duraspace.org/display/samvera/Samvera+Community+Helpers)
+([email](mailto:helpers@samvera.org)), a community member you
+trust, or the
+[Samvera Steering Group](https://wiki.duraspace.org/display/samvera/Samvera+Steering+Group+membership)
+immediately; at Samvera events, these people can be identified by
+distinctive name badges. The
+[Policy and Protocol](https://wiki.duraspace.org/display/samvera/Anti-Harassment+Policy)
+should be consulted for fuller details.

data/CONTRIBUTING.md

@@ -1,19 +1,22 @@
 # How to Contribute
 
-We want your help to make Samvera Community great.
-There are a few guidelines that we need contributors to follow so that we can have a chance of keeping on top of things.
+We want your help to make the Samvera community great. There are a few guidelines
+that we need contributors to follow so that we can have a chance of
+keeping on top of things.
 
 ## Code of Conduct
 
-The Samvera Community is dedicated to providing a welcoming and positive experience for all its
-members, whether they are at a formal gathering, in a social setting, or taking part in activities
-online.  Please see our [Code of Conduct](https://wiki.duraspace.org/display/samvera/Code+of+Conduct)
-for more information.
+The Samvera Community is dedicated to providing a welcoming and positive
+experience for all its members, whether they are at a formal gathering, in
+a social setting, or taking part in activities online. Please see our
+[Code of Conduct](CODE_OF_CONDUCT.md) for more information.
 
 ## Samvera Community Intellectual Property Licensing and Ownership
 
-All code contributors must have an Individual Contributor License Agreement (iCLA) on file with the Hydra Project Steering Group.
-If the contributor works for an institution, the institution must have a Corporate Contributor License Agreement (cCLA) on file.
+All code contributors must have an Individual Contributor License Agreement
+(iCLA) on file with the Samvera Steering Group. If the contributor works for
+an institution, the institution must have a Corporate Contributor License
+Agreement (cCLA) on file.
 
 https://wiki.duraspace.org/display/samvera/Samvera+Community+Intellectual+Property+Licensing+and+Ownership
 
@@ -31,7 +34,7 @@ You should also add yourself to the `CONTRIBUTORS.md` file in the root of the pr
 ### Reporting Issues
 
 * Make sure you have a [GitHub account](https://github.com/signup/free)
-* Submit a [Github issue](./issues) by:
+* Submit a [Github issue](https://github.com/samvera/browse-everything/issues) by:
   * Clearly describing the issue
     * Provide a descriptive summary
     * Explain the expected behavior
@@ -48,7 +51,7 @@ You should also add yourself to the `CONTRIBUTORS.md` file in the root of the pr
   * Please avoid working directly on the `master` branch.
   * You may find the [hub suite of commands](https://github.com/defunkt/hub) helpful
 * Make sure you have added sufficient tests and documentation for your changes.
-  * Test functionality with RSpec; est features / UI with Capybara.
+  * Test functionality with RSpec; Test features / UI with Capybara.
 * Run _all_ the tests to assure nothing else was accidentally broken.
 
 ### Documenting Code
@@ -60,15 +63,11 @@ You should also add yourself to the `CONTRIBUTORS.md` file in the root of the pr
   * If you don't know exactly what a bit of code does, it is extra likely that it needs to be documented. Take a stab at it and ask for feedback in your pull request. You can use the 'blame' button on GitHub to identify the original developer of the code and @mention them in your comment.
   * This work greatly increases the usability of the code base and supports the on-ramping of new committers.
   * We will all be understanding of one another's time constraints in this area.
-* YARD examples:
-  * [Hyrax::AdminSet](https://github.com/samvera/hyrax/blob/master/app/models/admin_set.rb)
-  * [ActiveTriples::LocalName::Minter](https://github.com/ActiveTriples/active_triples-local_name/blob/master/lib/active_triples/local_name/minter.rb)
 * [Getting started with YARD](http://www.rubydoc.info/gems/yard/file/docs/GettingStarted.md)
 
 ### Committing changes
 
 * Make commits of logical units.
-  * Your commit should include a high level description of your work in HISTORY.textile
 * Check for unnecessary whitespace with `git diff --check` before committing.
 * Make sure your commit messages are [well formed](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html).
 * If you created an issue, you can close it by including "Closes #issue" in your commit message. See [Github's blog post for more details](https://github.com/blog/1386-closing-issues-via-commit-messages)
@@ -103,6 +102,10 @@ You should also add yourself to the `CONTRIBUTORS.md` file in the root of the pr
       long to fit in 72 characters
 ```
 
+* Make sure you have added the necessary tests for your changes.
+* Run _all_ the tests to assure nothing else was accidentally broken.
+* When you are ready to submit a pull request
+
 ### Submitting Changes
 
 * Read the article ["Using Pull Requests"](https://help.github.com/articles/using-pull-requests) on GitHub.
@@ -125,9 +128,7 @@ We adopted [Github's Pull Request Review](https://help.github.com/articles/about
 Common checks that may occur in our repositories:
 
 1. Travis CI - where our automated tests are running
-2. Hound CI - where we check for style violations
-3. Approval Required - Github enforces at least one person approve a pull request. Also, all reviewers that have chimed in must approve.
-4. CodeClimate - is our code remaining healthy (at least according to static code analysis)
+2. Approval Required - Github enforces at least one person approve a pull request. Also, all reviewers that have chimed in must approve.
 
 If one or more of the required checks failed (or are incomplete), the code should not be merged (and the UI will not allow it). If all of the checks have passed, then anyone on the project (including the pull request submitter) may merge the code.
 
@@ -144,16 +145,17 @@ First, the person contributing the code is putting themselves out there. Be mind
 This is your chance for a mentoring moment of another developer. Take time to give an honest and thorough review of what has changed. Things to consider:
 
   * Does the commit message explain what is going on?
-  * Does the code changes have tests? _Not all changes need new tests, some changes are refactors_
+  * Does the code changes have tests? _Not all changes need new tests, some changes are refactorings_
   * Do new or changed methods, modules, and classes have documentation?
   * Does the commit contain more than it should? Are two separate concerns being addressed in one commit?
   * Does the description of the new/changed specs match your understanding of what the spec is doing?
+  * Did the Travis tests complete successfully?
 
 If you are uncertain, bring other contributors into the conversation by assigning them as a reviewer.
 
 # Additional Resources
 
 * [General GitHub documentation](http://help.github.com/)
-* [GitHub pull request documentation](http://help.github.com/send-pull-requests/)
+* [GitHub pull request documentation](https://help.github.com/articles/about-pull-requests/)
 * [Pro Git](http://git-scm.com/book) is both a free and excellent book about Git.
 * [A Git Config for Contributing](http://ndlib.github.io/practices/my-typical-per-project-git-config/)

data/Gemfile

@@ -39,6 +39,7 @@ else
   when /^4\.2/
     gem 'coffee-rails', '~> 4.1.0'
     gem 'json', '~> 1.8'
+    gem 'railties', '~> 4.2'
     gem 'responders', '~> 2.0'
     gem 'sass-rails', '>= 5.0'
   end

data/README.md

@@ -1,8 +1,17 @@
+# BrowseEverything
+
+Code:
 [![Gem Version](https://badge.fury.io/rb/browse-everything.png)](http://badge.fury.io/rb/browse-everything)
 [![Build Status](https://travis-ci.org/samvera/browse-everything.svg?branch=master)](https://travis-ci.org/samvera/browse-everything)
 [![Coverage Status](https://coveralls.io/repos/samvera/browse-everything/badge.svg?branch=master&service=github)](https://coveralls.io/github/samvera/browse-everything?branch=master)
 
-# BrowseEverything
+Docs:
+[![Contribution Guidelines](http://img.shields.io/badge/CONTRIBUTING-Guidelines-blue.svg)](./CONTRIBUTING.md)
+[![Apache 2.0 License](http://img.shields.io/badge/APACHE2-license-blue.svg)](./LICENSE.txt)
+
+Jump in: [![Slack Status](http://slack.samvera.org/badge.svg)](http://slack.samvera.org/)
+
+# What is BrowseEverything?
 
 This Gem allows your rails application to access user files from cloud storage.
 Currently there are drivers implemented for [Dropbox](http://www.dropbox.com),
@@ -16,6 +25,18 @@ download the files.
 
 **This gem does not depend on hydra-head**
 
+## Product Owner & Maintenance
+
+BrowseEverything is a Core Component of the Samvera community. The documentation for
+what this means can be found
+[here](http://samvera.github.io/core_components.html#requirements-for-a-core-component).
+
+### Product Owner
+
+[mbklein](https://github.com/mbklein)
+
+# Getting Started
+
 ## Supported Ruby Releases
 Currently, the following releases of Ruby are supported:
 - 2.5.1
@@ -213,14 +234,13 @@ See `spec/support/app/views/file_handler/index.html` for an example use case. Yo
 create a fully-functioning demo app in `spec/internal` (though you will have to create
 `spec/internal/config/browse_everything.providers.yml` file with your own configuration info.)
 
-## Contributing
+# Help
+
+The Samvera community is here to help. Please see our [support guide](./SUPPORT.md).
 
-1. Fork it
-2. Create your feature branch (`git checkout -b my-new-feature`)
-3. Commit your changes (`git commit -am 'Add some feature'`)
-4. Push to the branch (`git push origin my-new-feature`)
-5. Create new Pull Request
+# Acknowledgments
 
-## Help
+This software has been developed by and is brought to you by the Samvera community.  Learn more at the
+[Samvera website](http://samvera.org/).
 
-For help with Browse Everything, contact <samvera-tech@googlegroups.com>.
+![Samvera Logo](https://wiki.duraspace.org/download/thumbnails/87459292/samvera-fall-font2-200w.png?version=1&modificationDate=1498550535816&api=v2)

data/SUPPORT.md

@@ -0,0 +1,5 @@
+If you would like to report an issue, first search [the list of issues](https://github.com/samvera/browse-everything/issues/) to see if someone else has already reported it, and then feel free to [create a new issue](https://github.com/samvera/browse-everything/issues/new).
+
+If you have questions or need help, please email [the Samvera community tech list](https://groups.google.com/forum/#!forum/samvera-tech) or stop by the #dev channel in [the Samvera community Slack team](https://wiki.duraspace.org/pages/viewpage.action?pageId=87460391#Getintouch!-Slack).
+
+You can learn more about the various Samvera communication channels on the [Get in touch!](https://wiki.duraspace.org/pages/viewpage.action?pageId=87460391) wiki page.

data/app/controllers/browse_everything_controller.rb

@@ -36,10 +36,10 @@ class BrowseEverythingController < ActionController::Base
   end
 
   # Action for the OAuth2 callback
-  # Authenticate against the Google API and store the token in the session
+  # Authenticate against the API and store the token in the session
   def auth
     # params contains the access code with with the key :code
-    provider_session.token = provider.connect(params, provider_session.data)
+    provider_session.token = provider.connect(params, provider_session.data, connector_response_url_options)
   end
 
   def resolve
@@ -76,11 +76,15 @@ class BrowseEverythingController < ActionController::Base
       @provider_session = nil
     end
 
+    def connector_response_url_options
+      { protocol: request.protocol, host: request.host, port: request.port }
+    end
+
     # Generates the authentication link for a given provider service
     # @return [String] the authentication link
     def auth_link
       @auth_link ||= if provider.present?
-                       link, data = provider.auth_link
+                       link, data = provider.auth_link(connector_response_url_options)
                        provider_session.data = data
                        link = "#{link}&state=#{provider.key}" unless link.to_s.include?('state')
                        link

data/app/views/browse_everything/_files.html.erb

@@ -50,17 +50,25 @@
           </td>
         <% end %>
 
-        <td role="gridcell" class="ev-file-size">
-          <%= number_to_human_size(file.size).sub(/Bytes/,'bytes') %>
-        </td>
+        <% if file.size %>
+          <td role="gridcell" class="ev-file-size">
+            <%= number_to_human_size(file.size).sub(/Bytes/,'bytes') %>
+          </td>
+        <% else %>
+          <td role="gridcell" class="ev-file-size">Unknown</td>
+        <% end %>
 
         <td role="gridcell" class="ev-file-kind">
           <%= file.type %>
         </td>
 
-        <td role="gridcell" class="ev-file-date">
-          <%= file.mtime.strftime('%F %R') %>
-        </td>
+        <% if file.mtime %>
+          <td role="gridcell" class="ev-file-date">
+            <%= file.mtime.strftime('%F %R') %>
+          </td>
+        <% else %>
+          <td role="gridcell" class="ev-file-date">Unknown</td>
+        <% end %>
     </tr>
   <% end %>
 </table>

data/app/views/browse_everything/index.html.erb

@@ -12,7 +12,13 @@
       </div>
       <div class="ev-browser row" aria-live="polite">
         <div class="<%=fa3or4('fa3','fa4')%> col-xs-12 ev-files list">
-          <%= render :partial => 'files' if provider.present? %>
+          <% if provider.present? %>
+            <% if provider.authorized? %>
+              <%= render :partial => 'files' %>
+            <% else %>
+              <%= render :partial => 'auth' %>
+            <% end %>
+          <% end %>
         </div>
       </div>
     </div>

data/browse-everything.gemspec

@@ -24,24 +24,25 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'bootstrap-sass', '~> 3.2'
   spec.add_dependency 'dropbox_api', '>= 0.1.10'
   spec.add_dependency 'font-awesome-rails'
-  spec.add_dependency 'google-api-client', '~> 0.21'
+  spec.add_dependency 'google-api-client', '~> 0.23'
   spec.add_dependency 'google_drive', '~> 2.1'
-  spec.add_dependency 'googleauth', '0.6.2'
+  spec.add_dependency 'googleauth', '0.6.6'
   spec.add_dependency 'rails', '>= 4.2'
   spec.add_dependency 'ruby-box'
   spec.add_dependency 'sass-rails'
   spec.add_dependency 'signet', '~> 0.8'
-  spec.add_dependency 'thor', '~> 0.20'
+  spec.add_dependency 'thor', '~> 0.19'
   spec.add_dependency 'typhoeus'
 
   spec.add_development_dependency 'bixby', '>= 1.0'
   spec.add_development_dependency 'bundler', '~> 1.3'
   spec.add_development_dependency 'capybara'
-  spec.add_development_dependency 'chromedriver-helper'
+  spec.add_development_dependency 'chromedriver-helper', '1.2.0'
   spec.add_development_dependency 'coveralls'
   spec.add_development_dependency 'engine_cart', '~> 2.0'
   spec.add_development_dependency 'factory_bot_rails'
   spec.add_development_dependency 'jasmine', '~> 2.3'
+  spec.add_development_dependency 'pry-byebug'
   spec.add_development_dependency 'rails-controller-testing'
   spec.add_development_dependency 'rake'
   spec.add_development_dependency 'rspec', '~> 3.0'
@@ -51,6 +52,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'selenium-webdriver'
   spec.add_development_dependency 'simplecov'
   spec.add_development_dependency 'sqlite3'
-  spec.add_development_dependency 'vcr'
   spec.add_development_dependency 'webmock'
 end

data/lib/browse_everything/driver/base.rb

@@ -89,7 +89,7 @@ module BrowseEverything
       end
 
       # Abstract method
-      def auth_link
+      def auth_link(*_args)
         []
       end
 

data/lib/browse_everything/driver/box.rb

@@ -36,13 +36,8 @@ module BrowseEverything
       # @param [String] id of the file or folder in Box
       # @return [Array<RubyBox::File>]
       def contents(id = '')
-        if id.empty?
-          folder = box_client.root_folder
-          @entries = []
-        else
-          folder = box_client.folder_by_id(id)
-          @entries = [parent_directory(folder)]
-        end
+        folder = id.empty? ? box_client.root_folder : box_client.folder_by_id(id)
+        @entries = []
 
         folder.items(ITEM_LIMIT, 0, %w[name size created_at]).collect do |f|
           @entries << directory_entry(f)
@@ -62,7 +57,7 @@ module BrowseEverything
 
       # @return [String]
       # Authorization url that is used to request the initial access code from Box
-      def auth_link
+      def auth_link(*_args)
         box_session.authorize_url(callback.to_s)
       end
 
@@ -73,7 +68,7 @@ module BrowseEverything
 
       # @return [Hash]
       # Gets the appropriate tokens from Box using the access code returned from :auth_link:
-      def connect(params, _data)
+      def connect(params, _data, _url_options)
         register_access_token(box_session.get_access_token(params[:code]))
       end
 
@@ -138,11 +133,6 @@ module BrowseEverything
           @token.fetch('expires_at', nil).to_i
         end
 
-        # Used to represent the ".." parent directory of the folder
-        def parent_directory(folder)
-          BrowseEverything::FileEntry.new(Pathname(folder.name).join('..'), '', '..', 0, Time.current, true)
-        end
-
         def directory_entry(file)
           BrowseEverything::FileEntry.new(file.id, "#{key}:#{file.id}", file.name, file.size, file.created_at, file.type == 'folder')
         end

data/lib/browse_everything/driver/dropbox.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require 'tmpdir'
 require 'dropbox_api'
 require_relative 'authentication_factory'
 
@@ -66,6 +67,7 @@ module BrowseEverything
       # @param config_values [Hash] configuration for the driver
       def initialize(config_values)
         self.class.authentication_klass ||= self.class.default_authentication_klass
+        @downloaded_files = {}
         super(config_values)
       end
 
@@ -79,36 +81,53 @@ module BrowseEverything
       end
 
       def contents(path = '')
+        path = '/' + path unless path == ''
         response = client.list_folder(path)
         @entries = response.entries.map { |entry| FileEntryFactory.build(metadata: entry, key: key) }
         @sorter.call(@entries)
       end
 
-      def download(path)
-        temp_file = Tempfile.open(File.basename(path), encoding: 'ascii-8bit')
+      def downloaded_file_for(path)
+        return @downloaded_files[path] if @downloaded_files.key?(path)
+
+        # This ensures that the name of the file its extension are preserved for user downloads
+        temp_file_path = File.join(Dir.mktmpdir, File.basename(path))
+        temp_file = File.open(temp_file_path, mode: 'w+', encoding: 'ascii-8bit')
         client.download(path) do |chunk|
           temp_file.write chunk
         end
         temp_file.close
-        temp_file
+        @downloaded_files[path] = temp_file
       end
 
       def uri_for(path)
-        temp_file = download(path)
-        uri = ::Addressable::URI.new(scheme: 'file', path: temp_file.path)
-        uri.to_s
+        temp_file = downloaded_file_for(path)
+        "file://#{temp_file.path}"
+      end
+
+      def file_size_for(path)
+        downloaded_file = downloaded_file_for(path)
+        size = File.size(downloaded_file.path)
+        size.to_i
+      rescue StandardError => error
+        Rails.logger.error "Failed to find the file size for #{path}: #{error}"
+        0
       end
 
       def link_for(path)
-        [uri_for(path), {}]
+        uri = uri_for(path)
+        file_name = File.basename(path)
+        file_size = file_size_for(path)
+
+        [uri, { file_name: file_name, file_size: file_size }]
       end
 
-      def auth_link
-        authenticator.authorize_url
+      def auth_link(url_options)
+        authenticator.authorize_url redirect_uri: redirect_uri(url_options)
       end
 
-      def connect(params, _data)
-        auth_bearer = authenticator.get_token(params[:code])
+      def connect(params, _data, url_options)
+        auth_bearer = authenticator.get_token params[:code], redirect_uri: redirect_uri(url_options)
         self.token = auth_bearer.token
       end
 
@@ -137,6 +156,10 @@ module BrowseEverything
         def client
           DropboxApi::Client.new(token)
         end
+
+        def redirect_uri(url_options)
+          connector_response_url(**url_options)
+        end
     end
   end
 end