browse-everything 1.0.0.rc2 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 617d8d7a23fcee87c1b3fe38d99d060c23acdb0edb5181dbb0354d0df905a03e
-  data.tar.gz: 5726f28db0a5e000a87eb3de5055805d3b401334cd7100395d99550999ebcb5f
+  metadata.gz: ef33c2e0a8c1c1206dce56eedad11b136195a6d094ce585ff4799323a442cb34
+  data.tar.gz: 76a840d66d3fc96fb6a1193515889980aba59a2469cbe76bdbabb4a7bc8bd204
 SHA512:
-  metadata.gz: a1cd94b143e8ca8bbd126b37358aa8dfaef97399e90b81c4a34b870f491e4c50fe093aeeec4ac6192ae480a05fd2307628658b64bb8c8b0bd936b83d2f168a81
-  data.tar.gz: 131163303e6ab27cee2c92931898e44cf4f1a3d3f55ba1cc36e2046bf1b5eeea3971d5b540a1ef273871ce028f3c35e92524f986825cdc86ec29ca1959477ecf
+  metadata.gz: fc3f2a4506d217583eb05c32e1b632578772c13eb21accf2f40eea87d104c06228f38d172e110c0f2e5524697ef7560aa54164ca92536e010c8746f9b7aeb397
+  data.tar.gz: 86ef8ad24edeec846bf81c1887f038befcdcb06c3cc6c0730ca2beb8834cb67ea9e86167067913feab7fa84a5c45a898de79280a66b9725391c6437f274965a8

data/.circleci/config.yml

@@ -0,0 +1,148 @@
+
+version: 2.1
+executors:
+  ruby:
+    docker:
+      - image: circleci/ruby:2.6
+    working_directory: ~/browse-everything
+    environment:
+      BUNDLE_PATH: vendor/bundle
+      BUNDLE_JOBS: 4
+      BUNDLE_RETRY: 3
+
+jobs:
+  bundle:
+    executor: ruby
+    steps:
+    - restore_cache: # Restore the cached source code base (for repeated jobs)
+        keys:
+        - v1-source-{{ .Branch }}-{{ .Revision }}
+        - v1-source-{{ .Branch }}-
+        - v1-source-
+    - checkout
+    - save_cache: # Save the cache for the source code base
+        key: v1-source-{{ .Branch }}-{{ .Revision }}
+        paths:
+        - ".git"
+    - restore_cache:
+        keys:
+        - v1-bundle-{{ checksum "Gemfile" }}--{{ checksum "browse-everything.gemspec" }}
+        - v1-bundle
+    - run:
+        name: Install dependencies
+        command: bundle check || bundle install
+    - save_cache:
+        key: v1-bundle-{{ checksum "Gemfile.lock" }}--{{ checksum "browse-everything.gemspec" }}
+        paths:
+        - ~/browse-everything/vendor/bundle
+    - persist_to_workspace:
+        root: ~/
+        paths:
+        - browse-everything/*
+        - browse-everything/**/*
+  rubocop:
+    executor: ruby
+    steps:
+    - attach_workspace:
+        at: ~/
+    - run:
+        name: Call Rubocop
+        command: bundle exec rubocop
+  engine_cart:
+    docker:
+    - image: circleci/ruby:2.6-node
+
+    working_directory: ~/browse-everything
+
+    environment:
+      BUNDLE_PATH: vendor/bundle
+      BUNDLE_JOBS: 4
+      BUNDLE_RETRY: 3
+      RAILS_ENV: test
+      RACK_ENV: test
+      NOKOGIRI_USE_SYSTEM_LIBRARIES: true
+      ENGINE_CART_RAILS_OPTIONS: --skip-git --skip-bundle --skip-listen --skip-spring --skip-yarn --skip-keeps --skip-action-cable --skip-coffee --skip-puma --skip-test
+      SPEC_OPTS: --profile 10 --format RspecJunitFormatter --out /tmp/test-results/rspec.xml --format progress
+      COVERALLS_PARALLEL: true
+    steps:
+    - attach_workspace:
+        at: ~/
+    - restore_cache:
+        keys:
+        - v1-test-app-{{ checksum "Gemfile.lock" }}
+    - run:
+        name: Check dependencies
+        command: bundle check || bundle install
+    - run:
+        name: Generate test app
+        command: bundle exec rake engine_cart:generate
+    - run:
+        name: Ensure test app dependencies are installed
+        command: |
+          cd .internal_test_app
+          bundle check || bundle install
+
+    - save_cache:
+        key: v1-test-app-{{ checksum "Gemfile.lock" }}
+        paths:
+        - ".internal_test_app"
+    - persist_to_workspace:
+        root: ~/
+        paths:
+        - browse-everything/*
+        - browse-everything/**/*
+  rspec:
+    docker:
+    - image: circleci/ruby:2.6-node-browsers-legacy
+
+    working_directory: ~/browse-everything
+    parallelism: 4
+
+    environment:
+      BUNDLE_PATH: vendor/bundle
+      BUNDLE_JOBS: 4
+      BUNDLE_RETRY: 3
+      RAILS_ENV: test
+      RACK_ENV: test
+      NOKOGIRI_USE_SYSTEM_LIBRARIES: true
+      ENGINE_CART_RAILS_OPTIONS: --skip-git --skip-bundle --skip-listen --skip-spring --skip-yarn --skip-keeps --skip-action-cable --skip-coffee --skip-puma --skip-test
+      SPEC_OPTS: --profile 10 --format RspecJunitFormatter --out /tmp/test-results/rspec.xml --format progress
+      COVERALLS_PARALLEL: true
+    steps:
+    - attach_workspace:
+        at: ~/
+    - run:
+        name: Ensure top-level Gemfile.lock is valid
+        command: bundle check || bundle install
+    - run:
+        name: Install Karma for JavaScript and functional tests
+        command: sudo npm install -g karma karma-jasmine karma-chrome-launcher
+    - run:
+        name: Run RSpec in parallel
+        command: |
+          mkdir /tmp/test-results
+          bundle exec rspec $(circleci tests glob "spec/**/*_spec.rb" | circleci tests split --split-by=timings)
+    # collect reports
+    - store_test_results:
+        path: /tmp/test-results
+    - store_artifacts:
+        path: /tmp/test-results
+        destination: test-results
+
+workflows:
+  version: 2.1
+  ci:
+    jobs:
+      - bundle
+      - rubocop:
+          requires:
+            - bundle
+      - engine_cart:
+          requires:
+            - bundle
+      - rspec:
+          requires:
+            - rubocop
+            - engine_cart
+
+

data/.travis.yml

@@ -9,25 +9,22 @@ cache:
 
 before_install:
   - gem update --system # https://docs.travis-ci.com/user/languages/ruby/#Upgrading-RubyGems
-  - gem install bundler
+  - gem uninstall -v '>= 2' -i $(rvm gemdir)@global -ax bundler || true
+  - gem install bundler -v '< 2'
   - npm install -g karma karma-jasmine karma-chrome-launcher
   - google-chrome-stable --headless --disable-gpu --remote-debugging-port=9222 http://localhost &
 
 rvm:
-  - 2.5.1
-  - 2.4.4
-  - 2.3.7
+  - 2.6.1
+  - 2.5.3
+  - 2.4.5
 
 env:
   global:
     - CHROME_BIN=google-chrome-stable
     - NOKOGIRI_USE_SYSTEM_LIBRARIES=true
   matrix:
-    - "RAILS_VERSION=5.2.0"
-    - "RAILS_VERSION=5.2.0 TEST_BOOTSTRAP=3"
-    - "RAILS_VERSION=5.1.6"
-    - "RAILS_VERSION=5.1.6 TEST_BOOTSTRAP=3"
-    - "RAILS_VERSION=5.0.7"
-    - "RAILS_VERSION=5.0.7 TEST_BOOTSTRAP=3"
-    - "RAILS_VERSION=4.2.10"
-    - "RAILS_VERSION=4.2.10 TEST_BOOTSTRAP=3"
+    - "RAILS_VERSION=5.2.2"
+    - "RAILS_VERSION=5.2.2 TEST_BOOTSTRAP=3"
+    - "RAILS_VERSION=5.1.6.1"
+    - "RAILS_VERSION=5.1.6.1 TEST_BOOTSTRAP=3"

data/README.md

@@ -39,17 +39,14 @@ what this means can be found
 
 ## Supported Ruby Releases
 Currently, the following releases of Ruby are supported:
-- 2.5.1
-- 2.4.4
-- 2.3.7
-  - Please note that this is the last release in the 2.3.x series, and support is [scheduled to be withdrawn](https://www.ruby-lang.org/en/news/2018/03/28/ruby-2-3-7-released/).  We would strongly recommend that one upgrades from 2.3.7 in response to this.
+- 2.6.1
+- 2.5.3
+- 2.4.5
 
 ## Supported Rails Releases
-- 5.2.0
-- 5.1.6
-- 5.0.7
-- 4.2.10
-  - The supported Rail releases follow those specified by [the security policy of the Rails Community](https://rubyonrails.org/security/).  As is the case with the supported Ruby releases, it is recommended that one upgrades from any Rails release no longer receiving security updates.
+The supported Rail releases follow those specified by [the security policy of the Rails Community](https://rubyonrails.org/security/).  As is the case with the supported Ruby releases, it is recommended that one upgrades from any Rails release no longer receiving security updates.
+- 5.2.2
+- 5.1.6.1
 
 ## Installation
 
@@ -80,9 +77,9 @@ Browse-everything depends on bootstrap, it can work with bootstrap 3 or bootstra
 
 ### CSS
 
-**For bootstrap3 support**, your app should include the [bootstrap-sass](https://github.com/twbs/bootstrap-sass) gem in it's Gemfile, and following the install directions for bootstrap-sass, should have `@import 'bootstrap-sprockets'` and `@import 'bootstrap'` in it's application.scss. After those lines, add `@import "browse_everything_bootstrap3";` to your application.scss.
+**For bootstrap3 support**, your app should include the [bootstrap-sass](https://github.com/twbs/bootstrap-sass) gem in it's Gemfile, and following the install directions for bootstrap-sass, should have `@import 'bootstrap-sprockets'` and `@import 'bootstrap'` in it's application.scss. After those lines, add `@import "browse_everything/browse_everything_bootstrap3";` to your application.scss.
 
-**For bootstrap4 support**, your app should include the [bootstrap](https://github.com/twbs/bootstrap-rubygem) gem in it's Gemfile, and following the install directions for that gem should have `@import "bootstrap";` in it's application.scss. After that line, add `@import 'browse_everything_bootstrap4'` to your application.scss.
+**For bootstrap4 support**, your app should include the [bootstrap](https://github.com/twbs/bootstrap-rubygem) gem in it's Gemfile, and following the install directions for that gem should have `@import "bootstrap";` in it's application.scss. After that line, add `@import 'browse_everything/browse_everything_bootstrap4'` to your application.scss.
 
 ### Javascript
 
@@ -95,14 +92,18 @@ In `app/assets/javascripts/application.js` include jquery and the BrowseEverythi
 
 (Same for bootstrap3 or bootstrap 4)
 
-### Migration CSS inclusion from pre-1.0 (TODO: Is that the version this will be released with?)
+### Migration CSS inclusion from pre-1.0
 
-If your app has installed a previous version of browse-everything, you may have a generated file at `./app/assets/stylesheets/browse_everything.scss`, which has a line in it `@import "browse_everything/browse_everything";`.  That import should no longer be used; it can be changed to `@import "browse_everything_bootstrap3"` instead.
+If your app has installed a previous version of browse-everything, you may have a generated file at `./app/assets/stylesheets/browse_everything.scss`, which has a line in it `@import "browse_everything/browse_everything";`.  That import should no longer be used; it can be changed to `@import "browse_everything/browse_everything_bootstrap3"` instead.
 
 However, we also recommend merging the contents of this file into your main `application.scss` file, as documented in the current install instructions. With the separate generated file with bootstrap imports, you may likely be including bootstrap CSS in your generated CSS bundle twice, if you also have that import in your main application.scss already.
 
 ## Testing
-This is a Rails Engine which is tested using the [engine_cart](https://github.com/cbeer/engine_cart) Gem.  Test suites may be executed with the following invocation:
+This is a Rails Engine which is tested using the [engine_cart](https://github.com/cbeer/engine_cart) Gem and rspec.
+
+One rspec test invokes [karma](https://karma-runner.github.io/latest/index.html) to run Javascript tests. For this test to succeed, you need to install karma on your system, first by making sure `npm` is installed, and then run `npm install -g karma karma-jasmine karma-chrome-launcher`.
+
+Test suites may be executed with the following invocation:
 
 ```bash
 bundle exec rake

data/app/assets/javascripts/browse_everything/behavior.js

@@ -1,26 +1,20 @@
-/*
- * decaffeinate suggestions:
- * DS102: Remove unnecessary code created because of implicit returns
- * DS207: Consider shorter variations of null checks
- * Full docs: https://github.com/decaffeinate/decaffeinate/blob/master/docs/suggestions.md
- */
-$(function() {
-  let dialog = $('div#browse-everything');
-
-  const initialize = function(obj,options) {
+'use strict';
+
+$(function () {
+  var dialog = $('div#browse-everything');
+
+  var initialize = function initialize(obj, options) {
     if ($('div#browse-everything').length === 0) {
       // bootstrap 4 needs at least the inner class="modal-dialog" div, or it gets really
       // confused and can't close the dialog.
-      dialog = $('<div tabindex="-1" id="browse-everything" class="ev-browser modal fade" aria-live="polite" role="dialog" aria-labelledby="beModalLabel">' +
-                   '<div class="modal-dialog modal-lg" role="document"></div>' +
-                 '</div>').hide().appendTo('body');
+      dialog = $('<div tabindex="-1" id="browse-everything" class="ev-browser modal fade" aria-live="polite" role="dialog" aria-labelledby="beModalLabel">' + '<div class="modal-dialog modal-lg" role="document"></div>' + '</div>').hide().appendTo('body');
     }
 
     dialog.modal({
       backdrop: 'static',
-      show:     false
+      show: false
     });
-    const ctx = {
+    var ctx = {
       opts: $.extend(true, {}, options),
       callbacks: {
         show: $.Callbacks(),
@@ -30,36 +24,42 @@ $(function() {
       }
     };
     ctx.callback_proxy = {
-      show(func) { ctx.callbacks.show.add(func);    return this; },
-      done(func) { ctx.callbacks.done.add(func);    return this; },
-      cancel(func) { ctx.callbacks.cancel.add(func);  return this; },
-      fail(func) { ctx.callbacks.fail.add(func);    return this; }
+      show: function show(func) {
+        ctx.callbacks.show.add(func);return this;
+      },
+      done: function done(func) {
+        ctx.callbacks.done.add(func);return this;
+      },
+      cancel: function cancel(func) {
+        ctx.callbacks.cancel.add(func);return this;
+      },
+      fail: function fail(func) {
+        ctx.callbacks.fail.add(func);return this;
+      }
     };
-    $(obj).data('ev-state',ctx);
+    $(obj).data('ev-state', ctx);
     return ctx;
   };
 
-  const toHiddenFields = function(data) {
-    const fields = $.param(data)
-      .split('&')
-      .map(t => t.replace(/\+/g,' ').split('=',2));
-    const elements = $(fields).map(function() {
-      return $("<input type='hidden'/>")
-        .attr('name',decodeURIComponent(this[0]))
-        .val(decodeURIComponent(this[1]))[0].outerHTML;
+  var toHiddenFields = function toHiddenFields(data) {
+    var fields = $.param(data).split('&').map(function (t) {
+      return t.replace(/\+/g, ' ').split('=', 2);
+    });
+    var elements = $(fields).map(function () {
+      return $("<input type='hidden'/>").attr('name', decodeURIComponent(this[0])).val(decodeURIComponent(this[1]))[0].outerHTML;
     });
     return $(elements.toArray().join("\n"));
   };
 
-  const indicateSelected = () =>
-    $('input.ev-url').each(function() {
-      return $(`*[data-ev-location='${$(this).val()}']`).addClass('ev-selected');
-    })
-  ;
+  var indicateSelected = function indicateSelected() {
+    return $('input.ev-url').each(function () {
+      return $('*[data-ev-location=\'' + $(this).val() + '\']').addClass('ev-selected');
+    });
+  };
 
-  const fileIsSelected = function(row) {
-    let result = false;
-    $('input.ev-url').each(function() {
+  var fileIsSelected = function fileIsSelected(row) {
+    var result = false;
+    $('input.ev-url').each(function () {
       if (this.value === $(row).data('ev-location')) {
         return result = true;
       }
@@ -67,7 +67,7 @@ $(function() {
     return result;
   };
 
-  const toggleFileSelect = function(row) {
+  var toggleFileSelect = function toggleFileSelect(row) {
     row.toggleClass('ev-selected');
     if (row.hasClass('ev-selected')) {
       selectFile(row);
@@ -77,70 +77,74 @@ $(function() {
     return updateFileCount();
   };
 
-  var selectFile = function(row) {
-    const target_form = $('form.ev-submit-form');
-    const file_location = row.data('ev-location');
-    const hidden_input = $("<input type='hidden' class='ev-url' name='selected_files[]'/>").val(file_location);
+  var selectFile = function selectFile(row) {
+    var target_form = $('form.ev-submit-form');
+    var file_location = row.data('ev-location');
+    var hidden_input = $("<input type='hidden' class='ev-url' name='selected_files[]'/>").val(file_location);
     target_form.append(hidden_input);
     if (!$(row).find('.ev-select-file').prop('checked')) {
       return $(row).find('.ev-select-file').prop('checked', true);
     }
   };
 
-  var unselectFile = function(row) {
-    const target_form = $('form.ev-submit-form');
-    const file_location = row.data('ev-location');
-    $(`form.ev-submit-form input[value='${file_location}']`).remove();
+  var unselectFile = function unselectFile(row) {
+    var target_form = $('form.ev-submit-form');
+    var file_location = row.data('ev-location');
+    $('form.ev-submit-form input[value=\'' + file_location + '\']').remove();
     if ($(row).find('.ev-select-file').prop('checked')) {
-        return $(row).find('.ev-select-file').prop('checked', false);
-      }
+      return $(row).find('.ev-select-file').prop('checked', false);
+    }
   };
 
-  var updateFileCount = function() {
-    const count = $('input.ev-url').length;
-    const files = count === 1 ? "file" : "files";
-    return $('.ev-status').html(`${count} ${files} selected`);
+  var updateFileCount = function updateFileCount() {
+    var count = $('input.ev-url').length;
+    var files = count === 1 ? "file" : "files";
+    return $('.ev-status').html(count + ' ' + files + ' selected');
   };
 
-  const toggleBranchSelect = function(row) {
+  var toggleBranchSelect = function toggleBranchSelect(row) {
     if (row.hasClass('collapsed')) {
-      const node_id = row.find('td.ev-file-name a.ev-link').attr('href');
-      return $('table#file-list').treetable('expandNode',node_id);
+      var node_id = row.find('td.ev-file-name a.ev-link').attr('href');
+      return $('table#file-list').treetable('expandNode', node_id);
     }
   };
 
-  const selectAll = rows =>
-    rows.each(function() {
+  var selectAll = function selectAll(rows) {
+    return rows.each(function () {
       if ($(this).data('tt-branch')) {
-        const box = $(this).find('#select_all')[0];
+        var box = $(this).find('#select_all')[0];
         $(box).prop('checked', true);
         $(box).prop('value', "1");
         return toggleBranchSelect($(this));
       } else {
-        if (!fileIsSelected($(this))) { return toggleFileSelect($(this)); }
+        if (!fileIsSelected($(this))) {
+          return toggleFileSelect($(this));
+        }
       }
-    })
-  ;
+    });
+  };
 
-  const selectChildRows = (row, action) =>
-    $('table#file-list tr').each(function() {
+  var selectChildRows = function selectChildRows(row, action) {
+    return $('table#file-list tr').each(function () {
       if ($(this).data('tt-parent-id')) {
-        const re = RegExp($(row).data('tt-id'), 'i');
+        var re = RegExp($(row).data('tt-id'), 'i');
         if ($(this).data('tt-parent-id').match(re)) {
           if ($(this).data('tt-branch')) {
-            const box = $(this).find('#select_all')[0];
+            var box = $(this).find('#select_all')[0];
             $(box).prop('value', action);
             if (action === "1") {
               $(box).prop("checked", true);
-              const node_id = $(this).find('td.ev-file-name a.ev-link').attr('href');
-              return $('table#file-list').treetable('expandNode',node_id);
+              var node_id = $(this).find('td.ev-file-name a.ev-link').attr('href');
+              return $('table#file-list').treetable('expandNode', node_id);
             } else {
               return $(box).prop("checked", false);
             }
           } else {
             if (action === "1") {
               $(this).addClass('ev-selected');
-              if (!fileIsSelected($(this))) { selectFile($(this)); }
+              if (!fileIsSelected($(this))) {
+                selectFile($(this));
+              }
             } else {
               $(this).removeClass('ev-selected');
               unselectFile($(this));
@@ -149,49 +153,53 @@ $(function() {
           }
         }
       }
-    })
-  ;
+    });
+  };
 
-  const tableSetup = function(table) {
+  var tableSetup = function tableSetup(table) {
     table.treetable({
       expandable: true,
-      onNodeCollapse() {
-        const node = this;
+      onNodeCollapse: function onNodeCollapse() {
+        var node = this;
         return table.treetable("unloadBranch", node);
       },
-      onNodeExpand() {
-        const node = this;
+      onNodeExpand: function onNodeExpand() {
+        var node = this;
         startWait();
-        const size = $(node.row).find('td.ev-file-size').text().trim();
-        let start = 1;
-        let increment = 1;
-        if (size.indexOf("MB") >-1) {
+        var size = $(node.row).find('td.ev-file-size').text().trim();
+        var start = 1;
+        var increment = 1;
+        if (size.indexOf("MB") > -1) {
           start = 10;
           increment = 5;
         }
-        if (size.indexOf("KB") >-1) {
+        if (size.indexOf("KB") > -1) {
           start = 50;
           increment = 10;
         }
         setProgress(start);
-        const progressIntervalID = setInterval((function() {
+        var progressIntervalID = setInterval(function () {
           start = start + increment;
           if (start > 99) {
             start = 99;
           }
           return setProgress(start);
-        }), 2000);
-        return setTimeout((() => loadFiles(node, table, progressIntervalID)), 10);
+        }, 2000);
+        return setTimeout(function () {
+          return loadFiles(node, table, progressIntervalID);
+        }, 10);
       }
     });
     $("#file-list tr:first").focus();
     return sizeColumns(table);
   };
 
-  var sizeColumns = function(table) {
-    const full_width = $('.ev-files').width();
+  var sizeColumns = function sizeColumns(table) {
+    var full_width = $('.ev-files').width();
     table.width(full_width);
-    const set_size = (selector, pct) => $(selector, table).width(full_width * pct).css('width',full_width * pct).css('max-width',full_width * pct);
+    var set_size = function set_size(selector, pct) {
+      return $(selector, table).width(full_width * pct).css('width', full_width * pct).css('max-width', full_width * pct);
+    };
     set_size('.ev-file', 0.4);
     set_size('.ev-container', 0.4);
     set_size('.ev-size', 0.1);
@@ -199,60 +207,69 @@ $(function() {
     return set_size('.ev-date', 0.2);
   };
 
-  var loadFiles = (node, table, progressIntervalID)=>
-    $.ajax({
+  var loadFiles = function loadFiles(node, table, progressIntervalID) {
+    return $.ajax({
       async: true, // Must be false, otherwise loadBranch happens after showChildren?
-      url: $('a.ev-link',node.row).attr('href'),
+      url: $('a.ev-link', node.row).attr('href'),
       data: {
         parent: node.row.data('tt-id'),
         accept: dialog.data('ev-state').opts.accept,
         context: dialog.data('ev-state').opts.context
-      }}).done(function(html) {
+      } }).done(function (html) {
       setProgress('100');
       clearInterval(progressIntervalID);
-      const rows = $('tbody tr',$(html));
+      var rows = $('tbody tr', $(html));
       table.treetable("loadBranch", node, rows);
       $(node).show();
       sizeColumns(table);
       indicateSelected();
       if ($(node.row).find('#select_all')[0].checked) {
         return selectAll(rows);
-      }}).always(function() {
-        clearInterval(progressIntervalID);
-        return stopWait();
-    })
-  ;
+      }
+    }).always(function () {
+      clearInterval(progressIntervalID);
+      return stopWait();
+    });
+  };
 
-  var setProgress = done=> $('.loading-text').text(done+'% complete');
+  var setProgress = function setProgress(done) {
+    return $('.loading-text').text(done + '% complete');
+  };
 
-  const refreshFiles = () => $('.ev-providers select').change();
+  var refreshFiles = function refreshFiles() {
+    return $('.ev-providers select').change();
+  };
 
-  var startWait = function() {
+  var startWait = function startWait() {
     $('.loading-progress').removeClass("hidden");
-    $('body').css('cursor','wait');
+    $('body').css('cursor', 'wait');
     $("html").addClass("wait");
     $(".ev-browser").addClass("loading");
     return $('.ev-submit').attr('disabled', true);
   };
 
-  var stopWait = function() {
+  var stopWait = function stopWait() {
     $('.loading-progress').addClass("hidden");
-    $('body').css('cursor','default');
+    $('body').css('cursor', 'default');
     $("html").removeClass("wait");
     $(".ev-browser").removeClass("loading");
     return $('.ev-submit').attr('disabled', false);
   };
 
-  $(window).on('resize', () => sizeColumns($('table#file-list')));
+  $(window).on('resize', function () {
+    return sizeColumns($('table#file-list'));
+  });
 
-  $.fn.browseEverything = function(options) {
-    let ctx = $(this).data('ev-state');
-    if ((ctx == null) && (options == null)) { options = $(this).data(); }
+  $.fn.browseEverything = function (options) {
+    var ctx = $(this).data('ev-state');
+    if (ctx == null && options == null) {
+      options = $(this).data();
+    }
     if (options != null) {
       ctx = initialize(this[0], options);
-      $(this).click(function() {
-        dialog.data('ev-state',ctx);
-        return dialog.load(ctx.opts.route, function() {
+      $(this).click(function () {
+        dialog.data('ev-state', ctx);
+        return dialog.load(ctx.opts.route, function () {
           setTimeout(refreshFiles, 500);
           ctx.callbacks.show.fire();
           return dialog.modal('show');
@@ -264,15 +281,23 @@ $(function() {
       return ctx.callback_proxy;
     } else {
       return {
-        show() { return this; },
-        done() { return this; },
-        cancel() { return this; },
-        fail() { return this; }
+        show: function show() {
+          return this;
+        },
+        done: function done() {
+          return this;
+        },
+        cancel: function cancel() {
+          return this;
+        },
+        fail: function fail() {
+          return this;
+        }
       };
     }
   };
 
-  $.fn.browseEverything.toggleCheckbox = function(box) {
+  $.fn.browseEverything.toggleCheckbox = function (box) {
     if (box.value === "0") {
       return $(box).prop('value', "1");
     } else {
@@ -280,48 +305,53 @@ $(function() {
     }
   };
 
-  $(document).on('ev.refresh', event => refreshFiles());
+  $(document).on('ev.refresh', function (event) {
+    return refreshFiles();
+  });
 
-  $(document).on('click', 'button.ev-cancel', function(event) {
+  $(document).on('click', 'button.ev-cancel', function (event) {
     event.preventDefault();
     dialog.data('ev-state').callbacks.cancel.fire();
     return $('.ev-browser').modal('hide');
   });
 
-  $(document).on('click', 'button.ev-submit', function(event) {
+  $(document).on('click', 'button.ev-submit', function (event) {
     event.preventDefault();
     $(this).button('loading');
     startWait();
-    const main_form = $(this).closest('form');
-    const resolver_url = main_form.data('resolver');
-    const ctx = dialog.data('ev-state');
+    var main_form = $(this).closest('form');
+    var resolver_url = main_form.data('resolver');
+    var ctx = dialog.data('ev-state');
     $(main_form).find('input[name=context]').val(ctx.opts.context);
     return $.ajax(resolver_url, {
       type: 'POST',
       dataType: 'json',
       data: main_form.serialize()
-    }).done(function(data) {
+    }).done(function (data) {
       if (ctx.opts.target != null) {
-        const fields = toHiddenFields({selected_files: data});
+        var fields = toHiddenFields({ selected_files: data });
         $(ctx.opts.target).append($(fields));
       }
-      return ctx.callbacks.done.fire(data);}).fail((xhr,status,error) => ctx.callbacks.fail.fire(status, error, xhr.responseText)).always(function() {
-      $('body').css('cursor','default');
+      return ctx.callbacks.done.fire(data);
+    }).fail(function (xhr, status, error) {
+      return ctx.callbacks.fail.fire(status, error, xhr.responseText);
+    }).always(function () {
+      $('body').css('cursor', 'default');
       $('.ev-browser').modal('hide');
       return $('#browse-btn').focus();
     });
   });
 
-  $(document).on('click', '.ev-files .ev-container a.ev-link', function(event) {
+  $(document).on('click', '.ev-files .ev-container a.ev-link', function (event) {
     event.stopPropagation();
     event.preventDefault();
-    const row = $(this).closest('tr');
-    const action = row.hasClass('expanded') ? 'collapseNode' : 'expandNode';
-    const node_id = $(this).attr('href');
-    return $('table#file-list').treetable(action,node_id);
+    var row = $(this).closest('tr');
+    var action = row.hasClass('expanded') ? 'collapseNode' : 'expandNode';
+    var node_id = $(this).attr('href');
+    return $('table#file-list').treetable(action, node_id);
   });
 
-  $(document).on('change', '.ev-providers select', function(event) {
+  $(document).on('change', '.ev-providers select', function (event) {
     event.preventDefault();
     startWait();
     return $.ajax({
@@ -329,33 +359,37 @@ $(function() {
       data: {
         accept: dialog.data('ev-state').opts.accept,
         context: dialog.data('ev-state').opts.context
-      }}).done(function(data) {
+      } }).done(function (data) {
       $('.ev-files').html(data);
       indicateSelected();
       $('#provider_auth').focus();
-      return tableSetup($('table#file-list'));}).fail(function(xhr,status,error) {
-      if (xhr.responseText.indexOf("Refresh token has expired")>-1) {
+      return tableSetup($('table#file-list'));
+    }).fail(function (xhr, status, error) {
+      if (xhr.responseText.indexOf("Refresh token has expired") > -1) {
         return $('.ev-files').html("Your sessison has expired please clear your cookies.");
       } else {
         return $('.ev-files').html(xhr.responseText);
-      }}).always(() => stopWait());
+      }
+    }).always(function () {
+      return stopWait();
+    });
   });
 
-  $(document).on('click', '.ev-providers a', function(event) {
+  $(document).on('click', '.ev-providers a', function (event) {
     $('.ev-providers li').removeClass('ev-selected');
     return $(this).closest('li').addClass('ev-selected');
   });
 
-  $(document).on('click', '.ev-file a', function(event) {
+  $(document).on('click', '.ev-file a', function (event) {
     event.preventDefault();
-    const target = $(this).closest('*[data-ev-location]');
+    var target = $(this).closest('*[data-ev-location]');
     return toggleFileSelect(target);
   });
 
-  $(document).on('click', '.ev-auth', function(event) {
+  $(document).on('click', '.ev-auth', function (event) {
     event.preventDefault();
-    const auth_win = window.open($(this).attr('href'));
-    var check_func = function() {
+    var auth_win = window.open($(this).attr('href'));
+    var check_func = function check_func() {
       if (auth_win.closed) {
         return $('.ev-providers .ev-selected a').click();
       } else {
@@ -365,43 +399,44 @@ $(function() {
     return check_func();
   });
 
-  $(document).on('change', 'input.ev-select-all', function(event) {
+  $(document).on('change', 'input.ev-select-all', function (event) {
     event.stopPropagation();
     event.preventDefault();
     $.fn.browseEverything.toggleCheckbox(this);
-    const action = this.value;
-    const row = $(this).closest('tr');
-    const node_id = row.find('td.ev-file-name a.ev-link').attr('href');
+    var action = this.value;
+    var row = $(this).closest('tr');
+    var node_id = row.find('td.ev-file-name a.ev-link').attr('href');
     if (row.hasClass('collapsed')) {
-      return $('table#file-list').treetable('expandNode',node_id);
+      return $('table#file-list').treetable('expandNode', node_id);
     } else {
       return selectChildRows(row, action);
     }
   });
 
-  return $(document).on('change', 'input.ev-select-file', function(event) {
+  return $(document).on('change', 'input.ev-select-file', function (event) {
     event.stopPropagation();
     event.preventDefault();
     return toggleFileSelect($(this).closest('tr'));
   });
 });
 
-
-const auto_toggle = function() {
-  const triggers = $('*[data-toggle=browse-everything]');
+var auto_toggle = function auto_toggle() {
+  var triggers = $('*[data-toggle=browse-everything]');
   if (typeof Rails !== 'undefined' && Rails !== null) {
     $.ajaxSetup({
-        headers: { 'X-CSRF-TOKEN': (Rails || $.rails).csrfToken() || '' }
+      headers: { 'X-CSRF-TOKEN': (Rails || $.rails).csrfToken() || '' }
     });
   }
 
-  return triggers.each(function() {
-    const ctx = $(this).data('ev-state');
-    if (ctx == null) { return $(this).browseEverything($(this).data()); }
+  return triggers.each(function () {
+    var ctx = $(this).data('ev-state');
+    if (ctx == null) {
+      return $(this).browseEverything($(this).data());
+    }
   });
 };
 
-if ((typeof Turbolinks !== 'undefined' && Turbolinks !== null) && Turbolinks.supported) {
+if (typeof Turbolinks !== 'undefined' && Turbolinks !== null && Turbolinks.supported) {
   // Use turbolinks:load for Turbolinks 5, otherwise use the old way
   if (Turbolinks.BrowserAdapter) {
     $(document).on('turbolinks:load', auto_toggle);

data/app/assets/stylesheets/{_browse_everything_bootstrap3.scss → browse_everything/_browse_everything_bootstrap3.scss}

@@ -59,9 +59,6 @@
       border-top: none;
     }
 
-    &.detail {
-    }
-
     &.list ul {
       @include content-columns(3);
     }
@@ -97,11 +94,15 @@
 
   .ev-files {
     height: 50vh;
-    li { @include ev-link; }
+    li {
+      @include ev-link;
+    }
   }
 
   .ev-providers {
-    select { width: 30% }
+    select {
+      width: 30%
+    }
   }
 
   .loading {

data/browse-everything.gemspec

@@ -34,7 +34,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'bixby', '>= 1.0'
   spec.add_development_dependency 'bundler', '~> 1.3'
   spec.add_development_dependency 'capybara'
-  spec.add_development_dependency 'chromedriver-helper', '1.2.0'
+  spec.add_development_dependency 'chromedriver-helper', '~> 2.1'
   spec.add_development_dependency 'coveralls'
   spec.add_development_dependency 'engine_cart', '~> 2.0'
   spec.add_development_dependency 'factory_bot_rails'
@@ -45,6 +45,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'rspec-its'
   spec.add_development_dependency 'rspec-rails'
+  spec.add_development_dependency 'rspec_junit_formatter'
   spec.add_development_dependency 'rubocop-rspec'
   spec.add_development_dependency 'selenium-webdriver'
   spec.add_development_dependency 'simplecov'

data/lib/browse_everything/driver/dropbox.rb

@@ -91,7 +91,7 @@ module BrowseEverything
         return @downloaded_files[path] if @downloaded_files.key?(path)
 
         # This ensures that the name of the file its extension are preserved for user downloads
-        temp_file_path = File.join(Dir.mktmpdir, File.basename(path))
+        temp_file_path = File.join(download_directory_path, File.basename(path))
         temp_file = File.open(temp_file_path, mode: 'w+', encoding: 'ascii-8bit')
         client.download(path) do |chunk|
           temp_file.write chunk
@@ -160,6 +160,21 @@ module BrowseEverything
         def redirect_uri(url_options)
           connector_response_url(**url_options)
         end
+
+        # Ensures that the "tmp" directory is used if there is no default download
+        # directory specified in the configuration
+        # @return [String]
+        def default_download_directory
+          Rails.root.join('tmp')
+        end
+
+        # Retrieves the directory path for downloads used when retrieving the
+        # resource from Dropbox
+        # @return [String]
+        def download_directory_path
+          dir_path = config[:download_directory] || default_download_directory
+          File.expand_path(dir_path)
+        end
     end
   end
 end

data/lib/browse_everything/retriever.rb

@@ -31,8 +31,13 @@ module BrowseEverything
     attr_accessor :chunk_size
 
     class << self
-      def can_retrieve?(uri)
-        Typhoeus.get(uri, headers: { Range: 'bytes=0-0' }).success?
+      # Determines whether or not a remote resource can be retrieved
+      # @param uri [String] URI for the remote resource (usually a URL)
+      # @param headers [Hash] any custom headers required to transit the request
+      def can_retrieve?(uri, headers = {})
+        request_headers = headers.merge(Range: 'bytes=0-0')
+        response = Typhoeus.get(uri, headers: request_headers)
+        response.success?
       end
     end
 

data/lib/browse_everything/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module BrowseEverything
-  VERSION = '1.0.0.rc2'
+  VERSION = '1.0.0'
 end

data/lib/generators/browse_everything/templates/browse_everything_providers.yml.example

@@ -5,6 +5,7 @@
 # dropbox:
 #   client_id: YOUR_DROPBOX_APP_KEY
 #   client_secret: YOUR_DROPBOX_APP_SECRET
+#   download_directory: tmp/
 # box:
 #   client_id: YOUR_BOX_CLIENT_ID
 #   client_secret: YOUR_BOX_CLIENT_SECRET

data/spec/lib/browse_everything/browser_spec.rb

@@ -4,7 +4,7 @@ include BrowserConfigHelper
 
 describe BrowseEverything::Browser do
   let(:file_config) do
-    "file_system:\n  home: '/file/config/home'\ndropbox:\n  client_id: 'DropboxId'\n  client_secret: 'DropboxClientSecret'"
+    "file_system:\n  home: '/file/config/home'\ndropbox:\n  client_id: 'DropboxId'\n  client_secret: 'DropboxClientSecret'\n  download_directory: 'tmp/'"
   end
 
   let(:global_config) do
@@ -14,7 +14,8 @@ describe BrowseEverything::Browser do
       },
       dropbox: {
         client_id: 'DropboxId',
-        client_secret: 'DropboxClientSecret'
+        client_secret: 'DropboxClientSecret',
+        download_directory: 'tmp/'
       }
     }
   end
@@ -26,7 +27,8 @@ describe BrowseEverything::Browser do
       },
       dropbox: {
         client_id: 'DropboxId',
-        client_secret: 'DropboxClientSecret'
+        client_secret: 'DropboxClientSecret',
+        download_directory: 'tmp/'
       },
       url_options: url_options
     }

data/spec/lib/browse_everything/driver/dropbox_spec.rb

@@ -8,7 +8,8 @@ describe BrowseEverything::Driver::Dropbox do
   let(:provider_yml) do
     {
       client_id: 'client-id',
-      client_secret: 'client-secret'
+      client_secret: 'client-secret',
+      download_directory: 'spec/fixtures/'
     }
   end
   let(:oauth_response_body) do
@@ -63,6 +64,10 @@ describe BrowseEverything::Driver::Dropbox do
 
     before { driver.connect({ code: 'code' }, {}, connector_response_url_options) }
 
+    it 'accesses the download directory' do
+      expect(driver.config).to include('download_directory' => 'spec/fixtures/')
+    end
+
     describe '#auth_link' do
       subject { driver.auth_link(connector_response_url_options) }
 
@@ -133,6 +138,20 @@ describe BrowseEverything::Driver::Dropbox do
           expect(downloaded_file.read).not_to be_empty
         end
       end
+
+      context 'when the configuration does not specify a download directory' do
+        let(:provider_yml) do
+          {
+            client_id: 'client-id',
+            client_secret: 'client-secret'
+          }
+        end
+        let(:downloaded_file_path) { link_args.first }
+
+        it 'uses the "tmp" directory as the default path' do
+          expect(downloaded_file_path).to include '/tmp/Getting Started.pdf'
+        end
+      end
     end
   end
 end

data/spec/spec_helper.rb

@@ -36,6 +36,7 @@ require 'capybara/rspec'
 require 'rspec'
 require 'rspec/rails'
 require 'rspec/its'
+require 'chromedriver-helper'
 
 # Requires supporting ruby files with custom matchers and macros, etc,
 # in spec/support/ and its subdirectories.

data/spec/test_app_templates/lib/generators/test_app_generator.rb

@@ -19,10 +19,10 @@ class TestAppGenerator < Rails::Generators::Base
     insert_into_file 'app/assets/stylesheets/application.css.scss', after: '*/' do
       if ENV['TEST_BOOTSTRAP'] == "3"
         # bootstrap 3 from bootstrap-sass gem
-        %(\n\n@import "bootstrap-sprockets";\n@import "bootstrap";\n@import "browse_everything_bootstrap3";)
+        %(\n\n@import "bootstrap-sprockets";\n@import "bootstrap";\n@import "browse_everything/browse_everything_bootstrap3";)
       else
         # bootstrap4 from bootstrap gem
-        %(\n\n@import "bootstrap";\n@import "browse_everything_bootstrap4";)
+        %(\n\n@import "bootstrap";\n@import "browse_everything/browse_everything_bootstrap4";)
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: browse-everything
 version: !ruby/object:Gem::Version
-  version: 1.0.0.rc2
+  version: 1.0.0
 platform: ruby
 authors:
 - Carolyn Cole
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-28 00:00:00.000000000 Z
+date: 2019-03-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -215,16 +215,16 @@ dependencies:
   name: chromedriver-helper
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.2.0
+        version: '2.1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.2.0
+        version: '2.1'
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
@@ -365,6 +365,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec_junit_formatter
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -447,6 +461,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".circleci/config.yml"
 - ".engine_cart.yml"
 - ".gitignore"
 - ".rspec"
@@ -463,9 +478,10 @@ files:
 - SUPPORT.md
 - app/assets/javascripts/browse_everything.js
 - app/assets/javascripts/browse_everything/behavior.js
-- app/assets/stylesheets/_browse_everything_bootstrap3.scss
-- app/assets/stylesheets/_browse_everything_bootstrap4.scss
+- app/assets/stylesheets/browse_everything.scss
 - app/assets/stylesheets/browse_everything/_browse_everything.scss
+- app/assets/stylesheets/browse_everything/_browse_everything_bootstrap3.scss
+- app/assets/stylesheets/browse_everything/_browse_everything_bootstrap4.scss
 - app/assets/stylesheets/jquery.treetable.theme.browse.css
 - app/controllers/browse_everything_controller.rb
 - app/helpers/browse_everything_helper.rb
@@ -560,12 +576,11 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.3
+rubygems_version: 3.0.1
 signing_key: 
 specification_version: 4
 summary: AJAX/Rails engine file browser for cloud storage services