browse-everything 0.8.1 → 0.8.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 752262cadeaa0b3b5a2ad672940be2614d39cf31
-  data.tar.gz: de06161f252bed360dc7eb3cb6e36b6abfe2f350
+  metadata.gz: 894c8d28a00f0474da1f807768bb9cccc8add97e
+  data.tar.gz: dcaed8f54b8a79085536dd6a4b0c8743a9e370e6
 SHA512:
-  metadata.gz: e35f26412fe189b2c70ae575cab4e872078165fe7712bfb6fc0019822271667d6ff06cac215866411dd6e7ddff066bd06d95943bd9030c6082b53cdb0995f156
-  data.tar.gz: 3553e3fc787477acaf50f5f76f310768ec8681990f9582e5eb969e40f9728902aa502b432974f4e914d9d016cb347ba41f8ddf7c544d1e076b0b87a6f47e9897
+  metadata.gz: dad070cc647aece52eff80592a4ccaa702d195c87c37641f8b352c6b705db6c91c3b80b4c8132f3d461e22f4336b247e7d3a2594262cc9618bf5d8450bf38024
+  data.tar.gz: 1b8d2de4bc7415b2c504f5df2a979499d7f5142492d67b5e2b2e932395b35298cbd7adc3dcf42185211cad130f38502435424001e3074f3bda5c33c2f049f3c2

data/.travis.yml

@@ -2,20 +2,22 @@ language: ruby
 cache: bundler
 sudo: false
 rvm:
-  - 2.1
+  - 2.2
 env:
   global:
     - NOKOGIRI_USE_SYSTEM_LIBRARIES=true
   matrix:
-    - "RAILS_VERSION=4.1.8"
-    - "RAILS_VERSION=4.2.0"
+    - "RAILS_VERSION=4.1.10"
+    - "RAILS_VERSION=4.2.1"
 
 matrix:
   include:
-    - rvm: 1.9.3
-      env: "RAILS_VERSION=4.1.8"
+    - rvm: 2.1
+      env: "RAILS_VERSION=4.2.1"
     - rvm: 2.0
-      env: "RAILS_VERSION=4.1.8"
+      env: "RAILS_VERSION=4.2.1"
+    - rvm: 1.9.3
+      env: "RAILS_VERSION=4.2.1"
 
 notifications:
   irc: "irc.freenode.org#projecthydra"

data/HISTORY.md

@@ -1,3 +1,8 @@
+### 0.8.2 (2015-04-15)
+- Add support for latest 4.1 and 4.2 Rails versions
+- Add support for %20 encoded URLs 
+- Use Dropbox name consistently
+
 ### 0.8.1 (2015-03-03)
 - Use numeric size from Dropbox instead of string value
 

data/README.md

@@ -3,13 +3,13 @@
 
 # BrowseEverything
 
-This Gem allows your rails application to access user files from cloud storage.  
-Currently there are drivers implemented for [DropBox](http://www.dropbox.com), 
-[Skydrive](https://skydrive.live.com/), [Google Drive](http://drive.google.com), 
+This Gem allows your rails application to access user files from cloud storage.
+Currently there are drivers implemented for [Dropbox](http://www.dropbox.com),
+[Skydrive](https://skydrive.live.com/), [Google Drive](http://drive.google.com),
 [Box](http://www.box.com), and a server-side directory share.
 
-The gem uses [OAuth](http://oauth.net/) to connect to a user's account and 
-generate a list of single use urls that your application can then use to 
+The gem uses [OAuth](http://oauth.net/) to connect to a user's account and
+generate a list of single use urls that your application can then use to
 download the files.
 
 **This gem does not depend on hydra-head**
@@ -27,18 +27,18 @@ And then execute:
 Or install it yourself as:
 
     $ gem install browse-everything
-   
+
 ### Configuring the gem
- 
+
 After installing the gem, run the generator
 
     $ rails g browse_everything:config
-    
+
 This generator will set up the _config/browse_everything_providers.yml_ file and add the browse-everything engine to your application's routes.
 
-If you prefer not to use the generator, or need info on how to set up providers in the browse_everything_providers.yml, use the info on [Configuring browse-everything](https://github.com/projecthydra/browse-everything/wiki/Configuring-browse-everything).  
+If you prefer not to use the generator, or need info on how to set up providers in the browse_everything_providers.yml, use the info on [Configuring browse-everything](https://github.com/projecthydra/browse-everything/wiki/Configuring-browse-everything).
 
-### Include the CSS and JavaScript 
+### Include the CSS and JavaScript
 
 Add `@import "browse_everything";` to your application.css.scss
 
@@ -47,7 +47,7 @@ Add `//= require browse_everything` to your application.js
 ## Usage
 
 ### Adding Providers
-In order to connect to a provider like [DropBox](http://www.dropbox.com), 
+In order to connect to a provider like [Dropbox](http://www.dropbox.com),
 [Skydrive](https://skydrive.live.com/), [Google Drive](http://drive.google.com), or
 [Box](http://www.box.com), you must provide API keys in _config/browse_everything_providers.yml_.  For info on how to edit this file, see [Configuring browse-everything](https://github.com/projecthydra/browse-everything/wiki/Configuring-browse-everything)
 
@@ -57,8 +57,7 @@ browse-everything can be triggered in two ways -- either via data attributes in
 
 #### Options
 
-
-| Name            | Type            | Default         | Description                                                    |
+| Name            | Type            | Default         | Description |
 |-----------------|-----------------|-----------------|----------------------------------------------------------------|
 | route           | path (required) | ''              | The base route of the browse-everything engine.                |
 | target          | xpath or jQuery | null            | A form object to add the results to as hidden fields.          |
@@ -68,7 +67,6 @@ browse-everything can be triggered in two ways -- either via data attributes in
 If a `target` is provided, browse-everything will automatically convert the JSON response to a series of hidden form fields
 that can be posted back to Rails to re-create the array on the server side.
 
-
 #### Via data attributes
 
 To trigger browse-everything using data attributes, set the _data-toggle_ attribute to "browse-everything" on the HTML tag.  This tells the javascript where to attach the browse-everything behaviors. Pass in the options using the _data-route_ and _data-target_ attributes, as in `data-target="#myForm"`.
@@ -76,13 +74,13 @@ To trigger browse-everything using data attributes, set the _data-toggle_ attrib
 For example:
 
 ```html
-<button type="button" data-toggle="browse-everything" data-route="<%=browse_everything_engine.root_path%>" 
+<button type="button" data-toggle="browse-everything" data-route="<%=browse_everything_engine.root_path%>"
   data-target="#myForm" class="btn btn-large btn-success" id="browse">Browse!</button>
 ```
 
 #### Via JavaScript
 
-To trigger browse-everything via javascript, use the .browseEverything() method to attach the behaviors to DOM elements. 
+To trigger browse-everything via javascript, use the .browseEverything() method to attach the behaviors to DOM elements.
 
 ```javascript
 $('#browse').browseEverything(options)
@@ -98,20 +96,19 @@ $('#browse').browseEverything({
 
 See [JavaScript Methods](https://github.com/projecthydra/browse-everything/wiki/JavaScript-Methods) for more info on using javascript to trigger browse-everything.
 
-
-### The Results (Data Structure) 
+### The Results (Data Structure)
 
 browse-everything returns a JSON data structure consisting of an array of URL specifications. Each URL specification
 is a plain object with the following properties:
 
-| Property           | Description                                                                          |
+| Property           | Description |
 |--------------------|--------------------------------------------------------------------------------------|
-| url                | The URL of the selected remote file.                                                 |
+| url                | The URL of the selected remote file. |
 | auth_header        | Any headers that need to be added to the request in order to access the remote file. |
-| expires            | The expiration date/time of the specified URL.                                       |
+| expires            | The expiration date/time of the specified URL. |
 | file_name          | The base name (filename.ext) of the selected file.                                   |
 
-For example, after picking two files from dropbox, 
+For example, after picking two files from dropbox,
 
 If you initialized browse-everything via JavaScript, the results data passed to the `.done()` callback will look like this:
 ```json
@@ -127,19 +124,19 @@ If you initialized browse-everything via JavaScript, the results data passed to
   }
 ]
 ```
-See [JavaScript Methods](https://github.com/projecthydra/browse-everything/wiki/JavaScript-Methods) for more info on using javascript to trigger browse-everything. 
+See [JavaScript Methods](https://github.com/projecthydra/browse-everything/wiki/JavaScript-Methods) for more info on using javascript to trigger browse-everything.
 
 If you initialized browse-everything via data-attributes and set the _target_ option (via the _data-target_ attribute or via the _target_ option on the javascript method), the results data be written as hidden fields in the `<form>` you've specified as the target.  When the user submits that form, the results will look like this:
 ```ruby
 "selected_files" => {
   "0"=>{
-    "url"=>"https://dl.dropbox.com/fake/filepicker-demo.txt.txt", 
-    "expires"=>"2014-03-31T20:37:36.214Z", 
+    "url"=>"https://dl.dropbox.com/fake/filepicker-demo.txt.txt",
+    "expires"=>"2014-03-31T20:37:36.214Z",
     "file_name"=>"filepicker-demo.txt.txt"
-  }, 
+  },
   "1"=>{
-    "url"=>"https://dl.dropbox.com/fake/Getting%20Started.pdf", 
-    "expires"=>"2014-03-31T20:37:36.731Z", 
+    "url"=>"https://dl.dropbox.com/fake/Getting%20Started.pdf",
+    "expires"=>"2014-03-31T20:37:36.731Z",
     "file_name"=>"Getting Started.pdf"
   }
 }
@@ -174,7 +171,7 @@ end
 ### Examples
 
 See `spec/support/app/views/file_handler/index.html` for an example use case. You can also run `rake app:generate` to
-create a fully-functioning demo app in `spec/internal` (though you will have to create 
+create a fully-functioning demo app in `spec/internal` (though you will have to create
 `spec/internal/config/browse_everything.providers.yml` file with your own configuration info.)
 
 ## Contributing
@@ -185,6 +182,6 @@ create a fully-functioning demo app in `spec/internal` (though you will have to
 4. Push to the branch (`git push origin my-new-feature`)
 5. Create new Pull Request
 
-## Help 
+## Help
 
 For help with Questioning Authority, contact <hydra-tech@googlegroups.com>.

data/lib/browse_everything.rb

@@ -11,7 +11,7 @@ module BrowseEverything
   module Driver
     autoload :Base,        'browse_everything/driver/base'
     autoload :FileSystem,  'browse_everything/driver/file_system'
-    autoload :DropBox,     'browse_everything/driver/drop_box'
+    autoload :Dropbox,     'browse_everything/driver/dropbox'
     autoload :SkyDrive,    'browse_everything/driver/sky_drive'
     autoload :Box,         'browse_everything/driver/box'
     autoload :GoogleDrive, 'browse_everything/driver/google_drive'
@@ -23,6 +23,12 @@ module BrowseEverything
         @config = value
       elsif value.kind_of?(String)
         @config = YAML.load(File.read(value))
+
+        if @config.include? 'drop_box'
+          warn "[DEPRECATION] `drop_box` is deprecated.  Please use `dropbox` instead."
+          @config['dropbox'] = @config.delete('drop_box')
+        end
+
       else
         raise InitializationError, "Unrecognized configuration: #{value.inspect}"
       end

data/lib/browse_everything/driver/{drop_box.rb → dropbox.rb}

@@ -2,15 +2,15 @@ require 'dropbox_sdk'
 
 module BrowseEverything
   module Driver
-    class DropBox < Base
+    class Dropbox < Base
 
       def icon
         'dropbox'
       end
-      
+
       def validate_config
         unless [:app_key,:app_secret].all? { |key| config[key].present? }
-          raise BrowseEverything::InitializationError, "DropBox driver requires :app_key and :app_secret"
+          raise BrowseEverything::InitializationError, "Dropbox driver requires :app_key and :app_secret"
         end
       end
 
@@ -46,7 +46,7 @@ module BrowseEverything
       end
 
       def auth_link
-        [ auth_flow.start('drop_box'), @csrf ]
+        [ auth_flow.start('dropbox'), @csrf ]
       end
 
       def connect(params,data)

data/lib/browse_everything/engine.rb

@@ -1,10 +1,8 @@
 module BrowseEverything
   class Engine < ::Rails::Engine
-    initializer :assets do |config|
-      config.assets.paths << config.root.join('vendor', 'assets', 'javascripts')
-      config.assets.paths << config.root.join('vendor', 'assets', 'stylesheets')
-      Rails.application.config.assets.precompile += %w{ browse_everything.js }
-      Rails.application.config.assets.precompile += %w{ browse_everything.css }
-    end
+    config.assets.paths << config.root.join('vendor', 'assets', 'javascripts')
+    config.assets.paths << config.root.join('vendor', 'assets', 'stylesheets')
+    config.assets.precompile += %w{ browse_everything.js }
+    config.assets.precompile += %w{ browse_everything.css }
   end
 end

data/lib/browse_everything/retriever.rb

@@ -30,7 +30,7 @@ module BrowseEverything
         raise ArugumentError, "Download spec expired at #{spec['expires']}"
       end
       
-      url = URI.parse(spec['url'])
+      url = Addressable::URI.parse(spec['url'])
       retrieved = 0
       case url.scheme
       when 'file'

data/lib/browse_everything/version.rb

@@ -1,3 +1,3 @@
 module BrowseEverything
-  VERSION = "0.8.1"
+  VERSION = "0.8.2"
 end

data/lib/generators/browse_everything/config_generator.rb

@@ -8,24 +8,21 @@ class BrowseEverything::ConfigGenerator < Rails::Generators::Base
    2. Modifies your app's routes.rb to mount BrowseEverything at /browse
          """
   source_root File.expand_path('../templates', __FILE__)
-   
+
   def inject_routes
    insert_into_file "config/routes.rb", :after => ".draw do" do
 %{
   mount BrowseEverything::Engine => '/browse'}
    end
-  end 
-  
+  end
+
   def copy_example_config
     copy_file "browse_everything_providers.yml.example", "config/browse_everything_providers.yml"
   end
-  
+
   def insert_file_system_path
-    insert_into_file "config/browse_everything_providers.yml", :before => "# drop_box:" do
+    insert_into_file "config/browse_everything_providers.yml", :before => "# dropbox:" do
       YAML.dump({ 'file_system' => { :home => Rails.root.to_s }})
     end
   end
-  
-
-        
-end
+end

data/lib/generators/browse_everything/templates/browse_everything_providers.yml.example

@@ -2,7 +2,7 @@
 # To make browse-everything aware of a provider, uncomment the info for that provider and add your API key information.
 # The file_system provider can be a path to any directory on the server where your application is running.
 #
-# drop_box:
+# dropbox:
 #   :app_key: YOUR_DROPBOX_APP_KEY
 #   :app_secret: YOUR_DROPBOX_APP_SECRET
 # box:

data/spec/fixtures/vcr_cassettes/dropbox.yml

@@ -2,7 +2,7 @@
 http_interactions:
 - request:
     method: post
-    uri: https://DropBoxAppKey:DropBoxAppSecret@api.dropbox.com/1/oauth2/token
+    uri: https://DropboxAppKey:DropboxAppSecret@api.dropbox.com/1/oauth2/token
     body:
       encoding: UTF-8
       string: grant_type=authorization_code&code=FakeDropboxAuthorizationCodeABCDEFG&redirect_uri=http%3A%2F%2Fbrowse.example.edu%2Fbrowse%2Fconnect
@@ -341,7 +341,7 @@ http_interactions:
       X-RequestId: 83bc363934d5a5457cbcbd0fab8b4cfb
     body:
       encoding: UTF-8
-      string: ! '{ "revision": 4009, "rev": "fa900cbb190", "thumb_exists": false, "bytes": 20904, 
+      string: ! '{ "revision": 4009, "rev": "fa900cbb190", "thumb_exists": false, "bytes": 20904,
         "modified": "Sat, 09 Apr 2011 18:54:54 +0000", "client_mtime": "Sat, 09 Apr 2011 18:54:54 +0000",
         "path": "/Writer/Writer FAQ.txt", "is_dir": false, "icon": "page_white_text", "root":
         "dropbox", "mime_type": "text/plain", "size": "20.4 KB" }'
@@ -382,9 +382,9 @@ http_interactions:
       X-RequestId: 83bc363934d5a5457cbcbd0fab8b4cfb
     body:
       encoding: UTF-8
-      string: ! '{ "revision": 2754, "rev": "ac200cbb190", "thumb_exists": false, 
-        "bytes": 988, "modified": "Thu, 14 Oct 2010 08:32:20 +0000", 
-        "client_mtime": "Thu, 14 Oct 2010 08:32:20 +0000", 
+      string: ! '{ "revision": 2754, "rev": "ac200cbb190", "thumb_exists": false,
+        "bytes": 988, "modified": "Thu, 14 Oct 2010 08:32:20 +0000",
+        "client_mtime": "Thu, 14 Oct 2010 08:32:20 +0000",
         "path": "/Writer/Markdown Test.txt", "is_dir": false, "icon": "page_white_text",
         "root": "dropbox", "mime_type": "text/plain", "size": "988 bytes" }'
     http_version: '1.1'

data/spec/spec_helper.rb

@@ -44,9 +44,9 @@ module BrowserConfigHelper
         client_id: "BoxClientId",
         client_secret: "BoxClientSecret"
       },
-      "drop_box" => { 
-        app_key: "DropBoxAppKey", 
-        app_secret: "DropBoxAppSecret"
+      "dropbox" => {
+        app_key: "DropboxAppKey",
+        app_secret: "DropboxAppSecret"
       },
       "google_drive" => {
         client_id: "GoogleClientId",

data/spec/unit/browser_spec.rb

@@ -3,24 +3,24 @@ require File.expand_path('../../spec_helper',__FILE__)
 include BrowserConfigHelper
 
 describe BrowseEverything::Browser do
-  let(:file_config) { 
+  let(:file_config) {
     {
       file_system: { home: '/file/config/home' },
-      drop_box:    { app_key: 'FileConfigKey', app_secret: 'FileConfigSecret' }
+      dropbox:    { app_key: 'FileConfigKey', app_secret: 'FileConfigSecret' }
     }.to_yaml
   }
 
   let(:global_config) {
     {
       file_system: { home: '/global/config/home' },
-      drop_box:    { app_key: 'GlobalConfigKey', app_secret: 'GlobalConfigSecret' }
+      dropbox:    { app_key: 'GlobalConfigKey', app_secret: 'GlobalConfigSecret' }
     }
   }
 
   let(:local_config) {
     {
       file_system: { home: '/local/config/home' },
-      drop_box:    { app_key: 'LocalConfigKey', app_secret: 'LocalConfigSecret' },
+      dropbox:    { app_key: 'LocalConfigKey', app_secret: 'LocalConfigSecret' },
       url_options: url_options
     }
   }
@@ -30,47 +30,47 @@ describe BrowseEverything::Browser do
     subject { BrowseEverything::Browser.new(url_options) }
 
     it "should have 2 providers" do
-      expect(subject.providers.keys).to eq([:file_system,:drop_box])
+      expect(subject.providers.keys).to eq([:file_system, :dropbox])
     end
 
     it "should use the file configuration" do
-      expect(subject.providers[:drop_box].config[:app_key]).to eq('FileConfigKey')
+      expect(subject.providers[:dropbox].config[:app_key]).to eq('FileConfigKey')
     end
   end
 
   describe "global config" do
     before(:each) { BrowseEverything.configure(global_config) }
     subject { BrowseEverything::Browser.new(url_options) }
-    
+
     it "should have 2 providers" do
-      expect(subject.providers.keys).to eq([:file_system,:drop_box])
+      expect(subject.providers.keys).to eq([:file_system, :dropbox])
     end
 
     it "should use the global configuration" do
-      expect(subject.providers[:drop_box].config[:app_key]).to eq('GlobalConfigKey')
+      expect(subject.providers[:dropbox].config[:app_key]).to eq('GlobalConfigKey')
     end
   end
 
   describe "local config" do
     subject { BrowseEverything::Browser.new(local_config) }
-    
+
     it "should have 2 providers" do
-      expect(subject.providers.keys).to eq([:file_system,:drop_box])
+      expect(subject.providers.keys).to eq([:file_system, :dropbox])
     end
 
     it "should use the local configuration" do
-      expect(subject.providers[:drop_box].config[:app_key]).to eq('LocalConfigKey')
+      expect(subject.providers[:dropbox].config[:app_key]).to eq('LocalConfigKey')
     end
   end
 
   describe "unknown provider" do
-    subject { 
+    subject {
       BrowseEverything::Browser.new(local_config.merge(foo: { key: 'bar', secret: 'baz' }))
     }
 
     it "should complain but continue" do
       allow(Rails.logger).to receive(:warn).with('Unknown provider: foo')
-      expect(subject.providers.keys).to eq([:file_system,:drop_box])
+      expect(subject.providers.keys).to eq([:file_system, :dropbox])
     end
   end
 end

data/spec/unit/{drop_box_spec.rb → dropbox_spec.rb}

@@ -2,26 +2,26 @@ require File.expand_path('../../spec_helper',__FILE__)
 
 include BrowserConfigHelper
 
-describe BrowseEverything::Driver::DropBox, vcr: { cassette_name: 'dropbox', record: :none } do
+describe BrowseEverything::Driver::Dropbox, vcr: { cassette_name: 'dropbox', record: :none } do
   before(:all)  { stub_configuration   }
   after(:all)   { unstub_configuration }
 
   let(:browser) { BrowseEverything::Browser.new(url_options) }
-  let(:provider) { browser.providers['drop_box'] }
+  let(:provider) { browser.providers['dropbox'] }
   let(:auth_params) { {
     'code' => 'FakeDropboxAuthorizationCodeABCDEFG',
-    'state' => 'GjDcUhPNZrZzdsw%2FghBy2A%3D%3D|drop_box'
+    'state' => 'GjDcUhPNZrZzdsw%2FghBy2A%3D%3D|dropbox'
   } }
   let(:csrf_data) { {'token' => 'GjDcUhPNZrZzdsw%2FghBy2A%3D%3D'} }
 
   it "#validate_config" do
-    expect { BrowseEverything::Driver::DropBox.new({}) }.to raise_error(BrowseEverything::InitializationError)
+    expect { BrowseEverything::Driver::Dropbox.new({}) }.to raise_error(BrowseEverything::InitializationError)
   end
 
   describe "simple properties" do
     subject    { provider                 }
-    its(:name) { should == 'Drop Box'     }
-    its(:key)  { should == 'drop_box'     }
+    its(:name) { should == 'Dropbox'     }
+    its(:key)  { should == 'dropbox'     }
     its(:icon) { should be_a(String)      }
   end
 
@@ -33,7 +33,7 @@ describe BrowseEverything::Driver::DropBox, vcr: { cassette_name: 'dropbox', rec
     context "#auth_link" do
       specify { subject.auth_link[0].should start_with('https://www.dropbox.com/1/oauth2/authorize') }
     end
-    
+
     it "should authorize" do
       subject.connect(auth_params,csrf_data)
       expect(subject).to be_authorized
@@ -59,7 +59,7 @@ describe BrowseEverything::Driver::DropBox, vcr: { cassette_name: 'dropbox', rec
         subject { contents[4] }
         its(:name)     { should == 'iPad intro.pdf'           }
         its(:size)     { should == 208218                 }
-        its(:location) { should == "drop_box:/iPad intro.pdf" }
+        its(:location) { should == "dropbox:/iPad intro.pdf" }
         its(:type)     { should == "application/pdf"          }
         specify        { should_not be_container              }
       end
@@ -75,21 +75,21 @@ describe BrowseEverything::Driver::DropBox, vcr: { cassette_name: 'dropbox', rec
       context "[1]" do
         subject { contents[1] }
         its(:name)     { should == 'About Writer.txt'      }
-        its(:location) { should == "drop_box:/Writer/About Writer.txt" }
+        its(:location) { should == "dropbox:/Writer/About Writer.txt" }
         its(:type)     { should == "text/plain"      }
         specify        { should_not be_container     }
       end
       context "[2]" do
         subject { contents[2] }
         its(:name)     { should == 'Markdown Test.txt'      }
-        its(:location) { should == "drop_box:/Writer/Markdown Test.txt" }
+        its(:location) { should == "dropbox:/Writer/Markdown Test.txt" }
         its(:type)     { should == "text/plain"      }
         specify        { should_not be_container     }
       end
       context "[3]" do
         subject { contents[3] }
         its(:name)     { should == 'Writer FAQ.txt'      }
-        its(:location) { should == "drop_box:/Writer/Writer FAQ.txt" }
+        its(:location) { should == "dropbox:/Writer/Writer FAQ.txt" }
         its(:type)     { should == "text/plain"      }
         specify        { should_not be_container     }
       end
@@ -104,13 +104,13 @@ describe BrowseEverything::Driver::DropBox, vcr: { cassette_name: 'dropbox', rec
   describe "#link_for" do
     before(:each) { provider.connect(auth_params,csrf_data) }
 
-    context "[0]" do 
+    context "[0]" do
       subject { provider.link_for('/Writer/Writer FAQ.txt') }
       specify { subject[0].should == "https://dl.dropboxusercontent.com/1/view/FakeDropboxAccessPath/Writer/Writer%20FAQ.txt" }
       specify { subject[1].should have_key(:expires) }
     end
 
-    context "[1]" do 
+    context "[1]" do
       subject { provider.link_for('/Writer/Markdown Test.txt') }
       specify { subject[0].should == "https://dl.dropboxusercontent.com/1/view/FakeDropboxAccessPath/Writer/Markdown%20Test.txt" }
       specify { subject[1].should have_key(:expires) }

data/spec/unit/file_system_spec.rb

@@ -36,13 +36,21 @@ describe BrowseEverything::Driver::FileSystem do
       end
       context "[2]" do
         subject { contents[2] }
+        its(:name)     { should == 'file 1.pdf'              }
+        its(:size)     { should == 2256                      }
+        its(:location) { should == "file_system:#{File.join(home,'file 1.pdf')}" }
+        its(:type)     { should == "application/pdf"         }
+        specify        { should_not be_container             }
+      end
+      context "[3]" do
+        subject { contents[3] }
         its(:name)     { should == 'file_1.pdf'              }
         its(:size)     { should == 2256                      }
         its(:location) { should == "file_system:#{File.join(home,'file_1.pdf')}" }
         its(:type)     { should == "application/pdf"         }
         specify        { should_not be_container             }
       end
-    end
+     end
 
     context "subdirectory" do
       let(:contents) { provider.contents('/dir_1') }

data/spec/unit/retriever_spec.rb

@@ -3,7 +3,9 @@ require File.expand_path('../../spec_helper',__FILE__)
 describe BrowseEverything::Retriever, vcr: { cassette_name: 'retriever', record: :none,  } do
   subject { BrowseEverything::Retriever.new }
   let(:datafile) { File.expand_path('../../fixtures/file_system/file_1.pdf',__FILE__) }
+  let(:datafile_with_spaces) { File.expand_path('../../fixtures/file_system/file 1.pdf',__FILE__) }
   let(:data) { File.open(datafile,'rb',&:read) }
+  let(:data_with_spaces) { File.open(datafile_with_spaces, 'rb', &:read) }
   let(:size) { File.size(datafile) }
 
   context 'http://' do
@@ -18,7 +20,7 @@ describe BrowseEverything::Retriever, vcr: { cassette_name: 'retriever', record:
         }
       }
     }
-    
+
     context "#retrieve" do
       it "content" do
         content = ''
@@ -50,7 +52,12 @@ describe BrowseEverything::Retriever, vcr: { cassette_name: 'retriever', record:
           "url"=>"file://#{datafile}", 
           "file_name"=>"file.pdf", 
           "file_size"=>size.to_s
-        }
+        },
+	"1" => {
+	  "url" => "file://#{datafile_with_spaces}",
+	  "file_name" => "file.pdf",
+	  "file_size" => size.to_s
+	}
       }
     }
 
@@ -61,6 +68,12 @@ describe BrowseEverything::Retriever, vcr: { cassette_name: 'retriever', record:
         expect(content).to eq(data)
       end
 
+      it "content with spaces" do
+        content = ''
+	subject.retrieve(spec['1']) { |chunk, retrieved, total| content << chunk }
+	expect(content).to eq(data_with_spaces)
+      end
+
       it "callbacks" do
         expect { |block| subject.retrieve(spec['0'], &block) }.to yield_with_args(data, data.length, data.length)
       end

data/spec/views/browse_everything/_file.html.erb_spec.rb

@@ -13,6 +13,7 @@ describe 'browse_everything/_file.html.erb', type: :view do
 
 
   before do
+    allow(view).to receive(:browse_everything_engine).and_return(BrowseEverything::Engine.routes.url_helpers)
     allow(view).to receive(:file).and_return(file)
     allow(view).to receive(:provider).and_return(provider)
     allow(view).to receive(:path).and_return("path")

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: browse-everything
 version: !ruby/object:Gem::Version
-  version: 0.8.1
+  version: 0.8.2
 platform: ruby
 authors:
 - Carolyn Cole
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-03 00:00:00.000000000 Z
+date: 2015-04-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -383,7 +383,7 @@ files:
 - lib/browse_everything/browser.rb
 - lib/browse_everything/driver/base.rb
 - lib/browse_everything/driver/box.rb
-- lib/browse_everything/driver/drop_box.rb
+- lib/browse_everything/driver/dropbox.rb
 - lib/browse_everything/driver/file_system.rb
 - lib/browse_everything/driver/google_drive.rb
 - lib/browse_everything/driver/sky_drive.rb
@@ -397,6 +397,7 @@ files:
 - spec/fixtures/file_system/dir_1/dir_3/file_3.m4v
 - spec/fixtures/file_system/dir_1/file_2.txt
 - spec/fixtures/file_system/dir_2/file_4.docx
+- spec/fixtures/file_system/file 1.pdf
 - spec/fixtures/file_system/file_1.pdf
 - spec/fixtures/vcr_cassettes/dropbox.yml
 - spec/fixtures/vcr_cassettes/retriever.yml
@@ -408,7 +409,7 @@ files:
 - spec/unit/base_spec.rb
 - spec/unit/browse_everything_helper_spec.rb
 - spec/unit/browser_spec.rb
-- spec/unit/drop_box_spec.rb
+- spec/unit/dropbox_spec.rb
 - spec/unit/file_entry_spec.rb
 - spec/unit/file_system_spec.rb
 - spec/unit/retriever_spec.rb
@@ -438,7 +439,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
 summary: AJAX/Rails engine file browser for cloud storage services
@@ -447,6 +448,7 @@ test_files:
 - spec/fixtures/file_system/dir_1/dir_3/file_3.m4v
 - spec/fixtures/file_system/dir_1/file_2.txt
 - spec/fixtures/file_system/dir_2/file_4.docx
+- spec/fixtures/file_system/file 1.pdf
 - spec/fixtures/file_system/file_1.pdf
 - spec/fixtures/vcr_cassettes/dropbox.yml
 - spec/fixtures/vcr_cassettes/retriever.yml
@@ -458,7 +460,7 @@ test_files:
 - spec/unit/base_spec.rb
 - spec/unit/browse_everything_helper_spec.rb
 - spec/unit/browser_spec.rb
-- spec/unit/drop_box_spec.rb
+- spec/unit/dropbox_spec.rb
 - spec/unit/file_entry_spec.rb
 - spec/unit/file_system_spec.rb
 - spec/unit/retriever_spec.rb