brickset 0.0.2 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b88f8d7e145af60f0d4e3bcb38f19fe17c782061
-  data.tar.gz: 0cc4af00d816f6fa7f1c167c1b1d0288e0a82f47
+  metadata.gz: b28f2e5a3d92352293fc9229b1fe0775a4698ac0
+  data.tar.gz: b7d9989e097ff544188ce46b1879942fd65acd89
 SHA512:
-  metadata.gz: 700c40b0b1ec4a00bdcc0d34f306fb69442e7a218b919b71d9bfdf9ecb036aceb49b559ad75fc82f8f2b48ca17a264deffab8ae6a9b758fdbba16a5ff01cd6b4
-  data.tar.gz: 7924de3bad44bdd02a8f24084f7c04362119cb7e046e2a5c9d9e578de4539a86c14968a8b50e180f8a21bf457be6ad56d820110878f80fc79395adb3d2d1370d
+  metadata.gz: ae581ede7b2f000cdc2c0a7cb349a6188f096265b5751cd7ff4fbea58bc3c010ff604ed55fe9882ac7fef4dc80efb15d9ad6f0dd52c458c7b4c440e5af933ed2
+  data.tar.gz: 35b0325cbe3039fa40bf3392098b18dd441c76d92856d2a654d1821b2c2f4446b17e2f767a8e91ad977501279e1b668ce1d6b5bdc87d7456ecbbdd99da09d437

data/lib/brickset/client.rb

@@ -19,7 +19,7 @@ module Brickset
       end
     end
 
-    def get_sets options
+    def get_sets options = {}
       required_params = [:userHash, :query, :theme, :subtheme, :setNumber, :year, :owned, :wanted, :orderBy, :pageSize, :pageNumber, :userName]
       default_options = {}
       required_params.each { |param| default_options[param] = nil }
@@ -32,7 +32,7 @@ module Brickset
     end
 
     def get_recently_updated_sets minutes_ago
-      response = call_api :getRecentlyUpdatedSets, {minutesAgo: minutes_ago}
+      response = call_api :getRecentlyUpdatedSets, { minutesAgo: minutes_ago }
       if response["ArrayOfSets"].nil?
         []
       else

data/lib/brickset/version.rb

@@ -1,3 +1,3 @@
 module Brickset
-  VERSION = "0.0.2"
+  VERSION = "0.1.0"
 end

data/spec/client_spec.rb

@@ -1,6 +1,7 @@
 require 'spec_helper'
 
 describe Brickset::Client do
+  let(:client) { Brickset::Client.new(api_key: 'api_key') }
 
   before do
     @keys = Brickset::Configuration::VALID_CONFIG_KEYS
@@ -56,4 +57,108 @@ describe Brickset::Client do
       end
     end
   end
-end
+
+  describe "#get_sets" do
+    context 'with no options' do
+      it "calls api with null required options" do
+        expect(client).to receive(:call_api).with(
+          :getSets,
+          {
+            userHash: nil,
+            query: nil,
+            theme: nil,
+            subtheme: nil,
+            setNumber: nil,
+            year: nil,
+            owned: nil,
+            wanted: nil,
+            orderBy: nil,
+            pageSize: nil,
+            pageNumber: nil,
+            userName: nil
+          }
+        ) { {} }
+        client.get_sets
+      end
+      context 'ArrayOfSets nil?' do
+        it "is empty array" do
+          expect(client).to receive(:call_api) { {} }
+          expect(client.get_sets).to eq([])
+        end
+      end
+      context 'ArrayOfSets has sets' do
+        it "returns sets results" do
+          expect(client).to receive(:call_api) { {"ArrayOfSets" => { "sets" => "test" } } }
+          expect(client.get_sets).to eq("test")
+        end
+      end
+    end
+    context 'with options' do
+      it "passes the options to call_api" do
+        expect(client).to receive(:call_api).with(
+          :getSets,
+          {
+            userHash: 'hash',
+            query: nil,
+            theme: nil,
+            subtheme: nil,
+            setNumber: nil,
+            year: nil,
+            owned: nil,
+            wanted: nil,
+            orderBy: nil,
+            pageSize: nil,
+            pageNumber: nil,
+            userName: 'name'
+          }
+        ) { {} }
+        client.get_sets(userHash: 'hash', userName: 'name')
+      end
+    end
+  end
+
+  describe "#get_recently_updated_sets" do
+    it "calls the api with minutesAgo param" do
+      expect(client).to receive(:call_api).with(:getRecentlyUpdatedSets, { minutesAgo: 2 }) { {} }
+      client.get_recently_updated_sets 2
+    end
+    context 'ArrayOfSets nil?' do
+      it "is empty array" do
+        expect(client).to receive(:call_api) { {} }
+        expect(client.get_recently_updated_sets 1).to eq([])
+      end
+    end
+    context 'ArrayOfSets has sets' do
+      it "returns sets results" do
+        expect(client).to receive(:call_api) { {"ArrayOfSets" => { "sets" => "test" } } }
+        expect(client.get_recently_updated_sets 1).to eq("test")
+      end
+    end
+  end
+
+  describe "#call_api" do
+    let(:response) { double(code: 200, parsed_response: {}, body: '')}
+    it "calls get using endpoint and method name" do
+      expect(Brickset::Client).to receive(:get).with("#{client.endpoint}/test", hash_including(:query)) { response }
+      client.send :call_api, :test
+    end
+    it "passes options and merges api key" do
+      expect(Brickset::Client).to receive(:get).with("#{client.endpoint}/test", query: { option: 'test', apiKey: 'api_key'} ) { response }
+      client.send :call_api, :test, { option: 'test' }
+    end
+    context 'response code == 200' do
+      let(:response) { double(code: 200, parsed_response: { test: 'test' }, body: '')}
+      it "returns parsed_response" do
+        expect(Brickset::Client).to receive(:get) { response }
+        expect(client.send :call_api, :test).to eq({test: 'test'})
+      end
+    end
+    context 'response code != 200' do
+      let(:response) { double(code: 400, parsed_response: {  }, body: 'error') }
+      it "raises an error with body" do
+        expect(Brickset::Client).to receive(:get) { response }
+        expect { expect(client.send :call_api, :test) }.to raise_error('error')
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: brickset
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.1.0
 platform: ruby
 authors:
 - dbwinger
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-07-08 00:00:00.000000000 Z
+date: 2015-09-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler