brick_ftp 0.7.1 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5a0069f587ef3fe9093bac0c8226af17eecc3634cb461bee69b2de18748b6b1f
-  data.tar.gz: 31a6d9bb6e85cfe8fec3f246c97bc38632b42fdd1a3f6191f09f4e82948c89a7
+  metadata.gz: 7b5f39154f9f9cb909e38e0a7b3b20e7da36921d348340f21186b272cc06332b
+  data.tar.gz: 1cda57b5a7f2c3170ec94cbda3dc0c545a056aab7a1fb1893aed5ef0382d87d8
 SHA512:
-  metadata.gz: 3ccbfa02cab23edd32e91400fc5bc3fc1a0ec75dbe9e763024249c7271d78abede39074994fe1bae73e613f7f09f6c44761bb392f16bb8d1ff92831e0da4d98d
-  data.tar.gz: 68cd755ff67fcb37d21ca17743d2df51ceceebbf54f0afb24d38459f92c848df4b8043db36345a47376107224a0f94473dbbdfc6fc2df5e43b4d47e382d7a21d
+  metadata.gz: c678bfe33641ef68904283954d8fab9c8756b75265798fe53bec129fb7c65a30259a954fb894e3d029ded471d37b98d268a8d5f860d404e5d3a320f4b082c563
+  data.tar.gz: 508b6cdb4d5c1f7e250d2ffe48fd966d87add82ae8e33538d7b7f8c99cee5c5f08af67b05b3d2ba5ef7ca8d183829727b96576aa0e7589bc9620398450743ab7

data/CHANGELOG.md

@@ -2,10 +2,10 @@ Changelog
 ====
 
 
-[unreleased](https://github.com/koshigoe/brick_ftp/compare/v0.7.1...master)
+[unreleased](https://github.com/koshigoe/brick_ftp/compare/v0.8.0...master)
 ----
 
-[Full Changelog](https://github.com/koshigoe/brick_ftp/compare/v0.7.1...master)
+[Full Changelog](https://github.com/koshigoe/brick_ftp/compare/v0.8.0...master)
 
 ### Enhancements:
 
@@ -14,6 +14,25 @@ Changelog
 ### Breaking Changes:
 
 
+[v0.8.0](https://github.com/koshigoe/brick_ftp/compare/v0.7.1...v0.8.0)
+----
+
+[Full Changelog](https://github.com/koshigoe/brick_ftp/compare/v0.7.1...v0.8.0)
+
+### Enhancements:
+
+### Fixed Bugs:
+
+- [#92](https://github.com/koshigoe/brick_ftp/pull/92) Re-Overwrite `as_json` to avoid to too much loop.
+    - fixes [#91](https://github.com/koshigoe/brick_ftp/issues/91)
+
+### Breaking Changes:
+
+- [#92](https://github.com/koshigoe/brick_ftp/pull/92)
+    - Change type of key of returned Hash object from `BrickFTP::API::Base#as_json` to `String`.
+    - Initialize `BrickFTP::API::Base#properties` with all defined attributes.
+
+
 [v0.7.1](https://github.com/koshigoe/brick_ftp/compare/v0.7.0...v0.7.1)
 ----
 

data/lib/brick_ftp/api/base.rb

@@ -43,7 +43,7 @@ module BrickFTP
       attr_reader :properties
 
       def initialize(params = {})
-        @properties = {}
+        initialize_properties
         params.each { |k, v| write_property(k, v) }
       end
 
@@ -73,7 +73,7 @@ module BrickFTP
       end
 
       def as_json
-        self.class.attributes.each_with_object({}) { |name, res| res[name] = read_property(name) }
+        properties.dup
       end
 
       def to_json
@@ -94,6 +94,11 @@ module BrickFTP
 
       private
 
+      def initialize_properties
+        @properties = {}
+        self.class.attributes.each { |key| write_property(key, nil) }
+      end
+
       def respond_to_missing?(method_name, _include_private)
         self.class.attributes.include?(method_name.to_sym)
       end

data/lib/brick_ftp/api/file_operation/uploading_session.rb

@@ -79,6 +79,16 @@ module BrickFTP
         def commit
           UploadingResult.create(path: path, ref: ref)
         end
+
+        # Return single uploading session object.
+        #
+        # NOTE: The `#as_json` method will be overwritten by active_supprt.
+        #
+        # @return [Hash] a JSON serializable object
+        #
+        def as_json
+          properties.dup
+        end
       end
     end
   end

data/lib/brick_ftp/version.rb

@@ -1,3 +1,3 @@
 module BrickFTP
-  VERSION = '0.7.1'.freeze
+  VERSION = '0.8.0'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: brick_ftp
 version: !ruby/object:Gem::Version
-  version: 0.7.1
+  version: 0.8.0
 platform: ruby
 authors:
 - koshigoe
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-01-19 00:00:00.000000000 Z
+date: 2018-01-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler