brick_ftp 0.5.1 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a234ab93a2769cded17e32e1eb09693ba4cb488f
-  data.tar.gz: 0c546aa7972b3138965444c8c6c35a483640b099
+  metadata.gz: f4ceed2165ffe939ec9fa8d08932469060f5ac76
+  data.tar.gz: baca3f3769711375adede57195a0d62421b3bc8c
 SHA512:
-  metadata.gz: dbb6d3f3233ea40ed0cd5934d6b42302b02184c4dd101e7b19c342f124a054ee2c41ffaf2179d9b8e3f28d5d111969a64d969b058576541a0a3b01b9fc86568d
-  data.tar.gz: b5027966e98cdfeed34b07b0e1446c72e9bcb972ea00d3500f7378b69e80fda3f2a5fcd63a32b81ce8386dd92a6de5cea78abe0fc0b39d6773ae267af688d204
+  metadata.gz: 52eb974b0c1a30f5248e7fdb394dc0fd85da3b1499202694825d5ec845eeb27851a502808073ac759a4ff092f9caa1a8ab2fa9d22a2759ba8415c874db35ef6f
+  data.tar.gz: 4e2bb88fe63df32dd2dd781ff3e7537caaf01d7df694189128e5838e1aeb995b19c2af439ac1f2cb4a0ad0706b2262ee58af0758ebdd05604dd55252752fa5c6

data/CHANGELOG.md

@@ -2,20 +2,39 @@ Changelog
 ====
 
 
-[unreleased](https://github.com/koshigoe/brick_ftp/compare/v0.5.1...master)
+[unreleased](https://github.com/koshigoe/brick_ftp/compare/v0.6.0...master)
 ----
 
-[Full Changelog](https://github.com/koshigoe/brick_ftp/compare/v0.5.1...master)
+[Full Changelog](https://github.com/koshigoe/brick_ftp/compare/v0.6.0...master)
 
 ### Enhancements:
 
 ### Fixed Bugs:
 
+### Breaking Changes:
+
+
+[v0.6.0](https://github.com/koshigoe/brick_ftp/compare/v0.5.1...v0.6.0)
+----
+
+[Full Changelog](https://github.com/koshigoe/brick_ftp/compare/v0.5.1...v0.6.0)
+
+### Enhancements:
+
+### Fixed Bugs:
+
+### Breaking Changes:
+
+- [#72](https://github.com/koshigoe/brick_ftp/pull/72) Improve accessor of API properties
+    - Cannot access some API properties named same as methods of Ruby's Object.
+        - e.g. `send` property of [File Uploading](https://brickftp.com/docs/rest-api/file-uploading/)
+        - Use `#properties` to access properties
+
 
 [v0.5.1](https://github.com/koshigoe/brick_ftp/compare/v0.5.0...v0.5.1)
 ----
 
-[Full Changelog](https://github.com/koshigoe/brick_ftp/compare/v0.5.0...master)
+[Full Changelog](https://github.com/koshigoe/brick_ftp/compare/v0.5.0...v0.5.1)
 
 ### Enhancements:
 

data/lib/brick_ftp/api/authentication/session.rb

@@ -15,7 +15,7 @@ module BrickFTP
 
         def destroy
           super.tap do
-            @id = nil
+            delete_property(:id)
             BrickFTP.config.session = nil
           end
         end

data/lib/brick_ftp/api/base.rb

@@ -39,8 +39,12 @@ module BrickFTP
         new(data.symbolize_keys)
       end
 
+      # @return [Hash{String => Object}] Key Value pairs of API properties
+      attr_reader :properties
+
       def initialize(params = {})
-        params.each { |k, v| instance_variable_set(:"@#{sanitize_instance_variable_name(k)}", v) }
+        @properties = {}
+        params.each { |k, v| write_property(k, v) }
       end
 
       def update(params = {})
@@ -51,7 +55,7 @@ module BrickFTP
           self.class.api_path_for(:update, self),
           params: self.class.api_component_for(:update).except_path_and_query(params)
         )
-        data.each { |k, v| instance_variable_set(:"@#{k}", v) }
+        data.each { |k, v| write_property(k, v) }
 
         self
       end
@@ -69,17 +73,35 @@ module BrickFTP
       end
 
       def as_json
-        self.class.attributes.each_with_object({}) { |name, res| res[name] = send(name) }
+        self.class.attributes.each_with_object({}) { |name, res| res[name] = read_property(name) }
       end
 
       def to_json
         as_json.to_json
       end
 
+      def write_property(key, value)
+        properties[key.to_s] = value
+      end
+
+      def read_property(key)
+        properties[key.to_s]
+      end
+
+      def delete_property(key)
+        properties.delete(key.to_s)
+      end
+
       private
 
-      def sanitize_instance_variable_name(name)
-        name.to_s.gsub(/\W/, '')
+      def respond_to_missing?(method_name, _include_private)
+        self.class.attributes.include?(method_name.to_sym)
+      end
+
+      def method_missing(method_name, *args)
+        super unless self.class.attributes.include?(method_name.to_sym)
+
+        read_property(method_name)
       end
     end
   end

data/lib/brick_ftp/api/folder.rb

@@ -14,6 +14,7 @@ module BrickFTP
       attribute :md5
       attribute :provided_mtime
       attribute :permissions
+      attribute :subfolders_locked?
     end
   end
 end

data/lib/brick_ftp/api_component.rb

@@ -68,7 +68,7 @@ module BrickFTP
       when BrickFTP::API::Base
         keys = path_variables(params) + query_keys
         keys.each_with_object({}) do |key, res|
-          res[key] = params.send(key)
+          res[key] = params.read_property(key)
         end
       else
         keys = path_variables(params) + query_keys

data/lib/brick_ftp/api_definition.rb

@@ -37,7 +37,6 @@ module BrickFTP
         else
           readonly_attributes << name.to_sym
         end
-        attr_reader name.to_s.tr('-', '_')
       end
 
       # Return all attributes.

data/lib/brick_ftp/version.rb

@@ -1,3 +1,3 @@
 module BrickFTP
-  VERSION = "0.5.1"
+  VERSION = '0.6.0'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: brick_ftp
 version: !ruby/object:Gem::Version
-  version: 0.5.1
+  version: 0.6.0
 platform: ruby
 authors:
 - koshigoe