brick 1.0.11 → 1.0.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 513e7f88a3dc5ac0f198308e3d82b6f3990af72d5b7b628d83863d887ab50ee2
-  data.tar.gz: 845340d554fcfad33d1d841a3098fcf93aaae96dd426c17256cefbe103dd1997
+  metadata.gz: f7c3e4032e5e9f111839b7ff6e6378e4937edeabeb0edcf480cf6c50e79e599a
+  data.tar.gz: 1a1e5b096a3f6fff0f2c49c6be6abcfbe012f3e24fccf0ea6b307b58d9cbc076
 SHA512:
-  metadata.gz: 87f4c91911e83770c025c36945bec40c191b73a539a94bf5188738b01b516df0347f20f3710d9cca8f392dfcc32b2df68413309edddedc13dfff8d47ca99efa6
-  data.tar.gz: e357a73bd2f5d6371a3d92344cd5635f458f332b2027d66851e068cd3f833f7fffd3ff6dc2a51d48bc2b9b9696d14a5ff999ea5a626341d14ff90286b4a19836
+  metadata.gz: 4dbd885a2c4dc9666378a69423179ca2085c89b6b6120d21ef8d3274f229a88306f54868b8a18aad8e55a37a71bc9b78dff073263bb86fd89d5b982acf8d5210
+  data.tar.gz: 952f94f89445170f26fad10357ede0df7c9053d034ddb552b1e9cba884cbdf0325325cb29a2248fac4e9de3bd8c41619fc9612d44435e6ccb808a16fd018d8dc

data/lib/brick/extensions.rb

@@ -137,7 +137,26 @@ module ActiveRecord
       alias _brick_find_sti_class find_sti_class
       def find_sti_class(type_name)
         ::Brick.sti_models[type_name] = { base: self } unless type_name.blank?
-        _brick_find_sti_class(type_name)
+        module_prefixes = type_name.split('::')
+        module_prefixes.unshift('') unless module_prefixes.first.blank?
+        candidate_file = Rails.root.join('app/models' + module_prefixes.map(&:underscore).join('/') + '.rb')
+        if File.exists?(candidate_file)
+          # Find this STI class normally
+          _brick_find_sti_class(type_name)
+        else
+          # Build missing prefix modules if they don't yet exist
+          this_module = Object
+          module_prefixes[1..-2].each do |module_name|
+            mod = if this_module.const_defined?(module_name)
+                    this_module.const_get(module_name)
+                  else
+                    this_module.const_set(module_name.to_sym, Module.new)
+                  end
+          end
+          # Build missing prefix modules if they don't yet exist
+          this_module.const_set(module_prefixes.last.to_sym, klass = Class.new(self))
+          klass
+        end
       end
     end
   end
@@ -161,7 +180,8 @@ class Object
       return Object._brick_const_missing(*args) if ActiveSupport::Dependencies.search_for_file(class_name.underscore)
 
       relations = ::Brick.instance_variable_get(:@relations)[ActiveRecord::Base.connection_pool.object_id] || {}
-      result = if ::Brick.enable_controllers? && class_name.end_with?('Controller') && (plural_class_name = class_name[0..-11]).length.positive?
+      is_controllers_enabled = Rails.development? || ::Brick.enable_controllers?
+      result = if is_controllers_enabled && class_name.end_with?('Controller') && (plural_class_name = class_name[0..-11]).length.positive?
         # Otherwise now it's up to us to fill in the gaps
         if (model = ActiveSupport::Inflector.singularize(plural_class_name).constantize)
           # if it's a controller and no match or a model doesn't really use the same table name, eager load all models and try to find a model class of the right name.

data/lib/brick/frameworks/rails/engine.rb

@@ -8,9 +8,9 @@ module Brick
       config.brick = ActiveSupport::OrderedOptions.new
       ActiveSupport.on_load(:before_initialize) do |app|
         ::Brick.enable_models = app.config.brick.fetch(:enable_models, true)
-        ::Brick.enable_controllers = app.config.brick.fetch(:enable_controllers, true)
-        ::Brick.enable_views = app.config.brick.fetch(:enable_views, true)
-        ::Brick.enable_routes = app.config.brick.fetch(:enable_routes, true)
+        ::Brick.enable_controllers = app.config.brick.fetch(:enable_controllers, false)
+        ::Brick.enable_views = app.config.brick.fetch(:enable_views, false)
+        ::Brick.enable_routes = app.config.brick.fetch(:enable_routes, false)
         ::Brick.skip_database_views = app.config.brick.fetch(:skip_database_views, false)
 
         # Specific database tables and views to omit when auto-creating models
@@ -37,7 +37,7 @@ module Brick
         # ====================================
         # Dynamically create generic templates
         # ====================================
-        if ::Brick.enable_views?
+        if Rails.development? || ::Brick.enable_views?
           ActionView::LookupContext.class_exec do
             alias :_brick_template_exists? :template_exists?
             def template_exists?(*args, **options)
@@ -209,7 +209,11 @@ function changeout(href, param, value) {
       <% next if k == '#{pk}' || ::Brick.config.metadata_columns.include?(k) %>
       <td>
       <% if (bt = bts[k]) %>
-        <%= bt_obj = bt[1].find_by(bt.last => val); link_to(bt_obj.brick_descrip, bt_obj) if bt_obj %>
+        <%# Instead of just 'bt_obj we have to put in all of this junk:
+        # send(\"#\{bt_obj_class = bt[1].name.underscore\}_path\".to_sym, bt_obj.send(bt[1].primary_key.to_sym))
+        # Otherwise we get stuff like:
+        # ActionView::Template::Error (undefined method `vehicle_path' for #<ActionView::Base:0x0000000033a888>) %>
+        <%= bt_obj = bt[1].find_by(bt.last => val); link_to(bt_obj.brick_descrip, send(\"#\{bt_obj_class = bt[1].name.underscore\}_path\".to_sym, bt_obj.send(bt[1].primary_key.to_sym))) if bt_obj %>
       <% else %>
         <%= val %>
       <% end %>
@@ -244,7 +248,7 @@ function changeout(href, param, value) {
     </th>
     <td>
     <% if (bt = bts[k]) %>
-      <%= bt_obj = bt[1].find_by(bt.last => val); link_to(bt_obj.brick_descrip, bt_obj) if bt_obj %>
+      <%= bt_obj = bt[1].find_by(bt.last => val); link_to(bt_obj.brick_descrip, send(\"#\{bt_obj_class = bt[1].name.underscore\}_path\".to_sym, bt_obj.send(bt[1].primary_key.to_sym))) if bt_obj %>
     <% else %>
       <%= val %>
     <% end %>
@@ -279,7 +283,7 @@ function changeout(href, param, value) {
           end
         end
 
-        if ::Brick.enable_routes?
+        if Rails.development? || ::Brick.enable_routes?
           ActionDispatch::Routing::RouteSet.class_exec do
             alias _brick_finalize_routeset! finalize!
             def finalize!(*args, **options)

data/lib/brick/version_number.rb

@@ -5,7 +5,7 @@ module Brick
   module VERSION
     MAJOR = 1
     MINOR = 0
-    TINY = 11
+    TINY = 12
 
     # PRE is nil unless it's a pre-release (beta, RC, etc.)
     PRE = nil

data/lib/generators/brick/install_generator.rb

@@ -80,11 +80,13 @@ module Brick
 # # Settings for the Brick gem
 # # (By default this auto-creates models, controllers, views, and routes on-the-fly.)
 
-# # Normally these all start out as being enabled, but can be selectively disabled:
-# Brick.enable_routes = false
+# # Normally all are enabled in development mode, and for security reasons only models are enabled in production
+# # and test.  This allows you to either (a) turn off models entirely, or (b) enable controllers, views, and routes
+# # in production.
+# Brick.enable_routes = true # Setting this to \"false\" will disable routes in development
 # Brick.enable_models = false
-# Brick.enable_controllers = false
-# Brick.enable_views = false
+# Brick.enable_controllers = true # Setting this to \"false\" will disable controllers in development
+# Brick.enable_views = true # Setting this to \"false\" will disable views in development
 
 # # By default models are auto-created for database views, and set to be read-only.  This can be skipped.
 # Brick.skip_database_views = true

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: brick
 version: !ruby/object:Gem::Version
-  version: 1.0.11
+  version: 1.0.12
 platform: ruby
 authors:
 - Lorin Thwaits
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-03-22 00:00:00.000000000 Z
+date: 2022-03-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord