briard 2.9.3 → 2.9.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 06c9f718653483604dff7e7c3d71ab30360f443eac5f8e574019ad32ed2e2b41
-  data.tar.gz: 40e1d84a7163b754a1da8f7ff5f86e5420ea14916ea0a0661de70a6f7115dc48
+  metadata.gz: 9ce2b87b6b9a2b937d0ba4ee04cfa69376851ba89d36e475f23ed5a68fbb891f
+  data.tar.gz: 13699df8c5c34eaf7660cb49a77bee330b805ff3e68df5c3e67dcf18f91e430a
 SHA512:
-  metadata.gz: 6acc897545e269db5bc64c22f6aa660a2c054ccde110b123d01ffe402dbf12b134fb4102767bddde2ed956973940b177aee7ce1660b35ca1c70f2b7cd2ad4e60
-  data.tar.gz: 5cf21553130a1c05002c019cb0efebd842b8bb7a21fe1b0d02bdd6a10dad330b11076c70b36bf3f6e11fb8cc09cc85bc3607b8eee8e395803212cb304ecdc3a6
+  metadata.gz: 79380603529c8c27daafb342c17739fdc9a5ab7cabb0ad52abec052415316ab9cbaefba6ceea76715c1e49a4e3ec21eb23b90030add272f27a470dd825e3d5ac
+  data.tar.gz: d074e6e9a9f132707c46b8ba4320f038f06e5229aa95ba14dd67c42e4ccafe14b7191c756ce3c9b9ebada3a00d9b06beb9ed81f559231044b2362e25c27e95e0

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    briard (2.9.3)
+    briard (2.9.4)
       activesupport (>= 4.2.5, < 8.0)
       base32-url (>= 0.5.0, < 1)
       benchmark_methods (~> 0.7)

data/lib/briard/crossref_utils.rb

@@ -95,21 +95,16 @@ module Briard
 
     def insert_crossref_creators(xml)
       xml.contributors do
-        Array.wrap(creators).each_with_index do |au, index|
+        Array.wrap(creators).each_with_index do |person, index|
           xml.person_name('contributor_role' => 'author',
                           'sequence' => index.zero? ? 'first' : 'additional') do
-            insert_crossref_person(xml, au, 'author')
+            insert_crossref_person(xml, person)
           end
         end
       end
     end
 
-    def insert_crossref_person(xml, person, _type)
-      person_name = if person['familyName'].present?
-                      [person['familyName'], person['givenName']].compact.join(', ')
-                    else
-                      person['name']
-                    end
+    def insert_crossref_person(xml, person)
       xml.given_name(person['givenName']) if person['givenName'].present?
       xml.surname(person['familyName']) if person['familyName'].present?
       if person.dig('nameIdentifiers', 0, 'nameIdentifierScheme') == 'ORCID'

data/lib/briard/readers/schema_org_reader.rb

@@ -60,8 +60,8 @@ module Briard
                               'issn' => issn ? issn['content'] : nil }.compact
 
           # workaround if not all authors are included with schema.org (e.g. in Ghost metadata)
-          authors = doc.css("meta[name='citation_author']").to_a.map do |author|
-            { 'name' => author['content'] }
+          authors = doc.css("meta[name='citation_author']").map do |author|
+            { '@type' => 'Person', 'name' => author['content'] }
           end
 
           hsh['author'] = hsh['creator'] if hsh['author'].blank? && hsh['creator'].present?

data/lib/briard/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Briard
-  VERSION = '2.9.3'
+  VERSION = '2.9.4'
 end

data/spec/writers/crossref_writer_spec.rb

@@ -114,6 +114,8 @@ describe Briard::Metadata, vcr: true do
                                       'title' => 'Front Matter', 'type' => 'Blog')
       expect(subject.titles).to eq([{ 'title' => 'Editorial by more than 200 health journals: Call for emergency action to limit global temperature increases, restore biodiversity, and protect health' }])
       crossref = Maremma.from_xml(subject.crossref).dig('doi_batch', 'body', 'posted_content')
+      expect(Array.wrap(crossref.dig('contributors', 'person_name')).length).to eq(1)
+      expect(Array.wrap(crossref.dig('contributors', 'person_name')).first).to eq("ORCID"=>"https://orcid.org/0000-0003-1419-2405", "contributor_role"=>"author", "given_name"=>"Martin", "sequence"=>"first", "surname"=>"Fenner")
       expect(crossref.dig('titles',
                           'title')).to eq('Editorial by more than 200 health journals: Call for emergency action to limit global temperature increases, restore biodiversity, and protect health')
     end
@@ -174,6 +176,8 @@ describe Briard::Metadata, vcr: true do
                                           'rights' => 'Creative Commons Attribution 4.0 International', 'rightsUri' => 'https://creativecommons.org/licenses/by/4.0/legalcode', 'rightsIdentifier' => 'cc-by-4.0', 'rightsIdentifierScheme' => 'SPDX', 'schemeUri' => 'https://spdx.org/licenses/'
                                         }])
       crossref = Maremma.from_xml(subject.crossref).dig('doi_batch', 'body', 'posted_content')
+      expect(Array.wrap(crossref.dig('contributors', 'person_name')).length).to eq(4)
+      expect(Array.wrap(crossref.dig('contributors', 'person_name')).first).to eq("contributor_role"=>"author", "given_name"=>"Mohammad", "sequence"=>"first", "surname"=>"Hosseini")
       expect(crossref.dig('titles',
                           'title')).to eq('Deep dive into ethics of Contributor Roles: report of a FORCE11 workshop')
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: briard
 version: !ruby/object:Gem::Version
-  version: 2.9.3
+  version: 2.9.4
 platform: ruby
 authors:
 - Martin Fenner
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-01-12 00:00:00.000000000 Z
+date: 2023-01-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport