brazenhead 0.4 → 0.4.1

data/features/step_definitions/exception_steps.rb

@@ -1,13 +1,17 @@
 When /^I attempt to call a method that does not exist$/ do
-  @driver.should_not_exist_at_all
+  begin
+    @driver.should_not_exist_at_all
+  rescue Exception => e
+    @last_exception = e
+  end
 end
 
 Then /^I should receive an internal server error$/ do
-  @driver.last_response.code.should eq '500'
+  @last_exception.should_not be_nil
 end
 
 Then /^the exception should have detailed information$/ do
-  json = JSON.parse(@driver.last_response.body)
+  json = JSON.parse(@last_exception.message)
   json["exception"].should match ".*CommandNotFoundException"
   json["errorMessage"].should match "The \\w+\\(.*\\) method was not found on .*Solo\\."
 end

data/lib/brazenhead/device.rb

@@ -14,9 +14,10 @@ module Brazenhead
         $stderr.puts "Failed to send the command #{message} #{retries} times..."
         raise
       end
+      raise Exception, @last_response.body unless @last_response.code == "200"
       @last_response
     end
-    
+
     def stop
       http.post '/kill', ''
     end
@@ -30,6 +31,6 @@ module Brazenhead
     def http
       @http ||= Net::HTTP.new '127.0.0.1', 7777
     end
-    
+
   end
 end

data/lib/brazenhead/version.rb

@@ -1,3 +1,3 @@
 module Brazenhead
-  VERSION = "0.4"
+  VERSION = "0.4.1"
 end

data/spec/lib/brazenhead/device_spec.rb

@@ -3,9 +3,13 @@ require 'spec_helper'
 describe Brazenhead::Device do
   let(:device) { Brazenhead::Device.new }
   let(:http_mock) { double("http_mock") }
+  let(:http_response) { double("http_response") }
 
   before(:each) do
     Net::HTTP.stub(:new).and_return(http_mock)
+    device.stub(:sleep)
+    http_mock.stub(:post).and_return(http_response)
+    http_response.stub(:code).and_return('200')
   end
 
   it "should retry the http call if it fails the first time" do
@@ -24,4 +28,10 @@ describe Brazenhead::Device do
     http_mock.should_receive(:post).with('/kill', '')
     device.stop
   end
+
+  it "should raise if the status code is not ok" do
+    http_response.should_receive(:code).and_return('500')
+    http_response.stub(:body).and_return("the error message")
+    expect { device.send "blah" }.to raise_error(Exception, "the error message")
+  end
 end

data/spec/lib/brazenhead_spec.rb

@@ -8,10 +8,13 @@ describe Brazenhead do
 
   let(:driver) { Driver.new }
   let(:http_mock) { double("http_mock") }
+  let(:http_response) { double("http_response").as_null_object }
   
   context "when calling a method directly on the module" do
     before(:each) do
       Net::HTTP.stub(:new).and_return(http_mock)
+      http_mock.stub(:post).and_return(http_response)
+      http_response.stub(:code).and_return('200')
     end
     
     it "should convert method name to camel case with first letter lowercase" do
@@ -26,7 +29,8 @@ describe Brazenhead do
     end
 
     it "should make the result of the call available for inspection" do
-      http_mock.should_receive(:post).with('/', "commands=[{\"name\":\"fooBar\"}]").and_return("Success")
+      http_response.stub(:body).and_return("Success")
+      http_mock.should_receive(:post).with('/', "commands=[{\"name\":\"fooBar\"}]")
       result = driver.foo_bar
       driver.last_response.should == result
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: brazenhead
 version: !ruby/object:Gem::Version
-  version: '0.4'
+  version: 0.4.1
   prerelease: 
 platform: ruby
 authors:
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-09-20 00:00:00.000000000 Z
+date: 2012-09-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: childprocess
@@ -67,7 +67,7 @@ dependencies:
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 0.5.2
+        version: 0.5.4
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -75,7 +75,7 @@ dependencies:
     requirements:
     - - ! '>='
       - !ruby/object:Gem::Version
-        version: 0.5.2
+        version: 0.5.4
 description: Driver that accepts remote json requests and invokes methods inside Android
   emulator / device.
 email: