bravo 1.0.0.rc1 → 1.0.0.rc2

data/README.md

@@ -1,4 +1,7 @@
-# Bravo ![Travis status](https://travis-ci.org/leanucci/bravo.png)
+# Bravo 
+![Travis status](https://travis-ci.org/leanucci/bravo.png)
+[![Gem Version](https://badge.fury.io/rb/bravo.png)](http://badge.fury.io/rb/bravo)
+[![Code Climate](https://codeclimate.com/repos/5292a01e89af7e473304513a/badges/4a29fbaff3d74a23e634/gpa.png)](https://codeclimate.com/repos/5292a01e89af7e473304513a/feed)
 
 [~~Bravo~~](http://images.coveralia.com/audio/b/Bravo-Desierto_Sin_Amor-Frontal.jpg) Bravo permite la obtención del [~~C.A.E~~](http://www.muevamueva.com/masmusica/latina/cae/images/fotos.5.gif) C.A.E. (Código de Autorización Electrónico) por medio del Web Service de Facturación Electrónica provisto por AFIP.
 

data/lib/bravo.rb

@@ -2,7 +2,6 @@ require 'bundler/setup'
 require 'bravo/version'
 require 'bravo/constants'
 require 'savon'
-require 'bravo/core_ext/float'
 require 'bravo/core_ext/hash'
 require 'bravo/core_ext/string'
 
@@ -20,14 +19,13 @@ module Bravo
   # This class handles the logging options
   #
   class Logger < Struct.new(:log, :pretty_xml, :level)
-    # @param log [Boolean] wether to log or not.
-    # @param pretty_xml [Boolean] pass true to format xml in a readable way.
-    # @param level [Symbol] one of `:debug`, `:info`, `:warn`, `:error`, `:fatal`.
+    # @param opts [Hash] receives a hash with keys `log`, `pretty_xml` (both
+    # boolean) or the desired log level as `level`
 
-    def initialize(log = false, level = :debug, pretty_xml = true)
-      self.log = log
-      self.pretty_xml = pretty_xml
-      self.level = level
+    def initialize(opts = {})
+      self.log = opts[:log] || false
+      self.pretty_xml = opts[:pretty_xml] || self.log
+      self.level = opts[:level] || :debug
     end
 
     # @return [Hash] returns a hash with the proper logging optios for Savon.

data/lib/bravo/bill.rb

@@ -14,8 +14,8 @@ module Bravo
 
     def initialize(attrs = {})
       Bravo::AuthData.fetch
-      opts = { wsdl: Bravo::AuthData.wsfe_url}.merge! Bravo.logger_options
-      @client           = Savon.client(opts)
+      opts = { wsdl: Bravo::AuthData.wsfe_url }.merge! Bravo.logger_options
+      @client           ||= Savon.client(opts)
       @body             = { 'Auth' => Bravo::AuthData.auth_hash }
       self.iva_cond     = attrs[:iva_cond]
       @net              = attrs[:net]           || 0
@@ -50,8 +50,8 @@ module Bravo
     # TODO: fix this
     #
     def iva_sum
-      @iva_sum = net * Bravo::ALIC_IVA[aliciva_id][1]
-      @iva_sum.round_up_with_precision(2)
+      @iva_sum = net * applicable_iva_multiplier
+      @iva_sum.round(2)
     end
 
     # Files the authorization request to AFIP
@@ -88,7 +88,7 @@ module Bravo
                         'ImpTrib'     => 0.00,
                         'Iva'         => {
                           'AlicIva' => {
-                            'Id' => '5',
+                            'Id' => applicable_iva_code,
                             'BaseImp' => net,
                             'Importe' => iva_sum } } } } } }
 
@@ -162,5 +162,18 @@ module Bravo
       keys, values  = response_hash.to_a.transpose
       self.response = (defined?(Struct::Response) ? Struct::Response : Struct.new('Response', *keys)).new(*values)
     end
+
+    def applicable_iva
+      index = Bravo::APPLICABLE_IVA[Bravo.own_iva_cond][iva_cond]
+      Bravo::ALIC_IVA[index]
+    end
+
+    def applicable_iva_code
+      applicable_iva[0]
+    end
+
+    def applicable_iva_multiplier
+      applicable_iva[1]
+    end
   end
 end

data/lib/bravo/constants.rb

@@ -59,7 +59,16 @@ module Bravo
   #
   ALIC_IVA = [['03', 0], ['04', 0.105], ['05', 0.21], ['06', 0.27]]
 
-
+  # Applicable tax according to buyer and seller's iva condition.
+  #
+  APPLICABLE_IVA = {
+    :responsable_inscripto => {
+      responsable_inscripto: 02,
+      consumidor_final: 00,
+      exento: 00,
+      responsable_monotributo: 00
+    }
+  }
 
   # This hash keeps the codes for A document types by operation
   #
@@ -96,4 +105,4 @@ module Bravo
 
     :production => { :wsaa => 'https://wsaa.afip.gov.ar/ws/services/LoginCms',
                      :wsfe => 'https://servicios1.afip.gov.ar/wsfev1/service.asmx' } }
-end
+end

data/lib/bravo/version.rb

@@ -1,5 +1,5 @@
 module Bravo
   # Gem version
   #
-  VERSION = '1.0.0.rc1'
+  VERSION = '1.0.0.rc2'
 end

data/spec/bravo/bill_spec.rb

@@ -55,8 +55,8 @@ describe 'Bill' do
       bill.net          = 100.89
       bill.aliciva_id   = 2
 
-      bill.iva_sum.should be_within(0.05).of(21.18)
-      bill.total.should be_within(0.05).of(122.07)
+      bill.iva_sum.should be_within(0.005).of(21.19)
+      bill.total.should be_within(0.005).of(122.08)
     end
   end
 
@@ -101,7 +101,7 @@ describe 'Bill' do
           Bravo::BILL_TYPE[Bravo.own_iva_cond][target_iva_cond].keys.each do |bill_type|
             vcr_options = { cassette_name: "#{ target_iva_cond.to_s }_and_#{ bill_type }" }
             it "authorizes bill type #{ bill_type }", vcr: vcr_options do
-              bill.net          = 10000.00
+              bill.net          = 10000.88
               bill.aliciva_id   = 2
               bill.doc_num      = '30710151543'
               bill.iva_cond     = target_iva_cond

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bravo
 version: !ruby/object:Gem::Version
-  version: 1.0.0.rc1
+  version: 1.0.0.rc2
   prerelease: 6
 platform: ruby
 authors:
@@ -157,7 +157,6 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
-- VERSION
 - autotest/discover.rb
 - bin/bravo
 - bravo.gemspec
@@ -165,7 +164,6 @@ files:
 - lib/bravo/auth_data.rb
 - lib/bravo/bill.rb
 - lib/bravo/constants.rb
-- lib/bravo/core_ext/float.rb
 - lib/bravo/core_ext/hash.rb
 - lib/bravo/core_ext/string.rb
 - lib/bravo/reference.rb

data/VERSION

@@ -1 +0,0 @@
-0.3.6

data/lib/bravo/core_ext/float.rb

@@ -1,14 +0,0 @@
-# Float monkeypatching.
-#
-class Float
-  # Should be removed.
-  #
-  def round_with_precision(precision = nil)
-    precision.nil? ? round : (self * (10 ** precision)).round / (10 ** precision).to_f
-  end
-  # Should be removed.
-  #
-  def round_up_with_precision(precision = nil)
-    precision.nil? ? round : ((self * (10 ** precision)).round + 1) / (10 ** precision).to_f
-  end
-end