brakeman 4.1.0 → 4.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5473cad261403087ab82423bcb64eab734d11e8c
-  data.tar.gz: 59a9f5320cdd156c0d6202cd950238ce05a7b92f
+  metadata.gz: 8415945622378ed5786ec1a2f6a95e43da5c78dd
+  data.tar.gz: d2e4f64d195384e14dd9629af3b858a2137a631f
 SHA512:
-  metadata.gz: 72a9fc46b9385feddcb5ef032794470d68c2ce52f551f3eed00157c24e2f36015dff891f6c409a3862f78ec649c8aee2f3d373d5654f1fcfa3769d3cbf90f67c
-  data.tar.gz: 2fb4b886463bea09c6a46b78b83a507d1312d1d2f68df7d94df364d2eb374ea758f9f7fb959299a632d089288bc0b4304ec04f793708505b76f450c7e639ac9d
+  metadata.gz: 80f963fb7bea3911adb45e90648b02e105087511163568e8f6eac7b1a4efac72878fa266614f44b8483491d39be3f381f6ad55e17ae41afa82c4194116f5a635
+  data.tar.gz: 34e491a6927e409a6cc1e80c4b2c21c152aaee8ab67e9b8cbff3b5e79dd50dc66052843106964eab1e161ecc64bc3121271f7847466caaa8d348bd9c74f6aa0e

data/CHANGES.md

@@ -1,3 +1,8 @@
+# 4.1.1
+
+* Remove check for use of `permit` with `*_id` keys
+* Avoid duplicate warnings about permitted attributes
+
 # 4.1.0
 
 * Process models as root sexp instead of each sexp

data/lib/brakeman/checks/check_divide_by_zero.rb

@@ -12,6 +12,8 @@ class Brakeman::CheckDivideByZero < Brakeman::BaseCheck
   end
 
   def check_division result
+    return unless original? result
+
     call = result[:call]
 
     denominator = call.first_arg

data/lib/brakeman/checks/check_permit_attributes.rb

@@ -19,14 +19,14 @@ class Brakeman::CheckPermitAttributes < Brakeman::BaseCheck
   end
 
   def check_permit result
+    return unless original? result
+
     call = result[:call]
 
     call.each_arg do |arg|
       if symbol? arg
         if SUSPICIOUS_KEYS.key? arg.value
           warn_on_permit_key result, arg
-        elsif arg.value.match /_id$/
-          warn_on_permit_key result, arg, :medium
         end
       end
     end

data/lib/brakeman/version.rb

@@ -1,3 +1,3 @@
 module Brakeman
-  Version = "4.1.0"
+  Version = "4.1.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: brakeman
 version: !ruby/object:Gem::Version
-  version: 4.1.0
+  version: 4.1.1
 platform: ruby
 authors:
 - Justin Collins
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain:
 - brakeman-public_cert.pem
-date: 2017-12-14 00:00:00.000000000 Z
+date: 2017-12-19 00:00:00.000000000 Z
 dependencies: []
 description: Brakeman detects security vulnerabilities in Ruby on Rails applications
   via static analysis.