brakeman-min 3.2.0.pre1 → 3.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e1db53f4a7deaf2e3b3cade6acd5cac5e88f285f
-  data.tar.gz: 274429ac40d7afbdd8ac1d9caffbc5a3b5ebcdcb
+  metadata.gz: d877e6547bb9f0ceb4208cf36a29c3c71746d72e
+  data.tar.gz: 3350445ee21e3cfa3f8312840256540b7dae307c
 SHA512:
-  metadata.gz: e721a649d7dbc8d8dab8690ebe1dc166ba441610b85364c324a1caeaa6d49f45cc09d2329a37000d2c09bfa8de38cd5377a34a0869d4743073fd0fd53f8cbc45
-  data.tar.gz: 85a9eb5190847ebb9135e0496c69a103e30fdbbdf166e0d996c37ada9223578f69ab5f3151ad0e23d900ab9621dc5873bb130a643e41d33d759c0a4efbc09b27
+  metadata.gz: 04a24ded2a015de7ec238d3be912e9699edbcdabb2cb5d4007ed78571ce3b4cd296b5e8c6ab2396a5cc20131d71780d98c3beb133b598499e3619057fb6746c7
+  data.tar.gz: 432cc143fce3f9679a7bf41cfcf70da63d3d1c6da0e244b1d4a8ebb3fdc97279a4f47749bc8d38d18e97fd1de1e251df027c3d6df9a216aca44087e9b5042f45

data/CHANGES

@@ -1,5 +1,8 @@
-# 3.2.0.pre1
+# 3.2.0
 
+* Skip Symbol DoS check on Rails 5
+* Only update ignore config file on changes
+* Sort ignore config file
 * Support calls using `&.` operator
 * Update ruby_parser dependency to 3.8.1
 * Remove `fastercsv` dependency

data/lib/brakeman/checks/check_symbol_dos.rb

@@ -8,6 +8,8 @@ class Brakeman::CheckSymbolDoS < Brakeman::BaseCheck
   @description = "Checks for symbol denial of service"
 
   def run_check
+    return if rails_version > "5.0.0"
+
     tracker.find_call(:methods => UNSAFE_METHODS, :nested => true).each do |result|
       check_unsafe_symbol_creation(result)
     end

data/lib/brakeman/report/ignore/config.rb

@@ -13,6 +13,7 @@ module Brakeman
       @ignored_fingerprints = Set.new
       @notes = {}
       @shown_warnings = @ignored_warnings = nil
+      @changed = false
     end
 
     # Populate ignored_warnings and shown_warnings based on ignore
@@ -35,8 +36,8 @@ module Brakeman
     # Remove warning from ignored list
     def unignore warning
       @ignored_fingerprints.delete warning.fingerprint
-      @already_ignored.reject! do |w|
-        w[:fingerprint] == warning.fingerprint
+      if @already_ignored.reject! { |w|w[:fingerprint] == warning.fingerprint }
+        @changed = true
       end
     end
 
@@ -46,11 +47,13 @@ module Brakeman
     end
 
     def ignore warning
+      @changed = true unless ignored? warning
       @ignored_fingerprints << warning.fingerprint
     end
 
     # Add note for warning
     def add_note warning, note
+      @changed = true
       @notes[warning.fingerprint] = note
     end
 
@@ -98,7 +101,7 @@ module Brakeman
 
         w[:note] = @notes[w[:fingerprint]] || ""
         w
-      end
+      end.sort_by { |w| w[:fingerprint] }
 
       output = {
         :ignored_warnings => warnings,
@@ -124,7 +127,9 @@ module Brakeman
         end
       end
 
-      save_to_file warnings
+      if @changed
+        save_to_file warnings
+      end
     end
   end
 end

data/lib/brakeman/version.rb

@@ -1,3 +1,3 @@
 module Brakeman
-  Version = "3.2.0.pre1"
+  Version = "3.2.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: brakeman-min
 version: !ruby/object:Gem::Version
-  version: 3.2.0.pre1
+  version: 3.2.0
 platform: ruby
 authors:
 - Justin Collins
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain:
 - brakeman-public_cert.pem
-date: 2016-02-22 00:00:00.000000000 Z
+date: 2016-02-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: test-unit
@@ -245,9 +245,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: 1.3.1
+      version: '0'
 requirements: []
 rubyforge_project: 
 rubygems_version: 2.4.8