brainzlab 0.1.32 → 0.1.33

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2c27f671d247f5b7274905767ed060ec3bfc90c7e2389b8fe117fb300c09a59b
-  data.tar.gz: 3af6ac68bd7042f00aa16defa1c68d170653a9b053fe98cb375760b6f72bc14a
+  metadata.gz: a9a9a15a426d4a6853086c9a36851e57bd14736c5d11dbeb70fb510fe5fc1c10
+  data.tar.gz: 19f26af342b3d9150eacb2615da08fa063cc671388f7b97a87b207cd210cf6fc
 SHA512:
-  metadata.gz: 571ec070d0ff6d1f3503245a6c0e201d4d81903fda8a0d6ddf316ae7148c4bee6deb93299b76e5fc22839747d9f827cbf68da46dc04cb7d01abf2685580fb647
-  data.tar.gz: 9af9570ce725917a5093a9efbc46f81b13c454bb044549057eb49e43fa717e2750d28d580db055171bcb7e9d4c2cc2173e283bb47e7154510a16f1c82ac2ee3e
+  metadata.gz: b149c1fbf2c0f13fa34d0b2d2e6df634a1dc01f087f8174ba58fcc0bf05ea0301365721131e03441bf0af7e3b443d5a86acc5dfa141ba4fa9af2c24c610782a9
+  data.tar.gz: 737cd856a43c4c3555a566653692fd32d04798e464e24bad80d189610b82e81c0d0b2860cda232fae66063477b21687858c14e5178050a771af6745b9741d46f

data/lib/brainzlab/configuration.rb

@@ -43,6 +43,7 @@ module BrainzLab
                   :pulse_flush_interval,
                   :pulse_sample_rate,
                   :pulse_sample_tier,
+                  :pulse_always_keep_slow_ms,
                   :pulse_excluded_paths,
                   :flux_enabled,
                   :flux_url,
@@ -261,6 +262,10 @@ module BrainzLab
       # BRAINZLAB_PULSE_TIER=client (or PULSE_SAMPLE_RATE) to keep everything.
       @pulse_sample_rate = (v = ENV['PULSE_SAMPLE_RATE'] || ENV['BRAINZLAB_PULSE_SAMPLE_RATE']).nil? || v.to_s.strip.empty? ? nil : v.to_f
       @pulse_sample_tier = (ENV['BRAINZLAB_PULSE_TIER'] || 'internal').to_s.strip.downcase
+      # Traces at/above this duration (ms) bypass sampling and are ALWAYS kept,
+      # so slow requests / N+1s are never sampled away (APM's whole purpose).
+      # Set to 0 to disable. Default 1000ms.
+      @pulse_always_keep_slow_ms = (ENV['BRAINZLAB_PULSE_ALWAYS_KEEP_SLOW_MS'] || 1000).to_i
       @pulse_excluded_paths = %w[/health /ping /up /assets]
 
       # Flux settings

data/lib/brainzlab/pulse/client.rb

@@ -72,11 +72,24 @@ module BrainzLab
       # effective per-tier sample rate (internal=0.1, standard=0.5, client=1.0).
       def keep_trace?(payload)
         return true if payload[:error] == true || payload['error'] == true
+        # Always keep SLOW traces, regardless of sampling. Surfacing slow
+        # requests (N+1s, slow endpoints) is the whole point of APM — sampling
+        # them out blinds debugging, which is exactly how an inquiries-page N+1
+        # stayed invisible on a 10%-sampled app.
+        return true if slow_trace?(payload)
 
         rate = @config.effective_pulse_sample_rate
         rate >= 1.0 || rand < rate
       end
 
+      def slow_trace?(payload)
+        threshold = @config.pulse_always_keep_slow_ms.to_i
+        return false unless threshold.positive?
+
+        duration = payload[:duration_ms] || payload['duration_ms']
+        !duration.nil? && duration.to_f >= threshold
+      end
+
       def buffer_trace(payload)
         should_flush = false
 

data/lib/brainzlab/pulse/tracer.rb

@@ -44,8 +44,8 @@ module BrainzLab
         duration_ms = ((ended_at - trace[:started_at]) * 1000).round(2)
 
         payload = trace.merge(
-          ended_at: ended_at.iso8601(3),
-          started_at: trace[:started_at].utc.iso8601(3),
+          ended_at: iso_ts(ended_at),
+          started_at: iso_ts(trace[:started_at]),
           duration_ms: duration_ms,
           error: error,
           error_class: error_class,
@@ -99,8 +99,8 @@ module BrainzLab
           parent_span_id: span[:parent_span_id],
           name: span[:name],
           kind: span[:kind],
-          started_at: span[:started_at].utc.iso8601(3),
-          ended_at: span[:ended_at].utc.iso8601(3),
+          started_at: iso_ts(span[:started_at]),
+          ended_at: iso_ts(span[:ended_at]),
           duration_ms: span[:duration_ms],
           error: span[:error],
           error_class: span[:error_class],
@@ -108,6 +108,21 @@ module BrainzLab
           data: span[:data]
         }.compact
       end
+
+      # Rails 8 changed ActiveSupport::Notifications::Event#time/#end to return a
+      # Float (monotonic), so spans carry Float timestamps. Calling #utc on them
+      # raised NoMethodError, crashing trace serialization (error/job traces) on
+      # Rails 8 apps. Coerce Time/Float/Integer/String safely.
+      def iso_ts(ts)
+        return nil if ts.nil?
+
+        case ts
+        when Time, DateTime then ts.utc.iso8601(3)
+        when Numeric then Time.at(ts).utc.iso8601(3)
+        when String then ts
+        else ts.to_s
+        end
+      end
     end
   end
 end

data/lib/brainzlab/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module BrainzLab
-  VERSION = '0.1.32'
+  VERSION = '0.1.33'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: brainzlab
 version: !ruby/object:Gem::Version
-  version: 0.1.32
+  version: 0.1.33
 platform: ruby
 authors:
 - BrainzLab