braintreehttp 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a1895d2c71835653fc56bb8c44efab4651ebf32a
-  data.tar.gz: 4af18f05b407730beb152f2c424d62e13bcea989
+  metadata.gz: 599e49054f1dc90ce4af2229aba6e6bb6140143e
+  data.tar.gz: d9582efa699f71babf7f411744ca33efb34f2f46
 SHA512:
-  metadata.gz: 2683781ee86d293c2eb2bef08ae7e3911f0c72f6f1bb640e115755030a06f23e25c3784426190d4d3398e4cbbf86d997a661f43a5a9f2bfcf83a282e59b92774
-  data.tar.gz: c7fce1281552eff1c106aa421d599abc5cafbdbeb62a59a6a2660e5ee2f13928c702ada3161ecaf4a18b832ce82751f4a5b82f5e93eb17b317ae769ed1a21224
+  metadata.gz: 2e0fca1e69a0bf2bac1e6445bfc67d433c8323d8cdeeabe3b08437ec5c3fe1a0ce1225b0f68e98d0e72495c0e63905509f57af407c04a6ca2788994abb686e16
+  data.tar.gz: e1c67247bcf30af276952d34601a868d905b99e25cdcb1725ed6d7f66c95a1d5c08075a0b888cbd55212f153ee73dc510a67826302a8769f06613f1cb8ef5357

data/braintreehttp.gemspec

@@ -4,7 +4,7 @@ Gem::Specification.new do |s|
   s.name = "braintreehttp"
   s.summary = "BraintreeHttp Client Library"
   s.description = "Used for generated API clients"
-  s.version = "0.1.2"
+  s.version = "0.1.3"
   s.license = "MIT"
   s.author = "Braintree"
   s.email = "code@getbraintree.com"

data/lib/braintreehttp/errors.rb

@@ -1,5 +1,5 @@
 module BraintreeHttp
-  class ServiceIOError < IOError
+  class HttpError < IOError
     attr_accessor :status_code, :result, :headers
     def initialize(status_code, result, headers)
       @status_code = status_code

data/lib/braintreehttp/http_client.rb

@@ -19,8 +19,8 @@ module BraintreeHttp
       "BraintreeHttp-Ruby HTTP/1.1"
     end
 
-    def add_injector(inj)
-      @injectors << inj
+    def add_injector(&block)
+      @injectors << block
     end
 
     def has_body(request)
@@ -33,7 +33,7 @@ module BraintreeHttp
       end
 
       @injectors.each do |injector|
-        injector.inject(request)
+        injector.call(request)
       end
 
       if !request.headers["User-Agent"] || request.headers["User-Agent"] == "Ruby"
@@ -109,7 +109,7 @@ module BraintreeHttp
       headers = response.to_hash
       if result && !result.empty?
         deserialized = deserialize_response(response.body, headers)
-        if deserialized.is_a? String
+        if deserialized.is_a?(String) || deserialized.is_a?(Array)
           result = deserialized
         else
           result = OpenStruct.new(deserialized)
@@ -127,7 +127,7 @@ module BraintreeHttp
       if status_code >= 200 and status_code < 300
         return obj
       elsif
-        raise ServiceIOError.new(obj.status_code, obj.result, obj.headers)
+        raise HttpError.new(obj.status_code, obj.result, obj.headers)
       end
     end
   end

data/lib/braintreehttp.rb

@@ -1,6 +1,5 @@
 module BraintreeHttp
   require_relative "braintreehttp/environment"
-  require_relative "braintreehttp/injector"
   require_relative "braintreehttp/http_client"
   require_relative "braintreehttp/errors"
   require_relative "braintreehttp/encoder"

data/spec/braintreehttp/http_client_spec.rb

@@ -13,13 +13,10 @@ describe HttpClient do
 
     http_client = HttpClient.new(@environment)
 
-    class CustomInjector < Injector
-      def inject(request)
-        request.headers["Some-Key"] = "Some Value"
-      end
+    http_client.add_injector do |request|
+      request.headers["Some-Key"] = "Some Value"
     end
 
-    http_client.add_injector(CustomInjector.new)
     req = OpenStruct.new({:verb => "GET", :path => "/"})
 
     stub_request(:any, @environment.base_url)
@@ -190,6 +187,23 @@ describe HttpClient do
     expect(resp.result).to eq('something else')
   end
 
+  it 'handles json array result' do
+    WebMock.enable!
+
+    return_data = ["one", "two"]
+
+    http_client = HttpClient.new(@environment)
+
+    stub_request(:get, @environment.base_url + "/v1/api")
+      .to_return(body: JSON.generate(return_data), status: 200, headers: {"Content-Type" => "application/json"})
+
+    req = OpenStruct.new({:verb => "GET", :path => "/v1/api"})
+
+    resp = http_client.execute(req)
+
+    expect(resp.result).to eq(return_data)
+  end
+
   it "encodes multipart/form-data when a file is present without body" do
     WebMock.enable!
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: braintreehttp
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Braintree
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-10 00:00:00.000000000 Z
+date: 2017-08-15 00:00:00.000000000 Z
 dependencies: []
 description: Used for generated API clients
 email: code@getbraintree.com
@@ -22,7 +22,6 @@ files:
 - lib/braintreehttp/environment.rb
 - lib/braintreehttp/errors.rb
 - lib/braintreehttp/http_client.rb
-- lib/braintreehttp/injector.rb
 - spec/braintreehttp/encoder_spec.rb
 - spec/braintreehttp/http_client_spec.rb
 - spec/spec_helper.rb

data/lib/braintreehttp/injector.rb

@@ -1,7 +0,0 @@
-module BraintreeHttp
-  class Injector
-    def inject(request)
-      raise NotImplementedError, "Injectors must implement inject"
-    end
-  end
-end