braintree 4.18.0 → 4.19.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b8d5039746bfcbc33e3899cb43cf5a014084278543b5c83ea0b09146a0c0b63b
-  data.tar.gz: 688a569cbff984a1d6a0571095a7f990efda7ce717ee9393c93263f8b9007f80
+  metadata.gz: f43df747b2db22253268db6e5f01b79ea162b6c0911125b056b7bab73684dd3f
+  data.tar.gz: 6fad0280817f00e0c0e3e8c6ef3761a5bd20d3e3a777a9f91182e556fad59aba
 SHA512:
-  metadata.gz: df005acb10a67bdcf42ab131f49b93f595ad9431004922502b255c54d4222960e54a344a018abd0175c3b340d8474215a1f49b0a210b590fbe78fe020bf7daf1
-  data.tar.gz: 783676045da0d1240f5b9cd808149f04fd9a7005c99015ff5ec07ff0a0ffcf4093e1e0ab896334f2e7e0f953829a62b8532130a3057bef5c344d506c58064d67
+  metadata.gz: 7e6aa6b5b10734d82c66f9f7f315c5759700412ddda2642e2424f71c8be71aca06d35aa77b69936514c8e3d0ddc2e5dd24d479e8c4359ff9d67e43222ebe0256
+  data.tar.gz: f762c62cadc6476aebfc9f0f2aee72bd254b32b93c1c069c22c67661482ac433b2598ff1f86f2f1cad943dcf28878bac4f3293025d7b45e26cb34aec3c6fbc81

data/lib/braintree/advanced_search.rb

@@ -80,8 +80,7 @@ module Braintree
       operators :is
 
       def between(min, max)
-        self >= min
-        self <= max
+        self >= min && self <= max
       end
 
       def >=(min)

data/lib/braintree/configuration.rb

@@ -72,7 +72,7 @@ module Braintree
     end
 
     def self.instantiate
-      config = new(
+      new(
         :custom_user_agent => @custom_user_agent,
         :endpoint => @endpoint,
         :environment => environment,

data/lib/braintree/disbursement.rb

@@ -29,7 +29,7 @@ module Braintree
     end
 
     def transactions
-      transactions = @gateway.transaction.search do |search|
+      @gateway.transaction.search do |search|
         search.ids.in transaction_ids
       end
     end

data/lib/braintree/dispute.rb

@@ -43,6 +43,7 @@ module Braintree
       Expired = "expired"
       Open = "open"
       Lost = "lost"
+      UnderReview = "under_review"
       Won = "won"
 
       All = constants.map { |c| const_get(c) }

data/lib/braintree/http.rb

@@ -8,7 +8,6 @@ module Braintree
     end
 
     def delete(path, query_params = {})
-      full_path = path + _build_query_string(query_params)
       response = _http_do Net::HTTP::Delete, path
       if response.code.to_i == 200 || response.code.to_i == 204
         true
@@ -20,7 +19,6 @@ module Braintree
     end
 
     def get(path, query_params = {})
-      full_path = path + _build_query_string(query_params)
       response = _http_do Net::HTTP::Get, path
       if response.code.to_i == 200 || response.code.to_i == 422
         Xml.hash_from_xml(_body(response))
@@ -69,7 +67,7 @@ module Braintree
 
     def _setup_connection(server = @config.server, port = @config.port)
       if @config.proxy_address
-        connection = Net::HTTP.new(
+        Net::HTTP.new(
           server,
           port,
           @config.proxy_address,
@@ -78,7 +76,7 @@ module Braintree
           @config.proxy_pass,
         )
       else
-        connection = Net::HTTP.new(server, port)
+        Net::HTTP.new(server, port)
       end
     end
 

data/lib/braintree/util.rb

@@ -191,7 +191,7 @@ module Braintree
     def self._get_invalid_keys(valid_keys, hash)
       flattened_valid_keys = _flatten_valid_keys(valid_keys)
       keys = _flatten_hash_keys(hash) - flattened_valid_keys
-      keys = _remove_wildcard_keys(flattened_valid_keys, keys)
+      _remove_wildcard_keys(flattened_valid_keys, keys)
     end
 
     module IdEquality

data/lib/braintree/version.rb

@@ -1,7 +1,7 @@
 module Braintree
   module Version
     Major = 4
-    Minor = 18
+    Minor = 19
     Tiny = 0
 
     String = "#{Major}.#{Minor}.#{Tiny}"

data/lib/braintree/webhook_notification.rb

@@ -15,13 +15,14 @@ module Braintree
       Disbursement = "disbursement"
       DisbursementException = "disbursement_exception"
 
-      DisputeOpened = "dispute_opened"
-      DisputeLost = "dispute_lost"
-      DisputeWon = "dispute_won"
       DisputeAccepted = "dispute_accepted"
       DisputeAutoAccepted = "dispute_auto_accepted"
       DisputeDisputed = "dispute_disputed"
       DisputeExpired = "dispute_expired"
+      DisputeLost = "dispute_lost"
+      DisputeOpened = "dispute_opened"
+      DisputeUnderReview = "dispute_under_review"
+      DisputeWon = "dispute_won"
 
       GrantedPaymentInstrumentRevoked = "granted_payment_instrument_revoked"
 

data/lib/braintree/webhook_testing_gateway.rb

@@ -34,12 +34,6 @@ module Braintree
       case kind
       when Braintree::WebhookNotification::Kind::Check
         _check
-      when Braintree::WebhookNotification::Kind::DisputeOpened
-        _dispute_opened_sample_xml(id)
-      when Braintree::WebhookNotification::Kind::DisputeLost
-        _dispute_lost_sample_xml(id)
-      when Braintree::WebhookNotification::Kind::DisputeWon
-        _dispute_won_sample_xml(id)
       when Braintree::WebhookNotification::Kind::DisputeAccepted
         _dispute_accepted_sample_xml(id)
       when Braintree::WebhookNotification::Kind::DisputeAutoAccepted
@@ -48,6 +42,14 @@ module Braintree
         _dispute_disputed_sample_xml(id)
       when Braintree::WebhookNotification::Kind::DisputeExpired
         _dispute_expired_sample_xml(id)
+      when Braintree::WebhookNotification::Kind::DisputeLost
+        _dispute_lost_sample_xml(id)
+      when Braintree::WebhookNotification::Kind::DisputeOpened
+        _dispute_opened_sample_xml(id)
+      when Braintree::WebhookNotification::Kind::DisputeUnderReview
+        _dispute_under_review_sample_xml(id)
+      when Braintree::WebhookNotification::Kind::DisputeWon
+        _dispute_won_sample_xml(id)
       when Braintree::WebhookNotification::Kind::PartnerMerchantConnected
         _partner_merchant_connected_sample_xml(id)
       when Braintree::WebhookNotification::Kind::PartnerMerchantDisconnected
@@ -324,6 +326,14 @@ module Braintree
       XML
     end
 
+    def _dispute_under_review_sample_xml(id)
+      if id == "legacy_dispute_id"
+        _old_dispute_under_review_sample_xml(id)
+      else
+        _new_dispute_under_review_sample_xml(id)
+      end
+    end
+
     def _dispute_opened_sample_xml(id)
       if id == "legacy_dispute_id"
         _old_dispute_opened_sample_xml(id)
@@ -380,6 +390,26 @@ module Braintree
       end
     end
 
+    def _old_dispute_under_review_sample_xml(id)
+      <<-XML
+        <dispute>
+          <amount>100.00</amount>
+          <currency-iso-code>USD</currency-iso-code>
+          <received-date type="date">2014-03-01</received-date>
+          <reply-by-date type="date">2014-03-21</reply-by-date>
+          <kind>chargeback</kind>
+          <status>under_review</status>
+          <reason>fraud</reason>
+          <id>#{id}</id>
+          <transaction>
+            <id>#{id}</id>
+            <amount>100.00</amount>
+          </transaction>
+          <date-opened type=\"date\">2014-03-21</date-opened>
+        </dispute>
+      XML
+    end
+
     def _old_dispute_opened_sample_xml(id)
       <<-XML
         <dispute>
@@ -521,6 +551,48 @@ module Braintree
       XML
     end
 
+    def _new_dispute_under_review_sample_xml(id)
+      <<-XML
+        <dispute>
+          <id>#{id}</id>
+          <amount>100.00</amount>
+          <amount-disputed>100.00</amount-disputed>
+          <amount-won>95.00</amount-won>
+          <case-number>CASE-12345</case-number>
+          <created-at type="datetime">2017-06-16T20:44:41Z</created-at>
+          <currency-iso-code>USD</currency-iso-code>
+          <forwarded-comments nil="true"/>
+          <kind>chargeback</kind>
+          <merchant-account-id>ytnlulaloidoqwvzxjrdqputg</merchant-account-id>
+          <reason>fraud</reason>
+          <reason-code nil="true"/>
+          <reason-description nil="true"/>
+          <received-date type="date">2016-02-15</received-date>
+          <reference-number>REF-9876</reference-number>
+          <reply-by-date type="date">2016-02-22</reply-by-date>
+          <status>under_review</status>
+          <updated-at type="datetime">2017-06-16T20:44:41Z</updated-at>
+          <original-dispute-id>9qde5qgp</original-dispute-id>
+          <status-history type="array">
+            <status-history>
+              <status>under_review</status>
+              <timestamp type="datetime">2017-06-16T20:44:41Z</timestamp>
+            </status-history>
+          </status-history>
+          <evidence type="array"/>
+          <transaction>
+            <id>#{id}</id>
+            <amount>100.00</amount>
+            <created-at>2017-06-21T20:44:41Z</created-at>
+            <order-id nil="true"/>
+            <purchase-order-number nil="true"/>
+            <payment-instrument-subtype>Visa</payment-instrument-subtype>
+          </transaction>
+          <date-opened type=\"date\">2014-03-21</date-opened>
+        </dispute>
+      XML
+    end
+
     def _new_dispute_opened_sample_xml(id)
       <<-XML
         <dispute>

data/lib/braintree/xml/parser.rb

@@ -32,7 +32,7 @@ module Braintree
         case value.class.to_s
           when "Hash"
             if value["type"] == "array"
-              child_key, entries = value.detect { |k,_v| k != "type" }   # child_key is throwaway
+              _child_key, entries = value.detect { |k,_v| k != "type" }   # child_key is throwaway
               if entries.nil? || ((c = value[CONTENT_ROOT]) && c.strip.empty?)
                 []
               else
@@ -47,7 +47,7 @@ module Braintree
               end
             elsif value.has_key?(CONTENT_ROOT)
               content = value[CONTENT_ROOT]
-              if (parser = XML_PARSING[value["type"]])
+              if (XML_PARSING[value["type"]])
                 XML_PARSING[value["type"]].call(content)
               else
                 content

data/spec/integration/braintree/address_spec.rb

@@ -203,7 +203,7 @@ describe Braintree::Address do
 
     it "raises a NotFoundError if it cannot be found because of address id" do
       customer = Braintree::Customer.create!(:last_name => "Wilson")
-      address = Braintree::Address.create!(:customer_id => customer.id, :street_address => "123 E Main St")
+      Braintree::Address.create!(:customer_id => customer.id, :street_address => "123 E Main St")
       expect do
         Braintree::Address.find(customer, "invalid")
       end.to raise_error(
@@ -215,7 +215,7 @@ describe Braintree::Address do
   describe "self.update" do
     it "raises NotFoundError if the address can't be found" do
       customer = Braintree::Customer.create!(:last_name => "Wilson")
-      address = Braintree::Address.create!(:customer_id => customer.id, :street_address => "123 E Main St")
+      Braintree::Address.create!(:customer_id => customer.id, :street_address => "123 E Main St")
       expect do
         Braintree::Address.update(customer.id, "bad-id", {})
       end.to raise_error(Braintree::NotFoundError)
@@ -293,7 +293,7 @@ describe Braintree::Address do
   describe "self.update!" do
     it "raises NotFoundError if the address can't be found" do
       customer = Braintree::Customer.create!(:last_name => "Wilson")
-      address = Braintree::Address.create!(:customer_id => customer.id, :street_address => "123 E Main St")
+      Braintree::Address.create!(:customer_id => customer.id, :street_address => "123 E Main St")
       expect do
         Braintree::Address.update!(customer.id, "bad-id", {})
       end.to raise_error(Braintree::NotFoundError)

data/spec/integration/braintree/advanced_search_spec.rb

@@ -263,19 +263,19 @@ describe Braintree::AdvancedSearch do
   context "multiple_value_or_text_field" do
     describe "in" do
       it "works for the in operator" do
-        subscription1 = Braintree::Subscription.create(
+        Braintree::Subscription.create(
           :payment_method_token => @credit_card.token,
           :plan_id => SpecHelper::TriallessPlan[:id],
           :price => "17",
         ).subscription
 
-        subscription2 = Braintree::Subscription.create(
+        Braintree::Subscription.create(
           :payment_method_token => @credit_card.token,
           :plan_id => SpecHelper::TrialPlan[:id],
           :price => "17",
         ).subscription
 
-        subscription3 = Braintree::Subscription.create(
+        Braintree::Subscription.create(
           :payment_method_token => @credit_card.token,
           :plan_id => SpecHelper::AddOnDiscountPlan[:id],
           :price => "17",

data/spec/integration/braintree/client_api/client_token_spec.rb

@@ -28,14 +28,12 @@ describe Braintree::ClientToken do
 
     describe "version" do
       it "allows a client token version to be specified" do
-        config = Braintree::Configuration.instantiate
         client_token_string = Braintree::ClientToken.generate(:version => 1)
         client_token = JSON.parse(client_token_string)
         expect(client_token["version"]).to eq(1)
       end
 
       it "defaults to 2" do
-        config = Braintree::Configuration.instantiate
         client_token_string = Braintree::ClientToken.generate
         client_token = decode_client_token(client_token_string)
         expect(client_token["version"]).to eq(2)

data/spec/integration/braintree/client_api/spec_helper.rb

@@ -144,7 +144,7 @@ def generate_invalid_us_bank_account_nonce
   nonce_characters = "bcdfghjkmnpqrstvwxyz23456789".chars.to_a
   nonce = "tokenusbankacct_"
   nonce += 4.times.map { sample(nonce_characters) }.join("_")
-  nonce += "_xxx"
+  nonce + "_xxx"
 end
 
 def _cosmos_post(token, url, payload)

data/spec/integration/braintree/credit_card_spec.rb

@@ -322,16 +322,15 @@ describe Braintree::CreditCard do
       expect(result.success?).to eq(true)
 
       three_d_secure_info = result.credit_card.verification.three_d_secure_info
-      expect(three_d_secure_info.enrolled).to eq("Y")
+      expect(three_d_secure_info.status).to eq("authenticate_successful")
       expect(three_d_secure_info).to be_liability_shifted
       expect(three_d_secure_info).to be_liability_shift_possible
-      expect(three_d_secure_info.status).to eq("authenticate_successful")
-      expect(three_d_secure_info.cavv).to eq("cavv_value")
-      expect(three_d_secure_info.xid).to eq("xid_value")
-      expect(three_d_secure_info.eci_flag).to eq("05")
-      expect(three_d_secure_info.three_d_secure_version).to eq("1.0.2")
-      expect(three_d_secure_info.ds_transaction_id).to eq(nil)
-      expect(three_d_secure_info.three_d_secure_authentication_id).not_to be_nil
+      expect(three_d_secure_info.enrolled).to be_a(String)
+      expect(three_d_secure_info.cavv).to be_a(String)
+      expect(three_d_secure_info.xid).to be_a(String)
+      expect(three_d_secure_info.eci_flag).to be_a(String)
+      expect(three_d_secure_info.three_d_secure_version).to be_a(String)
+      expect(three_d_secure_info.three_d_secure_authentication_id).to be_a(String)
     end
 
     it "adds credit card with billing address to customer" do
@@ -649,7 +648,6 @@ describe Braintree::CreditCard do
       end
 
       it "errors with invalid account_type" do
-        customer = Braintree::Customer.create!
         result = Braintree::CreditCard.create(
           :number => Braintree::Test::CreditCardNumbers::Hiper,
           :expiration_month => "11",
@@ -666,7 +664,6 @@ describe Braintree::CreditCard do
       end
 
       it "errors when account_type not supported by merchant" do
-        customer = Braintree::Customer.create!
         result = Braintree::CreditCard.create(
           :number => Braintree::Test::CreditCardNumbers::Visa,
           :expiration_month => "11",

data/spec/integration/braintree/credit_card_verification_spec.rb

@@ -283,7 +283,7 @@ describe Braintree::CreditCardVerification, "search" do
       it "returns prepaid on a prepaid card" do
         cardholder_name = "Tom #{rand(1_000_000)} Smith"
 
-        result = Braintree::Customer.create(
+        Braintree::Customer.create(
           :credit_card => {
           :cardholder_name => cardholder_name,
           :expiration_date => "05/2012",

data/spec/integration/braintree/customer_spec.rb

@@ -924,11 +924,11 @@ describe Braintree::Customer do
           },
         ).credit_card
 
-        subscription = Braintree::Subscription.create(
+        Braintree::Subscription.create(
           :payment_method_token => credit_card.token,
           :plan_id => "integration_trialless_plan",
           :price => "1.00",
-        ).subscription
+        )
 
         found_customer = Braintree::Customer.find(customer.id, {
           :association_filter_id => "customernoassociations"
@@ -958,11 +958,11 @@ describe Braintree::Customer do
           },
         ).credit_card
 
-        subscription = Braintree::Subscription.create(
+        Braintree::Subscription.create(
           :payment_method_token => credit_card.token,
           :plan_id => "integration_trialless_plan",
           :price => "1.00",
-        ).subscription
+        )
 
         found_customer = Braintree::Customer.find(customer.id, {
          :association_filter_id =>  "customertoplevelassociations"
@@ -1233,7 +1233,7 @@ describe Braintree::Customer do
 
       token1 = random_payment_method_token
 
-      payment_method1 = Braintree::PaymentMethod.create(
+      Braintree::PaymentMethod.create(
         :customer_id => customer.id,
         :payment_method_nonce => Braintree::Test::Nonce::TransactableVisa,
         :token => token1,
@@ -1244,7 +1244,7 @@ describe Braintree::Customer do
 
       token2 = random_payment_method_token
 
-      payment_method2 = Braintree::PaymentMethod.create(
+      Braintree::PaymentMethod.create(
         :customer_id => customer.id,
         :payment_method_nonce => Braintree::Test::Nonce::TransactableMasterCard,
         :token => token2,
@@ -1266,7 +1266,7 @@ describe Braintree::Customer do
 
       token1 = random_payment_method_token
 
-      payment_method1 = Braintree::PaymentMethod.create(
+      Braintree::PaymentMethod.create(
         :customer_id => customer.id,
         :payment_method_nonce => Braintree::Test::Nonce::TransactableVisa,
         :token => token1,
@@ -1277,7 +1277,7 @@ describe Braintree::Customer do
 
       token2 = random_payment_method_token
 
-      payment_method2 = Braintree::PaymentMethod.create(
+      Braintree::PaymentMethod.create(
         :customer_id => customer.id,
         :payment_method_nonce => Braintree::Test::Nonce::TransactableMasterCard,
         :token => token2,

data/spec/integration/braintree/dispute_search_spec.rb

@@ -74,7 +74,6 @@ describe Braintree::Dispute, "search" do
       end
 
       expect(collection.disputes.count).to be >= 2
-      dispute = collection.disputes.first
     end
 
     it "correctly returns disputes by chargeback protection level flag" do

data/spec/integration/braintree/dispute_spec.rb

@@ -6,7 +6,7 @@ describe Braintree::Dispute do
   let(:document_upload) do
     file = File.new("#{File.dirname(__FILE__)}/../../fixtures/files/bt_logo.png", "r")
     response = Braintree::DocumentUpload.create({:kind => Braintree::DocumentUpload::Kind::EvidenceDocument, :file => file})
-    document_upload = response.document_upload
+    response.document_upload
   end
 
   let(:transaction) do

data/spec/integration/braintree/document_upload_spec.rb

@@ -67,7 +67,7 @@ describe Braintree::DocumentUploadGateway do
 
     it "returns invalid keys error if signature is invalid" do
       expect do
-        response = Braintree::DocumentUpload.create({:invalid_key => "do not add", :kind => Braintree::DocumentUpload::Kind::EvidenceDocument})
+        Braintree::DocumentUpload.create({:invalid_key => "do not add", :kind => Braintree::DocumentUpload::Kind::EvidenceDocument})
       end.to raise_error(ArgumentError, "invalid keys: invalid_key")
     end
   end

data/spec/integration/braintree/http_spec.rb

@@ -255,7 +255,6 @@ describe Braintree::Http do
         old_logger = Braintree::Configuration.logger
         output = StringIO.new
         Braintree::Configuration.logger = Logger.new(output)
-        utc_or_gmt = Time.now.utc.strftime("%Z")
         context = OpenSSL::X509::StoreContext.new(OpenSSL::X509::Store.new)
         context.error = 19
         expect(Braintree::Configuration.instantiate.http._verify_ssl_certificate(false, context)).to eq(false)
@@ -270,7 +269,6 @@ describe Braintree::Http do
         old_logger = Braintree::Configuration.logger
         output = StringIO.new
         Braintree::Configuration.logger = Logger.new(output)
-        utc_or_gmt = Time.now.utc.strftime("%Z")
         context = OpenSSL::X509::StoreContext.new(OpenSSL::X509::Store.new)
         expect do
           Braintree::Configuration.instantiate.http._verify_ssl_certificate(true, context)

data/spec/integration/braintree/oauth_spec.rb

@@ -36,7 +36,7 @@ describe "OAuth" do
       )
 
       expect(result).not_to be_success
-      errors = expect(result.errors.for(:credentials).on(:code)[0].code).to eq(Braintree::ErrorCodes::OAuth::InvalidGrant)
+      expect(result.errors.for(:credentials).on(:code)[0].code).to eq(Braintree::ErrorCodes::OAuth::InvalidGrant)
       expect(result.message).to match(/Invalid grant: code not found/)
     end
 

data/spec/integration/braintree/payment_method_spec.rb

@@ -390,15 +390,14 @@ describe Braintree::PaymentMethod do
       expect(result.success?).to eq(true)
 
       three_d_secure_info = result.payment_method.verification.three_d_secure_info
-      expect(three_d_secure_info.enrolled).to eq("Y")
+      expect(three_d_secure_info.status).to eq("authenticate_successful")
       expect(three_d_secure_info).to be_liability_shifted
       expect(three_d_secure_info).to be_liability_shift_possible
-      expect(three_d_secure_info.status).to eq("authenticate_successful")
-      expect(three_d_secure_info.cavv).to eq("cavv_value")
-      expect(three_d_secure_info.xid).to eq("xid_value")
-      expect(three_d_secure_info.eci_flag).to eq("05")
-      expect(three_d_secure_info.three_d_secure_version).to eq("1.0.2")
-      expect(three_d_secure_info.ds_transaction_id).to eq(nil)
+      expect(three_d_secure_info.enrolled).to be_a(String)
+      expect(three_d_secure_info.cavv).to be_a(String)
+      expect(three_d_secure_info.xid).to be_a(String)
+      expect(three_d_secure_info.eci_flag).to be_a(String)
+      expect(three_d_secure_info.three_d_secure_version).to be_a(String)
     end
 
     it "respects fail_on_duplicate_payment_method when included outside of the nonce" do
@@ -1409,7 +1408,6 @@ describe Braintree::PaymentMethod do
 
     it "raises a NotFoundError exception if payment method cannot be found" do
       token = make_token
-      customer = Braintree::Customer.create!
 
       expect do
         Braintree::PaymentMethod.delete(token)
@@ -1878,7 +1876,7 @@ describe Braintree::PaymentMethod do
         )
 
         updated_token = make_token
-        updated_result = Braintree::PaymentMethod.update(
+        Braintree::PaymentMethod.update(
           original_token,
           :token => updated_token,
         )
@@ -1907,7 +1905,7 @@ describe Braintree::PaymentMethod do
           :customer_id => customer.id,
         ).payment_method.token
 
-        updated_result = Braintree::PaymentMethod.update(
+        Braintree::PaymentMethod.update(
           original_token,
           :options => {:make_default => true},
         )
@@ -1925,7 +1923,7 @@ describe Braintree::PaymentMethod do
           :consent_code => "consent-code",
           :token => first_token,
         )
-        first_result = Braintree::PaymentMethod.create(
+        Braintree::PaymentMethod.create(
           :payment_method_nonce => first_nonce,
           :customer_id => customer.id,
         )
@@ -1934,7 +1932,7 @@ describe Braintree::PaymentMethod do
           :consent_code => "consent-code",
           :token => second_token,
         )
-        second_result = Braintree::PaymentMethod.create(
+        Braintree::PaymentMethod.create(
           :payment_method_nonce => second_nonce,
           :customer_id => customer.id,
         )

data/spec/integration/braintree/payment_method_us_bank_account_spec.rb

@@ -116,7 +116,7 @@ describe Braintree::PaymentMethod do
 
         it "returns additional processor response for failed NetworkCheck" do
           customer = Braintree::Customer.create.customer
-          invalid_nonce = generate_non_plaid_us_bank_account_nonce(account_number = "1000000005")
+          invalid_nonce = generate_non_plaid_us_bank_account_nonce("1000000005")
           result = Braintree::PaymentMethod.create(
             :payment_method_nonce => invalid_nonce,
             :customer_id => customer.id,
@@ -189,7 +189,7 @@ describe Braintree::PaymentMethod do
       context "unverified token" do
         let(:payment_method) do
           customer = Braintree::Customer.create.customer
-          result = Braintree::PaymentMethod.create(
+          Braintree::PaymentMethod.create(
             :payment_method_nonce => generate_non_plaid_us_bank_account_nonce,
             :customer_id => customer.id,
             :options => {
@@ -260,7 +260,7 @@ describe Braintree::PaymentMethod do
       context "unverified token" do
         let(:payment_method) do
           customer = Braintree::Customer.create.customer
-          result = Braintree::PaymentMethod.create(
+          Braintree::PaymentMethod.create(
             :payment_method_nonce => generate_non_plaid_us_bank_account_nonce,
             :customer_id => customer.id,
             :options => {

data/spec/integration/braintree/paypal_account_spec.rb

@@ -51,7 +51,7 @@ describe Braintree::PayPalAccount do
 
     it "does not return a different payment method type" do
       customer = Braintree::Customer.create!
-      result = Braintree::CreditCard.create(
+      Braintree::CreditCard.create(
         :customer_id => customer.id,
         :number => Braintree::Test::CreditCardNumbers::Visa,
         :expiration_date => "05/2009",
@@ -171,7 +171,7 @@ describe Braintree::PayPalAccount do
       )
 
       updated_token = "UPDATED_TOKEN-" + rand(36**3).to_s(36)
-      updated_result = Braintree::PayPalAccount.update(
+      Braintree::PayPalAccount.update(
         original_token,
         :token => updated_token,
       )
@@ -200,7 +200,7 @@ describe Braintree::PayPalAccount do
         :customer_id => customer.id,
       ).payment_method.token
 
-      updated_result = Braintree::PayPalAccount.update(
+      Braintree::PayPalAccount.update(
         original_token,
         :options => {:make_default => true},
       )
@@ -218,7 +218,7 @@ describe Braintree::PayPalAccount do
         :consent_code => "consent-code",
         :token => first_token,
       )
-      first_result = Braintree::PaymentMethod.create(
+      Braintree::PaymentMethod.create(
         :payment_method_nonce => first_nonce,
         :customer_id => customer.id,
       )
@@ -227,7 +227,7 @@ describe Braintree::PayPalAccount do
         :consent_code => "consent-code",
         :token => second_token,
       )
-      second_result = Braintree::PaymentMethod.create(
+      Braintree::PaymentMethod.create(
         :payment_method_nonce => second_nonce,
         :customer_id => customer.id,
       )
@@ -256,7 +256,7 @@ describe Braintree::PayPalAccount do
         :customer_id => customer.id,
       )
 
-      result = Braintree::PayPalAccount.delete(token)
+      Braintree::PayPalAccount.delete(token)
 
       expect do
         Braintree::PayPalAccount.find(token)

data/spec/integration/braintree/plan_spec.rb

@@ -113,7 +113,6 @@ describe Braintree::Plan do
     end
 
     it "returns the updated plan if valid" do
-      new_id = rand(36**9).to_s(36)
       plan = Braintree::Plan.update!(@plan.id,
                                      :name => "updated name",
                                      :price => 99.88,

data/spec/integration/braintree/sepa_direct_debit_account_spec.rb

@@ -53,8 +53,6 @@ describe Braintree::SepaDirectDebitAccount do
 
     context "subscriptions" do
       it "returns subscriptions associated with a SEPA direct debit account" do
-        customer = Braintree::Customer.create!
-
         subscription1 = Braintree::Subscription.create(
           :payment_method_token => token,
           :plan_id => SpecHelper::TriallessPlan[:id],

data/spec/integration/braintree/subscription_spec.rb

@@ -136,7 +136,6 @@ describe Braintree::Subscription do
       end
 
       it "returns an error if the payment_method_nonce hasn't been vaulted" do
-        customer = Braintree::Customer.create!
         result = Braintree::Subscription.create(
           :payment_method_nonce => Braintree::Test::Nonce::PayPalFuturePayment,
           :plan_id => SpecHelper::TriallessPlan[:id],
@@ -937,17 +936,17 @@ describe Braintree::Subscription do
 
       it "has validation errors on duplicate id" do
         duplicate_id = "new_id_#{rand(36**6).to_s(36)}"
-        duplicate = Braintree::Subscription.create(
+        Braintree::Subscription.create(
           :payment_method_token => @credit_card.token,
           :plan_id => SpecHelper::TrialPlan[:id],
           :id => duplicate_id,
         )
-        result = Braintree::Subscription.update(
+        duplicate = Braintree::Subscription.update(
           @subscription.id,
           :id => duplicate_id,
         )
-        expect(result.success?).to eq(false)
-        expect(result.errors.for(:subscription).on(:id)[0].code).to eq(Braintree::ErrorCodes::Subscription::IdIsInUse)
+        expect(duplicate.success?).to eq(false)
+        expect(duplicate.errors.for(:subscription).on(:id)[0].code).to eq(Braintree::ErrorCodes::Subscription::IdIsInUse)
       end
 
       it "cannot update a canceled subscription" do
@@ -1203,7 +1202,7 @@ describe Braintree::Subscription do
 
     it "returns a validation error if record not found" do
       expect {
-        r = Braintree::Subscription.cancel("noSuchSubscription")
+        Braintree::Subscription.cancel("noSuchSubscription")
       }.to raise_error(Braintree::NotFoundError, 'subscription with id "noSuchSubscription" not found')
     end
 

data/spec/integration/braintree/transaction_search_spec.rb

@@ -640,7 +640,7 @@ describe Braintree::Transaction, "search" do
     context "invalid search" do
       it "raises an exception on invalid transaction type" do
         expect do
-          collection = Braintree::Transaction.search do |search|
+          Braintree::Transaction.search do |search|
             search.customer_id.is "9171566"
             search.type.is "settled"
           end
@@ -649,7 +649,7 @@ describe Braintree::Transaction, "search" do
 
       it "raises an exception on invalid debit network" do
         expect do
-          collection = Braintree::Transaction.search do |search|
+          Braintree::Transaction.search do |search|
             search.debit_network.is "invalid_network"
           end
         end.to raise_error(ArgumentError)
@@ -849,8 +849,6 @@ describe Braintree::Transaction, "search" do
 
       context "ach return response created at" do
         it "it finds records within date range of the custom field" do
-          reason_code = "any_reason_code"
-
           date_search = Braintree::Transaction.search do |search|
             search.ach_return_responses_created_at.between(DateTime.now - 1.0, DateTime.now + 1.0)
           end
@@ -859,8 +857,6 @@ describe Braintree::Transaction, "search" do
         end
 
         it "it does not find records not within date range of the custom field" do
-          reason_code = "any_reason_code"
-
           neg_date_search = Braintree::Transaction.search do |search|
            search.ach_return_responses_created_at.between(DateTime.now + 1.0, DateTime.now - 1.0)
           end
@@ -1488,7 +1484,7 @@ describe Braintree::Transaction, "search" do
     context "when the search times out" do
       it "raises a UnexpectedError" do
         expect {
-          collection = Braintree::Transaction.search do |search|
+          Braintree::Transaction.search do |search|
             search.amount.is(-10)
           end
         }.to raise_error(Braintree::UnexpectedError)

data/spec/integration/braintree/transaction_spec.rb

@@ -2098,7 +2098,6 @@ describe Braintree::Transaction do
       end
 
       it "can create a transaction with a params nonce with PayPal account params" do
-        customer = Braintree::Customer.create!
         nonce = nonce_for_new_payment_method(
           :paypal_account => {
             :consent_code => "PAYPAL_CONSENT_CODE",
@@ -2174,7 +2173,6 @@ describe Braintree::Transaction do
       end
 
       it "can create a transaction with a fake apple pay nonce" do
-        customer = Braintree::Customer.create!
         result = Braintree::Transaction.create(
           :type => "sale",
           :amount => Braintree::Test::TransactionAmounts::Authorize,
@@ -2203,7 +2201,6 @@ describe Braintree::Transaction do
       end
 
       it "can create a vaulted transaction with a fake apple pay nonce" do
-        customer = Braintree::Customer.create!
         result = Braintree::Transaction.create(
           :type => "sale",
           :amount => Braintree::Test::TransactionAmounts::Authorize,
@@ -2225,7 +2222,6 @@ describe Braintree::Transaction do
       end
 
       it "can create a transaction with a fake google pay proxy card nonce" do
-        customer = Braintree::Customer.create!
         result = Braintree::Transaction.create(
           :type => "sale",
           :amount => Braintree::Test::TransactionAmounts::Authorize,
@@ -2257,7 +2253,6 @@ describe Braintree::Transaction do
       end
 
       it "can create a vaulted transaction with a fake google pay proxy card nonce" do
-        customer = Braintree::Customer.create!
         result = Braintree::Transaction.create(
           :type => "sale",
           :amount => Braintree::Test::TransactionAmounts::Authorize,
@@ -2282,7 +2277,6 @@ describe Braintree::Transaction do
       end
 
       it "can create a transaction with a fake google pay network token nonce" do
-        customer = Braintree::Customer.create!
         result = Braintree::Transaction.create(
           :type => "sale",
           :amount => Braintree::Test::TransactionAmounts::Authorize,
@@ -2335,7 +2329,6 @@ describe Braintree::Transaction do
       end
 
       it "can create a transaction with an unknown nonce" do
-        customer = Braintree::Customer.create!
         result = Braintree::Transaction.create(
           :type => "sale",
           :amount => Braintree::Test::TransactionAmounts::Authorize,
@@ -2364,7 +2357,6 @@ describe Braintree::Transaction do
       end
 
       it "can create a transaction with a payee id" do
-        customer = Braintree::Customer.create!
         nonce = nonce_for_new_payment_method(
           :paypal_account => {
             :consent_code => "PAYPAL_CONSENT_CODE",
@@ -2388,7 +2380,6 @@ describe Braintree::Transaction do
       end
 
       it "can create a transaction with a payee id in the options params" do
-        customer = Braintree::Customer.create!
         nonce = nonce_for_new_payment_method(
           :paypal_account => {
             :consent_code => "PAYPAL_CONSENT_CODE",
@@ -2413,7 +2404,6 @@ describe Braintree::Transaction do
       end
 
       it "can create a transaction with a payee id in options.paypal" do
-        customer = Braintree::Customer.create!
         nonce = nonce_for_new_payment_method(
           :paypal_account => {
             :consent_code => "PAYPAL_CONSENT_CODE",
@@ -2439,7 +2429,6 @@ describe Braintree::Transaction do
       end
 
       it "can create a transaction with a payee email" do
-        customer = Braintree::Customer.create!
         nonce = nonce_for_new_payment_method(
           :paypal_account => {
             :consent_code => "PAYPAL_CONSENT_CODE",
@@ -2463,7 +2452,6 @@ describe Braintree::Transaction do
       end
 
       it "can create a transaction with a payee email in the options params" do
-        customer = Braintree::Customer.create!
         nonce = nonce_for_new_payment_method(
           :paypal_account => {
             :consent_code => "PAYPAL_CONSENT_CODE",
@@ -2488,7 +2476,6 @@ describe Braintree::Transaction do
       end
 
       it "can create a transaction with a payee email in options.paypal" do
-        customer = Braintree::Customer.create!
         nonce = nonce_for_new_payment_method(
           :paypal_account => {
             :consent_code => "PAYPAL_CONSENT_CODE",
@@ -2514,7 +2501,6 @@ describe Braintree::Transaction do
       end
 
       it "can create a transaction with a paypal custom field" do
-        customer = Braintree::Customer.create!
         nonce = nonce_for_new_payment_method(
           :paypal_account => {
             :consent_code => "PAYPAL_CONSENT_CODE",
@@ -2540,7 +2526,6 @@ describe Braintree::Transaction do
       end
 
       it "can create a transaction with a paypal description" do
-        customer = Braintree::Customer.create!
         nonce = nonce_for_new_payment_method(
           :paypal_account => {
             :consent_code => "PAYPAL_CONSENT_CODE",
@@ -2566,7 +2551,6 @@ describe Braintree::Transaction do
       end
 
       it "can create a transaction with STC supplementary data" do
-        customer = Braintree::Customer.create!
         nonce = nonce_for_new_payment_method(
           :paypal_account => {
             :consent_code => "PAYPAL_CONSENT_CODE",
@@ -3300,7 +3284,7 @@ describe Braintree::Transaction do
             )
 
             config = Braintree::Configuration.instantiate
-            response = config.http.put("#{config.base_merchant_path}/transactions/#{transaction.id}/settle")
+            config.http.put("#{config.base_merchant_path}/transactions/#{transaction.id}/settle")
             transaction = Braintree::Transaction.find(transaction.id)
 
             result = Braintree::Transaction.refund(
@@ -3390,7 +3374,7 @@ describe Braintree::Transaction do
             },
           )
           config = Braintree::Configuration.instantiate
-          response = config.http.put("#{config.base_merchant_path}/transactions/#{transaction.id}/settle")
+          config.http.put("#{config.base_merchant_path}/transactions/#{transaction.id}/settle")
           result = Braintree::Transaction.refund(transaction.id, :amount => "2046.00")
           expect(result.success?).to eq(false)
           expect(result.transaction.id).to match(/^\w{6,}$/)
@@ -3411,7 +3395,7 @@ describe Braintree::Transaction do
             },
           )
           config = Braintree::Configuration.instantiate
-          response = config.http.put("#{config.base_merchant_path}/transactions/#{transaction.id}/settle")
+          config.http.put("#{config.base_merchant_path}/transactions/#{transaction.id}/settle")
           result = Braintree::Transaction.refund(transaction.id, :amount => "2009.00")
           expect(result.success?).to eq(false)
           expect(result.transaction.id).to match(/^\w{6,}$/)
@@ -7256,7 +7240,7 @@ describe Braintree::Transaction do
     )
 
     config = Braintree::Configuration.instantiate
-    response = config.http.put("#{config.base_merchant_path}/transactions/#{transaction.id}/settle")
+    config.http.put("#{config.base_merchant_path}/transactions/#{transaction.id}/settle")
     Braintree::Transaction.find(transaction.id)
   end
 
@@ -7287,8 +7271,8 @@ describe Braintree::Transaction do
     )
 
     config = Braintree::Configuration.instantiate
-    response = config.http.put("#{config.base_merchant_path}/transactions/#{transaction.id}/settle")
-    response = config.http.put("#{config.base_merchant_path}/transactions/#{transaction.id}/escrow")
+    config.http.put("#{config.base_merchant_path}/transactions/#{transaction.id}/settle")
+    config.http.put("#{config.base_merchant_path}/transactions/#{transaction.id}/escrow")
     Braintree::Transaction.find(transaction.id)
   end
 

data/spec/unit/braintree/client_token_spec.rb

@@ -14,7 +14,7 @@ module Braintree
 
       it "can't overwrite public_key, or created_at" do
         expect {
-          client_token = Braintree::ClientToken.generate(
+          Braintree::ClientToken.generate(
             :public_key => "bad_key",
             :created_at => "bad_time",
           )

data/spec/unit/braintree/digest_spec.rb

@@ -3,7 +3,6 @@ require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
 describe Braintree::Digest do
   describe "self.hexdigest" do
     it "returns the sha1 hmac of the input string (test case 6 from RFC 2202)" do
-      original_key = Braintree::Configuration.private_key
       private_key = "\xaa" * 80
       data = "Test Using Larger Than Block-Size Key - Hash Key First"
       expect(Braintree::Digest.hexdigest(private_key, data)).to eq("aa4ae5e15272d00e95705637ce8a3b55ed402112")

data/spec/unit/braintree/error_result_spec.rb

@@ -5,7 +5,7 @@ describe Braintree::ErrorResult do
     it "ignores data other than params, errors, and message" do
       # so that we can add more data into the response in the future without breaking the client lib
       expect do
-        result = Braintree::ErrorResult.new(
+        Braintree::ErrorResult.new(
           :gateway,
           :params => "params",
           :errors => {:errors => []},

data/spec/unit/braintree/paypal_account_spec.rb

@@ -4,7 +4,7 @@ describe Braintree::PayPalAccount do
   describe "self.create" do
     it "raises an exception if attributes contain an invalid key" do
       expect do
-        result = Braintree::PayPalAccount.create(
+        Braintree::PayPalAccount.create(
           :invalid_key => "bad stuff",
           :options => {
             :invalid_option => "bad option",

data/spec/unit/braintree/transaction_spec.rb

@@ -200,8 +200,8 @@ describe Braintree::Transaction do
         },
       )
 
-      expect(transaction.three_d_secure_info.enrolled).to eq("Y")
       expect(transaction.three_d_secure_info.status).to eq("authenticate_successful")
+      expect(transaction.three_d_secure_info.enrolled).to eq("Y")
       expect(transaction.three_d_secure_info.liability_shifted).to eq(true)
       expect(transaction.three_d_secure_info.liability_shift_possible).to eq(true)
     end
@@ -258,7 +258,7 @@ describe Braintree::Transaction do
     end
 
     it "handles receiving custom as an empty string" do
-      transaction = Braintree::Transaction._new(
+      Braintree::Transaction._new(
         :gateway,
         :custom => "\n    ",
       )

data/spec/unit/braintree/webhook_notification_spec.rb

@@ -168,6 +168,22 @@ describe Braintree::WebhookNotification do
           expect(dispute.kind).to eq(Braintree::Dispute::Kind::Chargeback)
         end
 
+        it "builds a sample notification for a dispute under_review webhook" do
+          sample_notification = Braintree::WebhookTesting.sample_notification(
+            Braintree::WebhookNotification::Kind::DisputeUnderReview,
+            dispute_id,
+          )
+
+          notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
+
+          expect(notification.kind).to eq(Braintree::WebhookNotification::Kind::DisputeUnderReview)
+
+          dispute = notification.dispute
+          expect(dispute.status).to eq(Braintree::Dispute::Status::UnderReview)
+          expect(dispute.id).to eq(dispute_id)
+          expect(dispute.kind).to eq(Braintree::Dispute::Kind::Chargeback)
+        end
+
         it "builds a sample notification for a dispute won webhook" do
           sample_notification = Braintree::WebhookTesting.sample_notification(
             Braintree::WebhookNotification::Kind::DisputeWon,

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: braintree
 version: !ruby/object:Gem::Version
-  version: 4.18.0
+  version: 4.19.0
 platform: ruby
 authors:
 - Braintree
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-01-09 00:00:00.000000000 Z
+date: 2024-03-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: builder