braintree 4.16.0 → 4.17.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fbacdc492fa27aed57086131c1feab00ed435923034cae5dd7b5c6d4c3184a1a
-  data.tar.gz: a3c9be778fb88ef5a0ea6c23182f74654b511dca659e34529fade077712418ef
+  metadata.gz: 02bb65b55ac949e73761f1a9ded2f1cf844bc81b7bbfc48d39e080387166e4d2
+  data.tar.gz: b3975e3c6a0d415544cc643aaa2471f3efe532537a0ad1a8175dcf42767b2684
 SHA512:
-  metadata.gz: 3b6e24f668d3bd022069f5e85ed55afe9fbdce43205af6dd44a101f6aef3f78d2b2099d5b8d5c8297cbf3076dee72da16e61d7b758cb162278190e99d9f95d91
-  data.tar.gz: 3ee3af6a1854de4b02db4670b3d32232b2ce7d26ae478bfa792dcc4ccfe638f52259e80e818704d630c8a0b453a1f566062865045f370f5f83a377e0c7083d16
+  metadata.gz: 6eb74dc8f70c828d8112b177bd9c424816626064fbfba2615d7246f9bae54513c5637b43be0c70a36e4dff5ac0b00aefbf208f66549829e64d37e30a37f0920a
+  data.tar.gz: d6af576d6a66816007de302db284e2bb456c1a37347eadac4df3ba483d5ab728e2a04dc26f2d98be91082c1a4b30790417e2d102bfd8b054b524c4b6d40174d5

data/lib/braintree/credit_card_verification_gateway.rb

@@ -47,22 +47,39 @@ module Braintree
     def self._create_signature
       [
         {:credit_card => [
-          :cardholder_name, :cvv, :expiration_date, :expiration_month, :expiration_year,
-          :number, {:billing_address => AddressGateway._shared_signature}
+          {:billing_address => AddressGateway._shared_signature},
+          :cardholder_name,
+          :cvv,
+          :expiration_date,
+          :expiration_month,
+          :expiration_year,
+          :number,
+        ]},
+        {:external_vault => [
+          :previous_network_transaction_id,
+          :status,
         ]},
         :intended_transaction_source,
-        {:options => [:amount, :merchant_account_id, :account_type]},
+        {:options => [
+          :account_type,
+          :amount,
+          :merchant_account_id,
+        ]},
         :payment_method_nonce,
+        {:risk_data => [
+          :customer_browser,
+          :customer_ip,
+        ]},
         :three_d_secure_authentication_id,
         {:three_d_secure_pass_thru => [
-            :eci_flag,
-            :cavv,
-            :xid,
-            :three_d_secure_version,
-            :authentication_response,
-            :directory_response,
-            :cavv_algorithm,
-            :ds_transaction_id,
+          :authentication_response,
+          :cavv,
+          :cavv_algorithm,
+          :directory_response,
+          :ds_transaction_id,
+          :eci_flag,
+          :three_d_secure_version,
+          :xid,
         ]},
       ]
     end

data/lib/braintree/http.rb

@@ -7,8 +7,8 @@ module Braintree
       @config = config
     end
 
-    def delete(_path, query_params = {})
-      path = _path + _build_query_string(query_params)
+    def delete(path, query_params = {})
+      full_path = path + _build_query_string(query_params)
       response = _http_do Net::HTTP::Delete, path
       if response.code.to_i == 200 || response.code.to_i == 204
         true
@@ -19,8 +19,8 @@ module Braintree
       end
     end
 
-    def get(_path, query_params = {})
-      path = _path + _build_query_string(query_params)
+    def get(path, query_params = {})
+      full_path = path + _build_query_string(query_params)
       response = _http_do Net::HTTP::Get, path
       if response.code.to_i == 200 || response.code.to_i == 422
         Xml.hash_from_xml(_body(response))

data/lib/braintree/transaction/address_details.rb

@@ -10,6 +10,7 @@ module Braintree
         Ground = "ground"
         Electronic = "electronic"
         ShipToStore = "ship_to_store"
+        PickupInStore = "pickup_in_store"
       end
 
       attr_reader :company

data/lib/braintree/version.rb

@@ -1,7 +1,7 @@
 module Braintree
   module Version
     Major = 4
-    Minor = 16
+    Minor = 17
     Tiny = 0
 
     String = "#{Major}.#{Minor}.#{Tiny}"

data/lib/braintree/webhook_notification_gateway.rb

@@ -27,7 +27,7 @@ module Braintree
       signature_pairs = signature_string.split("&")
       valid_pairs = signature_pairs.select { |pair| pair.include?("|") }.map { |pair| pair.split("|") }
 
-      valid_pairs.detect do |public_key, signature|
+      valid_pairs.detect do |public_key, _signature|
         public_key == @config.public_key
       end
     end
@@ -36,8 +36,8 @@ module Braintree
       public_key, signature = _matching_signature_pair(signature_string)
       raise InvalidSignature, "no matching public key" if public_key.nil?
 
-      signature_matches = [payload, payload + "\n"].any? do |_payload|
-        payload_signature = Braintree::Digest.hexdigest(@config.private_key, _payload)
+      signature_matches = [payload, payload + "\n"].any? do |p|
+        payload_signature = Braintree::Digest.hexdigest(@config.private_key, p)
         Braintree::Digest.secure_compare(signature, payload_signature)
       end
       raise InvalidSignature, "signature does not match payload - one has been modified" unless signature_matches

data/lib/braintree/xml/parser.rb

@@ -32,7 +32,7 @@ module Braintree
         case value.class.to_s
           when "Hash"
             if value["type"] == "array"
-              child_key, entries = value.detect { |k,v| k != "type" }   # child_key is throwaway
+              child_key, entries = value.detect { |k,_v| k != "type" }   # child_key is throwaway
               if entries.nil? || ((c = value[CONTENT_ROOT]) && c.strip.empty?)
                 []
               else

data/spec/integration/braintree/client_api/spec_helper.rb

@@ -282,8 +282,8 @@ class ClientApiHttp
     params = {:credit_card => params}
     params.merge!(
       :authorization_fingerprint => @options[:authorization_fingerprint],
-      :shared_customer_identifier => "fake_identifier",
-      :shared_customer_identifier_type => "testing",
+      :shared_customer_identifier => @options[:shared_customer_identifier],
+      :shared_customer_identifier_type => @options[:shared_customer_identifier_type],
     )
 
     post("/merchants/#{config.merchant_id}/client_api/v1/payment_methods/credit_cards", params)

data/spec/integration/braintree/credit_card_verification_spec.rb

@@ -48,6 +48,51 @@ describe Braintree::CreditCardVerification, "search" do
       expect(result.credit_card_verification.processor_response_type).to eq(Braintree::ProcessorResponseTypes::Approved)
     end
 
+    it "creates a new verification from external vault param" do
+      verification_params = {
+        :credit_card => {
+            :expiration_date => "05/2029",
+            :number => Braintree::Test::CreditCardNumbers::Visa,
+        },
+        :external_vault => {
+            :status => "will_vault"
+        }
+      }
+
+      result = Braintree::CreditCardVerification.create(verification_params)
+
+      expect(result).to be_success
+      expect(result.credit_card_verification.id).to match(/^\w{6,}$/)
+      expect(result.credit_card_verification.status).to eq(Braintree::CreditCardVerification::Status::Verified)
+      expect(result.credit_card_verification.processor_response_code).to eq("1000")
+      expect(result.credit_card_verification.processor_response_text).to eq("Approved")
+      expect(result.credit_card_verification.processor_response_type).to eq(Braintree::ProcessorResponseTypes::Approved)
+      expect(result.credit_card_verification.network_transaction_id).not_to be_nil
+    end
+
+    it "creates a new verification from risk data param" do
+      verification_params = {
+        :credit_card => {
+            :expiration_date => "05/2029",
+            :number => Braintree::Test::CreditCardNumbers::Visa,
+        },
+        :risk_data => {
+            :customer_browser => "IE7",
+            :customer_ip => "192.168.0.1"
+        }
+      }
+
+      result = Braintree::CreditCardVerification.create(verification_params)
+
+      expect(result).to be_success
+      expect(result.credit_card_verification.id).to match(/^\w{6,}$/)
+      expect(result.credit_card_verification.status).to eq(Braintree::CreditCardVerification::Status::Verified)
+      expect(result.credit_card_verification.processor_response_code).to eq("1000")
+      expect(result.credit_card_verification.processor_response_text).to eq("Approved")
+      expect(result.credit_card_verification.processor_response_type).to eq(Braintree::ProcessorResponseTypes::Approved)
+      expect(result.credit_card_verification.network_transaction_id).not_to be_nil
+    end
+
     it "returns processor response code and text as well as the additional processor response if declined" do
       verification_params = {
         :credit_card => {

data/spec/unit/braintree/base_module_spec.rb

@@ -8,11 +8,11 @@ describe Braintree::BaseModule do
         klass = Class.new { include Braintree::BaseModule }
         klass.return_object_or_raise(:obj) { result }
       rescue Braintree::ValidationsFailed => ex
-      end
       expect(ex).not_to eq(nil)
       expect(ex.error_result).to eq(result)
       expect(ex.inspect).to include(result.inspect)
       expect(ex.to_s).to include(result.inspect)
+      end
     end
   end
 end

data/spec/unit/braintree/credit_card_verification_gateway_spec.rb

@@ -22,30 +22,35 @@ describe Braintree::CreditCardVerificationGateway do
     it "creates a credit card verification gateway signature" do
       result = Braintree::CreditCardVerificationGateway._create_signature
       expect(result.inspect).to include("credit_card")
-      expect(result.inspect).to include("credit_card")
+      expect(result.inspect).to include("billing_address")
       expect(result.inspect).to include("cardholder_name")
       expect(result.inspect).to include("cvv")
       expect(result.inspect).to include("expiration_date")
       expect(result.inspect).to include("expiration_month")
       expect(result.inspect).to include("expiration_year")
       expect(result.inspect).to include("number")
-      expect(result.inspect).to include("billing_address")
+      expect(result.inspect).to include("external_vault")
+      expect(result.inspect).to include("previous_network_transaction_id")
+      expect(result.inspect).to include("status")
       expect(result.inspect).to include("intended_transaction_source")
       expect(result.inspect).to include("options")
+      expect(result.inspect).to include("account_type")
       expect(result.inspect).to include("amount")
       expect(result.inspect).to include("merchant_account_id")
-      expect(result.inspect).to include("account_type")
       expect(result.inspect).to include("payment_method_nonce")
+      expect(result.inspect).to include("risk_data")
+      expect(result.inspect).to include("customer_browser")
+      expect(result.inspect).to include("customer_ip")
       expect(result.inspect).to include("three_d_secure_authentication_id")
       expect(result.inspect).to include("three_d_secure_pass_thru")
-      expect(result.inspect).to include("eci_flag")
-      expect(result.inspect).to include("cavv")
-      expect(result.inspect).to include("xid")
-      expect(result.inspect).to include("three_d_secure_version")
       expect(result.inspect).to include("authentication_response")
-      expect(result.inspect).to include("directory_response")
+      expect(result.inspect).to include("cavv")
       expect(result.inspect).to include("cavv_algorithm")
+      expect(result.inspect).to include("directory_response")
       expect(result.inspect).to include("ds_transaction_id")
+      expect(result.inspect).to include("eci_flag")
+      expect(result.inspect).to include("three_d_secure_version")
+      expect(result.inspect).to include("xid")
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: braintree
 version: !ruby/object:Gem::Version
-  version: 4.16.0
+  version: 4.17.0
 platform: ruby
 authors:
 - Braintree
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-11-08 00:00:00.000000000 Z
+date: 2023-12-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: builder