braintree 2.98.0 → 2.99.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 67e6afaacba1448a5c2aafd4b1e9432aa6875c3f22d5a8812c4e102a156e2d67
-  data.tar.gz: 2c620e47df93ef23542d98b092bf93cf9ef7bfe21b5d4e424976d5b51187836a
+  metadata.gz: 35130c66d5071330674c5341da2e1586416f802a696845c1d81c8076fde0899c
+  data.tar.gz: 7d5f478974b02500f9866f650d6d5f3fdcc700d979aacf64dc7806bf331e6c34
 SHA512:
-  metadata.gz: ca18891a468ccdfa0e22960490781c60206775cccad4a2e23edad4a7a3883b515e68ec71436c6b1edf4e57c51c3633e6127986025aead83055f1f37b55640459
-  data.tar.gz: 0cdcff4610e50bfd41d939f27d164dc87d95c7949fef5fa07dd3d21a42df851cb642590be7088aa9e53008611208cbfac7d3dbd062e0eca6a5197430e7a61266
+  metadata.gz: 4a58351bfeed6f12c5988bae9af906a5aa73ff287494e6df8bd01f990140adde54dbe9c1ac9c0afd97a44b4f9dca9d5ffff115be76a7278242d6ff17c3cc397a
+  data.tar.gz: e6b523d6609ed0ae3784b9ddaa43e1fb3e65c5dc05df67e65b752e0b01d104331aedfce100e6244da10099ef1fa80252959d0c3b3473a7488c0fe3ddd8878c3d

data/lib/braintree/dispute.rb

@@ -12,11 +12,11 @@ module Braintree
     attr_reader :date_opened
     attr_reader :date_won
     attr_reader :evidence
-    attr_reader :forwarded_comments
     attr_reader :id
     attr_reader :kind
     attr_reader :merchant_account_id
     attr_reader :original_dispute_id
+    attr_reader :processor_comments
     attr_reader :reason
     attr_reader :reason_code
     attr_reader :reason_description
@@ -120,5 +120,11 @@ module Braintree
         Braintree::Dispute::HistoryEvent.new(event)
       end unless status_history.nil?
     end
+
+    def forwarded_comments
+      # NEXT_MAJOR_VERSION delete this method since it never returned anything anyway.
+      warn "[DEPRECATED] #forwarded_comments is deprecated. Please use #processor_comments"
+      processor_comments
+    end
   end
 end

data/lib/braintree/version.rb

@@ -1,7 +1,7 @@
 module Braintree
   module Version
     Major = 2
-    Minor = 98
+    Minor = 99
     Tiny = 0
 
     String = "#{Major}.#{Minor}.#{Tiny}"

data/spec/integration/braintree/transaction_spec.rb

@@ -4000,7 +4000,7 @@ describe Braintree::Transaction do
         result.errors.for(:transaction).for(:external_vault).on(:status)[0].code.should == Braintree::ErrorCodes::Transaction::ExternalVault::StatusIsInvalid
       end
 
-      context "Visa" do
+      context "Visa/Mastercard/Discover" do
         it "accepts status" do
           result = Braintree::Transaction.create(
             :type => "sale",
@@ -4021,7 +4021,7 @@ describe Braintree::Transaction do
           result = Braintree::Transaction.create(
             :type => "sale",
             :credit_card => {
-              :number => Braintree::Test::CreditCardNumbers::Visa,
+              :number => Braintree::Test::CreditCardNumbers::MasterCard,
               :expiration_date => "05/2009"
             },
             :external_vault => {
@@ -4038,7 +4038,7 @@ describe Braintree::Transaction do
           result = Braintree::Transaction.create(
             :type => "sale",
             :credit_card => {
-              :number => Braintree::Test::CreditCardNumbers::Visa,
+              :number => Braintree::Test::CreditCardNumbers::Discover,
               :expiration_date => "05/2009"
             },
             :external_vault => {
@@ -4050,31 +4050,14 @@ describe Braintree::Transaction do
           result.success?.should == false
           result.errors.for(:transaction).for(:external_vault).on(:status)[0].code.should == Braintree::ErrorCodes::Transaction::ExternalVault::StatusWithPreviousNetworkTransactionIdIsInvalid
         end
-
-        it "rejects invalid previous_network_transaction_id" do
-          result = Braintree::Transaction.create(
-            :type => "sale",
-            :credit_card => {
-              :number => Braintree::Test::CreditCardNumbers::Visa,
-              :expiration_date => "05/2009"
-            },
-            :external_vault => {
-              :status => Braintree::Transaction::ExternalVault::Status::Vaulted,
-              :previous_network_transaction_id => "not_and_valid_id",
-            },
-            :amount => "10.00",
-          )
-          result.success?.should == false
-          result.errors.for(:transaction).for(:external_vault).on(:previous_network_transaction_id)[0].code.should == Braintree::ErrorCodes::Transaction::ExternalVault::PreviousNetworkTransactionIdIsInvalid
-        end
       end
 
-      context "Non-Visa" do
+      context "Non-(Visa/Mastercard/Discover) card types" do
         it "accepts status" do
           result = Braintree::Transaction.create(
             :type => "sale",
             :credit_card => {
-              :number => Braintree::Test::CreditCardNumbers::MasterCard,
+              :number => Braintree::Test::CreditCardNumbers::AmExes[0],
               :expiration_date => "05/2009"
             },
             :external_vault => {
@@ -4090,7 +4073,7 @@ describe Braintree::Transaction do
           result = Braintree::Transaction.create(
             :type => "sale",
             :credit_card => {
-              :number => Braintree::Test::CreditCardNumbers::MasterCard,
+              :number => Braintree::Test::CreditCardNumbers::AmExes[0],
               :expiration_date => "05/2009"
             },
             :external_vault => {
@@ -4107,7 +4090,7 @@ describe Braintree::Transaction do
           result = Braintree::Transaction.create(
             :type => "sale",
             :credit_card => {
-              :number => Braintree::Test::CreditCardNumbers::Discover,
+              :number => Braintree::Test::CreditCardNumbers::AmExes[0],
               :expiration_date => "05/2009"
             },
             :external_vault => {

data/spec/unit/braintree/dispute_spec.rb

@@ -8,6 +8,7 @@ describe Braintree::Dispute do
       :amount_disputed => "500.00",
       :amount_won => "0.00",
       :created_at => Time.utc(2009, 3, 9, 10, 50, 39),
+      :processor_comments => "forwarded comments",
       :date_opened => "2009-03-09",
       :date_won => "2009-04-15",
       :original_dispute_id => "original_dispute_id",
@@ -391,6 +392,18 @@ describe Braintree::Dispute do
     end
   end
 
+  describe "comments" do
+    let(:dispute) { Braintree::Dispute._new(attributes) }
+
+    it "#forwarded_comments returns `processor_comments`" do
+      expect(dispute.forwarded_comments).to eq(dispute.processor_comments)
+    end
+
+    it "#processor_comments" do
+      expect(dispute.processor_comments).to eq(attributes[:processor_comments])
+    end
+  end
+
   describe "new" do
     it "is protected" do
       expect do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: braintree
 version: !ruby/object:Gem::Version
-  version: 2.98.0
+  version: 2.99.0
 platform: ruby
 authors:
 - Braintree
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-07 00:00:00.000000000 Z
+date: 2019-10-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: builder
@@ -320,7 +320,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.4
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
 summary: Braintree Gateway Ruby Client Library