braintree 2.94.0 → 2.95.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dce496fbd494eb6d7c00260e5f7ac5ce0082e588874e5ff85f8b1130009164c6
-  data.tar.gz: 827b5db86f4b2144bbbe795f2bbd2abd06b7f4c85d577e99842c544705b234d1
+  metadata.gz: a6885baaa1cf0362ea29a6c57834122bfef5ef5e4f022527e7d8d25fa4c748b6
+  data.tar.gz: b2bff8e8cc234fcab9ee20a37c53f5977da827ab74b3634f4ac1e7f044423ca3
 SHA512:
-  metadata.gz: 2d879cf0a13d3d799ecf92f8f447e91a75897ecc77a75ee9ed1a39a5d96f81b7e82b4f6edfa57147e689230ea5941ecb5f92e1e4fb3e0f8524cb2d8a66542bf8
-  data.tar.gz: e402c7a9f7d351a89ad7c205012b26e66f9ca82ac15c73fc5ff432c2e00296dc78422ef8c2e80ad45d12f2e9901a8f343b9164736cecd3c578546316e0a26e0d
+  metadata.gz: f79c7a60e1eeb0ad4ae677d8402eb0aa1538f55d6a29e2b324acb0db6506b8ec43e04e32ca8a5b3de20ced19f383c99038435d9a1a525fad3d8cf2b7aeb5d6df
+  data.tar.gz: 109bbdea462fddac547448a411f1d99a020ef46833313608846cb1d04c49eca0aa508a4221ac044cde8bb8a03251dcdf26002050d1499b857fe83b90f74a3a03

data/lib/braintree/credit_card_verification_gateway.rb

@@ -46,7 +46,7 @@ module Braintree
 
     def self._create_signature
       [
-         {:options => [:amount, :merchant_account_id]},
+         {:options => [:amount, :merchant_account_id, :account_type]},
          {:credit_card => [
            :cardholder_name, :cvv, :expiration_date, :expiration_month, :expiration_year,
            :number, {:billing_address => AddressGateway._shared_signature}

data/lib/braintree/error_codes.rb

@@ -100,6 +100,8 @@ module Braintree
       TokenIsTooLong = "91720"
       VenmoSDKPaymentMethodCodeCardTypeIsNotAccepted = "91726"
       VerificationNotSupportedOnThisMerchantAccount = "91730"
+      VerificationAccountTypeIsInvalid = "91757"
+      VerificationAccountTypeNotSupported = "91758"
 
       module Options
         UpdateExistingTokenIsInvalid = "91723"
@@ -419,6 +421,12 @@ module Braintree
         module PayPal
           CustomFieldTooLong = "91580"
         end
+
+        module CreditCard
+          AccountTypeIsInvalid = "915184"
+          AccountTypeNotSupported = "915185"
+          AccountTypeDebitDoesNotSupportAuths = "915186"
+        end
       end
 
       module Industry
@@ -724,6 +732,8 @@ module Braintree
         MerchantAccountIsSuspended = "94205"
         MerchantAccountIsForbidden = "94206"
         MerchantAccountCannotBeSubMerchantAccount = "94208"
+        AccountTypeIsInvalid = "942184"
+        AccountTypeNotSupported = "942185"
       end
     end
 

data/lib/braintree/payment_method_gateway.rb

@@ -155,6 +155,7 @@ module Braintree
       options = [
         :make_default, :verification_merchant_account_id, :verify_card, :venmo_sdk_session,
         :verification_amount, :us_bank_account_verification_method,
+        :verification_account_type,
         :paypal => [
           :payee_email,
           :order_id,

data/lib/braintree/test/credit_card.rb

@@ -32,6 +32,9 @@ module Braintree
       MasterCards = %w[5105105105105100 5555555555554444]
 
       Elo = "5066991111111118"
+      Hiper = "6370950000000005"
+      Hipercard = "6062820524845321"
+
       Visa = "4012888888881881"
       VisaInternational = "4009348888881881" # :nodoc:
       VisaPrepaid = "4500600000000061"

data/lib/braintree/transaction/credit_card_details.rb

@@ -3,6 +3,7 @@ module Braintree
     class CreditCardDetails # :nodoc:
       include BaseModule
 
+      attr_reader :account_type
       attr_reader :bin
       attr_reader :card_type
       attr_reader :cardholder_name

data/lib/braintree/transaction_gateway.rb

@@ -223,7 +223,8 @@ module Braintree
           {:paypal => [:custom_field, :payee_id, :payee_email, :description, {:supplementary_data => :_any_key_}]},
           {:three_d_secure => [:required]},
           {:amex_rewards => [:request_id, :points, :currency_amount, :currency_iso_code]},
-          {:venmo => [:profile_id]}
+          {:venmo => [:profile_id]},
+          {:credit_card => [:account_type]},
         ]
         },
         {:external_vault => [

data/lib/braintree/version.rb

@@ -1,7 +1,7 @@
 module Braintree
   module Version
     Major = 2
-    Minor = 94
+    Minor = 95
     Tiny = 0
 
     String = "#{Major}.#{Minor}.#{Tiny}"

data/lib/braintree/webhook_notification.rb

@@ -40,7 +40,11 @@ module Braintree
       ConnectedMerchantStatusTransitioned = "connected_merchant_status_transitioned"
       ConnectedMerchantPayPalStatusChanged = "connected_merchant_paypal_status_changed"
 
+      # NEXT_MAJOR_VERSION remove GrantedPaymentInstrumentUpdate. Kind is not sent by Braintree Gateway.
+      # Kind will either be GrantorUpdatedGrantedPaymentMethod or RecipientUpdatedGrantedPaymentMethod.
       GrantedPaymentInstrumentUpdate = "granted_payment_instrument_update"
+      GrantorUpdatedGrantedPaymentMethod = "grantor_updated_granted_payment_method"
+      RecipientUpdatedGrantedPaymentMethod = "recipient_updated_granted_payment_method"
       GrantedPaymentInstrumentRevoked = "granted_payment_instrument_revoked"
 
       LocalPaymentCompleted = "local_payment_completed"

data/lib/braintree/webhook_testing_gateway.rb

@@ -76,8 +76,13 @@ module Braintree
         _ideal_payment_complete_sample_xml(id)
       when Braintree::WebhookNotification::Kind::IdealPaymentFailed
         _ideal_payment_failed_sample_xml(id)
+      # NEXT_MAJOR_VERSION remove GrantedPaymentInstrumentUpdate
       when Braintree::WebhookNotification::Kind::GrantedPaymentInstrumentUpdate
         _granted_payment_instrument_update_sample_xml(id)
+      when Braintree::WebhookNotification::Kind::GrantorUpdatedGrantedPaymentMethod
+        _granted_payment_instrument_update_sample_xml(id)
+      when Braintree::WebhookNotification::Kind::RecipientUpdatedGrantedPaymentMethod
+        _granted_payment_instrument_update_sample_xml(id)
       when Braintree::WebhookNotification::Kind::LocalPaymentCompleted
         _local_payment_completed_sample_xml(id)
       else

data/spec/integration/braintree/credit_card_verification_spec.rb

@@ -61,6 +61,69 @@ describe Braintree::CreditCardVerification, "search" do
       result.success?.should == false
       result.errors.for(:verification).for(:options).first.code.should == Braintree::ErrorCodes::Verification::Options::AmountCannotBeNegative
     end
+
+    it "returns account type with debit" do
+      result = Braintree::CreditCardVerification.create(
+        :credit_card => {
+          :expiration_date => "01/2020",
+          :number => Braintree::Test::CreditCardNumbers::Hiper
+        },
+        :options => {
+          :merchant_account_id => SpecHelper::HiperBRLMerchantAccountId,
+          :account_type => "debit",
+        },
+      )
+
+      result.success?.should == true
+      result.credit_card_verification.credit_card[:account_type].should == "debit"
+    end
+
+    it "returns account type with credit" do
+      result = Braintree::CreditCardVerification.create(
+        :credit_card => {
+          :expiration_date => "01/2020",
+          :number => Braintree::Test::CreditCardNumbers::Hiper
+        },
+        :options => {
+          :merchant_account_id => SpecHelper::HiperBRLMerchantAccountId,
+          :account_type => "credit",
+        },
+      )
+
+      result.success?.should == true
+      result.credit_card_verification.credit_card[:account_type].should == "credit"
+    end
+
+    it "errors with unsupported account type" do
+      result = Braintree::CreditCardVerification.create(
+        :credit_card => {
+          :expiration_date => "01/2020",
+          :number => Braintree::Test::CreditCardNumbers::Visa
+        },
+        :options => {
+          :account_type => "credit",
+        },
+      )
+
+      result.success?.should == false
+      result.errors.for(:verification).for(:options).on(:account_type)[0].code.should == Braintree::ErrorCodes::Verification::Options::AccountTypeNotSupported
+    end
+
+    it "errors with invalid account type" do
+      result = Braintree::CreditCardVerification.create(
+        :credit_card => {
+          :expiration_date => "01/2020",
+          :number => Braintree::Test::CreditCardNumbers::Hiper
+        },
+        :options => {
+          :merchant_account_id => SpecHelper::HiperBRLMerchantAccountId,
+          :account_type => "ach",
+        },
+      )
+
+      result.success?.should == false
+      result.errors.for(:verification).for(:options).on(:account_type)[0].code.should == Braintree::ErrorCodes::Verification::Options::AccountTypeIsInvalid
+    end
   end
 
   describe "self.find" do

data/spec/integration/braintree/payment_method_spec.rb

@@ -487,6 +487,147 @@ describe Braintree::PaymentMethod do
       found_credit_card.billing_address.street_address.should == "456 Xyz Way"
     end
 
+    context "account_type" do
+      it "verifies card with account_type debit" do
+        nonce = nonce_for_new_payment_method(
+          :credit_card => {
+            :number => Braintree::Test::CreditCardNumbers::Hiper,
+            :expiration_month => "11",
+            :expiration_year => "2099",
+          }
+        )
+        customer = Braintree::Customer.create!
+        result = Braintree::PaymentMethod.create(
+          :payment_method_nonce => nonce,
+          :customer_id => customer.id,
+          :options => {
+            :verify_card => true,
+            :verification_merchant_account_id => SpecHelper::HiperBRLMerchantAccountId,
+            :verification_account_type => "debit",
+          }
+        )
+
+        result.should be_success
+        result.payment_method.verification.credit_card[:account_type].should == "debit"
+      end
+
+      it "verifies card with account_type credit" do
+        nonce = nonce_for_new_payment_method(
+          :credit_card => {
+            :number => Braintree::Test::CreditCardNumbers::Hiper,
+            :expiration_month => "11",
+            :expiration_year => "2099",
+          }
+        )
+        customer = Braintree::Customer.create!
+        result = Braintree::PaymentMethod.create(
+          :payment_method_nonce => nonce,
+          :customer_id => customer.id,
+          :options => {
+            :verify_card => true,
+            :verification_merchant_account_id => SpecHelper::HiperBRLMerchantAccountId,
+            :verification_account_type => "credit",
+          }
+        )
+
+        result.should be_success
+        result.payment_method.verification.credit_card[:account_type].should == "credit"
+      end
+
+      it "errors with invalid account_type" do
+        nonce = nonce_for_new_payment_method(
+          :credit_card => {
+            :number => Braintree::Test::CreditCardNumbers::Hiper,
+            :expiration_month => "11",
+            :expiration_year => "2099",
+          }
+        )
+        customer = Braintree::Customer.create!
+        result = Braintree::PaymentMethod.create(
+          :payment_method_nonce => nonce,
+          :customer_id => customer.id,
+          :options => {
+            :verify_card => true,
+            :verification_merchant_account_id => SpecHelper::HiperBRLMerchantAccountId,
+            :verification_account_type => "ach",
+          }
+        )
+
+        result.should_not be_success
+        result.errors.for(:credit_card).for(:options).on(:verification_account_type)[0].code.should == Braintree::ErrorCodes::CreditCard::VerificationAccountTypeIsInvalid
+      end
+
+      it "errors when account_type not supported by merchant" do
+        nonce = nonce_for_new_payment_method(
+          :credit_card => {
+            :number => Braintree::Test::CreditCardNumbers::Visa,
+            :expiration_month => "11",
+            :expiration_year => "2099",
+          }
+        )
+        customer = Braintree::Customer.create!
+        result = Braintree::PaymentMethod.create(
+          :payment_method_nonce => nonce,
+          :customer_id => customer.id,
+          :options => {
+            :verify_card => true,
+            :verification_account_type => "credit",
+          }
+        )
+
+        result.should_not be_success
+        result.errors.for(:credit_card).for(:options).on(:verification_account_type)[0].code.should == Braintree::ErrorCodes::CreditCard::VerificationAccountTypeNotSupported
+      end
+
+      it "updates the credit card with account_type credit" do
+        customer = Braintree::Customer.create!
+        credit_card = Braintree::CreditCard.create!(
+          :cardholder_name => "Original Holder",
+          :customer_id => customer.id,
+          :cvv => "123",
+          :number => Braintree::Test::CreditCardNumbers::Visa,
+          :expiration_date => "05/2012"
+        )
+        update_result = Braintree::PaymentMethod.update(credit_card.token,
+          :cardholder_name => "New Holder",
+          :cvv => "456",
+          :number => Braintree::Test::CreditCardNumbers::Hiper,
+          :expiration_date => "06/2013",
+          :options => {
+            :verify_card => true,
+            :verification_merchant_account_id => SpecHelper::HiperBRLMerchantAccountId,
+            :verification_account_type => "credit",
+          },
+        )
+        update_result.success?.should == true
+        update_result.payment_method.verification.credit_card[:account_type].should == "credit"
+      end
+
+      it "updates the credit card with account_type debit" do
+        customer = Braintree::Customer.create!
+        credit_card = Braintree::CreditCard.create!(
+          :cardholder_name => "Original Holder",
+          :customer_id => customer.id,
+          :cvv => "123",
+          :number => Braintree::Test::CreditCardNumbers::Visa,
+          :expiration_date => "05/2012"
+        )
+        update_result = Braintree::PaymentMethod.update(credit_card.token,
+          :cardholder_name => "New Holder",
+          :cvv => "456",
+          :number => Braintree::Test::CreditCardNumbers::Hiper,
+          :expiration_date => "06/2013",
+          :options => {
+            :verify_card => true,
+            :verification_merchant_account_id => SpecHelper::HiperBRLMerchantAccountId,
+            :verification_account_type => "debit",
+          },
+        )
+        update_result.success?.should == true
+        update_result.payment_method.verification.credit_card[:account_type].should == "debit"
+      end
+    end
+
     context "paypal" do
       it "creates a payment method from an unvalidated future paypal account nonce" do
         nonce = nonce_for_paypal_account(:consent_code => "PAYPAL_CONSENT_CODE")

data/spec/integration/braintree/transaction_spec.rb

@@ -2398,15 +2398,6 @@ describe Braintree::Transaction do
           refund_transaction.refunded_transaction_id.should == transaction.id
         end
 
-        it "returns an error if already refunded" do
-          transaction = create_paypal_transaction_for_refund
-          result = Braintree::Transaction.refund(transaction.id)
-          result.success?.should == true
-          result = Braintree::Transaction.refund(transaction.id)
-          result.success?.should == false
-          result.errors.for(:transaction).on(:base)[0].code.should == Braintree::ErrorCodes::Transaction::HasAlreadyBeenRefunded
-        end
-
         it "returns an error result if unsettled" do
           transaction = Braintree::Transaction.sale!(
             :amount => Braintree::Test::TransactionAmounts::Authorize,
@@ -3955,6 +3946,122 @@ describe Braintree::Transaction do
       end
 
     end
+
+    context "account_type" do
+      it "creates a Hiper transaction with account type credit" do
+          result = Braintree::Transaction.create(
+            :type => "sale",
+            :merchant_account_id => SpecHelper::HiperBRLMerchantAccountId,
+            :credit_card => {
+              :number => Braintree::Test::CreditCardNumbers::Hiper,
+              :expiration_date => "05/2009"
+            },
+            :amount => "10.00",
+            :options => {
+              :credit_card => {
+                :account_type => "credit",
+              }
+            }
+          )
+          result.success?.should == true
+          result.transaction.credit_card_details.account_type.should == "credit"
+       end
+
+       it "creates a Hipercard transaction with account_type credit" do
+          result = Braintree::Transaction.create(
+            :type => "sale",
+            :merchant_account_id => SpecHelper::HiperBRLMerchantAccountId,
+            :credit_card => {
+              :number => Braintree::Test::CreditCardNumbers::Hipercard,
+              :expiration_date => "05/2009"
+            },
+            :amount => "10.00",
+            :options => {
+              :credit_card => {
+                :account_type => "credit",
+              }
+            }
+          )
+          result.success?.should == true
+          result.transaction.credit_card_details.account_type.should == "credit"
+       end
+
+       it "creates a Hiper transaction with account_type debit" do
+          result = Braintree::Transaction.create(
+            :type => "sale",
+            :merchant_account_id => SpecHelper::HiperBRLMerchantAccountId,
+            :credit_card => {
+              :number => Braintree::Test::CreditCardNumbers::Hiper,
+              :expiration_date => "05/2009"
+            },
+            :amount => "10.00",
+            :options => {
+              :credit_card => {
+                :account_type => "debit",
+              },
+              :submit_for_settlement => true,
+            }
+          )
+          result.success?.should == true
+          result.transaction.credit_card_details.account_type.should == "debit"
+       end
+
+       it "does not allow auths with account_type debit" do
+          result = Braintree::Transaction.create(
+            :type => "sale",
+            :merchant_account_id => SpecHelper::HiperBRLMerchantAccountId,
+            :credit_card => {
+              :number => Braintree::Test::CreditCardNumbers::Hiper,
+              :expiration_date => "05/2009"
+            },
+            :amount => "10.00",
+            :options => {
+              :credit_card => {
+                :account_type => "debit",
+              },
+            }
+          )
+          result.success?.should == false
+          result.errors.for(:transaction).for(:options).for(:credit_card).on(:account_type)[0].code.should == Braintree::ErrorCodes::Transaction::Options::CreditCard::AccountTypeDebitDoesNotSupportAuths
+       end
+
+       it "does not allow invalid account_type" do
+          result = Braintree::Transaction.create(
+            :type => "sale",
+            :merchant_account_id => SpecHelper::HiperBRLMerchantAccountId,
+            :credit_card => {
+              :number => Braintree::Test::CreditCardNumbers::Hiper,
+              :expiration_date => "05/2009"
+            },
+            :amount => "10.00",
+            :options => {
+              :credit_card => {
+                :account_type => "ach",
+              },
+            }
+          )
+          result.success?.should == false
+          result.errors.for(:transaction).for(:options).for(:credit_card).on(:account_type)[0].code.should == Braintree::ErrorCodes::Transaction::Options::CreditCard::AccountTypeIsInvalid
+       end
+
+       it "does not allow account_type not supported by merchant" do
+          result = Braintree::Transaction.create(
+            :type => "sale",
+            :credit_card => {
+              :number => Braintree::Test::CreditCardNumbers::Visa,
+              :expiration_date => "05/2009"
+            },
+            :amount => "10.00",
+            :options => {
+              :credit_card => {
+                :account_type => "credit",
+              },
+            }
+          )
+          result.success?.should == false
+          result.errors.for(:transaction).for(:options).for(:credit_card).on(:account_type)[0].code.should == Braintree::ErrorCodes::Transaction::Options::CreditCard::AccountTypeNotSupported
+       end
+    end
   end
 
   describe "self.create!" do
@@ -6269,8 +6376,8 @@ describe Braintree::Transaction do
           :venmo_sdk_payment_method_code => Braintree::Test::VenmoSDK::InvalidPaymentMethodCode
         )
         result.success?.should == false
-        result.message.should == "Invalid VenmoSDK payment method code"
-        result.errors.first.code.should == "91727"
+        result.message.should include("Invalid VenmoSDK payment method code")
+        result.errors.map(&:code).should include("91727")
       end
     end
 

data/spec/spec_helper.rb

@@ -43,6 +43,7 @@ unless defined?(SPEC_HELPER_LOADED)
     AnotherUsBankMerchantAccountId = "another_us_bank_merchant_account"
     IdealMerchantAccountId = "ideal_merchant_account"
     AdyenMerchantAccountId = "adyen_ma"
+    HiperBRLMerchantAccountId = "hiper_brl"
 
     TrialPlan = {
       :description => "Plan for integration tests -- with trial",

data/spec/unit/braintree/webhook_notification_spec.rb

@@ -436,16 +436,33 @@ describe Braintree::WebhookNotification do
   end
 
   context "granted_payment_instrument_update" do
-    it "builds a sample notification for a granted_payment_instrument_update webhook" do
+    it "builds a sample notification for a GrantorUpdatedGrantedPaymentMethod webhook" do
       sample_notification = Braintree::WebhookTesting.sample_notification(
-        Braintree::WebhookNotification::Kind::GrantedPaymentInstrumentUpdate,
+        Braintree::WebhookNotification::Kind::GrantorUpdatedGrantedPaymentMethod,
         "my_id"
       )
 
       notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
       update = notification.granted_payment_instrument_update
 
-      notification.kind.should == Braintree::WebhookNotification::Kind::GrantedPaymentInstrumentUpdate
+      notification.kind.should == Braintree::WebhookNotification::Kind::GrantorUpdatedGrantedPaymentMethod
+      update.grant_owner_merchant_id.should == 'vczo7jqrpwrsi2px'
+      update.grant_recipient_merchant_id.should == 'cf0i8wgarszuy6hc'
+      update.payment_method_nonce.should == 'ee257d98-de40-47e8-96b3-a6954ea7a9a4'
+      update.token.should == 'abc123z'
+      update.updated_fields.should == ['expiration-month', 'expiration-year']
+    end
+
+    it "builds a sample notification for a RecipientUpdatedGrantedPaymentMethod webhook" do
+      sample_notification = Braintree::WebhookTesting.sample_notification(
+        Braintree::WebhookNotification::Kind::RecipientUpdatedGrantedPaymentMethod,
+        "my_id"
+      )
+
+      notification = Braintree::WebhookNotification.parse(sample_notification[:bt_signature], sample_notification[:bt_payload])
+      update = notification.granted_payment_instrument_update
+
+      notification.kind.should == Braintree::WebhookNotification::Kind::RecipientUpdatedGrantedPaymentMethod
       update.grant_owner_merchant_id.should == 'vczo7jqrpwrsi2px'
       update.grant_recipient_merchant_id.should == 'cf0i8wgarszuy6hc'
       update.payment_method_nonce.should == 'ee257d98-de40-47e8-96b3-a6954ea7a9a4'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: braintree
 version: !ruby/object:Gem::Version
-  version: 2.94.0
+  version: 2.95.0
 platform: ruby
 authors:
 - Braintree
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-23 00:00:00.000000000 Z
+date: 2019-03-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: builder
@@ -319,7 +319,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: braintree
-rubygems_version: 2.7.8
+rubygems_version: 2.7.9
 signing_key: 
 specification_version: 4
 summary: Braintree Gateway Ruby Client Library