braintree 2.92.0 → 2.93.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8ee8dac5bb756fb408c50fa5acef0ad21bf4d10127ade82df57828bd7123484f
-  data.tar.gz: adb2042d479a2418d62e8da23b6aeaa77490e46dea06daefbff0f4c19209c59c
+  metadata.gz: fe7e71dc2faed60283e8b70c632dcc9f60c5402897caed595cf7689b6d8152c1
+  data.tar.gz: aa6b2334db4ee60824c5fd84d0a665f4709f328337fae8ee3f081c9237093148
 SHA512:
-  metadata.gz: 5a1b0f3e1a7600a0a699baa9a398585704960e6fa78958be8ec9e8a95fa191d234b73c91294b15cb8f99ce699e2aaec9af2c5c9c5f28778895be039782fc96a2
-  data.tar.gz: 67f11e2d63c8ce0e0ca9bdd25a8b160ee0453c371495b9e9b4d83220c7c990963f496de28b08200852e8bfb76d9afad73a138136aeba0a22d303594a138008cb
+  metadata.gz: f50449f12b8e0c806a36a7111fd007c4d4bbc877a46dac3e50fe655e3258a6832983911f6354d0d361e59d4d2d9540b134f5f3fd45a0f6f8402b638a29b77229
+  data.tar.gz: f124d8089b885395f91fe95e88533fbe26e52e008a603cafd5ddb743b2abaee8b3416a6953c8a877a213503d8aeb95ffde7035694f67a8dd700e1af1fc7f06d7

data/lib/braintree/error_codes.rb

@@ -345,6 +345,7 @@ module Braintree
       MerchantAccountDoesNotMatchIdealPaymentMerchantAccount = "915143"
       MerchantAccountDoesNotSupportMOTO = "91558"
       MerchantAccountDoesNotSupportRefunds = "91547"
+      MerchantAccountIdDoesNotMatchSubscription = "915180"
       MerchantAccountIdIsInvalid = "91513"
       MerchantAccountIsSuspended = "91514"
       OrderIdIsTooLong = "91501"
@@ -439,6 +440,53 @@ module Braintree
           LodgingCheckInDateIsInvalid = "93412"
           LodgingCheckOutDateIsInvalid = "93413"
         end
+
+        module TravelFlight
+          EmptyData = "93414"
+          UnknownDataField = "93415"
+          CustomerCodeIsTooLong = "93416"
+          FareAmountCannotBeNegative = "93417"
+          FareAmountFormatIsInvalid = "93418"
+          FareAmountIsTooLarge = "93419"
+          FeeAmountCannotBeNegative = "93420"
+          FeeAmountFormatIsInvalid = "93421"
+          FeeAmountIsTooLarge = "93422"
+          IssuedDateFormatIsInvalid = "93423"
+          IssuingCarrierCodeIsTooLong = "93424"
+          PassengerMiddleInitialIsTooLong = "93425"
+          RestrictedTicketIsRequired = "93426"
+          TaxAmountCannotBeNegative = "93427"
+          TaxAmountFormatIsInvalid = "93428"
+          TaxAmountIsTooLarge = "93429"
+          TicketNumberIsTooLong = "93430"
+          LegsExpected = "93431"
+          TooManyLegs = "93432"
+        end
+
+        module Leg
+          module TravelFlight
+            ArrivalAirportCodeIsTooLong = "96301"
+            ArrivalTimeFormatIsInvalid = "96302"
+            CarrierCodeIsTooLong = "96303"
+            ConjunctionTicketIsTooLong = "96304"
+            CouponNumberIsTooLong = "96305"
+            DepartureAirportCodeIsTooLong = "96306"
+            DepartureTimeFormatIsInvalid = "96307"
+            ExchangeTicketIsTooLong = "96308"
+            FareAmountCannotBeNegative = "96309"
+            FareAmountFormatIsInvalid = "96310"
+            FareAmountIsTooLarge = "96311"
+            FareBasisCodeIsTooLong = "96312"
+            FeeAmountCannotBeNegative = "96313"
+            FeeAmountFormatIsInvalid = "96314"
+            FeeAmountIsTooLarge = "96315"
+            ServiceClassIsTooLong = "96316"
+            TaxAmountCannotBeNegative = "96317"
+            TaxAmountFormatIsInvalid = "96318"
+            TaxAmountIsTooLarge = "96319"
+            TicketNumberIsTooLong = "96320"
+          end
+        end
       end
 
       module ExternalVault

data/lib/braintree/risk_data.rb

@@ -5,13 +5,14 @@ module Braintree
     attr_reader :decision
     attr_reader :device_data_captured
     attr_reader :id
+    attr_reader :fraud_service_provider
 
     def initialize(attributes)
       set_instance_variables_from_hash attributes unless attributes.nil?
     end
 
     def inspect
-      attr_order = [:id, :decision, :device_data_captured]
+      attr_order = [:id, :decision, :device_data_captured, :fraud_service_provider]
       formatted_attrs = attr_order.map do |attr|
         "#{attr}: #{send(attr).inspect}"
       end

data/lib/braintree/transaction.rb

@@ -58,6 +58,7 @@ module Braintree
     module IndustryType
       Lodging = "lodging"
       TravelAndCruise = "travel_cruise"
+      TravelAndFlight = "travel_flight"
 
       All = constants.map { |c| const_get(c) }
     end

data/lib/braintree/transaction_gateway.rb

@@ -232,8 +232,19 @@ module Braintree
         ]},
         {:custom_fields => :_any_key_},
         {:descriptor => [:name, :phone, :url]},
-        {:paypal_account => [:email, :token, :paypal_data, :payee_id, :payee_email]},
-        {:industry => [:industry_type, {:data => [:folio_number, :check_in_date, :check_out_date, :travel_package, :lodging_check_in_date, :lodging_check_out_date, :departure_date, :lodging_name, :room_rate]}]},
+        {:paypal_account => [:email, :token, :paypal_data, :payee_id, :payee_email, :payer_id, :payment_id]},
+        {:industry => [
+          :industry_type,
+          {:data => [
+            :folio_number, :check_in_date, :check_out_date, :travel_package, :lodging_check_in_date, :lodging_check_out_date, :departure_date, :lodging_name, :room_rate,
+            :passenger_first_name, :passenger_last_name, :passenger_middle_initial, :passenger_title, :issued_date, :travel_agency_name, :travel_agency_code, :ticket_number,
+            :issuing_carrier_code, :customer_code, :fare_amount, :fee_amount, :tax_amount, :restricted_ticket,
+            {:legs => [
+              :conjunction_ticket, :exchange_ticket, :coupon_number, :service_class, :carrier_code, :fare_basis_code, :flight_number, :departure_date, :departure_airport_code, :departure_time,
+              :arrival_airport_code, :arrival_time, :stopover_permitted, :fare_amount, :fee_amount, :tax_amount, :endorsement_or_restrictions,
+            ]},
+          ]},
+        ]},
         {:apple_pay_card => [:number, :cardholder_name, :cryptogram, :expiration_month, :expiration_year, :eci_indicator]},
         {:android_pay_card => [:number, :cryptogram, :google_transaction_id, :expiration_month, :expiration_year, :source_card_type, :source_card_last_four, :eci_indicator]}
       ]

data/lib/braintree/version.rb

@@ -1,7 +1,7 @@
 module Braintree
   module Version
     Major = 2
-    Minor = 92
+    Minor = 93
     Tiny = 0
 
     String = "#{Major}.#{Minor}.#{Tiny}"

data/spec/integration/braintree/credit_card_spec.rb

@@ -152,6 +152,7 @@ describe Braintree::CreditCard do
         verification.risk_data.should respond_to(:id)
         verification.risk_data.should respond_to(:decision)
         verification.risk_data.should respond_to(:device_data_captured)
+        verification.risk_data.should respond_to(:fraud_service_provider)
       end
     end
 

data/spec/integration/braintree/transaction_spec.rb

@@ -137,6 +137,7 @@ describe Braintree::Transaction do
           result.transaction.risk_data.should respond_to(:id)
           result.transaction.risk_data.should respond_to(:decision)
           result.transaction.risk_data.should respond_to(:device_data_captured)
+          result.transaction.risk_data.should respond_to(:fraud_service_provider)
         end
       end
     end
@@ -246,6 +247,105 @@ describe Braintree::Transaction do
           result.errors.for(:transaction).for(:industry).map { |e| e.code }.sort.should == [Braintree::ErrorCodes::Transaction::Industry::TravelCruise::TravelPackageIsInvalid]
         end
       end
+
+      context "for travel flight" do
+        it "accepts valid industry data" do
+          result = Braintree::Transaction.create(
+            :type => "sale",
+            :amount => 1_00,
+            :payment_method_nonce => Braintree::Test::Nonce::PayPalOneTimePayment,
+            :options => {
+              :submit_for_settlement => true
+            },
+            :industry => {
+              :industry_type => Braintree::Transaction::IndustryType::TravelAndFlight,
+              :data => {
+                :passenger_first_name => "John",
+                :passenger_last_name => "Doe",
+                :passenger_middle_initial => "M",
+                :passenger_title => "Mr.",
+                :issued_date => Date.new(2018, 1, 1),
+                :travel_agency_name => "Expedia",
+                :travel_agency_code => "12345678",
+                :ticket_number => "ticket-number",
+                :issuing_carrier_code => "AA",
+                :customer_code => "customer-code",
+                :fare_amount => 70_00,
+                :fee_amount => 10_00,
+                :tax_amount => 20_00,
+                :restricted_ticket => false,
+                :legs => [
+                  {
+                    :conjunction_ticket => "CJ0001",
+                    :exchange_ticket => "ET0001",
+                    :coupon_number => "1",
+                    :service_class => "Y",
+                    :carrier_code => "AA",
+                    :fare_basis_code => "W",
+                    :flight_number => "AA100",
+                    :departure_date => Date.new(2018, 1, 2),
+                    :departure_airport_code => "MDW",
+                    :departure_time => "08:00",
+                    :arrival_airport_code => "ATX",
+                    :arrival_time => "10:00",
+                    :stopover_permitted => false,
+                    :fare_amount => 35_00,
+                    :fee_amount => 5_00,
+                    :tax_amount => 10_00,
+                    :endorsement_or_restrictions => "NOT REFUNDABLE"
+                  },
+                  {
+                    :conjunction_ticket => "CJ0002",
+                    :exchange_ticket => "ET0002",
+                    :coupon_number => "1",
+                    :service_class => "Y",
+                    :carrier_code => "AA",
+                    :fare_basis_code => "W",
+                    :flight_number => "AA200",
+                    :departure_date => Date.new(2018, 1, 3),
+                    :departure_airport_code => "ATX",
+                    :departure_time => "12:00",
+                    :arrival_airport_code => "MDW",
+                    :arrival_time => "14:00",
+                    :stopover_permitted => false,
+                    :fare_amount => 35_00,
+                    :fee_amount => 5_00,
+                    :tax_amount => 10_00,
+                    :endorsement_or_restrictions => "NOT REFUNDABLE"
+                  }
+                ]
+              }
+            }
+          )
+          result.success?.should be(true)
+        end
+
+        it "returns errors if validations on industry data fails" do
+          result = Braintree::Transaction.create(
+            :type => "sale",
+            :amount => 1_00,
+            :payment_method_nonce => Braintree::Test::Nonce::PayPalOneTimePayment,
+            :options => {
+              :submit_for_settlement => true
+            },
+            :industry => {
+              :industry_type => Braintree::Transaction::IndustryType::TravelAndFlight,
+              :data => {
+                :fare_amount => -1_23,
+                :restricted_ticket => false,
+                :legs => [
+                  {
+                    :fare_amount => -1_23
+                  }
+                ]
+              }
+            }
+          )
+          result.success?.should be(false)
+          result.errors.for(:transaction).for(:industry).map { |e| e.code }.sort.should == [Braintree::ErrorCodes::Transaction::Industry::TravelFlight::FareAmountCannotBeNegative]
+          result.errors.for(:transaction).for(:industry).for(:legs).for(:index_0).map { |e| e.code }.sort.should == [Braintree::ErrorCodes::Transaction::Industry::Leg::TravelFlight::FareAmountCannotBeNegative]
+        end
+      end
     end
 
     context "elo" do
@@ -777,12 +877,8 @@ describe Braintree::Transaction do
       }
       result = Braintree::Transaction.create(params[:transaction])
       result.success?.should == false
-      result.errors.for(:transaction).on(:base).map{|error| error.code}.should include(Braintree::ErrorCodes::Transaction::PaymentMethodConflictWithVenmoSDK)
       result.errors.for(:transaction).on(:base).map{|error| error.code}.should include(Braintree::ErrorCodes::Transaction::PaymentMethodDoesNotBelongToCustomer)
-      result.errors.for(:transaction).on(:amount)[0].code.should == Braintree::ErrorCodes::Transaction::AmountIsRequired
       result.errors.for(:transaction).on(:customer_id)[0].code.should == Braintree::ErrorCodes::Transaction::CustomerIdIsInvalid
-      result.errors.for(:transaction).on(:order_id)[0].code.should == Braintree::ErrorCodes::Transaction::OrderIdIsTooLong
-      result.errors.for(:transaction).on(:channel)[0].code.should == Braintree::ErrorCodes::Transaction::ChannelIsTooLong
       result.errors.for(:transaction).on(:payment_method_token)[0].code.should == Braintree::ErrorCodes::Transaction::PaymentMethodTokenIsInvalid
       result.errors.for(:transaction).on(:type)[0].code.should == Braintree::ErrorCodes::Transaction::TypeIsInvalid
     end
@@ -1636,6 +1732,24 @@ describe Braintree::Transaction do
         result.transaction.should_not be_nil
       end
 
+      it "can create a transaction with local payment webhook content" do
+        result = Braintree::Transaction.sale(
+          :amount => "100",
+          :options => {
+            :submit_for_settlement => true
+          },
+          :paypal_account => {
+            :payer_id => "PAYER-1234",
+            :payment_id => "PAY-5678",
+          }
+        )
+
+        result.success?.should == true
+        result.transaction.status.should == Braintree::Transaction::Status::Settling
+        result.transaction.paypal_details.payer_id.should == "PAYER-1234"
+        result.transaction.paypal_details.payment_id.should == "PAY-5678"
+      end
+
       it "can create a transaction with a payee id" do
         customer = Braintree::Customer.create!
         nonce = nonce_for_new_payment_method(

data/spec/unit/braintree/credit_card_verification_spec.rb

@@ -108,12 +108,14 @@ describe Braintree::CreditCardVerification do
       verification = Braintree::CreditCardVerification._new(:risk_data => {
         :id => "123",
         :decision => "WOO YOU WON $1000 dollars",
-        :device_data_captured => true
+        :device_data_captured => true,
+        :fraud_service_provider => "kount"
       })
 
       verification.risk_data.id.should == "123"
       verification.risk_data.decision.should == "WOO YOU WON $1000 dollars"
       verification.risk_data.device_data_captured.should == true
+      verification.risk_data.fraud_service_provider.should == "kount"
     end
 
     it "handles a nil risk_data" do

data/spec/unit/braintree/risk_data_spec.rb

@@ -3,10 +3,11 @@ require File.expand_path(File.dirname(__FILE__) + "/../../spec_helper")
 describe Braintree::RiskData do
   describe "#initialize" do
     it "sets id, decision and device_data_captured" do
-      risk_data = Braintree::RiskData.new(:id => "123", :decision => "YOU WON $1000 DOLLARS", :device_data_captured => true)
+      risk_data = Braintree::RiskData.new(:id => "123", :decision => "YOU WON $1000 DOLLARS", :device_data_captured => true, :fraud_service_provider => "kount")
       risk_data.id.should == "123"
       risk_data.decision.should == "YOU WON $1000 DOLLARS"
       risk_data.device_data_captured.should be_truthy
+      risk_data.fraud_service_provider.should == "kount"
     end
   end
 
@@ -15,9 +16,10 @@ describe Braintree::RiskData do
       details = Braintree::RiskData.new(
         :id => "123",
         :decision => "YOU WON $1000 DOLLARS",
-        :device_data_captured => true
+        :device_data_captured => true,
+        :fraud_service_provider => "kount",
       )
-      details.inspect.should == %(#<RiskData id: "123", decision: "YOU WON $1000 DOLLARS", device_data_captured: true>)
+      details.inspect.should == %(#<RiskData id: "123", decision: "YOU WON $1000 DOLLARS", device_data_captured: true, fraud_service_provider: "kount">)
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: braintree
 version: !ruby/object:Gem::Version
-  version: 2.92.0
+  version: 2.93.0
 platform: ruby
 authors:
 - Braintree
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-01 00:00:00.000000000 Z
+date: 2018-12-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: builder
@@ -316,7 +316,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: braintree
-rubygems_version: 2.7.7
+rubygems_version: 2.7.8
 signing_key: 
 specification_version: 4
 summary: Braintree Gateway Ruby Client Library