braintree 2.87.0 → 2.88.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4213a3a4067576307a99ec5057963ae90eee83b7
-  data.tar.gz: 716ecb6baa8f9a0134ac5d1baaa9123058c0aaf4
+  metadata.gz: c971a0bacc5df30ce7c762b37047e83bb86b6036
+  data.tar.gz: 8adfabbcb3d4855170eb3c2e66d6ecd5b8e48a7d
 SHA512:
-  metadata.gz: e74de4236aa5bb09c33775c3a09c67df3714fa74252fa3e0c3e8587460d3a190a09b4e1ea8eb13b8c0de40c2bcf0ece3b2811c1099587c8ecc45dfd6f60ecc42
-  data.tar.gz: 3f62aca3888a83732af83699158fdf5b02cd359e3989b8225f18b21f3255af7c51a51d28fba132452786431aeca1c2bf505714c80b63a0e735cbab977fd042ce
+  metadata.gz: 78286324c7e94afc9281390b7ae4f465a34e823d97e7bdb268ebd899becd492db89ba0695ccf99f07bdf3c3fb854dffb26a1e85ba8a314e1808ec3f1096ac378
+  data.tar.gz: ca5421117f2d7e2d324cf65651071ff1fb3e26eecfeb175a2d8a6efc08a8cb95188cfcdd3b6270a023bc76f76bd0588df2033ffa6051ba3264c48c36387f78d9

data/lib/braintree/error_codes.rb

@@ -668,5 +668,14 @@ module Braintree
         MerchantAccountCannotBeSubMerchantAccount = "94208"
       end
     end
+
+    module UsBankAccountVerification
+      NotConfirmable = "96101"
+      MustBeMicroTransfersVerification = "96102"
+      AmountsDoNotMatch = "96103"
+      TooManyConfirmationAttempts = "96104"
+      UnableToConfirmDepositAmounts = "96105"
+      InvalidDepositAmounts = "96106"
+    end
   end
 end

data/lib/braintree/successful_result.rb

@@ -21,6 +21,7 @@ module Braintree
     attr_reader :subscription
     attr_reader :supported_networks
     attr_reader :transaction
+    attr_reader :us_bank_account_verification
 
     def initialize(attributes = {}) # :nodoc:
       @attrs = attributes.keys

data/lib/braintree/transaction/android_pay_details.rb

@@ -7,10 +7,12 @@ module Braintree
       attr_reader :expiration_month
       attr_reader :expiration_year
       attr_reader :google_transaction_id
+      attr_reader :image_url
       attr_reader :last_4
       attr_reader :source_card_last_4
       attr_reader :source_card_type
       attr_reader :source_description
+      attr_reader :token
       attr_reader :virtual_card_last_4
       attr_reader :virtual_card_type
 

data/lib/braintree/transaction/apple_pay_details.rb

@@ -7,9 +7,11 @@ module Braintree
       attr_reader :cardholder_name
       attr_reader :expiration_month
       attr_reader :expiration_year
+      attr_reader :image_url
       attr_reader :last_4
       attr_reader :payment_instrument_name
       attr_reader :source_description
+      attr_reader :token
 
       def initialize(attributes)
         set_instance_variables_from_hash attributes unless attributes.nil?

data/lib/braintree/us_bank_account_verification.rb

@@ -8,16 +8,18 @@ module Braintree
       GatewayRejected = "gateway_rejected"
       ProcessorDeclined = "processor_declined"
       Verified = "verified"
+      Pending = "pending"
 
-      All = [Failed, GatewayRejected, ProcessorDeclined, Verified]
+      All = [Failed, GatewayRejected, ProcessorDeclined, Verified, Pending]
     end
 
     module VerificationMethod
       IndependentCheck = "independent_check"
       NetworkCheck = "network_check"
       TokenizedCheck = "tokenized_check"
+      MicroTransfers = "micro_transfers"
 
-      All = [IndependentCheck, NetworkCheck, TokenizedCheck]
+      All = [IndependentCheck, NetworkCheck, TokenizedCheck, MicroTransfers]
     end
 
     attr_reader :id
@@ -64,6 +66,10 @@ module Braintree
       self.new *args
     end
 
+    def self.confirm_micro_transfer_amounts(*args)
+      Configuration.gateway.us_bank_account_verification.confirm_micro_transfer_amounts(*args)
+    end
+
     def self.find(*args)
       Configuration.gateway.us_bank_account_verification.find(*args)
     end

data/lib/braintree/us_bank_account_verification_gateway.rb

@@ -6,6 +6,25 @@ module Braintree
       @config.assert_has_access_token_or_keys
     end
 
+    def confirm_micro_transfer_amounts(id, deposit_amounts)
+      raise ArgumentError if id.nil? || id.to_s.strip == "" || !deposit_amounts.kind_of?(Array)
+      response = @config.http.put(
+        "#{@config.base_merchant_path}/us_bank_account_verifications/#{id}/confirm_micro_transfer_amounts",
+        :us_bank_account_verification => {
+          :deposit_amounts => deposit_amounts,
+        },
+      )
+      if response[:api_error_response]
+        ErrorResult.new(@gateway, response[:api_error_response])
+      else
+        SuccessfulResult.new(
+          :us_bank_account_verification => UsBankAccountVerification._new(response[:us_bank_account_verification])
+        )
+      end
+    rescue NotFoundError
+      raise NotFoundError, "verification with id #{id.inspect} not found"
+    end
+
     def find(id)
       raise ArgumentError if id.nil? || id.to_s.strip == ""
       response = @config.http.get("#{@config.base_merchant_path}/us_bank_account_verifications/#{id}")

data/lib/braintree/version.rb

@@ -1,7 +1,7 @@
 module Braintree
   module Version
     Major = 2
-    Minor = 87
+    Minor = 88
     Tiny = 0
 
     String = "#{Major}.#{Minor}.#{Tiny}"

data/spec/integration/braintree/client_api/spec_helper.rb

@@ -55,7 +55,7 @@ def nonce_for_paypal_account(paypal_account_details)
   body["paypalAccounts"][0]["nonce"]
 end
 
-def generate_non_plaid_us_bank_account_nonce
+def generate_non_plaid_us_bank_account_nonce(account_number="1000000000")
   raw_client_token = Braintree::ClientToken.generate
   client_token = decode_client_token(raw_client_token)
 
@@ -71,7 +71,7 @@ def generate_non_plaid_us_bank_account_nonce
     },
     :account_type => "checking",
     :routing_number => "021000021",
-    :account_number => "1000000000",
+    :account_number => account_number,
     :first_name => "John",
     :last_name => "Doe",
     :ownership_type => "personal",

data/spec/integration/braintree/transaction_spec.rb

@@ -1385,6 +1385,30 @@ describe Braintree::Transaction do
         apple_pay_details.expiration_month.to_i.should > 0
         apple_pay_details.expiration_year.to_i.should > 0
         apple_pay_details.cardholder_name.should_not be_nil
+        apple_pay_details.image_url.should_not be_nil
+        apple_pay_details.token.should be_nil
+      end
+
+      it "can create a vaulted transaction with a fake apple pay nonce" do
+        customer = Braintree::Customer.create!
+        result = Braintree::Transaction.create(
+          :type => "sale",
+          :amount => Braintree::Test::TransactionAmounts::Authorize,
+          :payment_method_nonce => Braintree::Test::Nonce::ApplePayVisa,
+          :options => { :store_in_vault_on_success => true }
+        )
+        result.success?.should == true
+        result.transaction.should_not be_nil
+        apple_pay_details = result.transaction.apple_pay_details
+        apple_pay_details.should_not be_nil
+        apple_pay_details.card_type.should == Braintree::ApplePayCard::CardType::Visa
+        apple_pay_details.payment_instrument_name.should == "Visa 8886"
+        apple_pay_details.source_description.should == "Visa 8886"
+        apple_pay_details.expiration_month.to_i.should > 0
+        apple_pay_details.expiration_year.to_i.should > 0
+        apple_pay_details.cardholder_name.should_not be_nil
+        apple_pay_details.image_url.should_not be_nil
+        apple_pay_details.token.should_not be_nil
       end
 
       it "can create a transaction with a fake android pay proxy card nonce" do
@@ -1406,6 +1430,32 @@ describe Braintree::Transaction do
         android_pay_details.expiration_month.to_i.should > 0
         android_pay_details.expiration_year.to_i.should > 0
         android_pay_details.google_transaction_id.should == "google_transaction_id"
+        android_pay_details.image_url.should_not be_nil
+        android_pay_details.token.should be_nil
+      end
+
+      it "can create a vaulted transaction with a fake android pay proxy card nonce" do
+        customer = Braintree::Customer.create!
+        result = Braintree::Transaction.create(
+          :type => "sale",
+          :amount => Braintree::Test::TransactionAmounts::Authorize,
+          :payment_method_nonce => Braintree::Test::Nonce::AndroidPayDiscover,
+          :options => { :store_in_vault_on_success => true }
+        )
+        result.success?.should == true
+        result.transaction.should_not be_nil
+        android_pay_details = result.transaction.android_pay_details
+        android_pay_details.should_not be_nil
+        android_pay_details.card_type.should == Braintree::CreditCard::CardType::Discover
+        android_pay_details.virtual_card_type.should == Braintree::CreditCard::CardType::Discover
+        android_pay_details.last_4.should == "1117"
+        android_pay_details.virtual_card_last_4.should == "1117"
+        android_pay_details.source_description.should == "Discover 1111"
+        android_pay_details.expiration_month.to_i.should > 0
+        android_pay_details.expiration_year.to_i.should > 0
+        android_pay_details.google_transaction_id.should == "google_transaction_id"
+        android_pay_details.image_url.should_not be_nil
+        android_pay_details.token.should_not be_nil
       end
 
       it "can create a transaction with a fake android pay network token nonce" do

data/spec/integration/braintree/us_bank_account_verification_spec.rb

@@ -1,7 +1,7 @@
 require File.expand_path(File.dirname(__FILE__) + "/../spec_helper")
 require File.expand_path(File.dirname(__FILE__) + "/client_api/spec_helper")
 
-describe Braintree::UsBankAccountVerification, "search" do
+describe Braintree::UsBankAccountVerification do
   let(:nonce) { generate_non_plaid_us_bank_account_nonce }
   let(:customer) do
     params = {
@@ -13,6 +13,167 @@ describe Braintree::UsBankAccountVerification, "search" do
     Braintree::Customer.create(params).customer
   end
 
+  describe "self.confirm_micro_transfer_amounts" do
+    before do
+      Braintree::Configuration.merchant_id = "integration2_merchant_id"
+      Braintree::Configuration.public_key = "integration2_public_key"
+      Braintree::Configuration.private_key = "integration2_private_key"
+    end
+
+    after(:all) do
+      Braintree::Configuration.merchant_id = "integration_merchant_id"
+      Braintree::Configuration.public_key = "integration_public_key"
+      Braintree::Configuration.private_key = "integration_private_key"
+    end
+
+    context "with a micro transfer verification" do
+      it "successfully confirms settled amounts" do
+        nonce = generate_non_plaid_us_bank_account_nonce("1000000000")
+
+        result = Braintree::PaymentMethod.create(
+          :payment_method_nonce => nonce,
+          :customer_id => customer.id,
+          :options => {
+            :verification_merchant_account_id => SpecHelper::AnotherUsBankMerchantAccountId,
+            :us_bank_account_verification_method => Braintree::UsBankAccountVerification::VerificationMethod::MicroTransfers,
+          }
+        )
+
+        result.should be_success
+
+        verification = result.payment_method.verifications.first
+        verification.verification_method.should == Braintree::UsBankAccountVerification::VerificationMethod::MicroTransfers
+        verification.status.should == Braintree::UsBankAccountVerification::Status::Pending
+
+        response = Braintree::UsBankAccountVerification.confirm_micro_transfer_amounts(verification.id, [17, 29])
+
+        response.should be_success
+        response.us_bank_account_verification.status.should == Braintree::UsBankAccountVerification::Status::Verified
+
+        us_bank_account = Braintree::UsBankAccount.find(response.us_bank_account_verification.us_bank_account[:token])
+
+        us_bank_account.verified.should be_truthy
+      end
+
+      it "successfully confirms not-yet-settled amounts" do
+        nonce = generate_non_plaid_us_bank_account_nonce("1000000001")
+
+        result = Braintree::PaymentMethod.create(
+          :payment_method_nonce => nonce,
+          :customer_id => customer.id,
+          :options => {
+            :verification_merchant_account_id => SpecHelper::AnotherUsBankMerchantAccountId,
+            :us_bank_account_verification_method => Braintree::UsBankAccountVerification::VerificationMethod::MicroTransfers,
+          }
+        )
+
+        result.should be_success
+
+        verification = result.payment_method.verifications.first
+        verification.verification_method.should == Braintree::UsBankAccountVerification::VerificationMethod::MicroTransfers
+        verification.status.should == Braintree::UsBankAccountVerification::Status::Pending
+
+        response = Braintree::UsBankAccountVerification.confirm_micro_transfer_amounts(verification.id, [17, 29])
+
+        response.should be_success
+        response.us_bank_account_verification.status.should == Braintree::UsBankAccountVerification::Status::Pending
+      end
+
+      it "attempts to confirm" do
+        result = Braintree::PaymentMethod.create(
+          :payment_method_nonce => nonce,
+          :customer_id => customer.id,
+          :options => {
+            :verification_merchant_account_id => SpecHelper::AnotherUsBankMerchantAccountId,
+            :us_bank_account_verification_method => Braintree::UsBankAccountVerification::VerificationMethod::MicroTransfers,
+          }
+        )
+
+        result.should be_success
+
+        verification = result.payment_method.verifications.first
+        verification.verification_method.should == Braintree::UsBankAccountVerification::VerificationMethod::MicroTransfers
+        verification.status.should == Braintree::UsBankAccountVerification::Status::Pending
+
+        response = Braintree::UsBankAccountVerification.confirm_micro_transfer_amounts(verification.id, [1, 1])
+
+        response.should_not be_success
+        response.errors.for(:us_bank_account_verification)[0].code.should == Braintree::ErrorCodes::UsBankAccountVerification::AmountsDoNotMatch
+      end
+
+      it "exceeds the confirmation attempt threshold" do
+        result = Braintree::PaymentMethod.create(
+          :payment_method_nonce => nonce,
+          :customer_id => customer.id,
+          :options => {
+            :verification_merchant_account_id => SpecHelper::AnotherUsBankMerchantAccountId,
+            :us_bank_account_verification_method => Braintree::UsBankAccountVerification::VerificationMethod::MicroTransfers,
+          }
+        )
+
+        result.should be_success
+
+        verification = result.payment_method.verifications.first
+
+        response = nil
+        4.times do
+          response = Braintree::UsBankAccountVerification.confirm_micro_transfer_amounts(verification.id, [1, 1])
+
+          response.should_not be_success
+          response.errors.for(:us_bank_account_verification)[0].code.should == Braintree::ErrorCodes::UsBankAccountVerification::AmountsDoNotMatch
+        end
+
+        response = Braintree::UsBankAccountVerification.confirm_micro_transfer_amounts(verification.id, [1, 1])
+        response.should_not be_success
+        response.errors.for(:us_bank_account_verification)[0].code.should == Braintree::ErrorCodes::UsBankAccountVerification::TooManyConfirmationAttempts
+
+        response = Braintree::UsBankAccountVerification.confirm_micro_transfer_amounts(verification.id, [1, 1])
+        response.should_not be_success
+        response.errors.for(:us_bank_account_verification)[0].code.should == Braintree::ErrorCodes::UsBankAccountVerification::TooManyConfirmationAttempts
+      end
+
+      it "returns an error for invalid deposit amounts" do
+        result = Braintree::PaymentMethod.create(
+          :payment_method_nonce => nonce,
+          :customer_id => customer.id,
+          :options => {
+            :verification_merchant_account_id => SpecHelper::AnotherUsBankMerchantAccountId,
+            :us_bank_account_verification_method => Braintree::UsBankAccountVerification::VerificationMethod::MicroTransfers,
+          }
+        )
+
+        result.should be_success
+
+        verification = result.payment_method.verifications.first
+        response = Braintree::UsBankAccountVerification.confirm_micro_transfer_amounts(verification.id, ["abc"])
+
+        response.should_not be_success
+        response.errors.for(:us_bank_account_verification)[0].code.should == Braintree::ErrorCodes::UsBankAccountVerification::InvalidDepositAmounts
+      end
+    end
+
+    context "non-micro transfer" do
+      it "rejects for incorrect verification type" do
+        result = Braintree::PaymentMethod.create(
+          :payment_method_nonce => nonce,
+          :customer_id => customer.id,
+          :options => {
+            :verification_merchant_account_id => SpecHelper::AnotherUsBankMerchantAccountId,
+            :us_bank_account_verification_method => Braintree::UsBankAccountVerification::VerificationMethod::NetworkCheck,
+          }
+        )
+
+        result.should be_success
+
+        verification = result.payment_method.verifications.first
+        response = Braintree::UsBankAccountVerification.confirm_micro_transfer_amounts(verification.id, [1, 1])
+
+        response.should_not be_success
+        response.errors.for(:us_bank_account_verification)[0].code.should == Braintree::ErrorCodes::UsBankAccountVerification::MustBeMicroTransfersVerification
+      end
+    end
+  end
+
   describe "self.find" do
     it "finds the verification with the given id" do
       result = Braintree::PaymentMethod.create(

data/spec/unit/braintree/us_bank_account_verification_spec.rb

@@ -16,6 +16,32 @@ describe Braintree::UsBankAccountVerification do
     end
   end
 
+  describe "self.confirm_micro_transfer_amounts" do
+    it "raises error if passed empty string" do
+      expect do
+        Braintree::UsBankAccountVerification.confirm_micro_transfer_amounts("", [])
+      end.to raise_error(ArgumentError)
+    end
+
+    it "raises error if passed empty string wth space" do
+      expect do
+        Braintree::UsBankAccountVerification.confirm_micro_transfer_amounts(" ", [])
+      end.to raise_error(ArgumentError)
+    end
+
+    it "raises error if passed nil" do
+      expect do
+        Braintree::UsBankAccountVerification.confirm_micro_transfer_amounts(nil, [])
+      end.to raise_error(ArgumentError)
+    end
+
+    it "raises error if passed non-array" do
+      expect do
+        Braintree::UsBankAccountVerification.confirm_micro_transfer_amounts(999, 123)
+      end.to raise_error(ArgumentError)
+    end
+  end
+
   describe "self.find" do
     it "raises error if passed empty string" do
       expect do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: braintree
 version: !ruby/object:Gem::Version
-  version: 2.87.0
+  version: 2.88.0
 platform: ruby
 authors:
 - Braintree
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-04-12 00:00:00.000000000 Z
+date: 2018-04-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: builder
@@ -185,7 +185,6 @@ files:
 - spec/fixtures/files/gif_extension_bt_logo.gif
 - spec/fixtures/files/malformed_pdf.pdf
 - spec/hacks/tcp_socket.rb
-- spec/httpsd.pid
 - spec/integration/braintree/add_on_spec.rb
 - spec/integration/braintree/address_spec.rb
 - spec/integration/braintree/advanced_search_spec.rb
@@ -306,7 +305,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: braintree
-rubygems_version: 2.5.2
+rubygems_version: 2.6.14
 signing_key: 
 specification_version: 4
 summary: Braintree Gateway Ruby Client Library

data/spec/httpsd.pid

@@ -1 +0,0 @@
-8020