braintree 2.20.0 → 2.21.0

data/lib/braintree/error_codes.rb

@@ -180,6 +180,7 @@ module Braintree
       MerchantAccountNameIsInvalid = "91513" # Deprecated
       OrderIdIsTooLong = "91501"
       PaymentMethodConflict = "91515"
+      PaymentMethodConflictWithVenmoSDK = "91549"
       PaymentMethodDoesNotBelongToCustomer = "91516"
       PaymentMethodDoesNotBelongToSubscription = "91527"
       PaymentMethodTokenCardTypeIsNotAccepted = "91517"

data/lib/braintree/transaction/credit_card_details.rb

@@ -4,7 +4,8 @@ module Braintree
       include BaseModule
 
       attr_reader :bin, :card_type, :cardholder_name, :customer_location, :expiration_month,
-        :expiration_year, :last_4, :token
+        :expiration_year, :last_4, :token, :prepaid, :healthcare, :durbin_regulated, :debit,
+        :commercial, :payroll, :country_of_issuance, :issuing_bank
 
       def initialize(attributes)
         set_instance_variables_from_hash attributes unless attributes.nil?
@@ -15,7 +16,8 @@ module Braintree
       end
 
       def inspect
-        attr_order = [:token, :bin, :last_4, :card_type, :expiration_date, :cardholder_name, :customer_location]
+        attr_order = [:token, :bin, :last_4, :card_type, :expiration_date, :cardholder_name, :customer_location, :prepaid,
+        :healthcare, :durbin_regulated, :debit, :commercial, :payroll, :country_of_issuance, :issuing_bank]
         formatted_attrs = attr_order.map do |attr|
           "#{attr}: #{send(attr).inspect}"
         end

data/lib/braintree/util.rb

@@ -26,11 +26,11 @@ module Braintree
     end
 
     def self.url_decode(text)
-      CGI.unescape text.to_s
+      CGI.unescape text.to_s.to_str
     end
 
     def self.url_encode(text)
-      CGI.escape text.to_s
+      CGI.escape text.to_s.to_str
     end
 
     def self.symbolize_keys(hash)

data/lib/braintree/version.rb

@@ -1,7 +1,7 @@
 module Braintree
   module Version
     Major = 2
-    Minor = 20
+    Minor = 21
     Tiny = 0
 
     String = "#{Major}.#{Minor}.#{Tiny}"

data/spec/httpsd.pid

@@ -1 +1 @@
-54061
+44961

data/spec/integration/braintree/credit_card_verification_spec.rb

@@ -25,5 +25,31 @@ describe Braintree::CreditCardVerification, "search" do
         Braintree::CreditCardVerification.find("invalid-id")
       end.to raise_error(Braintree::NotFoundError, 'verification with id "invalid-id" not found')
     end
+
+    describe "card type indicators" do
+      it "returns prepaid on a prepaid card" do
+        cardholder_name = "Tom #{rand(1_000_000)} Smith"
+
+        result = Braintree::Customer.create(
+          :credit_card => {
+          :cardholder_name => cardholder_name,
+          :expiration_date => "05/2012",
+          :number => Braintree::Test::CreditCardNumbers::CardTypeIndicators::Prepaid,
+          :cvv => '200',
+          :options => {
+            :verify_card => true
+        }
+        })
+
+        search_results = Braintree::CreditCardVerification.search do |search|
+          search.credit_card_cardholder_name.is cardholder_name
+        end
+
+        verification_id = search_results.first.id
+
+        found_verification = Braintree::CreditCardVerification.find(verification_id)
+        found_verification.credit_card[:prepaid].should == Braintree::CreditCard::Prepaid::Yes
+      end
+    end
   end
 end

data/spec/integration/braintree/transaction_spec.rb

@@ -115,6 +115,21 @@ describe Braintree::Transaction do
   end
 
   describe "self.create" do
+
+    describe "card type indicators" do
+      it "sets the prepaid field if the card is prepaid" do
+        result = Braintree::Transaction.create(
+          :type => "sale",
+          :amount => 1_00,
+          :credit_card => {
+          :number => Braintree::Test::CreditCardNumbers::CardTypeIndicators::Prepaid,
+          :expiration_date => "05/2009"
+        }
+        )
+        result.transaction.credit_card_details.prepaid.should == Braintree::CreditCard::Prepaid::Yes
+      end
+    end
+
     it "returns a successful result if successful" do
       result = Braintree::Transaction.create(
         :type => "sale",
@@ -461,7 +476,7 @@ describe Braintree::Transaction do
       }
       result = Braintree::Transaction.create(params[:transaction])
       result.success?.should == false
-      result.errors.for(:transaction).on(:base).map{|error| error.code}.should include(Braintree::ErrorCodes::Transaction::PaymentMethodConflict)
+      result.errors.for(:transaction).on(:base).map{|error| error.code}.should include(Braintree::ErrorCodes::Transaction::PaymentMethodConflictWithVenmoSDK)
       result.errors.for(:transaction).on(:base).map{|error| error.code}.should include(Braintree::ErrorCodes::Transaction::PaymentMethodDoesNotBelongToCustomer)
       result.errors.for(:transaction).on(:amount)[0].code.should == Braintree::ErrorCodes::Transaction::AmountIsRequired
       result.errors.for(:transaction).on(:customer_id)[0].code.should == Braintree::ErrorCodes::Transaction::CustomerIdIsInvalid

data/spec/unit/braintree/transaction/credit_card_details_spec.rb

@@ -21,10 +21,19 @@ describe Braintree::Transaction::CreditCardDetails do
         :expiration_year => "2012",
         :last_4 => "6789",
         :token => "token",
-        :customer_location => "US"
+        :customer_location => "US",
+        :healthcare => "No",
+        :prepaid => "Yes",
+        :durbin_regulated => "No",
+        :debit => "Yes",
+        :commercial => "Unknown",
+        :payroll => "Unknown",
+        :country_of_issuance => "Lilliput",
+        :issuing_bank => "Gulliver Bank"
       )
-      details.inspect.should == %(#<token: "token", bin: "123456", last_4: "6789", card_type: "Visa", expiration_date: "05/2012", cardholder_name: "The Cardholder", customer_location: "US">)
+      details.inspect.should == %(#<token: "token", bin: "123456", last_4: "6789", card_type: "Visa", expiration_date: "05/2012", cardholder_name: "The Cardholder", customer_location: "US", prepaid: "Yes", healthcare: "No", durbin_regulated: "No", debit: "Yes", commercial: "Unknown", payroll: "Unknown", country_of_issuance: "Lilliput", issuing_bank: "Gulliver Bank">)
     end
+
   end
 
   describe "masked_number" do

data/spec/unit/braintree/transaction_spec.rb

@@ -95,7 +95,15 @@ describe Braintree::Transaction do
           :card_type => "Visa",
           :expiration_month => "08",
           :expiration_year => "2009",
-          :customer_location => "US"
+          :customer_location => "US",
+          :prepaid => "Yes",
+          :healthcare => "Yes",
+          :durbin_regulated => "Yes",
+          :debit => "Yes",
+          :commercial => "No",
+          :payroll => "Unknown",
+          :country_of_issuance => "Narnia",
+          :issuing_bank => "Mr Tumnus"
         }
       )
       transaction.credit_card_details.token.should == "mzg2"
@@ -105,6 +113,13 @@ describe Braintree::Transaction do
       transaction.credit_card_details.expiration_month.should == "08"
       transaction.credit_card_details.expiration_year.should == "2009"
       transaction.credit_card_details.customer_location.should == "US"
+      transaction.credit_card_details.prepaid.should == Braintree::CreditCard::Prepaid::Yes
+      transaction.credit_card_details.healthcare.should == Braintree::CreditCard::Healthcare::Yes
+      transaction.credit_card_details.durbin_regulated.should == Braintree::CreditCard::DurbinRegulated::Yes
+      transaction.credit_card_details.debit.should == Braintree::CreditCard::Debit::Yes
+      transaction.credit_card_details.commercial.should == Braintree::CreditCard::Commercial::No
+      transaction.credit_card_details.country_of_issuance.should == "Narnia"
+      transaction.credit_card_details.issuing_bank.should == "Mr Tumnus"
     end
 
     it "sets up history attributes in status_history" do

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: braintree
 version: !ruby/object:Gem::Version 
-  hash: 95
+  hash: 91
   prerelease: false
   segments: 
   - 2
-  - 20
+  - 21
   - 0
-  version: 2.20.0
+  version: 2.21.0
 platform: ruby
 authors: 
 - Braintree
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-11-09 00:00:00 -06:00
+date: 2012-12-05 00:00:00 -06:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency