braintree 2.13.4 → 2.14.0

data/lib/braintree/advanced_search.rb

@@ -14,8 +14,12 @@ module Braintree
       end
     end
 
-    class EqualityNode < SearchNode # :nodoc:
-      operators :is, :is_not
+    class IsNode < SearchNode # :nodoc:
+      operators :is
+    end
+
+    class EqualityNode < IsNode # :nodoc:
+      operators :is_not
     end
 
     class PartialMatchNode < EqualityNode # :nodoc:
@@ -93,6 +97,10 @@ module Braintree
       _create_field_accessors(fields, EqualityNode)
     end
 
+    def self.is_fields(*fields)
+      _create_field_accessors(fields, IsNode)
+    end
+
     def self.partial_match_fields(*fields)
       _create_field_accessors(fields, PartialMatchNode)
     end

data/lib/braintree/credit_card_gateway.rb

@@ -76,15 +76,17 @@ module Braintree
 
     def self._signature(type) # :nodoc:
       billing_address_params = AddressGateway._shared_signature
+      options = [:make_default, :verification_merchant_account_id, :verify_card]
       signature = [
         :billing_address_id, :cardholder_name, :cvv, :expiration_date,
         :expiration_month, :expiration_year, :number, :token,
-        {:options => [:make_default, :verification_merchant_account_id, :verify_card]},
+        {:options => options},
         {:billing_address => billing_address_params}
       ]
 
       case type
       when :create
+        options << :fail_on_duplicate_payment_method
         signature << :customer_id
       when :update
         billing_address_params << {:options => [:update_existing]}

data/lib/braintree/customer_search.rb

@@ -21,6 +21,8 @@ module Braintree
       :website
     )
 
+    is_fields :payment_method_token_with_duplicates
+
     equality_fields :credit_card_expiration_date
 
     partial_match_fields :credit_card_number

data/lib/braintree/error_codes.rb

@@ -36,6 +36,7 @@ module Braintree
       CustomerIdIsRequired = "91704"
       CvvIsInvalid = "81707"
       CvvIsRequired = "81706"
+      DuplicateCardExists = "81724"
       ExpirationDateConflict = "91708"
       ExpirationDateIsInvalid = "81710"
       ExpirationDateIsRequired = "81709"
@@ -174,7 +175,7 @@ module Braintree
       CustomerIdIsInvalid = "91510"
       HasAlreadyBeenRefunded = "91512"
       MerchantAccountIdIsInvalid = "91513"
-      MerchantAccountIsSuspended = "91515"
+      MerchantAccountIsSuspended = "91514"
       MerchantAccountDoesNotSupportRefunds = "91547"
       MerchantAccountNameIsInvalid = "91513" # Deprecated
       OrderIdIsTooLong = "91501"

data/lib/braintree/version.rb

@@ -1,8 +1,8 @@
 module Braintree
   module Version
     Major = 2
-    Minor = 13
-    Tiny = 4
+    Minor = 14
+    Tiny = 0
 
     String = "#{Major}.#{Minor}.#{Tiny}"
   end

data/spec/integration/braintree/credit_card_spec.rb

@@ -1088,6 +1088,25 @@ describe Braintree::CreditCard do
       update_result.credit_card_verification.status.should == Braintree::Transaction::Status::ProcessorDeclined
     end
 
+    it "fails on create if credit_card[options][fail_on_duplicate_payment_method]=true and there is a duplicated payment method" do
+      customer = Braintree::Customer.create!
+      Braintree::CreditCard.create(
+        :customer_id => customer.id,
+        :number => Braintree::Test::CreditCardNumbers::Visa,
+        :expiration_date => "05/2015"
+      )
+
+      result = Braintree::CreditCard.create(
+        :customer_id => customer.id,
+        :number => Braintree::Test::CreditCardNumbers::Visa,
+        :expiration_date => "05/2015",
+        :options => {:fail_on_duplicate_payment_method => true}
+      )
+
+      result.success?.should == false
+      result.errors.for(:credit_card).on(:number)[0].message.should == "Duplicate card exists in the vault."
+    end
+
     it "allows user to specify merchant account for verification" do
       customer = Braintree::Customer.create!
       credit_card = Braintree::CreditCard.create!(

data/spec/integration/braintree/customer_search_spec.rb

@@ -89,6 +89,31 @@ describe Braintree::Transaction, "search" do
       collection.first.id.should == customer.id
     end
 
+    it "can find duplicate credit cards for a give payment method token " do
+      jim = Braintree::Customer.create(
+        :first_name => "Jim",
+        :credit_card => {
+          :number => Braintree::Test::CreditCardNumbers::Maestro,
+          :expiration_date => "05/2012"
+        }
+      ).customer
+
+      joe = Braintree::Customer.create(
+        :first_name => "Joe",
+        :credit_card => {
+          :number => Braintree::Test::CreditCardNumbers::Maestro,
+          :expiration_date => "05/2012"
+        }
+      ).customer
+
+      collection = Braintree::Customer.search do |search|
+        search.payment_method_token_with_duplicates.is jim.credit_cards.first.token
+      end
+
+      collection.should include(jim)
+      collection.should include(joe)
+    end
+
     it "can search by created_at" do
       company = "Company #{rand(1_000_000)}"
       customer = Braintree::Customer.create!(

data/spec/integration/braintree/customer_spec.rb

@@ -127,6 +127,27 @@ describe Braintree::Customer do
       result.credit_card_verification.status.should == Braintree::Transaction::Status::ProcessorDeclined
     end
 
+    it "fails on create if credit_card[options][fail_on_duplicate_payment_method]=true and there is a duplicated payment method" do
+      customer = Braintree::Customer.create!
+      Braintree::CreditCard.create(
+        :customer_id => customer.id,
+        :number => Braintree::Test::CreditCardNumbers::Visa,
+        :expiration_date => "05/2015"
+      )
+
+      result = Braintree::Customer.create(
+        :first_name => "Mike",
+        :last_name => "Jones",
+        :credit_card => {
+          :number => Braintree::Test::CreditCardNumbers::FailsSandboxVerification::MasterCard,
+          :expiration_date => "05/2015",
+          :options => {:fail_on_duplicate_payment_method => true}
+        }
+      )
+      result.success?.should == false
+      result.errors.for(:customer).for(:credit_card).on(:number)[0].message.should == "Duplicate card exists in the vault."
+    end
+
     it "allows the user to specify the merchant account for verification" do
       result = Braintree::Customer.create(
         :first_name => "Mike",

data/spec/unit/braintree/credit_card_spec.rb

@@ -20,7 +20,7 @@ describe Braintree::CreditCard do
         :expiration_year,
         :number,
         :token,
-        {:options => [:make_default, :verification_merchant_account_id, :verify_card]},
+        {:options => [:make_default, :verification_merchant_account_id, :verify_card, :fail_on_duplicate_payment_method]},
         {:billing_address => [
           :company,
           :country_code_alpha2,

data/spec/unit/braintree/customer_spec.rb

@@ -83,7 +83,7 @@ describe Braintree::Customer do
           :expiration_year,
           :number,
           :token,
-          {:options => [:make_default, :verification_merchant_account_id, :verify_card]},
+          {:options => [:make_default, :verification_merchant_account_id, :verify_card, :fail_on_duplicate_payment_method]},
           {:billing_address => [
             :company,
             :country_code_alpha2,

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: braintree
 version: !ruby/object:Gem::Version 
-  hash: 51
-  prerelease: 
+  hash: 55
+  prerelease: false
   segments: 
   - 2
-  - 13
-  - 4
-  version: 2.13.4
+  - 14
+  - 0
+  version: 2.14.0
 platform: ruby
 authors: 
 - Braintree
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-02-07 00:00:00 -06:00
+date: 2012-03-06 00:00:00 -06:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -185,7 +185,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: braintree
-rubygems_version: 1.4.2
+rubygems_version: 1.3.7
 signing_key: 
 specification_version: 3
 summary: Braintree Gateway Ruby Client Library