braintree-rails 1.4.0 → 1.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: beb78e264daf6f5aa910f0f22a037a401de719ee
-  data.tar.gz: 964ddabe92b7e24904d9fc2a7611c3eb7f57721f
+  metadata.gz: 51d3059b858bb2192c5a21e6fe99da5b79ce2dbd
+  data.tar.gz: 51a3f9d66af180e42bbc0e5beea380a8fe3e3853
 SHA512:
-  metadata.gz: 45abffe047116fef0dff574b3bc833afa11e1c44af7c1019776b387f5f80123d0e4bf186200fa0f6bac331d1cda858080ef50d864d7656d367afb5d74c133c4e
-  data.tar.gz: 1c45542fe5e4ce03cd46a8b2e00f0a289c4f5fdbc643b7af83624c21962b317a09636c019eda5bd7b1b5fecd421ce1ddb300bfa5c126ab272b25e3e730af3745
+  metadata.gz: 48a8b5c76024facbfe7b091d804b072ed91a4d18f68bacb565d46bc0a7f13d704ceda99d0fd55e646c104db4a2ee1f96e8c7790e10e0d77cae9a56fd456e527a
+  data.tar.gz: eb131427147d9b22525738f4e9b04f93598f6d6e9c7fd0c7eae24c5f6b9e3261aacdac89bf28934d898b6f60f1658393dec412c4e5ad45c51970619978f38601

data/CHANGELOG.md

@@ -1,4 +1,12 @@
 ## Unreleased (master)
+### Enhancements
+  * Added image_url to credit card readonly attributes. (Thanks, @maxkaplan)
+
+### Bug Fixes
+  * Fix propagation of braintree reported errors to associations in merchant accounts. (Thanks, @twalpole)
+  * Do not raise exception on gateway rejected transactions. (Thanks, @murtyk)
+
+## v1.4.0 (0830c14), Dec 12 2014
 ### Enhancements
   * Added `service_fee_amount` to `BraintreeRails::Transaction`. (Thanks, @KELiON)
   * Enhanced validation error parsing so that they can be customized/i18n-ed

data/Gemfile

@@ -7,5 +7,6 @@ group :test do
   gem 'rake'
   gem 'rspec'
   gem 'webmock'
+  gem 'pry'
   gem 'coveralls', require: false
 end

data/Gemfile.lock

@@ -14,6 +14,7 @@ GEM
     braintree (2.38.0)
       builder (>= 2.0.0)
     builder (3.2.2)
+    coderay (1.1.0)
     coveralls (0.7.2)
       multi_json (~> 1.3)
       rest-client (= 1.6.7)
@@ -26,9 +27,14 @@ GEM
     docile (1.1.5)
     i18n (0.6.11)
     json (1.8.1)
+    method_source (0.8.2)
     mime-types (2.4.3)
     minitest (5.4.3)
     multi_json (1.10.1)
+    pry (0.10.3)
+      coderay (~> 1.1.0)
+      method_source (~> 0.8.1)
+      slop (~> 3.4)
     rake (10.4.2)
     rest-client (1.6.7)
       mime-types (>= 1.16)
@@ -50,6 +56,7 @@ GEM
       multi_json (~> 1.0)
       simplecov-html (~> 0.8.0)
     simplecov-html (0.8.0)
+    slop (3.6.0)
     term-ansicolor (1.2.2)
       tins (~> 0.8)
     thor (0.18.1)
@@ -69,6 +76,10 @@ DEPENDENCIES
   activesupport (>= 3.0)
   braintree (>= 2.28.0)
   coveralls
+  pry
   rake
   rspec
   webmock
+
+BUNDLED WITH
+   1.10.6

data/lib/braintree_rails/address_details.rb

@@ -10,5 +10,9 @@ module BraintreeRails
     def self.braintree_model_name
       "merchant_account/#{name.demodulize.underscore}"
     end
+
+    def extract_errors(errors)
+      errors.for(:address) if errors
+    end
   end
 end

data/lib/braintree_rails/business_details.rb

@@ -14,7 +14,7 @@ module BraintreeRails
     end
 
     def add_errors(validation_errors)
-      address.add_errors(validation_errors) if address
+      address.add_errors(extract_errors(validation_errors)) if address
       super(validation_errors)
     end
 
@@ -25,5 +25,9 @@ module BraintreeRails
     def address_attributes
       address.present? ? {:address => address.attributes_for(:as_association)} : {}
     end
+
+    def extract_errors(errors)
+      errors.for(:business)
+    end
   end
 end

data/lib/braintree_rails/credit_card.rb

@@ -6,7 +6,7 @@ module BraintreeRails
       :update => [:billing_address, :cardholder_name, :expiration_date, :expiration_month, :expiration_year, :options, :number, :cvv, :device_data],
       :readonly => [
         :bin, :card_type, :commercial, :country_of_issuance, :created_at, :debit, :durbin_regulated, :default,
-        :expired, :healthcare, :issuing_bank, :last_4, :payroll, :prepaid, :unique_number_identifier, :updated_at
+        :expired, :healthcare, :issuing_bank, :image_url, :last_4, :payroll, :prepaid, :unique_number_identifier, :updated_at
       ],
       :as_association => [:cardholder_name, :cvv, :expiration_date, :expiration_month, :expiration_year, :number]
     )

data/lib/braintree_rails/funding_details.rb

@@ -13,5 +13,9 @@ module BraintreeRails
     def self.braintree_model_name
       "merchant_account/#{name.demodulize.underscore}"
     end
+
+    def extract_errors(errors)
+      errors.for(:funding)
+    end
   end
 end

data/lib/braintree_rails/individual_details.rb

@@ -17,7 +17,7 @@ module BraintreeRails
     end
 
     def add_errors(validation_errors)
-      address.add_errors(validation_errors) if address
+      address.add_errors(extract_errors(validation_errors)) if address
       super(validation_errors)
     end
 
@@ -28,5 +28,9 @@ module BraintreeRails
     def address_attributes
       address.present? ? {:address => address.attributes_for(:as_association)} : {}
     end
+
+    def extract_errors(errors)
+      errors.for(:individual)
+    end
   end
 end

data/lib/braintree_rails/merchant_account.rb

@@ -20,13 +20,13 @@ module BraintreeRails
     after_create :reload, :if => :persisted?
 
     def add_errors(validation_errors)
-      propergate_errors_to_associations(extract_errors(validation_errors))
+      propagate_errors_to_associations(extract_errors(validation_errors))
       super(validation_errors)
     end
 
-    def propergate_errors_to_associations(validation_errors)
+    def propagate_errors_to_associations(validation_errors)
       [individual, business, funding].each do |association|
-        association.add_errors(validation_errors) if association
+        association.add_errors(validation_errors) if association && errors
       end
     end
 

data/lib/braintree_rails/persistence.rb

@@ -114,13 +114,17 @@ module BraintreeRails
       def with_update_braintree(context)
         raise RecordInvalid.new(self) unless valid?(context)
         run_callbacks context do
-          result = yield
-          if result.respond_to?(:success?) && !result.success?
+          case result = yield
+          when Braintree::ErrorResult
+            if result.respond_to?(self.class.braintree_model_name) && result.send(self.class.braintree_model_name)
+              init(result.send(self.class.braintree_model_name))
+            end
             add_errors(result.errors)
             false
+          when Braintree::SuccessfulResult
+            init(result.send(self.class.braintree_model_name))
           else
-            new_record = result.respond_to?(self.class.braintree_model_name) ? result.send(self.class.braintree_model_name) : result
-            init(new_record)
+            init(result)
           end
         end
       end
@@ -136,4 +140,4 @@ module BraintreeRails
       end
     end
   end
-end
+end

data/lib/braintree_rails/transaction.rb

@@ -13,8 +13,8 @@ module BraintreeRails
       :readonly => [
         :avs_error_response_code, :avs_postal_code_response_code, :avs_street_address_response_code, :billing_details,
         :channel, :created_at, :credit_card, :credit_card_details, :currency_iso_code, :customer, :customer_details,
-        :cvv_response_code, :id, :plan_id, :purchase_order_number, :refund_ids, :refunded_transaction_id, :settlement_batch_id,
-        :shipping_details, :status, :status_history, :subscription_details, :updated_at
+        :cvv_response_code, :gateway_rejection_reason, :id, :plan_id, :purchase_order_number, :refund_ids, :refunded_transaction_id,
+        :settlement_batch_id, :shipping_details, :status, :status_history, :subscription_details, :updated_at
       ]
     )
 
@@ -64,7 +64,7 @@ module BraintreeRails
     end
 
     def add_errors(validation_errors)
-      propergate_errors_to_associations(extract_errors(validation_errors))
+      propagate_errors_to_associations(extract_errors(validation_errors))
       super(validation_errors)
     end
 
@@ -80,9 +80,9 @@ module BraintreeRails
 
     protected
 
-    def propergate_errors_to_associations(errors)
+    def propagate_errors_to_associations(errors)
       [customer, credit_card, billing, shipping].each do |association|
-        association.add_errors(errors) if association
+        association.add_errors(errors) if association && errors
       end
     end
 
@@ -116,4 +116,4 @@ module BraintreeRails
       end
     end
   end
-end
+end

data/lib/braintree_rails/version.rb

@@ -1,3 +1,3 @@
 module BraintreeRails
-  Version = "1.4.0"
+  Version = "1.4.1"
 end

data/spec/config/braintree_auth.yml.example

@@ -1,4 +1,5 @@
 ---
 merchant_id: 'merchant_id'
 public_key: 'public_key'
-private_key: 'private_key'
+private_key: 'private_key'
+default_merchant_account_id: 'default_merchant_account_id'

data/spec/fixtures/gateway_rejected.xml

@@ -0,0 +1,147 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<api-error-response>
+  <errors>
+    <errors type="array"/>
+  </errors>
+  <params>
+    <transaction>
+      <amount>5001</amount>
+      <type>sale</type>
+      <customer-id>customer_id</customer-id>
+      <payment-method-token>credit_card_id</payment-method-token>
+    </transaction>
+  </params>
+  <message>Gateway Rejected: application_incomplete</message>
+  <transaction>
+    <id>transactionid</id>
+    <status>gateway_rejected</status>
+    <type>sale</type>
+    <currency-iso-code>USD</currency-iso-code>
+    <amount>5001.00</amount>
+    <merchant-account-id>merchant_id</merchant-account-id>
+    <order-id nil="true"/>
+    <created-at type="datetime">2015-11-21T22:23:51Z</created-at>
+    <updated-at type="datetime">2015-11-21T22:23:51Z</updated-at>
+    <customer>
+      <id>customer_id</id>
+      <first-name>Brain47</first-name>
+      <last-name>Tree17</last-name>
+      <company nil="true"/>
+      <email nil="true"/>
+      <website nil="true"/>
+      <phone nil="true"/>
+      <fax nil="true"/>
+    </customer>
+    <billing>
+      <id>ff</id>
+      <first-name>Brain</first-name>
+      <last-name>Tree</last-name>
+      <company>Braintree</company>
+      <street-address>8711 Crane Avenue</street-address>
+      <extended-address>Suite 629</extended-address>
+      <locality>Menlo Park</locality>
+      <region>CA</region>
+      <postal-code>82875</postal-code>
+      <country-name>United States of America</country-name>
+      <country-code-alpha2>US</country-code-alpha2>
+      <country-code-alpha3>USA</country-code-alpha3>
+      <country-code-numeric>840</country-code-numeric>
+    </billing>
+    <refund-id nil="true"/>
+    <refund-ids type="array"/>
+    <refunded-transaction-id nil="true"/>
+    <partial-settlement-transaction-ids type="array"/>
+    <authorized-transaction-id nil="true"/>
+    <settlement-batch-id nil="true"/>
+    <shipping>
+      <id nil="true"/>
+      <first-name nil="true"/>
+      <last-name nil="true"/>
+      <company nil="true"/>
+      <street-address nil="true"/>
+      <extended-address nil="true"/>
+      <locality nil="true"/>
+      <region nil="true"/>
+      <postal-code nil="true"/>
+      <country-name nil="true"/>
+      <country-code-alpha2 nil="true"/>
+      <country-code-alpha3 nil="true"/>
+      <country-code-numeric nil="true"/>
+    </shipping>
+    <custom-fields/>
+    <avs-error-response-code nil="true"/>
+    <avs-postal-code-response-code nil="true"/>
+    <avs-street-address-response-code nil="true"/>
+    <cvv-response-code nil="true"/>
+    <gateway-rejection-reason>application_incomplete</gateway-rejection-reason>
+    <processor-authorization-code nil="true"/>
+    <processor-response-code></processor-response-code>
+    <processor-response-text>Unknown ()</processor-response-text>
+    <additional-processor-response nil="true"/>
+    <voice-referral-number nil="true"/>
+    <purchase-order-number nil="true"/>
+    <tax-amount nil="true"/>
+    <tax-exempt type="boolean">false</tax-exempt>
+    <credit-card>
+      <token>credit_card_id</token>
+      <bin>400011</bin>
+      <last-4>1115</last-4>
+      <card-type>Visa</card-type>
+      <expiration-month>11</expiration-month>
+      <expiration-year>2017</expiration-year>
+      <customer-location>US</customer-location>
+      <cardholder-name>Brain Tree</cardholder-name>
+      <image-url>https://assets.braintreegateway.com/payment_method_logo/visa.png?environment=sandbox</image-url>
+      <prepaid>Unknown</prepaid>
+      <healthcare>Unknown</healthcare>
+      <debit>Unknown</debit>
+      <durbin-regulated>Unknown</durbin-regulated>
+      <commercial>Unknown</commercial>
+      <payroll>Unknown</payroll>
+      <issuing-bank>Unknown</issuing-bank>
+      <country-of-issuance>Unknown</country-of-issuance>
+      <product-id>Unknown</product-id>
+      <unique-number-identifier>26f8b913bb2a574089777f07d48cc590</unique-number-identifier>
+      <venmo-sdk type="boolean">false</venmo-sdk>
+    </credit-card>
+    <status-history type="array">
+      <status-event>
+        <timestamp type="datetime">2015-11-21T22:23:51Z</timestamp>
+        <status>gateway_rejected</status>
+        <amount>5001.00</amount>
+        <user>braintree-rails-integration-test</user>
+        <transaction-source>api</transaction-source>
+      </status-event>
+    </status-history>
+    <plan-id nil="true"/>
+    <subscription-id nil="true"/>
+    <subscription>
+      <billing-period-end-date nil="true"/>
+      <billing-period-start-date nil="true"/>
+    </subscription>
+    <add-ons type="array"/>
+    <discounts type="array"/>
+    <descriptor>
+      <name nil="true"/>
+      <phone nil="true"/>
+      <url nil="true"/>
+    </descriptor>
+    <recurring type="boolean">false</recurring>
+    <channel nil="true"/>
+    <service-fee-amount nil="true"/>
+    <escrow-status nil="true"/>
+    <disbursement-details>
+      <disbursement-date nil="true"/>
+      <settlement-amount nil="true"/>
+      <settlement-currency-iso-code nil="true"/>
+      <settlement-currency-exchange-rate nil="true"/>
+      <funds-held nil="true"/>
+      <success nil="true"/>
+    </disbursement-details>
+    <disputes type="array"/>
+    <payment-instrument-type>credit_card</payment-instrument-type>
+    <processor-settlement-response-code></processor-settlement-response-code>
+    <processor-settlement-response-text></processor-settlement-response-text>
+    <three-d-secure-info nil="true"/>
+  </transaction>
+</api-error-response>

data/spec/integration/braintree_rails/credit_card_integration_spec.rb

@@ -29,6 +29,7 @@ describe 'Credit Card Integration' do
     attributes.except(:number, :cvv, :billing_address).each do |key, value|
       expect(braintree_credit_card.send(key)).to eq(value)
     end
+    expect(credit_card.image_url).to eq(braintree_credit_card.image_url)
 
     braintree_address = braintree_credit_card.billing_address
     attributes[:billing_address].each do |key, value|

data/spec/integration/braintree_rails/customer_integration_spec.rb

@@ -42,7 +42,8 @@ describe 'Customer Integration' do
     customer.update_attributes!(:first_name => 'Foo', :last_name => 'Bar', :credit_card => credit_card_hash.merge(:cardholder_name => "FooBar"))
 
     braintree_customer = Braintree::Customer.find(customer.id)
-    expect(braintree_customer.credit_cards.first.cardholder_name).to eq("FooBar")
+    expect(braintree_customer.credit_cards.size).to eq(2)
+    expect(braintree_customer.credit_cards.map(&:cardholder_name)).to include("FooBar")
   end
 
   it 'should be able to destroy existing customer' do

data/spec/integration/braintree_rails/merchant_account_integration_spec.rb

@@ -8,8 +8,13 @@ describe 'MerchantAccount Integration' do
     expect(merchant_account.status).to eq(braintree_merchant_account.status)
   end
 
-  it 'can create sub merchant account' do
-    merchant_account = BraintreeRails::MerchantAccount.create(merchant_account_hash)
+  it 'can create sub merchant account paid via email' do
+    merchant_account = BraintreeRails::MerchantAccount.create(merchant_account_hash(:email))
+    expect(merchant_account).to be_persisted
+  end
+
+  it 'can create sub merchant account paid via bank account' do
+    merchant_account = BraintreeRails::MerchantAccount.create(merchant_account_hash(:bank))
     expect(merchant_account).to be_persisted
   end
 
@@ -18,7 +23,7 @@ describe 'MerchantAccount Integration' do
     expect(merchant_account).to_not be_persisted
   end
 
-  it 'sets validation errors properly to its associations' do
+  it 'sets internal validation errors properly to its associations' do
     merchant_account = BraintreeRails::MerchantAccount.create(merchant_account_hash.merge(:individual => {}, :funding => {}, :business => {:legal_name => "foo"}))
     expect(merchant_account).to_not be_persisted
     expect(merchant_account.individual.errors).to_not be_empty
@@ -26,6 +31,20 @@ describe 'MerchantAccount Integration' do
     expect(merchant_account.business.errors).to_not be_empty
   end
 
+  it 'sets validation errors reported by Braintree properly to its associations' do
+    mah = merchant_account_hash(:bank)
+    mah[:funding][:routing_number]='22222222' #invalid routing number
+    mah[:individual][:address][:postal_code] = '1234' #invalid postal code
+    mah[:individual][:ssn]='111-11-111' #invalid ssn
+    mah[:business][:tax_id]='1' #invlaid tax id
+    merchant_account = BraintreeRails::MerchantAccount.create(mah)
+    expect(merchant_account).to_not be_persisted
+    expect(merchant_account.funding.errors).to_not be_empty
+    expect(merchant_account.business.errors).to_not be_empty
+    expect(merchant_account.individual.errors).to_not be_empty
+    expect(merchant_account.individual.address.errors).to_not be_empty
+  end
+
   it 'can update the submerchant account' do
     individual = merchant_account_hash[:individual].merge(:first_name => "foo")
     merchant_account = BraintreeRails::MerchantAccount.create(merchant_account_hash.merge(:individual => individual))

data/spec/support/helper.rb

@@ -65,12 +65,12 @@ module Helper
     }
   end
 
-  def merchant_account_hash
+  def merchant_account_hash(kind = :email)
     {
       :master_merchant_account_id => BraintreeRails::Configuration.default_merchant_account_id,
       :tos_accepted => true,
       :individual => individual_details_hash,
-      :funding => funding_details_hash,
+      :funding => send("#{kind.to_s}_funding_details_hash"),
       :business => business_details_hash,
     }
   end
@@ -93,13 +93,23 @@ module Helper
     }
   end
 
-  def funding_details_hash
+  def email_funding_details_hash
     {
       :destination => Braintree::MerchantAccount::FundingDestination::Email,
       :email => "braintree-rails@exameple.com"
     }
   end
 
+  def bank_funding_details_hash
+    {
+      :destination => Braintree::MerchantAccount::FundingDestination::Bank,
+      :email => "braintree-rails@example.com",
+      :mobile_phone => '2015551212',
+      :account_number => '1234567890',
+      :routing_number => '071101307'
+    }
+  end
+
   def address_details_hash
     {
       :street_address => "#{(1000..9999).to_a.sample} Crane Avenue",

data/spec/unit/braintree_rails/credit_card_spec.rb

@@ -14,6 +14,7 @@ describe BraintreeRails::CreditCard do
       expect(credit_card.default?).to eq(braintree_credit_card.default?)
       expect(credit_card.expired?).to eq(braintree_credit_card.expired?)
       expect(credit_card.masked_number).to eq(braintree_credit_card.masked_number)
+      expect(credit_card.image_url).to eq(braintree_credit_card.image_url)
       BraintreeRails::CreditCard.attributes.each do |attribute|
         next if BraintreeRails::CreditCard.associations.include?(attribute)
         if braintree_credit_card.respond_to?(attribute)
@@ -350,4 +351,4 @@ describe BraintreeRails::CreditCard do
       expect(BraintreeRails::CreditCard.delete('credit_card_id')).to eq(true)
     end
   end
-end
+end

data/spec/unit/braintree_rails/funding_details_spec.rb

@@ -3,31 +3,31 @@ require File.expand_path(File.join(File.dirname(__FILE__), '../unit_spec_helper'
 describe BraintreeRails::FundingDetails do
   describe 'validations' do
     it "requries destination" do
-      funding = BraintreeRails::FundingDetails.new(funding_details_hash.merge(:destination => nil))
+      funding = BraintreeRails::FundingDetails.new(email_funding_details_hash.merge(:destination => nil))
       expect(funding).to be_invalid
       expect(funding.errors[:destination]).to eq(["can't be blank", "is not included in the list"])
     end
 
     it "cannot be trash destination" do
-      funding = BraintreeRails::FundingDetails.new(funding_details_hash.merge(:destination => "foo"))
+      funding = BraintreeRails::FundingDetails.new(email_funding_details_hash.merge(:destination => "foo"))
       expect(funding).to be_invalid
       expect(funding.errors[:destination]).to eq(["is not included in the list"])
     end
 
     it "requries email if destination is Email" do
-      funding = BraintreeRails::FundingDetails.new(funding_details_hash.merge(:destination => Braintree::MerchantAccount::FundingDestination::Email, :email => nil))
+      funding = BraintreeRails::FundingDetails.new(email_funding_details_hash.merge(:destination => Braintree::MerchantAccount::FundingDestination::Email, :email => nil))
       expect(funding).to be_invalid
       expect(funding.errors[:email]).to eq(["can't be blank"])
     end
 
     it "requries mobile_phone if destination is MobilePhone" do
-      funding = BraintreeRails::FundingDetails.new(funding_details_hash.merge(:destination => Braintree::MerchantAccount::FundingDestination::MobilePhone, :mobile_phone => nil))
+      funding = BraintreeRails::FundingDetails.new(email_funding_details_hash.merge(:destination => Braintree::MerchantAccount::FundingDestination::MobilePhone, :mobile_phone => nil))
       expect(funding).to be_invalid
       expect(funding.errors[:mobile_phone]).to eq(["can't be blank"])
     end
 
     it "requries account_number and routing_number if destination is Bank" do
-      funding = BraintreeRails::FundingDetails.new(funding_details_hash.merge(:destination => Braintree::MerchantAccount::FundingDestination::Bank, :account_number => nil, :routing_number => nil))
+      funding = BraintreeRails::FundingDetails.new(email_funding_details_hash.merge(:destination => Braintree::MerchantAccount::FundingDestination::Bank, :account_number => nil, :routing_number => nil))
       expect(funding).to be_invalid
       expect(funding.errors[:account_number]).to eq(["can't be blank"])
       expect(funding.errors[:routing_number]).to eq(["can't be blank"])

data/spec/unit/braintree_rails/transaction_spec.rb

@@ -218,7 +218,7 @@ describe BraintreeRails::Transaction do
       expect {transaction.submit_for_settlement!}.to raise_error(BraintreeRails::RecordInvalid)
     end
 
-    it 'should propergate api errors to associations if any' do
+    it 'should propagate api errors to associations if any' do
       customer = BraintreeRails::Customer.find('customer_id')
       credit_card = BraintreeRails::CreditCard.find('credit_card_id')
       transaction = BraintreeRails::Transaction.new(:amount => '10.00', :customer => customer, :credit_card => credit_card, :billing => address_hash, :shipping => address_hash)
@@ -243,9 +243,19 @@ describe BraintreeRails::Transaction do
       expect(transaction.shipping.errors.full_messages.map(&:to_s)).to eq(["Postal code Postal code may contain no more than 9 letter or number characters."])
     end
 
+    it 'should be able to handle gateway rejected transactions' do
+      customer = BraintreeRails::Customer.find('customer_id')
+      credit_card = BraintreeRails::CreditCard.find('credit_card_id')
+      transaction = BraintreeRails::Transaction.new(:amount => '10.00', :customer => customer, :credit_card => credit_card, :billing => address_hash, :shipping => address_hash)
+      stub_braintree_request(:post, '/transactions', :status => 422, :body => fixture('gateway_rejected.xml'))
+      expect {transaction.save}.to_not raise_error
+      expect(transaction.status).to eq(Braintree::Transaction::Status::GatewayRejected)
+      expect(transaction.gateway_rejection_reason).to eq("application_incomplete")
+    end
+
     it 'does not support update or destroy' do
       expect {BraintreeRails::Transaction.find('transactionid').update_attributes(:amount => 1)}.to raise_error(BraintreeRails::NotSupportedApiException)
       expect {BraintreeRails::Transaction.find('transactionid').destroy!}.to raise_error(BraintreeRails::NotSupportedApiException)
     end
   end
-end
+end

metadata

@@ -1,129 +1,129 @@
 --- !ruby/object:Gem::Specification
 name: braintree-rails
 version: !ruby/object:Gem::Version
-  version: 1.4.0
+  version: 1.4.1
 platform: ruby
 authors:
 - Lin Yang
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-12 00:00:00.000000000 Z
+date: 2015-11-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: braintree
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.28.0
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
         version: '3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 2.28.0
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
         version: '3'
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
         version: '5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
         version: '5'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
         version: '5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '3.0'
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
         version: '5'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '10'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '10'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '3'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1'
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '0'
 description: Provides ActiveModel compatible wrappers for Braintree models and more.
@@ -132,8 +132,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .travis.yml
+- ".gitignore"
+- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - Gemfile.lock
@@ -207,6 +207,7 @@ files:
 - spec/fixtures/credit_card_validation_error.xml
 - spec/fixtures/customer.xml
 - spec/fixtures/discounts.xml
+- spec/fixtures/gateway_rejected.xml
 - spec/fixtures/merchant_account.xml
 - spec/fixtures/plans.xml
 - spec/fixtures/subscription.xml
@@ -259,17 +260,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: 1.9.2
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.6
 signing_key: 
 specification_version: 4
 summary: Provides ActiveModel compatible wrappers for Braintree models.