bpalmen-httpbl 0.1.2 → 0.1.3

data/README

@@ -17,7 +17,7 @@ crawling, comment-spamming, dictionary attacks, and email-harvesting.
 Installation
 ------------
 
-	gem install httpbl
+	gem install bpalmen-httpbl
 	
 Basic Usage
 ------------
@@ -33,7 +33,7 @@ To add HttpBL to your middleware stack, simply add the following to config.ru:
 	
 For Rails 2.3+ add the following to environment.rb:
 	
-	config.gem 'httpbl'
+	require 'httpbl'
 	
 	config.middleware.use HttpBL, :api_key => "YOUR API KEY"
 	
@@ -51,7 +51,7 @@ To customize HttpBL's filtering behavior, use the available options:
 				:deny_types => [1, 2, 4],
 				:threat_level_threshold => 0,
 				:age_threshold => 5,
-				:blocked_search_engines => [0]
+				:blocked_search_engines => [0],
 
 Available Options:
 
@@ -134,4 +134,14 @@ customize the particular types of suspicious activity you wish to thwart:
 			8: MSN
 			9: Yahoo
 			10: Cuil
-			11: InfoSeek
+			11: InfoSeek
+	
+	:dns_timeout => 0.5
+	
+		DNS requests to the Http:BL service should NEVER take this long, but if
+		they do, you can modify this setting to prevent the application from 
+		hanging until a system default timeout.  Of course, setting this timeout 
+		too low will essentially disable the filter (but 0 is a bad idea), if responses
+		can't be returned from the API before the request is permitted, by default.  
+		Best not to mess with it unless you know what you're doing - it's a safety 
+		mechanism. 

data/lib/httpbl.rb

@@ -8,8 +8,10 @@ class HttpBL
     @options = {:blocked_search_engines => [],
                 :age_threshold => 10,
                 :threat_level_threshold => 2,
-                :deny_types => [1, 2, 4, 8, 16, 32, 64, 128]
                 # 8..128 aren't used as of 3/2009, but might be used in the future
+                :deny_types => [1, 2, 4, 8, 16, 32, 64, 128],
+                # DONT set this to 0
+                :dns_timeout => 0.5
                 }.merge(options)
     raise "Missing :api_key for Http:BL middleware" unless @options[:api_key]
   end
@@ -19,14 +21,22 @@ class HttpBL
   end
   
   def _call(env)
-    ip = Rack::Request.new(env).ip
-    query = @options[:api_key] + '.' + ip.split('.').reverse.join('.') + '.dnsbl.httpbl.org'
-    @bl_response = (Resolv::DNS.new.getaddress(query).to_s rescue nil)
-    if @bl_response and blocked?(@bl_response)
-      [403, {"Content-Type" => "text/html"}, "<h1>403 Forbidden</h1> Request IP is listed as suspicious by <a href='http://projecthoneypot.org/ip_#{ip}'>Project Honeypot</a>"]
+    request = Rack::Request.new(env)
+    bl_status = resolve(request.ip)
+    if bl_status and blocked?(bl_status)
+      [403, {"Content-Type" => "text/html"}, "<h1>403 Forbidden</h1> Request IP is listed as suspicious by <a href='http://projecthoneypot.org/ip_#{request.ip}'>Project Honeypot</a>"]
     else
       @app.call(env)
     end
+    
+  end
+  
+  def resolve(ip)
+    query = @options[:api_key] + '.' + ip.split('.').reverse.join('.') + '.dnsbl.httpbl.org'
+    Timeout::timeout(@options[:dns_timeout]) do
+       Resolv::DNS.new.getaddress(query).to_s rescue nil
+    end
+    rescue Timeout::Error, Errno::ECONNREFUSED
   end
   
   def blocked?(response)
@@ -46,4 +56,4 @@ class HttpBL
     return @blocked
   end
 
-end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: bpalmen-httpbl
 version: !ruby/object:Gem::Version 
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors: 
 - Brandon Palmen