box_view 0.0.4 → 0.0.5

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MDNiODM0YTdhMjdiMTk4ODg2ZDQ5ZjgzNjdhZTU2M2FmMWNiOTI5ZA==
+    ZTlkMjY2ODQzYjJlYjNkYTFkMWZjMzg1ZWU0MDNhYzY1NmRkMTUwNQ==
   data.tar.gz: !binary |-
-    NTRhYWVlNmE1MTEzODM0NmE1N2RkN2RhOWI2MDU3OGVjN2NiYWM4OA==
+    MTVjZjc4OTBkNDdhZjNhNGFkNjdkNGJiZDhmNDA3Y2M4YzMzYzA5Zg==
 !binary "U0hBNTEy":
   metadata.gz: !binary |-
-    NTBmZjViZmI4YzQwOTI1OGVmNGRkOGY2NzRkM2JhYzZjYjE2MDRjOTEzMTk3
-    NjJmZjExNzIxYjM0NGM5NWQyYmFiZTQ2YTk2ZjU1YjhhZDg2NmY4ZWI3ZWFi
-    MDE3NDExMTg1NWNlODlhYTczZTgxNDg4ZGZiMDU1Y2JkYzJlMDA=
+    N2Q5ZGNiMGU2YWJiYzM3MDg2N2RkYjVkOGQ3YzJhNjJiMjU1YzRiNDY0NTFl
+    MmMwNmFjMWI3MDUyMGMyZWMyMzNjNTM3OGYzYTFlM2YwNDIxMWFmODJjNDY3
+    YWIxNWNhNTA4MzhkNzk3ZDU3NzZiMzYxNWU3ODQwNTA2ZTc3MWY=
   data.tar.gz: !binary |-
-    YWQ3MDljNjhlMDBlYWE1Y2JjNjg2Y2JlMDE4NGFjMWI3MjljZDA4NjJkMDEz
-    ZmMzNGJkMmY5NmU2MTQ4M2NlMzAyNGM5YWUxZDJmMTI0OTI0MTI0OTBjMzhj
-    Y2I2NGUyM2M5MGYzNzExNDc2NTY5ZjYwNGVhMzA5NzM5NjE5NTQ=
+    MzQ3NDk3ZmJhNzgzZDJjMDg5NTM2Zjk3ZTAxMDk2Y2QwYmM2MmM5NGJiYThl
+    MjBjODQ1OGNiZTM1NmFkZjM2ODdhYThhYTcxMmNlMDY1MDI5NTA0NTFjMjI5
+    YTE0NjNhNGI4OTQyZGE0Y2JmNDI3MWIyZmEwMTlmYmFiNmVmMDI=

data/lib/box_view/http.rb

@@ -14,6 +14,7 @@ module BoxView
         super(msg)
       end
     end
+    class RequestThrottledError < BoxView::Http::RetryNeededError; end
 
     def base_uri(path, params = {})
       uri = URI.parse("https://view-api.box.com")
@@ -69,18 +70,20 @@ module BoxView
     end
 
     def check_for_error(res)
-      case res
-      when Net::HTTPAccepted
+      case res.code.to_s
+      when '202' # Accepted
         if res['Retry-After']
           raise BoxView::Http::RetryNeededError.new('Retry Needed', res['Retry-After'])
         end
-      when Net::HTTPBadRequest
+      when '400' # Bad Request
         msg = 'Bad Request'
         if err_dets = error_details(res)
           msg += " (#{err_dets})"
         end
 
         raise BoxView::Http::BadRequestError.new(msg)
+      when '429' # Too Many Requests
+        raise BoxView::Http::RequestThrottledError.new('Request Throttled', res['Retry-After'])
       end
     end
 

data/lib/box_view/models/base.rb

@@ -1,3 +1,5 @@
+require 'date'
+
 module BoxView
   module Models
 

data/lib/box_view/version.rb

@@ -1,3 +1,3 @@
 module BoxView
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/spec/http_spec.rb

@@ -66,5 +66,24 @@ describe BoxView::Http do
         end
       end
     end
+
+    context 'given a 429 response' do
+      let(:body) do
+        '{"message": "Request was throttled. Try again in 2 seconds", "type": "error",
+          "request_id": "5b296c69f9f94c0eace43a5912fcbb41"}'
+      end
+      let(:response) do
+        Net::HTTPClientError.new('1.1', '429', 'TOO MANY REQUESTS').tap do |r|
+          r['Retry-After'] == '2'
+          r.stub(:body).and_return(body)
+        end
+      end
+
+      it 'should raise a BoxView::Http:BadRequest with a message indicating the problem' do
+        expect { subject }.to raise_error(BoxView::Http::RequestThrottledError) do |error|
+          error.retry_after.should == '2'
+        end
+      end
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: box_view
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Reilly Forshaw
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-20 00:00:00.000000000 Z
+date: 2014-04-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler