bounce_fetcher 0.0.4 → 0.0.5

data/bounce_fetcher.gemspec

@@ -21,4 +21,6 @@ Gem::Specification.new do |s|
 
   s.add_dependency 'tmail', '~> 1.2'
   s.add_dependency 'bounce-email', '~> 0.0.1'
+
+  s.add_development_dependency 'eventmachine'
 end

data/lib/bounce_fetcher.rb

@@ -4,8 +4,8 @@ module BounceFetcher
     BounceFetcher.new(*args, &block)
   end
 
-  def self.pop3(host, username, password)
-    fetcher = PopFetcher.new(host, username, password)
+  def self.pop3(host, username, password, port = 110)
+    fetcher = PopFetcher.new(host, username, password, port)
     extractor = EmailExtractor.new
     detector = BounceDetector.new
     new(fetcher, extractor, detector)
@@ -22,7 +22,7 @@ module BounceFetcher
     def each
       @fetcher.each do |e|
         if @detector.permanent_bounce?(e)
-          @extractor.extract_emails(e).each do |email|
+          @extractor.extract_emails(e.body).each do |email|
             yield email
           end
           e.delete

data/lib/bounce_fetcher/pop_fetcher.rb

@@ -1,6 +1,8 @@
 # lifted from the action_mailer_verp plugin:
 # http://github.com/jamesgolick/action_mailer_verp
 
+require 'net/pop'
+
 module BounceFetcher
 
   class PopFetcher
@@ -25,10 +27,11 @@ module BounceFetcher
       end
     end
 
-    def initialize(host, username, password)
+    def initialize(host, username, password, port = 110)
       @host = host
       @username = username
       @password = password
+      @port = port
     end
 
     def each
@@ -42,7 +45,7 @@ module BounceFetcher
 
     def connection
       if @connection.nil?
-        @connection = Net::POP3.new(@host)
+        @connection = Net::POP3.new(@host, @port)
         @connection.start(@username, @password)
       end
 

data/lib/bounce_fetcher/version.rb

@@ -1,3 +1,3 @@
 module BounceFetcher
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/test/test_bounce_fetcher.rb

@@ -24,8 +24,8 @@ class TestBounceFetcher < MiniTest::Unit::TestCase
   end
 
   class FakeExtractor
-    def extract_emails(tmail)
-      [tmail.body]
+    def extract_emails(string)
+      [string]
     end
   end
 

data/test/test_integration.rb

@@ -0,0 +1,53 @@
+require 'minitest/autorun'
+require 'bounce_fetcher'
+require 'net/smtp'
+
+class TestIntegration < MiniTest::Unit::TestCase
+
+  def start_server
+    child_pid = fork do
+      STDIN.reopen('/dev/null')
+      STDOUT.reopen('/dev/null', 'a')
+      STDERR.reopen(STDOUT)
+      Dir.chdir(File.dirname(__FILE__) + "/support/localpost")
+      system("ruby -I. localpost.rb")
+    end
+  end
+
+  def send_email(options = {})
+    mail = TMail::Mail.new
+
+    mail.to      = options[:to] || 'blah@blah.com'
+    mail.from    = options[:from] || 'postmaster@blah.com'
+    mail.subject = options[:subject] || 'mail delivery failed'
+    mail.body    = options[:body] || 'foo@bar.com mailbox unavailable'
+    mail.date    = options[:date] || Time.now
+
+    begin
+      Net::SMTP.start('127.0.0.1', 25000) do |smtp|
+        smtp.send_message(mail.to_s, mail.from, mail.to)
+      end
+    rescue Errno::ECONNREFUSED => e
+      sleep 0.1
+      retry
+    end
+  end
+
+  def setup
+    start_server
+    send_email # bounce
+    send_email(:subject => 'hi', :body => 'there') # not bounce
+  end
+
+  def test_bounce_fetcher
+    bounces = BounceFetcher.pop3('127.0.0.1', 'localpost', 'localpost', 11000)
+
+    emails = []
+    bounces.each do |email|
+      emails << email
+    end
+
+    assert_equal ['foo@bar.com'], emails
+  end
+
+end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: bounce_fetcher
 version: !ruby/object:Gem::Version 
-  hash: 23
-  prerelease: false
+  hash: 21
+  prerelease: 
   segments: 
   - 0
   - 0
-  - 4
-  version: 0.0.4
+  - 5
+  version: 0.0.5
 platform: ruby
 authors: 
 - Michael Guterl
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-04-06 00:00:00 -04:00
+date: 2011-04-07 00:00:00 -04:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -49,6 +49,20 @@ dependencies:
         version: 0.0.1
   type: :runtime
   version_requirements: *id002
+- !ruby/object:Gem::Dependency 
+  name: eventmachine
+  prerelease: false
+  requirement: &id003 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
+        version: "0"
+  type: :development
+  version_requirements: *id003
 description: A set of tools for processing email bounces in a flexible way.
 email: 
 - michael@diminishing.org
@@ -73,6 +87,7 @@ files:
 - test/test_bounce_detector.rb
 - test/test_bounce_fetcher.rb
 - test/test_email_extractor.rb
+- test/test_integration.rb
 has_rdoc: true
 homepage: http://github.com/mguterl/bounce_fetcher
 licenses: []
@@ -103,7 +118,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: bounce_fetcher
-rubygems_version: 1.3.7
+rubygems_version: 1.5.2
 signing_key: 
 specification_version: 3
 summary: A set of tools for processing email bounces in a flexible way.
@@ -111,3 +126,4 @@ test_files:
 - test/test_bounce_detector.rb
 - test/test_bounce_fetcher.rb
 - test/test_email_extractor.rb
+- test/test_integration.rb