bosh_lastpass_plugin 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bb635e104d8c932f0c7ae6c36c546c77a98104ac
-  data.tar.gz: e7f2b38b2d6f7e3f959e5a271ff68ef7ba72ddf3
+  metadata.gz: d92addaf3520acd8e27ace4bfa4686302f79f886
+  data.tar.gz: b9b5df33d5ceeca8fb1d8aa7f694cfe8a2ca56bd
 SHA512:
-  metadata.gz: a5b8b6ac9e42ab7aac6ccc7a4d2cd2e9bfda761f7ad9505ac3995c69f6c66153a3e784497de1ba63f4091e4bfe0433c8da30c3b7158f7557f39bc1b693f425a9
-  data.tar.gz: dd8084398426df03cac21bd7c207bce0e8e497ed2d65192deafcc7d6ac33a447e0a65fdb2d30722f8e42905ad7773641fb4e2dee1f3a4e80f46aa4a852e14453
+  metadata.gz: f629a89153ee7242e52d63fd221c26cadf29d9f87208255a3be74a981c4bc91879ce25860e6ff4524d4ceefcff9ebbdcede8d8a76b06d33a68e875b6aae5d88b
+  data.tar.gz: 5fbe716b7725433812773c048be5e87de04f167b4e8ca5380edf7da4de61a48c495acbc4fce4eb0db741b988a0c3a5b5473168140d6a5ff92ebb492473ae7c35

data/.travis.yml

@@ -0,0 +1,3 @@
+language: ruby
+rvm:
+  - 2.2

data/Gemfile.lock

@@ -1,12 +1,12 @@
 PATH
   remote: .
   specs:
-    bosh_lastpass_plugin (0.0.1)
+    bosh_lastpass_plugin (0.0.4)
       bosh_cli (>= 1.2682.0)
       bosh_common (>= 1.2682.0)
-      git (~> 1.2.6)
-      membrane (~> 1.1.0)
-      semi_semantic (~> 1.1.0)
+      git (>= 1.2.6)
+      membrane (>= 1.1.0)
+      semi_semantic (>= 1.1.0)
 
 GEM
   remote: https://rubygems.org/
@@ -16,17 +16,17 @@ GEM
       jmespath (~> 1.0)
     aws-sdk-resources (2.2.0)
       aws-sdk-core (= 2.2.0)
-    blobstore_client (1.3232.0)
+    blobstore_client (1.3262.0)
       aws-sdk-resources (= 2.2.0)
-      bosh_common (~> 1.3232.0)
+      bosh_common (~> 1.3262.0)
       httpclient (= 2.7.1)
       multi_json (~> 1.1)
-    bosh-template (1.3232.0)
-      semi_semantic (~> 1.1.0)
-    bosh_cli (1.3232.0)
-      blobstore_client (~> 1.3232.0)
-      bosh-template (~> 1.3232.0)
-      bosh_common (~> 1.3232.0)
+    bosh-template (1.3262.0)
+      semi_semantic (~> 1.2.0)
+    bosh_cli (1.3262.0)
+      blobstore_client (~> 1.3262.0)
+      bosh-template (~> 1.3262.0)
+      bosh_common (~> 1.3262.0)
       cf-uaa-lib (~> 3.2.1)
       highline (~> 1.6.2)
       httpclient (= 2.7.1)
@@ -39,13 +39,13 @@ GEM
       progressbar (~> 0.9.0)
       sshkey (~> 1.7.0)
       terminal-table (~> 1.4.3)
-    bosh_common (1.3232.0)
+    bosh_common (1.3262.0)
       logging (~> 1.8.2)
-      semi_semantic (~> 1.1.0)
+      semi_semantic (~> 1.2.0)
     cf-uaa-lib (3.2.5)
       multi_json
     diff-lcs (1.2.5)
-    git (1.2.9.1)
+    git (1.3.0)
     highline (1.6.21)
     httpclient (2.7.1)
     jmespath (1.2.4)
@@ -57,7 +57,7 @@ GEM
       multi_json (>= 1.8.4)
     membrane (1.1.0)
     minitar (0.5.4)
-    multi_json (1.12.0)
+    multi_json (1.12.1)
     net-scp (1.1.2)
       net-ssh (>= 2.6.5)
     net-ssh (2.9.2)
@@ -92,7 +92,7 @@ GEM
       ruby-progressbar (~> 1.7)
       unicode-display_width (~> 1.0, >= 1.0.1)
     ruby-progressbar (1.8.1)
-    semi_semantic (1.1.0)
+    semi_semantic (1.2.0)
     sshkey (1.7.0)
     terminal-table (1.4.5)
     unicode-display_width (1.0.5)
@@ -109,4 +109,4 @@ DEPENDENCIES
   rubocop
 
 BUNDLED WITH
-   1.11.2
+   1.12.5

data/README.md

@@ -1,9 +1,8 @@
 # Bosh lastpass plugin
 
-Store bosh secrets in lastpass instead of the manifest. 
+[![Build Status](https://travis-ci.org/pivotal-cf/bosh_lastpass_plugin.svg?branch=master)](https://travis-ci.org/pivotal-cf/bosh_lastpass_plugin)
 
-## What is BOSH?
-BOSH orchestrates initial deployments and ongoing updates that are: predictable, repeatable, reliable, self-healing, infrastructure-agnostic. You can take a look on [BOSH project on GitHub](https://github.com/cloudfoundry/bosh) and read more details in [docs](http://docs.cloudfoundry.org/bosh/).
+Store bosh secrets in lastpass instead of the manifest. 
 
 ## How to install
 ```
@@ -60,6 +59,9 @@ properties:
 4. Push to the branch (`git push origin my-new-feature`)
 5. Create new Pull Request
 
+## What is BOSH?
+BOSH orchestrates initial deployments and ongoing updates that are: predictable, repeatable, reliable, self-healing, infrastructure-agnostic. You can take a look on [BOSH project on GitHub](https://github.com/cloudfoundry/bosh) and read more details in [docs](http://docs.cloudfoundry.org/bosh/).
+
 ## Notes
 
 Generated by [BOSH plugin generator](https://github.com/Altoros/bosh-plugin-generator)

data/bosh_lastpass_plugin.gemspec

@@ -22,9 +22,9 @@ Gem::Specification.new do |spec|
 
   spec.add_runtime_dependency "bosh_cli",  ">= 1.2682.0"
   spec.add_runtime_dependency "bosh_common",  ">= 1.2682.0"
-  spec.add_runtime_dependency "semi_semantic", "~> 1.1.0"
-  spec.add_runtime_dependency "membrane", "~> 1.1.0"
-  spec.add_runtime_dependency "git", "~> 1.2.6"
+  spec.add_runtime_dependency "semi_semantic", ">= 1.1.0"
+  spec.add_runtime_dependency "membrane", ">= 1.1.0"
+  spec.add_runtime_dependency "git", ">= 1.2.6"
 
   spec.add_development_dependency "bundler", "~> 1.6"
   spec.add_development_dependency "rspec", "~> 3.1.0"

data/lib/bosh/cli/commands/lastpass_plugin.rb

@@ -2,9 +2,7 @@ require "bosh/lastpass_plugin"
 
 module Bosh::Cli::Command
   class LastpassPlugin < Base
-    extend Bosh::LastpassPlugin::Additions
-
-    inject_into_yaml_parsing
+    Bosh::LastpassPlugin::Additions.inject_lastpass
 
     usage "lastpass show manifest"
     desc "display the manifest with lastpass keys substituted"

data/lib/bosh/lastpass_plugin/additions.rb

@@ -1,12 +1,13 @@
 module Bosh
   module LastpassPlugin
     module Additions
-      def inject_into_yaml_parsing
+      def self.inject_lastpass
         ::BoshExtensions.module_eval do
           def lpass key,type
             output = `lpass show #{key} --#{type}`
             if $?.exitstatus != 0
               say "Error: BOSH Lastpass Error failed to fetch #{key}"
+              say "Error: #{output}"
               exit($?.exitstatus)
             end
             output

data/lib/bosh/lastpass_plugin/version.rb

@@ -1,5 +1,5 @@
 module Bosh
   module LastpassPlugin
-    VERSION = "0.0.3"
+    VERSION = "0.0.4"
   end
 end

data/spec/command_spec.rb

@@ -1,11 +1,58 @@
 describe "bosh say hello" do
+  let(:path) { create_path_with_executables("ruby", "git", "bosh", mock_lpass_path) }
 
-  before do
-    system("bosh say hello > /dev/null")
+  before(:each) do
+    @output = `PATH=#{path} bosh --config #{erb_fixtures("bosh_config.erb")} lastpass show manifest`
   end
+  after(:each) do
+    FileUtils.rm_rf path
+  end
+
+
+  context "substitutes the lpass passwords " do
+    let(:mock_lpass_path) { fixtures("stub_executables/success/lpass")}
+    it "exits without errors" do
+      expect($?.exitstatus).to eq(0)
+    end
+
+    it "successfully substitutes lpass entries" do
+      hash = YAML.load(@output.split("\n")[1..-1].join("\n"))
+      expect(hash["instance_groups"][0]["jobs"][0]["properties"]["username"]).to eql("entry_from_lastpass")
+    end
+  end
+
+  context "lpass key/value not found" do
+    let(:mock_lpass_path) { fixtures("stub_executables/key_not_found/lpass")}
+
+    it "exits with errors" do
+      expect($?.exitstatus).to eq(1)
+    end
 
-  it "exits without errors" do
-    expect($?.exitstatus).to eq(0)
+    it "displays a error message" do
+      expect(@output).to include("Could not find specified account")
+    end
   end
 
+  context "lpass command not found" do
+    let(:mock_lpass_path) { fixtures("stub_executables/command_not_found/lpass")}
+    it "exits with errors" do
+      expect($?.exitstatus).to eq(127)
+    end
+    it "displays a error message" do
+      expect(@output).to include("BOSH Lastpass Error lastpass cli not found")
+    end
+  end
+end
+
+def required_executables_path(*commands)
+  commands.collect{|command| File.dirname(`which #{command}`)}.uniq.join(":")
+end
+
+
+def create_path_with_executables(*commands)
+  dir = Dir.mktmpdir
+  commands.collect{|command| `which #{command}`.strip}.reject(&:empty?).each do |command|
+    `ln -s #{command} #{dir}`
+  end
+  dir
 end

data/spec/fixtures/bosh_config.erb

@@ -0,0 +1,16 @@
+---
+target: https://whatever.com:25555
+target_name: Bosh Lite Director
+target_version: 1.3215.0 (00000000)
+target_uuid: 17a45148-1d00-43bc-af28-9882e5a6535a
+ca_cert:
+  https://whatever.com:25555:
+aliases:
+  target:
+    17a45148-1d00-43bc-af28-9882e5a6535a: https://whatever.com:25555
+auth:
+  https://whatever.com:25555:
+    username: admin
+    password: admin
+deployment:
+  https://whatever.com:25555: "<%= File.dirname(__FILE__) %>/deployment.yml"

data/spec/fixtures/deployment.yml

@@ -0,0 +1,22 @@
+---
+name: fixture-deployment
+
+director_uuid: 17a45148-1d00-43bc-af28-9882e5a6535a
+
+releases:
+  - name: syslog
+    version: 7
+
+stemcells:
+  - alias: trusty
+    os: ubuntu-trusty
+    version: latest
+
+instance_groups:
+  - name: broker
+    instances: 1
+    jobs:
+      - name: syslog
+        release: syslog
+        properties:
+          username: <%= lpass "test_note", "test_field" %>

data/spec/fixtures/stub_executables/key_not_found/lpass

@@ -0,0 +1,2 @@
+echo "Error: Could not find specified account(s)."
+exit 1

data/spec/fixtures/stub_executables/success/lpass

@@ -0,0 +1,2 @@
+echo "entry_from_lastpass"
+exit 0

data/spec/spec_helper.rb

@@ -8,5 +8,23 @@ $:.unshift(File.expand_path("../../lib", __FILE__))
 
 require "rspec/core"
 require "rspec/its"
+require "yaml"
+require "erb"
+require 'tempfile'
 
-require "bosh/lastpass_plugin"
+def fixtures name
+  File.join(File.dirname(__FILE__), "fixtures", name)
+end
+
+def erb_fixtures name
+  file = Tempfile.new('bosh_lastpass_plugin')
+  file.write(erb_evaluate(fixtures(name)))
+  file.close
+  file.path
+end
+
+def erb_evaluate(filename)
+  erb = ERB.new(File.read(filename))
+  erb.filename = filename
+  erb.result
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bosh_lastpass_plugin
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Jatin Naik
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-05-24 00:00:00.000000000 Z
+date: 2016-06-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bosh_cli
@@ -42,42 +42,42 @@ dependencies:
   name: semi_semantic
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.1.0
 - !ruby/object:Gem::Dependency
   name: membrane
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.1.0
 - !ruby/object:Gem::Dependency
   name: git
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.2.6
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: 1.2.6
 - !ruby/object:Gem::Dependency
@@ -159,6 +159,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".travis.yml"
 - Gemfile
 - Gemfile.lock
 - README.md
@@ -169,6 +170,10 @@ files:
 - lib/bosh/lastpass_plugin/additions.rb
 - lib/bosh/lastpass_plugin/version.rb
 - spec/command_spec.rb
+- spec/fixtures/bosh_config.erb
+- spec/fixtures/deployment.yml
+- spec/fixtures/stub_executables/key_not_found/lpass
+- spec/fixtures/stub_executables/success/lpass
 - spec/spec_helper.rb
 homepage: https://github.com/cloudfoundry/bosh
 licenses: []
@@ -195,4 +200,8 @@ specification_version: 4
 summary: Short description.
 test_files:
 - spec/command_spec.rb
+- spec/fixtures/bosh_config.erb
+- spec/fixtures/deployment.yml
+- spec/fixtures/stub_executables/key_not_found/lpass
+- spec/fixtures/stub_executables/success/lpass
 - spec/spec_helper.rb