bosh_cli 1.2068.0 → 1.2086.0

data/lib/cli.rb

@@ -45,6 +45,7 @@ require 'cli/yaml_helper'
 require 'cli/version_calc'
 require 'cli/dependency_helper'
 require 'cli/deployment_manifest'
+require 'cli/manifest_warnings'
 require 'cli/deployment_helper'
 require 'cli/validation'
 require 'cli/stemcell'

data/lib/cli/deployment_helper.rb

@@ -61,6 +61,8 @@ module Bosh::Cli
       resolve_release_aliases(manifest)
       resolve_stemcell_aliases(manifest)
 
+      report_manifest_warnings(manifest)
+
       options[:yaml] ? Psych.dump(manifest) : manifest
     end
 
@@ -375,5 +377,9 @@ module Bosh::Cli
         end
       end
     end
+
+    def report_manifest_warnings(manifest)
+      ManifestWarnings.new(manifest).report
+    end
   end
 end

data/lib/cli/manifest_warnings.rb

@@ -0,0 +1,37 @@
+module Bosh::Cli
+  class ManifestWarnings
+    WARNING_MESSAGES = {
+      'resource_pools.[].cloud_properties.spot_bid_price' => <<-EOM
+AWS spot instance support is an experimental feature.
+Please log an issue at https://github.com/cloudfoundry/bosh/issues if you run into any issues related to spot instances.
+      EOM
+    }
+
+    def initialize(manifest)
+      @manifest = manifest
+    end
+
+    def report
+      WARNING_MESSAGES.each do |keypath, warning|
+        say(warning.make_yellow) if keypath_exists?(manifest, keypath.split('.'))
+      end
+    end
+
+    private
+
+    attr_reader :manifest
+
+    def keypath_exists?(config, keypath)
+      case
+        when keypath.empty?
+          true
+
+        when keypath.first == '[]'
+          config.is_a?(Array) && config.any? { |element| keypath_exists?(element, keypath[1..-1]) }
+
+        when config.respond_to?(:has_key?) && config.has_key?(keypath.first)
+          keypath_exists?(config[keypath.first], keypath[1..-1])
+      end
+    end
+  end
+end

data/lib/cli/version.rb

@@ -1,5 +1,5 @@
 module Bosh
   module Cli
-    VERSION = '1.2068.0'
+    VERSION = '1.2086.0'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bosh_cli
 version: !ruby/object:Gem::Version
-  version: 1.2068.0
+  version: 1.2086.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-26 00:00:00.000000000 Z
+date: 2014-02-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bosh_common
@@ -18,7 +18,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.2068.0
+        version: 1.2086.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -26,7 +26,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.2068.0
+        version: 1.2086.0
 - !ruby/object:Gem::Dependency
   name: json_pure
   requirement: !ruby/object:Gem::Requirement
@@ -114,7 +114,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.2068.0
+        version: 1.2086.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -122,7 +122,7 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.2068.0
+        version: 1.2086.0
 - !ruby/object:Gem::Dependency
   name: net-ssh
   requirement: !ruby/object:Gem::Requirement
@@ -269,7 +269,7 @@ dependencies:
         version: '0'
 description: ! 'BOSH CLI
 
-  5f63a5'
+  8d26be'
 email: support@cloudfoundry.com
 executables:
 - bosh
@@ -329,6 +329,7 @@ files:
 - lib/cli/job_property_validator.rb
 - lib/cli/job_state.rb
 - lib/cli/line_wrap.rb
+- lib/cli/manifest_warnings.rb
 - lib/cli/name_version_pair.rb
 - lib/cli/package_builder.rb
 - lib/cli/packaging_helper.rb
@@ -378,7 +379,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -2465170715055136714
+      hash: 2109217702553857662
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.8.23