bootstrap_form 5.2.1 → 5.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9bea3ab95f979a7fc02d2c2a5dff3bae3ca536c6e277a86d11361c3e3bd72e59
-  data.tar.gz: 80fa55a6cbcd89ae0b52ebc8135d8b9f38b25b321bdbe492983db46c866c1e7d
+  metadata.gz: 4f254a69bb17aa95e9b912696e17d960c76a8b276946e3e33a0c4ade55cc3a38
+  data.tar.gz: 5d7d83dd48e78fc1dfbb9be6cea0cf12a4bdc9dbe646e3720152e4f78953adb3
 SHA512:
-  metadata.gz: a97b0ddfb9afcfb847b27ea4853c4f3b99bb0c72a0366d4d1a0a3fac217f0693090c96ea03c51e3a07e66cfe3c8c4576be8618eb3b48401c6d6f326e35619fa7
-  data.tar.gz: 3d79f681187a5fa0cab604ced1919229cdbdd101cc8f91c4261a115b82fa5589c3037b8b0c6d6208ce17affe964397a8fc33a9483a82a5c74efd22c9224eb582
+  metadata.gz: 2e9d0227f8d07cd40fd0986cb67f0b86de8c759fd7e7b60d42e3ea8dd0d825555a62b5f60de26e30a8b08985cc9b38e42e765338d1ca628e50c5a8841ca64756
+  data.tar.gz: 74034f6ad801fea16c3002242b80647eed61732c9a15c8d6b4197f59cd232c7d361974ef42697fa4b81f03100d73e7699794a0a5454da03661bde1677045ee42

data/CHANGELOG.md

@@ -6,13 +6,14 @@ https://github.com/bootstrap-ruby/bootstrap_form/releases
 
 ## Diffs
 
-- [Pending Release](https://github.com/bootstrap-ruby/bootstrap_form/compare/v5.2.0...HEAD)
+- [5.2.2](https://github.com/bootstrap-ruby/bootstrap_form/compare/v5.2.1...v5.2.2)
+  [Closed issues](https://github.com/bootstrap-ruby/bootstrap_form/issues?q=closed%3A2023-05-23T10%3A00..2023-05-28T16%3A00)
 - [5.2.1](https://github.com/bootstrap-ruby/bootstrap_form/compare/v5.2.0...v5.2.1)
-  [Issues](https://github.com/bootstrap-ruby/bootstrap_form/issues?q=closed%3A2023-05-20T23%3A59..2023-05-23T10%3A00)
+  [Closed issues](https://github.com/bootstrap-ruby/bootstrap_form/issues?q=closed%3A2023-05-20T23%3A59..2023-05-23T10%3A00)
 - [5.2.0](https://github.com/bootstrap-ruby/bootstrap_form/compare/v5.1.0...v5.2.0)
-  [Issues](https://github.com/bootstrap-ruby/bootstrap_form/issues?q=closed%3A2022-06-25T17%3A22..2023-05-20T23%3A59)
+  [Closed issues](https://github.com/bootstrap-ruby/bootstrap_form/issues?q=closed%3A2022-06-25T17%3A22..2023-05-20T23%3A59)
 - [5.1.0](https://github.com/bootstrap-ruby/bootstrap_form/compare/v5.0.0...v5.1.0)
-  [Issues](https://github.com/bootstrap-ruby/bootstrap_form/issues?q=closed%3A2021-11-12T05%3A58..2022-06-25T17%3A22)
+  [Closed issues](https://github.com/bootstrap-ruby/bootstrap_form/issues?q=closed%3A2021-11-12T05%3A58..2022-06-25T17%3A22)
 - [5.0.0](https://github.com/bootstrap-ruby/bootstrap_form/compare/v4.5.0...v5.0.0)
 - [4.5.0](https://github.com/bootstrap-ruby/bootstrap_form/compare/v4.4.0...v4.5.0)
 - [4.4.0](https://github.com/bootstrap-ruby/bootstrap_form/compare/v4.3.0...v4.4.0)

data/RELEASING.md

@@ -10,22 +10,37 @@ Follow these steps to release a new version of bootstrap_form to rubygems.org.
 
 ## How to release
 
-1. Run `BUNDLE_GEMFILE=gemfiles/7.0.gemfile bundle update` to make sure that you have all the gems necessary for testing and releasing.
+1. Make sure that you have all the gems necessary for testing and releasing.
+
+       BUNDLE_GEMFILE=gemfiles/7.0.gemfile bundle update
+
 2. **Ensure the tests are passing by running the tests**
 
    (There should be no errors or warnings.)
 
        BUNDLE_GEMFILE=gemfiles/7.0.gemfile bundle exec rake test
 
-2. **Ensure the demo tests are passing by running**
+3. **Ensure the demo tests are passing by running**
 
        cd demo
        bundle update
        bundle exec rake test:all
-
-3. Determine which would be the correct next version number according to [semver](http://semver.org/).
-4. Update the version in `./lib/bootstrap_form/version.rb`.
-5. Update the GitHub diff links at the beginning of `CHANGELOG.md` (The pattern should be obvious when you look at them).
-6. Update the installation instructions in `README.md` to use the new version.
-7. Commit the CHANGELOG and version changes in a single commit; the message should be "Preparing vX.Y.Z" where `X.Y.Z` is the version being released.
-8. Run `bundle exec rake release`; this will tag, push to GitHub, and publish to rubygems.org.
+       cd -
+
+4. Determine which would be the correct next version number according to [semver](http://semver.org/).
+5. Update the version in `./lib/bootstrap_form/version.rb`.
+6. Update the GitHub diff links at the beginning of `CHANGELOG.md` (The pattern should be obvious when you look at them).
+7. Update the installation instructions in `README.md` to use the new version.
+8. Commit the CHANGELOG and version changes in a single commit; the message should be "Preparing vX.Y.Z" where `X.Y.Z` is the version being released.
+9. Tag, push to GitHub, and publish to rubygems.org:
+
+       bundle exec rake release
+
+10. Go to https://github.com/bootstrap-ruby/bootstrap_form/releases and create the new release and add release notes by clicking the "Generate release notes" button.
+    Add the link of closed issues from CHANGELOG.
+    Group the commits in sections:
+    * ### New features
+    * ### Bugfixes
+    * ### Performance
+    * ### Documentation
+    * ### Development

data/Rakefile

@@ -1,12 +1,14 @@
 begin
   require 'bundler/setup'
+
+  require 'bundler/gem_tasks'
+  require "minitest/test_task"
+  require 'rdoc/task'
   require 'rubocop/rake_task'
 rescue LoadError
   puts 'You must `gem install bundler` and `bundle install` to run rake tasks'
 end
 
-require 'rdoc/task'
-
 RDoc::Task.new(:rdoc) do |rdoc|
   rdoc.rdoc_dir = 'rdoc'
   rdoc.title    = 'BootstrapForm'
@@ -15,10 +17,6 @@ RDoc::Task.new(:rdoc) do |rdoc|
   rdoc.rdoc_files.include('lib/**/*.rb')
 end
 
-require 'bundler/gem_tasks'
-
-require "minitest/test_task"
-
 Minitest::TestTask.create(:test) do |t|
   t.libs << "test"
   t.libs << "lib"
@@ -26,12 +24,6 @@ Minitest::TestTask.create(:test) do |t|
   t.test_globs = ["test/**/*_test.rb"]
 end
 
-# This automatically updates GitHub Releases whenever we `rake release` the gem
-task "release:rubygem_push" do
-  require "chandler/tasks"
-  Rake.application.invoke_task("chandler:push")
-end
-
 desc 'Run RuboCop checks'
 RuboCop::RakeTask.new(:rubocop)
 

data/lib/bootstrap_form/components/validation.rb

@@ -26,7 +26,7 @@ module BootstrapForm
         target = obj.instance_of?(Class) ? obj : obj.class
         return false unless target.respond_to? :validators_on
 
-        presence_validator?(target_validators(target, attribute)) ||
+        presence_validator?(target_unconditional_validators(target, attribute)) ||
           required_association?(target, attribute)
       end
 
@@ -35,12 +35,14 @@ module BootstrapForm
           next unless a.is_a?(ActiveRecord::Reflection::BelongsToReflection)
           next unless a.foreign_key == attribute.to_s
 
-          presence_validator?(target_validators(target, name))
+          presence_validator?(target_unconditional_validators(target, name))
         end
       end
 
-      def target_validators(target, attribute)
-        target.validators_on(attribute).map(&:class)
+      def target_unconditional_validators(target, attribute)
+        target.validators_on(attribute)
+              .reject { |validator| validator.options[:if].present? || validator.options[:unless].present? }
+              .map(&:class)
       end
 
       def presence_validator?(target_validators)

data/lib/bootstrap_form/version.rb

@@ -1,4 +1,4 @@
 module BootstrapForm
-  VERSION = "5.2.1".freeze
+  VERSION = "5.2.2".freeze
   REQUIRED_RAILS_VERSION = ">= 6.0".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bootstrap_form
 version: !ruby/object:Gem::Version
-  version: 5.2.1
+  version: 5.2.2
 platform: ruby
 authors:
 - Stephen Potenza
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-05-23 00:00:00.000000000 Z
+date: 2023-05-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack