bootsnap 1.21.1 → 1.22.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4ca69038da7071534a7279f36d694ec5bcf5687272d091b314372b1f3195831b
-  data.tar.gz: c5dc747c2c66a71881d99af980085c06bfc378134d25712c51221b7fb6a6c03a
+  metadata.gz: 1ab247855b4e6a35b2db80b44f2d3da184fd9780e9a4faa3d35d952e15398839
+  data.tar.gz: c8fd54ed988e11df7e934e9ff4f30f7dfb6440b4b9a2ecd2eaf3dbf9aefa61fd
 SHA512:
-  metadata.gz: 9da2aa5050b26d377f46d1de5e8424168e0a60b00160d43ebdaf9f93c4a9006931bf6463a24afa6dd76559ccedc4ce3798d48733d5000a7a5eac08d7c7a03510
-  data.tar.gz: 17a8da7a372189c22f400f5c059947f98c6aa7836390965c92e6e173970a61e2e6aa57d77d3dd11a9ecea0afd729512a115fd38a21c7a30850d1e9bd662b7d26
+  metadata.gz: 4a7225b866cbe788281af91aa690c75191e19bc09f4d8695a58557e024193d4b0924bbf9892cbb84dad93658eda9ff46c609b113c0b588660ac318e0b9176f1f
+  data.tar.gz: cadb844c862e9185befec65d7fa53beb6940945ebbddbea48ab30fd22b88f19aa773baa856c414522f5acf1a1c2a8aeafa75d72fb5a86cde5ebc8557172d049c

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Unreleased
 
+# 1.22.0
+
+* Better fix for the `opendir` crash.
+* Add `bootsnap/rake` for cleaning the bootsnap cache as part of `rake clobber`.
+
 # 1.21.1
 
 * Prevent a Ruby crash while scanning load path if `opendir` fails without setting `errno`.

data/ext/bootsnap/bootsnap.c

@@ -176,26 +176,16 @@ bs_rb_scan_dir(VALUE self, VALUE abspath)
 {
     Check_Type(abspath, T_STRING);
 
-    DIR *dirp = opendir(RSTRING_PTR(abspath));
-
     VALUE dirs = rb_ary_new();
     VALUE requirables = rb_ary_new();
     VALUE result = rb_ary_new_from_args(2, requirables, dirs);
 
+    DIR *dirp = opendir(RSTRING_PTR(abspath));
     if (dirp == NULL) {
         if (errno == ENOTDIR || errno == ENOENT) {
             return result;
         }
 
-        // BUG: Some users reported a crash here because Ruby's syserr trigger
-        // a crash if called with `errno == 0`.
-        // The opendir spec is quite clear that if it returns NULL, then `errno` must
-        // be set, and yet here we are.
-        // So turning no errno into EINVAL, and from there I hope to get to the bottom of things.
-        if (errno == 0) {
-            errno = EINVAL;
-        }
-
         bs_syserr_fail_path("opendir", errno, abspath);
         return Qundef;
     }

data/lib/bootsnap/load_path_cache/path_scanner.rb

@@ -102,13 +102,6 @@ module Bootsnap
             end
 
             all_requirables
-          rescue SystemCallError => error
-            if ENV["BOOTSNAP_DEBUG"]
-              raise
-            else
-              Bootsnap.logger&.call("Unexpected error: #{error.class}: #{error.message}")
-              ruby_call(root_path)
-            end
           end
           alias_method :call, :native_call
         else

data/lib/bootsnap/rake.rb

@@ -0,0 +1,14 @@
+# frozen_string_literal: true
+
+require "bootsnap"
+require "rake/clean"
+
+# Typically, should have been set up prior to requiring rake integration.
+# But allow for a streamlined ::default_setup
+require "bootsnap/setup" if Bootsnap.cache_dir.nil?
+
+if Bootsnap.cache_dir
+  CLEAN.include Bootsnap.cache_dir
+else
+  abort "Bootsnap must be set-up prior to rake integration"
+end

data/lib/bootsnap/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Bootsnap
-  VERSION = "1.21.1"
+  VERSION = "1.22.0"
 end

data/lib/bootsnap.rb

@@ -7,7 +7,7 @@ module Bootsnap
   InvalidConfiguration = Class.new(StandardError)
 
   class << self
-    attr_reader :logger
+    attr_reader :cache_dir, :logger
 
     def log_stats!
       stats = {hit: 0, revalidated: 0, miss: 0, stale: 0}
@@ -58,9 +58,11 @@ module Bootsnap
         warn("Bootsnap.setup `compile_cache_json` argument is deprecated and has no effect")
       end
 
+      @cache_dir = "#{cache_dir}/bootsnap"
+
       if load_path_cache
         Bootsnap::LoadPathCache.setup(
-          cache_path: "#{cache_dir}/bootsnap/load-path-cache",
+          cache_path: "#{@cache_dir}/load-path-cache",
           development_mode: development_mode,
           ignore_directories: ignore_directories,
           readonly: readonly,
@@ -68,7 +70,7 @@ module Bootsnap
       end
 
       Bootsnap::CompileCache.setup(
-        cache_dir: "#{cache_dir}/bootsnap/compile-cache",
+        cache_dir: "#{@cache_dir}/compile-cache",
         iseq: compile_cache_iseq,
         yaml: compile_cache_yaml,
         readonly: readonly,

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bootsnap
 version: !ruby/object:Gem::Version
-  version: 1.21.1
+  version: 1.22.0
 platform: ruby
 authors:
 - Burke Libbey
@@ -55,6 +55,7 @@ files:
 - lib/bootsnap/load_path_cache/path.rb
 - lib/bootsnap/load_path_cache/path_scanner.rb
 - lib/bootsnap/load_path_cache/store.rb
+- lib/bootsnap/rake.rb
 - lib/bootsnap/setup.rb
 - lib/bootsnap/version.rb
 homepage: https://github.com/rails/bootsnap