bootsnap 1.1.7 → 1.1.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 58c56b006431cac3c1cf8a8c8c542f76ec6cd7dd
-  data.tar.gz: b71fd217b2aded27b42d582d6a123a80bd6c8747
+  metadata.gz: a6f66d96dbadca08e5c50985c45319350f1e85ca
+  data.tar.gz: c1227f8f8c6ed542abe582c221ccf45318655e87
 SHA512:
-  metadata.gz: 43ce6810dfe1626cb8e9b6213ee197c26123fb98bfd7aaa42b5795a7133349002e86037cea64b94bdf7d1cdc45d42671285ae21693e4c0d25962d5e1dc5b133f
-  data.tar.gz: 22545b119efedef68895f61b3f403b6eedb8e6f4a7152da99fed09d430df7bc7125f1d81d5db9ebb45919958c5a215c5968efc34202aa708d7b8349fdb232768
+  metadata.gz: fa366476bf324d6eda9415e7170d67e31eb4a01d08758ff51d9e83c7661db8160cfa334ef9df67777ef059887de24a3f8a7da49b1675f3a1b0bf7704ecf42620
+  data.tar.gz: '06758fb4f8445d041816330983799684a3b79e6ec82ac1e21cf087544d377744b0bb8bc20012146d529876fac6398e1053821eea2468be60c8194c6c07855312'

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+# 1.1.8
+
+* Don't cache YAML documents with `!ruby/object`
+* Fix cache write mode on Windows
+
 # 1.1.7
 
 * Create cache entries as 0775/0664 instead of 0755/0644

data/README.md

@@ -18,13 +18,15 @@ Add `bootsnap` to your `Gemfile`:
 gem 'bootsnap', require: false
 ```
 
-If you are using rails, add this to `config/boot.rb` immediately after `require 'bundler/setup'`:
+If you are using Rails, add this to `config/boot.rb` immediately after `require 'bundler/setup'`:
 
 ```ruby
 require 'bootsnap/setup'
 ```
 
-If you are not using rails, or if you are but want more control over things, add this to your
+You can see how this require works [here](https://github.com/Shopify/bootsnap/blob/master/lib/bootsnap/setup.rb).
+
+If you are not using Rails, or if you are but want more control over things, add this to your
 application setup immediately after `require 'bundler/setup'` (i.e. as early as possible: the sooner
 this is loaded, the sooner it can start optimizing things)
 
@@ -49,7 +51,13 @@ will help optimize boot time further if you have an extremely large `$LOAD_PATH`
 Note: Bootsnap and [Spring](https://github.com/rails/spring) are orthogonal tools. While Bootsnap
 speeds up the loading of individual source files, Spring keeps a copy of a pre-booted Rails process
 on hand to completely skip parts of the boot process the next time it's needed. The two tools work
-well together, and are both included in a newly-generated Rails applications by default. 
+well together, and are both included in a newly-generated Rails applications by default.
+
+### Environments
+
+All Bootsnap features are enabled in development, test, production, and all other environments according to the configuration in the setup. At Shopify, we use this gem safely in all environments without issue.
+
+If you would like to disable any feature for a certain environment, we suggest changing the configuration to take into account the appropriate ENV var or configuration according to your needs.
 
 ## How does this work?
 

data/lib/bootsnap/compile_cache/yaml.rb

@@ -8,6 +8,7 @@ module Bootsnap
       end
 
       def self.input_to_storage(contents, _)
+        raise Uncompilable if contents.index("!ruby/object")
         obj = ::YAML.load(contents)
         msgpack_factory.packer.write(obj).to_s
       rescue NoMethodError, RangeError

data/lib/bootsnap/load_path_cache/store.rb

@@ -72,7 +72,9 @@ module Bootsnap
         tmp = "#{@store_path}.#{Process.pid}.#{(rand * 100000).to_i}.tmp"
         FileUtils.mkpath(File.dirname(tmp))
         exclusive_write = File::Constants::CREAT | File::Constants::EXCL | File::Constants::WRONLY
-        File.binwrite(tmp, MessagePack.dump(@data), mode: exclusive_write)
+        # `encoding:` looks redundant wrt `binwrite`, but necessary on windows
+        # because binary is part of mode.
+        File.binwrite(tmp, MessagePack.dump(@data), mode: exclusive_write, encoding: Encoding::BINARY)
         FileUtils.mv(tmp, @store_path)
       rescue Errno::EEXIST
         retry

data/lib/bootsnap/version.rb

@@ -1,3 +1,3 @@
 module Bootsnap
-  VERSION = "1.1.7"
+  VERSION = "1.1.8"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bootsnap
 version: !ruby/object:Gem::Version
-  version: 1.1.7
+  version: 1.1.8
 platform: ruby
 authors:
 - Burke Libbey
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-12-13 00:00:00.000000000 Z
+date: 2018-01-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler