boolean_validator 0.1.1 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 211c6e902816bcf08e1ca63ef7b7c6b4749147a324b5c6269b5ce1957082d440
-  data.tar.gz: d25fd380c3863e8eaadc1c0ee00b42635d482a82a475e5bc06093f57519fd8ed
+  metadata.gz: 02041fdc13701a69b69dc71e484aee448a445871dd367b0edea01f5f2f39108c
+  data.tar.gz: 58ff8c80cbc0a4373a4379d24ee49720a42e972954d6ccdb2d64d85a507af58a
 SHA512:
-  metadata.gz: fce0aab9b8ad438fce116f9ea1365d42322ee20e6332f044c566c6df9a48340f11b26078fa4d9570ada51b43d52628e345b36e238af8ac25efc2008e5b09b3fa
-  data.tar.gz: 72253cfd635c94da5ebea3956b2ca093b8fa72593b2740f108003329947d1519a5068ce43167d41146aa3c9e596f701b74bce8e8e6397d8458e4546c2652f38d
+  metadata.gz: 8bd9c3a1473c9b50c3de3ffc9bfcc181e12e8770ff71345bac01c0cce3f2bb4c638401d2ba5e30e43c04053e5401bc1c12f71bf3e672bca241b302dba9ab14ce
+  data.tar.gz: e75f04a1caffff67fdd8709be8a348ebbfabd56652ca5e61b9f5ecf55d469d721f135e7a20c0c6cc5fd77ab0f34f8c5f0f47467cba8ea06cd3cbf60f64f12c8e

data/README.md

@@ -13,48 +13,34 @@ gem 'boolean_validator'
 
 And then execute:
 
-    $ bundle
+    $ bundle install
 
 
 ## Usage
 
-You would have implemented a `Post` model like this:
-
-```ruby
-class Post < ActiveRecord::Base
-  validates :is_public_before_type_cast, inclusion: { in: [true, false] }
-end
-```
-
-or this (though this is wrong because this *validation* actually *validates nothing*):
-
-```ruby
-class Post < ActiveRecord::Base
-  validates :is_public, inclusion: { in: [true, false] }
-end
-```
-
-
-To validate boolean value with this gem, try:
-
+In your model:
 ```ruby
-class Post < ActiveRecord::Base
-  validates :is_public_before_type_cast, boolean: true
+class Post
+  include ActiveModel::Model
+  validates :is_public, boolean: true
 end
 ```
 
 or you can pass an option like:
 
 ```ruby
-class Post < ActiveRecord::Base
-  validate :is_public_before_type_cast, boolean: { message: 'Customize your error message' }
+class Post
+  include ActiveModel::Model
+  validate :is_public, boolean: { message: 'Customize your error message' }
 end
 ```
 
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/spice-inc/boolean_validator.
+- Note: With `ActiveRecord`, this validation does not work functionally and just work as column type declaration.
+- Implementation for `ActiveRecord` is here: https://github.com/ayumitamai97/boolean_validator/pull/4
+- Bug reports and your opinions are welcome.
 
 ## License
 

data/lib/boolean_validator.rb

@@ -1,11 +1,8 @@
 require 'active_model/validator'
-require 'extensions/active_model/type/boolean'
 
 class BooleanValidator < ActiveModel::EachValidator
-  BOOLEAN_VALUES = ActiveModel::Type::Boolean::TRUE_VALUES + ActiveModel::Type::Boolean::FALSE_VALUES
-
   def validate_each(record, attribute, value)
-    return if BOOLEAN_VALUES.include?(value)
+    return if [true, false].include?(value)
 
     record.errors.add(attribute, :invalid, options.slice(:message).merge(value: value))
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: boolean_validator
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.3
 platform: ruby
 authors:
 - ayumitamai97
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-28 00:00:00.000000000 Z
+date: 2019-05-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -24,7 +24,7 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 5.0.0
-description: Boolean validator for Rails and ActiveModel.
+description: Boolean validator for ActiveModel.
 email:
 - ayumitamai97@gmail.com
 executables: []
@@ -34,7 +34,6 @@ files:
 - README.md
 - Rakefile
 - lib/boolean_validator.rb
-- lib/extensions/active_model/type/boolean.rb
 homepage: https://github.com/ayumitamai97/boolean_validator
 licenses:
 - MIT
@@ -57,5 +56,5 @@ requirements: []
 rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
-summary: Boolean validator for Rails and ActiveModel.
+summary: Boolean validator for ActiveModel.
 test_files: []

data/lib/extensions/active_model/type/boolean.rb

@@ -1,12 +0,0 @@
-require 'active_model/type'
-
-module ActiveModelExtension
-  module Boolean
-    # FALSE_VALUES are defined in:
-    # https://github.com/rails/rails/blob/406d3a926cfcd3724f8002f70346aad95eed4a8c/activemodel/lib/active_model/type/boolean.rb
-
-    TRUE_VALUES = Set.new([true, 1, "1", "t", "T", "true", "TRUE", "on", "ON"])
-  end
-end
-
-ActiveModel::Type::Boolean.send(:include, ActiveModelExtension::Boolean)