bookland 3.2.0 → 3.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5b5ae359f32e9fe781b86320bcf0b7a7b095caa4
-  data.tar.gz: 80143d0efdb7a3b958ab4e5fddefb93579d3b9da
+  metadata.gz: 6fb91e00c5bb23802dd09d5e3e0b5413d3b22135
+  data.tar.gz: c17a294ae6804e1a7a91130753fa4e03128e3f6c
 SHA512:
-  metadata.gz: 772184fabb0aef7f79fa41a7dfaa9abfac58c27bb85dd518f2282ef64b3cfeb7db0e132fb4291391ef47d4d08cf5f0bea78daa757e3cd9e6bb3d118b2e5916a9
-  data.tar.gz: 2da6323dc8a21306674b50199d653be13bd71f89dc725ccc4b38a9af198b5e67b5cfcb962bc3121a9810984718037274a5d855080068754a9c85d9f4f7b1e903
+  metadata.gz: aa0aa72c2402d39ff0ff1c75f15ab3d5d955e1666f150c2f897fb933d13d3437a50dab2ac1f12f648e420135b98a58737954198fac9a373e42671ea4fa55aaef
+  data.tar.gz: 508d0a310a0948b54fda5025d195ca287db5661414ba7fccff29cc0fe93356258723894c151f58ccb12f2e047f392f52e02eeeba68398ff5cea59600dd07041f

data/lib/bookland/validators.rb

@@ -5,10 +5,11 @@
         return if value.nil? && options[:allow_nil]
 
         unless Bookland::#{klass}.valid?(value)
+          message = "is not an #{klass}"
           if options[:strict]
-            raise ActiveModel::StrictValidationFailed, "\#{value} \#{options[:message] || "is not an #{klass}"}"
+            raise ActiveModel::StrictValidationFailed, "\#{value} \#{message}"
           else
-            record.errors[attribute] << (options[:message] || 'is not an #{klass}')
+            record.errors[attribute] << message
           end
         end
       end

data/lib/bookland/version.rb

@@ -1,3 +1,3 @@
 module Bookland
-  VERSION = '3.2.0'
+  VERSION = '3.2.1'
 end

data/test/validators_test.rb

@@ -27,6 +27,13 @@ class TestValidators < MiniTest::Unit::TestCase
     assert instance.valid?
   end
 
+  def test_validates_asin_with_message
+    @klass.validates(:attribute, asin: true)#, { message: 'is bad' })
+    instance = @klass.new(attribute: '123')
+    instance.valid?
+    assert_includes instance.errors.first, 'is not an ASIN'
+  end
+
   def test_validates_asin_strictly
     @klass.validates!(:attribute, asin: true)
     instance = @klass.new(attribute: '0262011530')
@@ -52,6 +59,13 @@ class TestValidators < MiniTest::Unit::TestCase
     assert instance.valid?
   end
 
+  def test_validates_ean_with_message
+    @klass.validates(:attribute, ean: true)#, { message: 'is bad' })
+    instance = @klass.new(attribute: '123')
+    instance.valid?
+    assert_includes instance.errors.first, 'is not an EAN'
+  end
+
   def test_validates_ean_strictly
     @klass.validates!(:attribute, ean: true)
     instance = @klass.new(attribute: '0814916013890')
@@ -76,6 +90,13 @@ class TestValidators < MiniTest::Unit::TestCase
     assert instance.valid?
   end
 
+  def test_validates_isbn_with_message
+    @klass.validates(:attribute, isbn: true)#, { message: 'is bad' })
+    instance = @klass.new(attribute: '123')
+    instance.valid?
+    assert_includes instance.errors.first, 'is not an ISBN'
+  end
+
   def test_validates_isbn_strictly
     @klass.validates!(:attribute, isbn: true)
     instance = @klass.new(attribute: '9780262011532')

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bookland
 version: !ruby/object:Gem::Version
-  version: 3.2.0
+  version: 3.2.1
 platform: ruby
 authors:
 - Hakan Ensari